From f5a69d6faee5e3055be78614582968ee9238a002 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Thu, 16 May 2024 09:44:01 +0200
Subject: [PATCH] OZG-5294 Fix reviewed comments
---
.../abschliessen-button.component.spec.ts | 16 ++++++++--------
.../vorgang-detail-page.component.spec.ts | 9 +++++----
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/alfa-client/libs/vorgang-detail/src/lib/buttons/abschliessen-button/abschliessen-button.component.spec.ts b/alfa-client/libs/vorgang-detail/src/lib/buttons/abschliessen-button/abschliessen-button.component.spec.ts
index 1b919cbc84..ff72e92492 100644
--- a/alfa-client/libs/vorgang-detail/src/lib/buttons/abschliessen-button/abschliessen-button.component.spec.ts
+++ b/alfa-client/libs/vorgang-detail/src/lib/buttons/abschliessen-button/abschliessen-button.component.spec.ts
@@ -135,10 +135,10 @@ describe('AbschliessenButtonComponent', () => {
});
it('should be hidden if in bearbeitung', () => {
- component.vorgang = createVorgangWithEingangResource([
- VorgangWithEingangLinkRel.ABSCHLIESSEN,
- ]);
- component.vorgang.status = VorgangStatus.IN_BEARBEITUNG;
+ component.vorgang = {
+ ...createVorgangWithEingangResource([VorgangWithEingangLinkRel.ABSCHLIESSEN]),
+ status: VorgangStatus.IN_BEARBEITUNG,
+ };
fixture.detectChanges();
const buttonElement = fixture.nativeElement.querySelector(abschliessenButton);
@@ -174,10 +174,10 @@ describe('AbschliessenButtonComponent', () => {
});
it('should be hidden if in bearbeitung', () => {
- component.vorgang = createVorgangWithEingangResource([
- VorgangWithEingangLinkRel.ABSCHLIESSEN,
- ]);
- component.vorgang.status = VorgangStatus.IN_BEARBEITUNG;
+ component.vorgang = {
+ ...createVorgangWithEingangResource([VorgangWithEingangLinkRel.ABSCHLIESSEN]),
+ status: VorgangStatus.IN_BEARBEITUNG,
+ };
fixture.detectChanges();
const buttonElement = fixture.nativeElement.querySelector(abschliessenIconButton);
diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-page.component.spec.ts b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-page.component.spec.ts
index b6cdb6d313..ac7153bf10 100644
--- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-page.component.spec.ts
+++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-page.component.spec.ts
@@ -37,6 +37,7 @@ import {
} from '@alfa-client/vorgang-shared';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { MatIcon } from '@angular/material/icon';
+import { getDataTestIdOf } from 'libs/tech-shared/test/data-test';
import { ProgressBarComponent } from 'libs/ui/src/lib/ui/progress-bar/progress-bar.component';
import { SubnavigationComponent } from 'libs/ui/src/lib/ui/subnavigation/subnavigation.component';
import { createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang';
@@ -63,10 +64,10 @@ describe('VorgangDetailPageComponent', () => {
const vorgangWithEingang: VorgangWithEingangResource = createVorgangWithEingangResource();
- const subnavigation: string = 'ozgcloud-subnavigation';
- const actionButtons: string = 'alfa-vorgang-detail-action-buttons';
- const moreMenu: string = 'alfa-vorgang-detail-more-menu';
- const detailArea: string = 'alfa-vorgang-detail-area';
+ const subnavigation: string = getDataTestIdOf('ozgcloud-subnavigation');
+ const actionButtons: string = getDataTestIdOf('alfa-vorgang-detail-action-buttons');
+ const moreMenu: string = getDataTestIdOf('alfa-vorgang-detail-more-menu');
+ const detailArea: string = getDataTestIdOf('alfa-vorgang-detail-area');
beforeEach(async () => {
await TestBed.configureTestingModule({
--
GitLab