diff --git a/goofy-server/src/main/java/de/itvsh/goofy/vorgang/VorgangWithEingang.java b/goofy-server/src/main/java/de/itvsh/goofy/vorgang/VorgangWithEingang.java index 6f87db05215eb6dde11e801d34189e677dc1149a..d400d09e981c9eb2d60154d0353cee36110d3aac 100644 --- a/goofy-server/src/main/java/de/itvsh/goofy/vorgang/VorgangWithEingang.java +++ b/goofy-server/src/main/java/de/itvsh/goofy/vorgang/VorgangWithEingang.java @@ -26,6 +26,7 @@ public class VorgangWithEingang implements Vorgang { private VorgangStatus status; private ZonedDateTime createdAt; private String aktenzeichen; + private String nummer; private Eingang eingang; } \ No newline at end of file diff --git a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWithEingangResponseTestFactory.java b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWithEingangResponseTestFactory.java new file mode 100644 index 0000000000000000000000000000000000000000..2a9795acce39972e89e46dac28ca1485a55e1673 --- /dev/null +++ b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWithEingangResponseTestFactory.java @@ -0,0 +1,14 @@ +package de.itvsh.goofy.vorgang; + +import de.itvsh.ozg.pluto.vorgang.GrpcFindVorgangWithEingangResponse; + +class GrpcVorgangWithEingangResponseTestFactory { + + static GrpcFindVorgangWithEingangResponse createVorgangWithEingangResponse() { + return createVorgangWithEingangResponseBuilder().build(); + } + + private static GrpcFindVorgangWithEingangResponse.Builder createVorgangWithEingangResponseBuilder() { + return GrpcFindVorgangWithEingangResponse.newBuilder().setVorgangWithEingang(GrpcVorgangWithEingangTestFactory.create()); + } +} \ No newline at end of file diff --git a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWithEingangTestFactory.java b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWithEingangTestFactory.java index 5118485034329d32a5e12622d8bbf375a5a1fc62..e7aa82501269ee593d8d1a431f38f7ae7eb6965e 100644 --- a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWithEingangTestFactory.java +++ b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWithEingangTestFactory.java @@ -1,5 +1,7 @@ package de.itvsh.goofy.vorgang; +import static de.itvsh.goofy.vorgang.VorgangHeaderTestFactory.*; + import de.itvsh.ozg.pluto.vorgang.GrpcEingang; import de.itvsh.ozg.pluto.vorgang.GrpcVorgangWithEingang; @@ -15,7 +17,11 @@ class GrpcVorgangWithEingangTestFactory { static GrpcVorgangWithEingang.Builder createBuilder() { return GrpcVorgangWithEingang.newBuilder() - .setStatus(VorgangHeaderTestFactory.STATUS.name()) + .setStatus(STATUS.name()) + .setNummer(NUMMER) + .setAktenzeichen(AKTENZEICHEN) + .setAssignedTo(ASSIGNED_TO) + .setCreatedAt(CREATED_AT_STR) .setEingang(GrpcEingangTestFactory.create()); } } \ No newline at end of file diff --git a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWthEingangTestFactory.java b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWthEingangTestFactory.java deleted file mode 100644 index 66a03fc0cdf8ea0203537bb55e1008d7357fe7fd..0000000000000000000000000000000000000000 --- a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/GrpcVorgangWthEingangTestFactory.java +++ /dev/null @@ -1,29 +0,0 @@ -package de.itvsh.goofy.vorgang; - -import static de.itvsh.goofy.vorgang.VorgangHeaderTestFactory.*; - -import de.itvsh.ozg.pluto.vorgang.GrpcFindVorgangWithEingangResponse; -import de.itvsh.ozg.pluto.vorgang.GrpcVorgangWithEingang; - -public class GrpcVorgangWthEingangTestFactory { - - public static GrpcFindVorgangWithEingangResponse createVorgangWithEingangResponse() { - return createVorgangWithEingangResponseBuilder().build(); - } - - private static GrpcFindVorgangWithEingangResponse.Builder createVorgangWithEingangResponseBuilder() { - return GrpcFindVorgangWithEingangResponse.newBuilder().setVorgangWithEingang(createVorgangWithEingang()); - } - - public static GrpcVorgangWithEingang createVorgangWithEingang() { - return createVorgangWithEingangBuilder().build(); - } - - private static GrpcVorgangWithEingang.Builder createVorgangWithEingangBuilder() { - return GrpcVorgangWithEingang.newBuilder() - .setId(ID) - .setName(NAME) - .setCreatedAt(CREATED_AT_STR) - .setStatus(STATUS.toString()); - } -} \ No newline at end of file diff --git a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangRemoteServiceTest.java b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangRemoteServiceTest.java index 36de788b14502b508757c48ea46d86d0b225de52..0400afb646d3543268b49bae576bdc907923c526 100644 --- a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangRemoteServiceTest.java +++ b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangRemoteServiceTest.java @@ -285,7 +285,8 @@ class VorgangRemoteServiceTest { @BeforeEach void mockReturnValue() { - when(serviceStub.findVorgangWithEingang(any())).thenReturn(GrpcVorgangWthEingangTestFactory.createVorgangWithEingangResponse()); + when(serviceStub.findVorgangWithEingang(any())) + .thenReturn(GrpcVorgangWithEingangResponseTestFactory.createVorgangWithEingangResponse()); when(vorgangWithEingangMapper.toVorgangWithEingang(any())).thenReturn(vorgangWithEingang); doReturn(filterBy).when(service).createFilterBy(any()); } diff --git a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangWithEingangMapperTest.java b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangWithEingangMapperTest.java new file mode 100644 index 0000000000000000000000000000000000000000..32ec16e9e29841ca7190c35fa978692a8fa5c713 --- /dev/null +++ b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangWithEingangMapperTest.java @@ -0,0 +1,74 @@ +package de.itvsh.goofy.vorgang; + +import static de.itvsh.goofy.vorgang.VorgangHeaderTestFactory.*; +import static org.assertj.core.api.Assertions.*; + +import org.junit.jupiter.api.Nested; +import org.junit.jupiter.api.Test; +import org.mapstruct.factory.Mappers; +import org.mockito.InjectMocks; +import org.mockito.Mock; +import org.mockito.Spy; + +import de.itvsh.goofy.common.BaseTypesMapper; +import de.itvsh.goofy.common.user.UserId; +import de.itvsh.goofy.common.user.UserIdMapper; +import de.itvsh.goofy.vorgang.Vorgang.VorgangStatus; + +class VorgangWithEingangMapperTest { + + @Spy + @InjectMocks + private VorgangWithEingangMapper mapper = Mappers.getMapper(VorgangWithEingangMapper.class); + + @Spy + private UserIdMapper userIdMapper = Mappers.getMapper(UserIdMapper.class); + + @Spy + private BaseTypesMapper baseTypesMapper = Mappers.getMapper(BaseTypesMapper.class); + + @Mock + private EingangMapper eingangMapper; + + @Nested + class TestGrpcVorgangWithEingangToGoofyVorgangWithEingang { + @Test + void shouldMapCreatedAt() { + var vorgang = callMapper(); + + assertThat(vorgang.getCreatedAt()).isEqualTo(CREATED_AT); + } + + @Test + void shouldMapNummer() { + var vorgang = callMapper(); + + assertThat(vorgang.getNummer()).isEqualTo(NUMMER); + } + + @Test + void shouldMapAktenzeichen() { + var vorgang = callMapper(); + + assertThat(vorgang.getAktenzeichen()).isEqualTo(AKTENZEICHEN); + } + + @Test + void shouldMapStatus() { + var vorgang = callMapper(); + + assertThat(vorgang.getStatus()).isEqualTo(VorgangStatus.NEU); + } + + @Test + void shouldMapAssignedTo() { + var vorgang = callMapper(); + + assertThat(vorgang.getAssignedTo()).isEqualTo(UserId.from(ASSIGNED_TO)); + } + + private VorgangWithEingang callMapper() { + return mapper.toVorgangWithEingang(GrpcVorgangWithEingangTestFactory.create()); + } + } +} diff --git a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangWithEingangTestFactory.java b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangWithEingangTestFactory.java index 38737bbe85f2e490e7e1c25c024151c221c5aeeb..45c4fc3b895b59e11f9514a261042aa4be816900 100644 --- a/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangWithEingangTestFactory.java +++ b/goofy-server/src/test/java/de/itvsh/goofy/vorgang/VorgangWithEingangTestFactory.java @@ -17,6 +17,7 @@ public class VorgangWithEingangTestFactory { .assignedTo(UserProfileTestFactory.ID) .name(NAME) .status(STATUS) + .nummer(NUMMER) .createdAt(CREATED_AT) .eingang(EingangTestFactory.create()); } diff --git a/package-lock.json b/package-lock.json new file mode 100644 index 0000000000000000000000000000000000000000..1d53587185233e7fb873cd4a72e76b6bab291f1b --- /dev/null +++ b/package-lock.json @@ -0,0 +1,6 @@ +{ + "name": "goofy", + "lockfileVersion": 2, + "requires": true, + "packages": {} +}