From cb22c094afa86cd13361da94e49a3a8c0f9ecf51 Mon Sep 17 00:00:00 2001 From: OZGCloud <ozgcloud@mgm-tp.com> Date: Fri, 9 Aug 2024 09:26:44 +0200 Subject: [PATCH] OZG-6129 refactor test for event emitter --- .../instant-search/instant-search.component.ts | 2 +- .../search-field/search-field.component.spec.ts | 11 ++++++----- .../search-field/search-field.component.ts | 4 ++-- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/alfa-client/libs/design-system/src/lib/instant-search/instant-search/instant-search.component.ts b/alfa-client/libs/design-system/src/lib/instant-search/instant-search/instant-search.component.ts index 883096670d..39c716b45f 100644 --- a/alfa-client/libs/design-system/src/lib/instant-search/instant-search/instant-search.component.ts +++ b/alfa-client/libs/design-system/src/lib/instant-search/instant-search/instant-search.component.ts @@ -40,7 +40,7 @@ import { InstantSearchResult } from './instant-search.model'; [attr.aria-expanded]="results.length" [control]="control" aria-controls="results" - (clickInput)="showResults()" + (inputClicked)="showResults()" #searchField /> <ods-aria-live-region [text]="ariaLiveText" /> diff --git a/alfa-client/libs/design-system/src/lib/instant-search/search-field/search-field.component.spec.ts b/alfa-client/libs/design-system/src/lib/instant-search/search-field/search-field.component.spec.ts index 7902ea43fc..f1f730f80e 100644 --- a/alfa-client/libs/design-system/src/lib/instant-search/search-field/search-field.component.spec.ts +++ b/alfa-client/libs/design-system/src/lib/instant-search/search-field/search-field.component.spec.ts @@ -1,5 +1,6 @@ import { EMPTY_STRING } from '@alfa-client/tech-shared'; -import { getElementFromFixtureByType } from '@alfa-client/test-utils'; +import { getElementFromFixtureByType, mock } from '@alfa-client/test-utils'; +import { EventEmitter } from '@angular/core'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { FormControl } from '@angular/forms'; import { TextInputComponent } from '../../form/text-input/text-input.component'; @@ -23,14 +24,14 @@ describe('SearchFieldComponent', () => { expect(component).toBeTruthy(); }); - describe('clickInput', () => { + describe('inputClicked', () => { it('should emit event', () => { + component.inputClicked = <any>mock(EventEmitter); const input = getElementFromFixtureByType(fixture, TextInputComponent); - const emitSpy = jest.spyOn(component.clickInput, 'emit'); - input.clickEmitter.emit(); + input.inputElement.nativeElement.click(); - expect(emitSpy).toHaveBeenCalledTimes(1); + expect(component.inputClicked.emit).toHaveBeenCalled(); }); }); diff --git a/alfa-client/libs/design-system/src/lib/instant-search/search-field/search-field.component.ts b/alfa-client/libs/design-system/src/lib/instant-search/search-field/search-field.component.ts index b2fa9bccad..1f2e01bd04 100644 --- a/alfa-client/libs/design-system/src/lib/instant-search/search-field/search-field.component.ts +++ b/alfa-client/libs/design-system/src/lib/instant-search/search-field/search-field.component.ts @@ -16,7 +16,7 @@ import { SearchIconComponent } from '../../icons/search-icon/search-icon.compone [placeholder]="placeholder" [withPrefix]="true" [withSuffix]="true" - (clickEmitter)="clickInput.emit()" + (clickEmitter)="inputClicked.emit()" role="combobox" > <ods-search-icon prefix aria-hidden="true" aria-label="Suchfeld" /> @@ -30,7 +30,7 @@ export class SearchFieldComponent { @Input() placeholder: string = EMPTY_STRING; @Input() control = new FormControl(EMPTY_STRING); - @Output() clickInput: EventEmitter<MouseEvent> = new EventEmitter<MouseEvent>(); + @Output() inputClicked: EventEmitter<MouseEvent> = new EventEmitter<MouseEvent>(); clearInput() { this.control.setValue(EMPTY_STRING); -- GitLab