From a35c07c74d588b09a3ed81481848c124cd3881e9 Mon Sep 17 00:00:00 2001 From: OZGCloud <ozgcloud@mgm-tp.com> Date: Thu, 3 Jun 2021 10:17:14 +0200 Subject: [PATCH] OZG-400 tests --- .../header/header.component.spec.ts | 4 +- .../libs/user-profile-shared/src/index.ts | 1 + .../user-icon-container.component.spec.ts | 47 ++++++++++++------- .../user-icon-container.component.ts | 3 +- .../lib/user-icon/user-icon.component.html | 30 ++++++------ .../lib/user-icon/user-icon.component.spec.ts | 3 ++ .../src/lib/user-icon/user-icon.component.ts | 2 +- .../vorgang-detail-header.component.spec.ts | 4 +- .../vorgang-list-item.component.spec.ts | 4 +- 9 files changed, 57 insertions(+), 41 deletions(-) diff --git a/goofy-client/libs/navigation/src/lib/header-container/header/header.component.spec.ts b/goofy-client/libs/navigation/src/lib/header-container/header/header.component.spec.ts index 6412f14e79..4617bd101a 100644 --- a/goofy-client/libs/navigation/src/lib/header-container/header/header.component.spec.ts +++ b/goofy-client/libs/navigation/src/lib/header-container/header/header.component.spec.ts @@ -1,7 +1,7 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { RouterTestingModule } from '@angular/router/testing'; import { UiModule } from '@goofy-client/ui'; -import { UserIconComponent } from '@goofy-client/user-profile'; +import { UserIconContainerComponent } from '@goofy-client/user-profile'; import { VorgangSearchContainerComponent } from '@goofy-client/vorgang-shared-ui'; import { configureTestSuite } from 'ng-bullet'; import { MockComponent } from 'ng-mocks'; @@ -22,7 +22,7 @@ describe('HeaderComponent', () => { HeaderComponent, MockComponent(SettingsComponent), MockComponent(VorgangSearchContainerComponent), - MockComponent(UserIconComponent) + MockComponent(UserIconContainerComponent) ] }) }); diff --git a/goofy-client/libs/user-profile-shared/src/index.ts b/goofy-client/libs/user-profile-shared/src/index.ts index 657b4429b5..bf11023f34 100644 --- a/goofy-client/libs/user-profile-shared/src/index.ts +++ b/goofy-client/libs/user-profile-shared/src/index.ts @@ -1,2 +1,3 @@ export * from './lib/user-profile-shared.module'; +export * from './lib/user-profile.model'; export * from './lib/user-profile.service'; diff --git a/goofy-client/libs/user-profile/src/lib/user-icon-container/user-icon-container.component.spec.ts b/goofy-client/libs/user-profile/src/lib/user-icon-container/user-icon-container.component.spec.ts index 6d338b051b..7bd242c808 100644 --- a/goofy-client/libs/user-profile/src/lib/user-icon-container/user-icon-container.component.spec.ts +++ b/goofy-client/libs/user-profile/src/lib/user-icon-container/user-icon-container.component.spec.ts @@ -1,25 +1,38 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; - +import { mock } from '@goofy-client/test-utils'; +import { UserProfileService } from '@goofy-client/user-profile-shared'; +import { MockComponent } from 'ng-mocks'; +import { UserIconComponent } from '../user-icon/user-icon.component'; import { UserIconContainerComponent } from './user-icon-container.component'; describe('UserIconContainerComponent', () => { - let component: UserIconContainerComponent; - let fixture: ComponentFixture<UserIconContainerComponent>; + let component: UserIconContainerComponent; + let fixture: ComponentFixture<UserIconContainerComponent>; + + const userProfileService = mock(UserProfileService); - beforeEach(async () => { - await TestBed.configureTestingModule({ - declarations: [ UserIconContainerComponent ] - }) - .compileComponents(); - }); + beforeEach(async () => { + await TestBed.configureTestingModule({ + declarations: [ + UserIconContainerComponent, + MockComponent(UserIconComponent) + ], + providers: [ + { + provide: UserProfileService, + useValue: userProfileService + } + ] + }).compileComponents(); + }); - beforeEach(() => { - fixture = TestBed.createComponent(UserIconContainerComponent); - component = fixture.componentInstance; - fixture.detectChanges(); - }); + beforeEach(() => { + fixture = TestBed.createComponent(UserIconContainerComponent); + component = fixture.componentInstance; + fixture.detectChanges(); + }); - it('should create', () => { - expect(component).toBeTruthy(); - }); + it('should create', () => { + expect(component).toBeTruthy(); + }); }); diff --git a/goofy-client/libs/user-profile/src/lib/user-icon-container/user-icon-container.component.ts b/goofy-client/libs/user-profile/src/lib/user-icon-container/user-icon-container.component.ts index 5b17ae3a9a..ec53ff086a 100644 --- a/goofy-client/libs/user-profile/src/lib/user-icon-container/user-icon-container.component.ts +++ b/goofy-client/libs/user-profile/src/lib/user-icon-container/user-icon-container.component.ts @@ -1,9 +1,8 @@ import { Component, Input, OnChanges, SimpleChanges } from '@angular/core'; import { createEmptyStateResource, StateResource } from '@goofy-client/tech-shared'; -import { UserProfileService } from '@goofy-client/user-profile-shared'; +import { UserProfileResource, UserProfileService } from '@goofy-client/user-profile-shared'; import { VorgangHeaderLinkRel, VorgangWithEingangResource } from '@goofy-client/vorgang-shared'; import { hasLink } from '@ngxp/rest'; -import { UserProfileResource } from 'libs/user-profile-shared/src/lib/user-profile.model'; import { isNil } from 'lodash-es'; import { Observable, of } from 'rxjs'; diff --git a/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.html b/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.html index 22f917db9b..8abc89e88a 100644 --- a/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.html +++ b/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.html @@ -1,16 +1,16 @@ - <div class="editor" - [ngStyle]="{ - 'transform': 'scale(' + scaleFactor + ')', - 'transform-origin': transformOrigin - }" - [matTooltipDisabled]="disableTooltip" - matTooltip="{{ toolTip }}"> +<div class="editor" + [ngStyle]="{ + 'transform': 'scale(' + scaleFactor + ')', + 'transform-origin': transformOrigin + }" + [matTooltipDisabled]="disableTooltip" + matTooltip="{{ toolTip }}"> - <ng-container *ngIf="userProfileStateResource.resource; else noUser"> - <span>{{ initials }}</span> - </ng-container> - <ng-template #noUser> - <mat-icon>account_circle</mat-icon> - </ng-template> - <div class="picture"></div> - </div> \ No newline at end of file + <ng-container *ngIf="userProfileStateResource.resource; else noUser"> + <span>{{ initials }}</span> + </ng-container> + <ng-template #noUser> + <mat-icon>account_circle</mat-icon> + </ng-template> + <div class="picture"></div> +</div> \ No newline at end of file diff --git a/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.spec.ts b/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.spec.ts index 3ebb930f73..5088630681 100644 --- a/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.spec.ts +++ b/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.spec.ts @@ -1,6 +1,8 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MatIcon } from '@angular/material/icon'; import { MatTooltipModule } from '@angular/material/tooltip'; +import { createStateResource } from '@goofy-client/tech-shared'; +import { createUserProfileResource } from '../../../../user-profile-shared/test/user-profile'; import { UserIconComponent } from './user-icon.component'; describe('UserIconComponent', () => { @@ -20,6 +22,7 @@ describe('UserIconComponent', () => { beforeEach(() => { fixture = TestBed.createComponent(UserIconComponent); component = fixture.componentInstance; + component.userProfileStateResource = createStateResource(createUserProfileResource()); fixture.detectChanges(); }); diff --git a/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.ts b/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.ts index e0348d0f8b..bedfb1d456 100644 --- a/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.ts +++ b/goofy-client/libs/user-profile/src/lib/user-icon/user-icon.component.ts @@ -1,6 +1,6 @@ import { Component, Input, SimpleChanges } from '@angular/core'; import { StateResource } from '@goofy-client/tech-shared'; -import { UserProfileResource } from 'libs/user-profile-shared/src/lib/user-profile.model'; +import { UserProfileResource } from '@goofy-client/user-profile-shared'; import { isNil } from 'lodash'; @Component({ diff --git a/goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-area/vorgang-detail-header/vorgang-detail-header.component.spec.ts b/goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-area/vorgang-detail-header/vorgang-detail-header.component.spec.ts index 3f9e8919ea..3606faa094 100644 --- a/goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-area/vorgang-detail-header/vorgang-detail-header.component.spec.ts +++ b/goofy-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-area/vorgang-detail-header/vorgang-detail-header.component.spec.ts @@ -1,6 +1,6 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { EnumToLabelPipe, HasLinkPipe } from '@goofy-client/tech-shared'; -import { UserIconComponent } from '@goofy-client/user-profile'; +import { UserIconContainerComponent } from '@goofy-client/user-profile'; import { VorgangHeaderLinkRel } from '@goofy-client/vorgang-shared'; import { AktenzeichenComponent, StatusDotComponent } from '@goofy-client/vorgang-shared-ui'; import { createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang'; @@ -17,7 +17,7 @@ describe('VorgangDetailHeaderComponent', () => { await TestBed.configureTestingModule({ declarations: [ VorgangDetailHeaderComponent, - MockComponent(UserIconComponent), + MockComponent(UserIconContainerComponent), MockComponent(StatusDotComponent), MockComponent(AktenzeichenComponent), EnumToLabelPipe, diff --git a/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/vorgang-list-item/vorgang-list-item.component.spec.ts b/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/vorgang-list-item/vorgang-list-item.component.spec.ts index 8a1b07832f..0bad81d4d1 100644 --- a/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/vorgang-list-item/vorgang-list-item.component.spec.ts +++ b/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/vorgang-list-item/vorgang-list-item.component.spec.ts @@ -9,7 +9,7 @@ import { MatIconTestingModule } from '@angular/material/icon/testing'; import { MatTooltipModule } from '@angular/material/tooltip'; import { RouterTestingModule } from '@angular/router/testing'; import { EnumToLabelPipe, FormatDateWithTimePipe, FormatListDatePipe, HasLinkPipe, ToResourceUriPipe } from '@goofy-client/tech-shared'; -import { UserIconComponent } from '@goofy-client/user-profile'; +import { UserIconContainerComponent } from '@goofy-client/user-profile'; import { VorgangHeaderLinkRel } from '@goofy-client/vorgang-shared'; import { AktenzeichenComponent, StatusDotComponent } from '@goofy-client/vorgang-shared-ui'; import { WiedervorlageListInVorgangListContainerComponent } from '@goofy-client/wiedervorlage'; @@ -43,7 +43,7 @@ describe('VorgangListItemComponent', () => { ToResourceUriPipe, HasLinkPipe, MockComponent(AktenzeichenComponent), - MockComponent(UserIconComponent), + MockComponent(UserIconContainerComponent), MockComponent(StatusDotComponent), MockComponent(WiedervorlageListInVorgangListContainerComponent), MockComponent(VorgangNextFristButton) -- GitLab