From 8ba6f0169f09cd4d9819267d4011283cd4843413 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Mon, 26 Aug 2024 14:20:12 +0200
Subject: [PATCH] OZG-6311 OZG-6534 Remove unnecessary ngIf
---
.../collaboration-in-vorgang.component.html | 36 +++++++++----------
...collaboration-in-vorgang.component.spec.ts | 9 -----
2 files changed, 17 insertions(+), 28 deletions(-)
diff --git a/alfa-client/libs/collaboration/src/lib/collaboration-in-vorgang-container/collaboration-in-vorgang/collaboration-in-vorgang.component.html b/alfa-client/libs/collaboration/src/lib/collaboration-in-vorgang-container/collaboration-in-vorgang/collaboration-in-vorgang.component.html
index e706958af0..4d53cb37fc 100644
--- a/alfa-client/libs/collaboration/src/lib/collaboration-in-vorgang-container/collaboration-in-vorgang/collaboration-in-vorgang.component.html
+++ b/alfa-client/libs/collaboration/src/lib/collaboration-in-vorgang-container/collaboration-in-vorgang/collaboration-in-vorgang.component.html
@@ -4,26 +4,24 @@
| hasLink: collaborationListLinkRel.CREATE_COLLABORATION_REQUEST
"
>
- <ng-container *ngIf="!collaboration" data-test-id="collaboration-in-progres">
- <ng-template #anfrageErstellenButton>
- <ods-button
- variant="outline"
- text="Anfrage erstellen"
- dataTestId="anfrage-erstellen-button"
- (clickEmitter)="showRequestForm.emit()"
- >
- <ods-collaboration-icon icon />
- </ods-button>
- </ng-template>
+ <ng-template #anfrageErstellenButton>
+ <ods-button
+ variant="outline"
+ text="Anfrage erstellen"
+ dataTestId="anfrage-erstellen-button"
+ (clickEmitter)="showRequestForm.emit()"
+ >
+ <ods-collaboration-icon icon />
+ </ods-button>
+ </ng-template>
- <ng-container *ngIf="isRequestFormVisible; else anfrageErstellenButton">
- <alfa-collaboration-request-form
- data-test-id="collaboration-request-form"
- [collaborationListResource]="collaborationStateListResource.resource"
- (hide)="hideRequestForm.emit()"
- (showResult)="setCollaboration($event)"
- ></alfa-collaboration-request-form>
- </ng-container>
+ <ng-container *ngIf="isRequestFormVisible; else anfrageErstellenButton">
+ <alfa-collaboration-request-form
+ data-test-id="collaboration-request-form"
+ [collaborationListResource]="collaborationStateListResource.resource"
+ (hide)="hideRequestForm.emit()"
+ (showResult)="setCollaboration($event)"
+ ></alfa-collaboration-request-form>
</ng-container>
</ng-container>
<ng-container *ngIf="collaboration">
diff --git a/alfa-client/libs/collaboration/src/lib/collaboration-in-vorgang-container/collaboration-in-vorgang/collaboration-in-vorgang.component.spec.ts b/alfa-client/libs/collaboration/src/lib/collaboration-in-vorgang-container/collaboration-in-vorgang/collaboration-in-vorgang.component.spec.ts
index 5f7ca53507..5b17cd273c 100644
--- a/alfa-client/libs/collaboration/src/lib/collaboration-in-vorgang-container/collaboration-in-vorgang/collaboration-in-vorgang.component.spec.ts
+++ b/alfa-client/libs/collaboration/src/lib/collaboration-in-vorgang-container/collaboration-in-vorgang/collaboration-in-vorgang.component.spec.ts
@@ -31,7 +31,6 @@ describe('CollaborationInVorgangComponent', () => {
const anfrageErstellenButton: string = getDataTestIdAttributeOf('anfrage-erstellen-button');
const collaborationRequestForm: string = getDataTestIdOf('collaboration-request-form');
const collaborationRequestResult: string = getDataTestIdOf('collaboration-request-result');
- const collaborationInProgress: string = getDataTestIdOf('collaboration-in-progress');
const collaborationListResource: CollaborationListResource = createCollaborationListResource();
@@ -168,14 +167,6 @@ describe('CollaborationInVorgangComponent', () => {
existsAsHtmlElement(fixture, collaborationRequestResult);
});
-
- it('should not show collaboration in progress', () => {
- component.collaboration = undefined;
-
- fixture.detectChanges();
-
- notExistsAsHtmlElement(fixture, collaborationRequestResult);
- });
});
describe('set collaboration', () => {
--
GitLab