From 825596183ffece9ea598d19a95c2d07c8feb2bb2 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Fri, 9 Jul 2021 15:27:11 +0200
Subject: [PATCH] fix some sonarqube issues
---
.../libs/forwarding-shared/src/lib/forwarding.service.ts | 2 +-
.../libs/tech-shared/src/lib/services/formservice.abstract.ts | 2 +-
.../vorgang-list/empty-list/empty-list.component.ts | 1 -
.../vorgang-list/vorgang-list.component.ts | 1 -
.../libs/wiedervorlage-shared/src/lib/wiedervorlage.service.ts | 2 +-
.../wiedervorlage-page/breadcrumb/breadcrumb.component.ts | 2 --
6 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/goofy-client/libs/forwarding-shared/src/lib/forwarding.service.ts b/goofy-client/libs/forwarding-shared/src/lib/forwarding.service.ts
index 5e241cafe7..5a682f2a4d 100644
--- a/goofy-client/libs/forwarding-shared/src/lib/forwarding.service.ts
+++ b/goofy-client/libs/forwarding-shared/src/lib/forwarding.service.ts
@@ -107,7 +107,7 @@ export class ForwardingService implements OnDestroy {
createMarkAsCommand(forward: ForwardingResource, linkRel: string, command: CreateCommand): Observable<StateResource<CommandResource>> {
return this.commandService.createCommand(forward, linkRel, command).pipe(
- startWith(<StateResource<CommandResource>>createEmptyStateResource(true))
+ startWith(createEmptyStateResource<CommandResource>(true))
);
}
diff --git a/goofy-client/libs/tech-shared/src/lib/services/formservice.abstract.ts b/goofy-client/libs/tech-shared/src/lib/services/formservice.abstract.ts
index e9eec1092c..053c2fe130 100644
--- a/goofy-client/libs/tech-shared/src/lib/services/formservice.abstract.ts
+++ b/goofy-client/libs/tech-shared/src/lib/services/formservice.abstract.ts
@@ -40,7 +40,7 @@ export abstract class AbstractFormService {
doAfterPatch(source: any): void {
//No Implementation here for abstract class
- };
+ }
setError(apiError: ApiError): void {
apiError.issues.forEach(issue => setValidationError(this.form, issue, this.getPathPrefix()))
diff --git a/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/empty-list/empty-list.component.ts b/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/empty-list/empty-list.component.ts
index 2c9513352a..9c94699fee 100644
--- a/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/empty-list/empty-list.component.ts
+++ b/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/empty-list/empty-list.component.ts
@@ -1,5 +1,4 @@
import { Component, Input } from '@angular/core';
-import { Observable } from 'rxjs';
@Component({
selector: 'goofy-client-empty-list',
diff --git a/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/vorgang-list.component.ts b/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/vorgang-list.component.ts
index 6ddc6f542d..9117586b78 100644
--- a/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/vorgang-list.component.ts
+++ b/goofy-client/libs/vorgang/src/lib/vorgang-list-container/vorgang-list/vorgang-list.component.ts
@@ -2,7 +2,6 @@ import { CdkVirtualScrollViewport } from '@angular/cdk/scrolling';
import { Component, EventEmitter, Input, Output, ViewChild } from '@angular/core';
import { StateResource } from '@goofy-client/tech-shared';
import { VorgangListResource, VorgangResource } from '@goofy-client/vorgang-shared';
-import { Observable } from 'rxjs';
@Component({
selector: 'goofy-client-vorgang-list',
diff --git a/goofy-client/libs/wiedervorlage-shared/src/lib/wiedervorlage.service.ts b/goofy-client/libs/wiedervorlage-shared/src/lib/wiedervorlage.service.ts
index 650360d772..b9fc9a1422 100644
--- a/goofy-client/libs/wiedervorlage-shared/src/lib/wiedervorlage.service.ts
+++ b/goofy-client/libs/wiedervorlage-shared/src/lib/wiedervorlage.service.ts
@@ -194,7 +194,7 @@ export class WiedervorlageService implements OnDestroy {
proceedAfterReceiveCommand(commandStateResource: StateResource<CommandResource>, message: string): void {
this.submitInProgress$.next({ ...this.submitInProgress$.value, resource: commandStateResource.resource });
- if (isDone(<CommandResource>commandStateResource.resource)) {
+ if (isDone(commandStateResource.resource)) {
this.submitInProgress$.next(createStateResource(commandStateResource.resource));
this.snackbarService.showSnackbar(commandStateResource.resource, message)
this.setWiedervorlageListReload();
diff --git a/goofy-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/breadcrumb/breadcrumb.component.ts b/goofy-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/breadcrumb/breadcrumb.component.ts
index 1600393570..a0cbf44898 100644
--- a/goofy-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/breadcrumb/breadcrumb.component.ts
+++ b/goofy-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/breadcrumb/breadcrumb.component.ts
@@ -14,8 +14,6 @@ export class BreadcrumbComponent implements OnChanges {
betreff: string;
- constructor() { }
-
ngOnChanges(changes: SimpleChanges) {
if (changes.wiedervorlage) {
this.betreff = this.wiedervorlage ? this.wiedervorlage.betreff : WiedervorlageMessages.NEW;
--
GitLab