From 81af1208ef43145b025c29af5eff17c380b0849d Mon Sep 17 00:00:00 2001
From: sebo <sebastian.bergandy@external.mgm-cp.com>
Date: Tue, 25 Mar 2025 12:10:11 +0100
Subject: [PATCH] OZG-7473 improve code
Based on CR comment.
---
.../aggregation-mapping-list.component.spec.ts | 5 +++--
.../src/lib/aggregation-mapping.service.spec.ts | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-list-container/aggregation-mapping-list/aggregation-mapping-list.component.spec.ts b/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-list-container/aggregation-mapping-list/aggregation-mapping-list.component.spec.ts
index 4dbf9393d2..37718ad397 100644
--- a/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-list-container/aggregation-mapping-list/aggregation-mapping-list.component.spec.ts
+++ b/alfa-client/libs/admin/aggregation-mapping/src/lib/aggregation-mapping-list-container/aggregation-mapping-list/aggregation-mapping-list.component.spec.ts
@@ -49,12 +49,13 @@ describe('AggregationMappingListComponent', () => {
});
it('should have spinner with state resource', () => {
- const comp = getElementFromFixtureByType(fixture, SpinnerComponent);
+ const comp: SpinnerComponent = getElementFromFixtureByType(fixture, SpinnerComponent);
+
expect(comp.stateResource).toEqual(aggregationMappingListStateResource);
});
it('should have list item with mapping', () => {
- const comp = getElementFromFixtureByType(fixture, AggregationMappingListItemComponent);
+ const comp: AggregationMappingListItemComponent = getElementFromFixtureByType(fixture, AggregationMappingListItemComponent);
expect(comp.aggregationMapping).toEqual(
getEmbeddedResources(aggregationMappingListStateResource, AggregationMappingListLinkRel.LIST)[0],
);
diff --git a/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.spec.ts b/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.spec.ts
index 4e21e50174..bca88ee563 100644
--- a/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.spec.ts
+++ b/alfa-client/libs/admin/reporting-shared/src/lib/aggregation-mapping.service.spec.ts
@@ -97,6 +97,7 @@ describe('AggregationMappingService', () => {
describe('get', () => {
const stateResource: StateResource<AggregationMappingResource> = createStateResource(createAggregationMappingResource());
+
beforeEach(() => {
resourceService.get = jest.fn().mockReturnValue(of(stateResource));
});
@@ -108,9 +109,9 @@ describe('AggregationMappingService', () => {
});
it('should emit resource', () => {
- const got$: Observable<StateResource<AggregationMappingResource>> = service.get();
+ const stateResource$: Observable<StateResource<AggregationMappingResource>> = service.get();
- expect(got$).toBeObservable(singleColdCompleted(stateResource));
+ expect(stateResource$).toBeObservable(singleColdCompleted(stateResource));
});
});
--
GitLab