From 7ddf5ce29932b5a4e5958fd9d54630bc86eb93c9 Mon Sep 17 00:00:00 2001 From: sebo <sebastian.bergandy@external.mgm-cp.com> Date: Wed, 5 Mar 2025 19:57:42 +0100 Subject: [PATCH] OZG-6185 remove direct bescheiden passing wizard --- .../bescheiden-button.component.spec.ts | 27 ++----------------- .../bescheiden-button.component.ts | 13 +-------- 2 files changed, 3 insertions(+), 37 deletions(-) diff --git a/alfa-client/libs/vorgang-detail/src/lib/buttons/bescheiden-button/bescheiden-button.component.spec.ts b/alfa-client/libs/vorgang-detail/src/lib/buttons/bescheiden-button/bescheiden-button.component.spec.ts index 34b1e2377f..728a67f054 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/buttons/bescheiden-button/bescheiden-button.component.spec.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/buttons/bescheiden-button/bescheiden-button.component.spec.ts @@ -24,7 +24,7 @@ import { BescheidWizardContainerComponent } from '@alfa-client/bescheid'; import { BescheidWizardDialogResult } from '@alfa-client/bescheid-shared'; import { CommandResource } from '@alfa-client/command-shared'; -import { createEmptyStateResource, createStateResource, HasLinkPipe, StateResource } from '@alfa-client/tech-shared'; +import { createStateResource, HasLinkPipe, StateResource } from '@alfa-client/tech-shared'; import { createDialogRefMock, DialogRefMock, getElementComponentFromFixtureByCss, getMockComponent, Mock, mock, notExistsAsHtmlElement, tooltipExistsWithText, triggerEvent, } from '@alfa-client/test-utils'; import { OzgcloudDialogService } from '@alfa-client/ui'; import { VorgangCommandService, VorgangService, VorgangWithEingangLinkRel } from '@alfa-client/vorgang-shared'; @@ -36,7 +36,7 @@ import { createCommandResource } from 'libs/command-shared/test/command'; import { getDataTestIdAttributeOf } from 'libs/tech-shared/test/data-test'; import { createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang'; import { MockComponent } from 'ng-mocks'; -import { Observable, of } from 'rxjs'; +import { of } from 'rxjs'; import { BescheidenButtonComponent } from './bescheiden-button.component'; describe('BescheidenButtonComponent', () => { @@ -124,29 +124,6 @@ describe('BescheidenButtonComponent', () => { expect(component.openBescheidenWizard).toHaveBeenCalled(); }); }); - - describe('should do bescheiden', () => { - const command: CommandResource = createCommandResource(); - const comandStateResource$: Observable<StateResource<CommandResource>> = of(createStateResource(command)); - - beforeEach(() => { - vorgangCommandService.bescheiden.mockReturnValue(comandStateResource$); - }); - - it('should call vorgangCommandService.bescheiden', () => { - component.bescheiden(); - - expect(vorgangCommandService.bescheiden).toHaveBeenCalled(); - }); - - it('should assign response', () => { - component.commandStateResource$ = of(createEmptyStateResource<CommandResource>()); - - component.bescheiden(); - - expect(component.commandStateResource$).toBe(comandStateResource$); - }); - }); }); describe('bescheiden icon button', () => { diff --git a/alfa-client/libs/vorgang-detail/src/lib/buttons/bescheiden-button/bescheiden-button.component.ts b/alfa-client/libs/vorgang-detail/src/lib/buttons/bescheiden-button/bescheiden-button.component.ts index c6b90c722c..eb3496cd4e 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/buttons/bescheiden-button/bescheiden-button.component.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/buttons/bescheiden-button/bescheiden-button.component.ts @@ -65,18 +65,7 @@ export class BescheidenButtonComponent implements OnInit { } public bescheiden(): void { - if (this.shouldOpenBescheidenWizard()) { - this.openBescheidenWizard(); - } else { - this.commandStateResource$ = this.vorgangCommandService.bescheiden(this.vorgang); - } - } - - private shouldOpenBescheidenWizard(): boolean { - return ( - hasLink(this.vorgang, VorgangWithEingangLinkRel.CREATE_BESCHEID_DRAFT) || - hasLink(this.vorgang, VorgangWithEingangLinkRel.BESCHEID_DRAFT) - ); + this.openBescheidenWizard(); } public openBescheidenWizard(): void { -- GitLab