diff --git a/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.ts b/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.ts index e99b6e1d79106eaa29ce3120b9aacc6b74eb42be..f76f1f907cecaa625c3e1c6dc950458e3f4aa640 100644 --- a/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.ts +++ b/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.ts @@ -36,11 +36,7 @@ type ButtonVariants = VariantProps<typeof buttonVariants>; standalone: true, imports: [CommonModule, ButtonComponent, ErrorMessageComponent], styles: [':host {@apply flex flex-col w-fit}'], - template: ` <ods-error-message - *ngIf="isError" - text="Ein Fehler ist aufgetreten." - subText="Versuchen Sie es noch einmal." - > + template: ` <ods-error-message *ngIf="isError" text="Ein Fehler ist aufgetreten." subText="Versuchen Sie es noch einmal."> </ods-error-message> <ods-button [text]="text" @@ -50,6 +46,7 @@ type ButtonVariants = VariantProps<typeof buttonVariants>; [isLoading]="isLoading" (click)="clickEmitter.emit()" > + <ng-content icon select="[icon]" /> </ods-button>`, }) export class ButtonWithSpinnerComponent implements OnInit { @@ -74,8 +71,6 @@ export class ButtonWithSpinnerComponent implements OnInit { } get isError(): boolean { - return ( - isLoaded(this.stateResource) && hasCommandError(<CommandResource>this.stateResource.resource) - ); + return isLoaded(this.stateResource) && hasCommandError(<CommandResource>this.stateResource.resource); } } diff --git a/alfa-client/libs/design-system/src/lib/icons/check-icon/check-icon.component.ts b/alfa-client/libs/design-system/src/lib/icons/check-icon/check-icon.component.ts index bc40469a5206b07306caa19683d5522dcabb9091..a6b377a382a36589723627390d9a91e76a7cc6d8 100644 --- a/alfa-client/libs/design-system/src/lib/icons/check-icon/check-icon.component.ts +++ b/alfa-client/libs/design-system/src/lib/icons/check-icon/check-icon.component.ts @@ -32,7 +32,7 @@ import { iconVariants, IconVariants } from '../iconVariants'; imports: [CommonModule], template: `<svg viewBox="0 0 24 24" - [ngClass]="[twMerge(iconVariants({ size }), 'fill-text', class)]" + [ngClass]="[twMerge(iconVariants({ size }), 'fill-primary', class)]" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" > diff --git a/alfa-client/libs/design-system/src/lib/icons/save-icon/save-icon.component.ts b/alfa-client/libs/design-system/src/lib/icons/save-icon/save-icon.component.ts index 979a765b71da5b28823ba44c21ee3621d1996b1e..bb788b58a02f50a80369e702d153d17f83995e00 100644 --- a/alfa-client/libs/design-system/src/lib/icons/save-icon/save-icon.component.ts +++ b/alfa-client/libs/design-system/src/lib/icons/save-icon/save-icon.component.ts @@ -31,15 +31,14 @@ import { IconVariants, iconVariants } from '../iconVariants'; selector: 'ods-save-icon', standalone: true, imports: [NgClass], - template: `<svg - xmlns="http://www.w3.org/2000/svg" + template: ` <svg [ngClass]="[twMerge(iconVariants({ size }), 'fill-primary', class)]" aria-hidden="true" - viewBox="0 0 24 24" - fill="none" + viewBox="0 0 32 32" + xmlns="http://www.w3.org/2000/svg" > <path - d="M21.3333 12V21.3333H2.66667V12H0V21.3333C0 22.8 1.2 24 2.66667 24H21.3333C22.8 24 24 22.8 24 21.3333V12H21.3333ZM13.3333 12.8933L16.7867 9.45333L18.6667 11.3333L12 18L5.33333 11.3333L7.21333 9.45333L10.6667 12.8933V0H13.3333V12.8933Z" + d="M25.3333 16V25.3333H6.66667V16H4V25.3333C4 26.8 5.2 28 6.66667 28H25.3333C26.8 28 28 26.8 28 25.3333V16H25.3333ZM17.3333 16.8933L20.7867 13.4533L22.6667 15.3333L16 22L9.33333 15.3333L11.2133 13.4533L14.6667 16.8933V4H17.3333V16.8933Z" /> </svg>`, }) diff --git a/alfa-client/libs/design-system/src/lib/icons/send-icon/send-icon.component.ts b/alfa-client/libs/design-system/src/lib/icons/send-icon/send-icon.component.ts index b4bd00c0ffdf26eb069de6a1aecc73c8923b4e3d..851ea807cfa4fddcc2b80a28bf76ea1232cfed9a 100644 --- a/alfa-client/libs/design-system/src/lib/icons/send-icon/send-icon.component.ts +++ b/alfa-client/libs/design-system/src/lib/icons/send-icon/send-icon.component.ts @@ -32,21 +32,19 @@ import { IconVariants, iconVariants } from '../iconVariants'; standalone: true, imports: [NgClass], template: `<svg - xmlns="http://www.w3.org/2000/svg" [ngClass]="[twMerge(iconVariants({ size }), 'fill-primary', class)]" aria-hidden="true" - viewBox="0 0 24 24" - fill="none" + viewBox="0 0 32 32" + xmlns="http://www.w3.org/2000/svg" > <path - d="M0 21.6693V0.335938L25.3333 11.0026L0 21.6693ZM2.66667 17.6693L18.4667 11.0026L2.66667 4.33594V9.0026L10.6667 11.0026L2.66667 13.0026V17.6693Z" + d="M4 26.6688V5.33545L29.3333 16.0021L4 26.6688ZM6.66667 22.6688L22.4667 16.0021L6.66667 9.33545V14.0021L14.6667 16.0021L6.66667 18.0021V22.6688Z" /> </svg>`, }) export class SendIconComponent { @Input() size: IconVariants['size'] = 'medium'; @Input() class: string = undefined; - iconVariants = iconVariants; twMerge = twMerge; } diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden-steps/vorgang-detail-bescheiden-steps-content/vorgang-detail-bescheiden-bescheid-versenden/vorgang-detail-bescheiden-bescheid-versenden.component.html b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden-steps/vorgang-detail-bescheiden-steps-content/vorgang-detail-bescheiden-bescheid-versenden/vorgang-detail-bescheiden-bescheid-versenden.component.html index d5ddb566808baa79394497f37bfc150ee91c8428..db7e7a2afbbe80ca4fef1198e35794870fc6f4a6 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden-steps/vorgang-detail-bescheiden-steps-content/vorgang-detail-bescheiden-bescheid-versenden/vorgang-detail-bescheiden-bescheid-versenden.component.html +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden-steps/vorgang-detail-bescheiden-steps-content/vorgang-detail-bescheiden-bescheid-versenden/vorgang-detail-bescheiden-bescheid-versenden.component.html @@ -37,7 +37,7 @@ variant="bescheid_save" [fullWidthText]="true" data-test-id="send-to-antragsteller-button" - ><ods-send-icon></ods-send-icon + ><ods-send-icon size="large"></ods-send-icon ></ods-radio-button-card> <ods-radio-button-card *ngIf="bescheidResource$ | async | hasLink: bescheidLinkRel.BESCHEIDEN" @@ -47,7 +47,7 @@ variant="bescheid_save" [fullWidthText]="true" data-test-id="save-button" - ><ods-save-icon></ods-save-icon + ><ods-save-icon size="large"></ods-save-icon ></ods-radio-button-card> </ng-container> </div> diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-archive-container/vorgang-archive-container.component.html b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-archive-container/vorgang-archive-container.component.html index 3e98adaa3682b9c15e2f4022337ae6b976bb7571..aabaa1db527f7da3a18e21404dadf92a27395e49 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-archive-container/vorgang-archive-container.component.html +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-archive-container/vorgang-archive-container.component.html @@ -1,6 +1,9 @@ -<ozgcloud-button-with-spinner +<ods-button dataTestId="archive-vorgang" (click)="openArchiveConfirmationDialog()" + variant="outline" + size="medium" text="Archivierung starten" - icon="archive" -/> \ No newline at end of file +> + <ods-archive-icon icon /> +</ods-button> \ No newline at end of file diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-archive-container/vorgang-archive-container.component.spec.ts b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-archive-container/vorgang-archive-container.component.spec.ts index 719a3d1c86750caaef87f14d33bf391c27286977..a8fa62ffcf26525cbb6677ea9b9db82624aa3f8b 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-archive-container/vorgang-archive-container.component.spec.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-archive-container/vorgang-archive-container.component.spec.ts @@ -1,10 +1,10 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { mock } from '@alfa-client/test-utils'; -import { OzgcloudButtonWithSpinnerComponent, OzgcloudDialogService } from '@alfa-client/ui'; +import { OzgcloudDialogService } from '@alfa-client/ui'; +import { ArchiveIconComponent, ButtonComponent } from '@ods/system'; import { createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang'; import { MockComponent } from 'ng-mocks'; -import { describe } from 'node:test'; import { VorgangArchiveConfirmationDialogContainerComponent } from './vorgang-archive-confirmation-dialog-container/vorgang-archive-confirmation-dialog-container.component'; import { VorgangArchiveContainerComponent } from './vorgang-archive-container.component'; @@ -20,8 +20,9 @@ describe('VorgangArchiveContainerComponent', () => { await TestBed.configureTestingModule({ imports: [ VorgangArchiveContainerComponent, - MockComponent(OzgcloudButtonWithSpinnerComponent), + MockComponent(ButtonComponent), MockComponent(VorgangArchiveConfirmationDialogContainerComponent), + MockComponent(ArchiveIconComponent), ], providers: [ { diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.html b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.html index 5e342045a6fd05e9ee6c7dafa65b2337ceb8d58c..1ab39ddeb6953af23176375781680b3c93b58fe8 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.html +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.html @@ -23,14 +23,17 @@ unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<ozgcloud-button-with-spinner + +<ods-button-with-spinner *ngIf="vorgangWithEingang | hasLink: vorgangWithEingangLinkRel.EXPORT; else exportNotPossible" dataTestId="export-vorgang" - [showSpinner]="(exportStateResource$ | async)?.loading" (clickEmitter)="export()" + [stateResource]="exportStateResource$ | async" + variant="outline" text="Herunterladen" - icon="save_alt" -/> +> + <ods-save-icon icon /> +</ods-button-with-spinner> <ng-template #exportNotPossible> <div class="flex items-start gap-2" data-test-id="cannot-export-vorgang"> <ods-exclamation-icon /> diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.scss b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.scss deleted file mode 100644 index 54c4f3eb8c92af93694c03cdf577fed23cf9f86b..0000000000000000000000000000000000000000 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.scss +++ /dev/null @@ -1,23 +0,0 @@ -/** - * Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - * Ministerpräsidenten des Landes Schleswig-Holstein - * Staatskanzlei - * Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - * - * Lizenziert unter der EUPL, Version 1.2 oder - sobald - * diese von der Europäischen Kommission genehmigt wurden - - * Folgeversionen der EUPL ("Lizenz"); - * Sie dürfen dieses Werk ausschließlich gemäß - * dieser Lizenz nutzen. - * Eine Kopie der Lizenz finden Sie hier: - * - * https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - * - * Sofern nicht durch anwendbare Rechtsvorschriften - * gefordert oder in schriftlicher Form vereinbart, wird - * die unter der Lizenz verbreitete Software "so wie sie - * ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - * ausdrücklich oder stillschweigend - verbreitet. - * Die sprachspezifischen Genehmigungen und Beschränkungen - * unter der Lizenz sind dem Lizenztext zu entnehmen. - */ diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.spec.ts b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.spec.ts index 252e214664a08b65bf33efda7a9c0520c51c255e..56a9ee5d0e97c4977955053e68da5e110ba3a4ba 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.spec.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.spec.ts @@ -23,10 +23,10 @@ */ import { HasLinkPipe, StateResource, createStateResource } from '@alfa-client/tech-shared'; import { getElementFromFixture, mock } from '@alfa-client/test-utils'; -import { OzgcloudButtonWithSpinnerComponent } from '@alfa-client/ui'; import { VorgangService, VorgangWithEingangLinkRel } from '@alfa-client/vorgang-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { ExclamationIconComponent } from '@ods/system'; +import { ButtonWithSpinnerComponent } from '@ods/component'; +import { ExclamationIconComponent, SaveIconComponent } from '@ods/system'; import { getDataTestIdOf } from 'libs/tech-shared/test/data-test'; import { createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang'; import { MockComponent } from 'ng-mocks'; @@ -48,8 +48,9 @@ describe('VorgangExportContainerComponent', () => { declarations: [ HasLinkPipe, VorgangExportContainerComponent, - MockComponent(OzgcloudButtonWithSpinnerComponent), + MockComponent(ButtonWithSpinnerComponent), MockComponent(ExclamationIconComponent), + MockComponent(SaveIconComponent), ], providers: [ { diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.ts b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.ts index c41a76aa1bb1425107643c0fbbcec366c629e989..d7402d47d16f87180f042dd8b714896e0a0e3118 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-export-container/vorgang-export-container.component.ts @@ -22,18 +22,13 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { StateResource } from '@alfa-client/tech-shared'; -import { - VorgangService, - VorgangWithEingangLinkRel, - VorgangWithEingangResource, -} from '@alfa-client/vorgang-shared'; +import { VorgangService, VorgangWithEingangLinkRel, VorgangWithEingangResource } from '@alfa-client/vorgang-shared'; import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; import { Observable, tap } from 'rxjs'; @Component({ selector: 'alfa-vorgang-export-container', templateUrl: './vorgang-export-container.component.html', - styleUrls: ['./vorgang-export-container.component.scss'], }) export class VorgangExportContainerComponent implements OnInit { @Input() vorgangWithEingang: VorgangWithEingangResource; diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-process-vorgang-container/vorgang-process-vorgang-container.component.html b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-process-vorgang-container/vorgang-process-vorgang-container.component.html index bc44557c368dc9d04d6b79e1ad0724acb9190993..881e47d601c89b457d5fc6d133dfc94d9a606005 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-process-vorgang-container/vorgang-process-vorgang-container.component.html +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-more-menu/vorgang-process-vorgang-container/vorgang-process-vorgang-container.component.html @@ -23,11 +23,12 @@ unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<ozgcloud-button-with-spinner +<ods-button-with-spinner dataTestId="process-vorgang" - [stateResource]="commandStateResource$ | async" (clickEmitter)="processVorgang()" + [stateResource]="commandStateResource$ | async" + variant="outline" text="Vorgang vorprüfen" - svgIcon="done" > -</ozgcloud-button-with-spinner> + <ods-check-icon icon /> +</ods-button-with-spinner> \ No newline at end of file diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail.module.ts b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail.module.ts index 5396b5240004ed1a2dd17dbbafa3cd3bfd29f772..33de77704a82b60284d655cd1fd584f7dc12142a 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail.module.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail.module.ts @@ -57,6 +57,7 @@ import { BescheidUploadIconComponent, ButtonCardComponent, ButtonComponent, + CheckIconComponent, CloseIconComponent, ErrorMessageComponent, ExclamationIconComponent, @@ -168,6 +169,7 @@ const routes: Routes = [ ErrorMessageComponent, CollaborationModule, ArchiveIconComponent, + CheckIconComponent, ], declarations: [ VorgangDetailPageComponent,