From 59bd5b962c771fb22980f6d228e5f21721d72bea Mon Sep 17 00:00:00 2001 From: sebo <sebastian.bergandy@external.mgm-cp.com> Date: Mon, 6 Jan 2025 12:54:33 +0100 Subject: [PATCH] OZG-6989 always init users in e2e --- .../src/e2e/main-tests/init-users.cy.ts | 18 +++++++----------- .../apps/alfa-e2e/src/support/user-util.ts | 5 ----- 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/init-users.cy.ts b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/init-users.cy.ts index 0725ac9ce2..5df41dccaf 100644 --- a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/init-users.cy.ts +++ b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/init-users.cy.ts @@ -28,7 +28,7 @@ import { HeaderE2EComponent } from '../../page-objects/header.po'; import { MainPage, waitForSpinnerToDisappear } from '../../page-objects/main.po'; import { login, writeUserIdsIntoFile } from '../../support/cypress-helper'; import { exist } from '../../support/cypress.util'; -import { areUsersSynced, DatabaseUser } from '../../support/user-util'; +import { DatabaseUser } from '../../support/user-util'; registerLocaleData(localeDe, 'de', localeDeExtra); @@ -61,18 +61,14 @@ describe('Init users', () => { }); it('should write user ids to file', () => { - if (!areUsersSynced()) { - writeUserIdsIntoFile(); - } + writeUserIdsIntoFile(); }); function syncUser(user: DatabaseUser) { - if (!areUsersSynced()) { - login(user); - waitForSpinnerToDisappear(); - exist(header.getLogo()); - header.getCurrentUserProfile().getUserIconButton().click(); - header.getCurrentUserProfile().getLogoutButton().click(); - } + login(user); + waitForSpinnerToDisappear(); + exist(header.getLogo()); + header.getCurrentUserProfile().getUserIconButton().click(); + header.getCurrentUserProfile().getLogoutButton().click(); } }); diff --git a/alfa-client/apps/alfa-e2e/src/support/user-util.ts b/alfa-client/apps/alfa-e2e/src/support/user-util.ts index 7fedf55dc2..c3fab69f00 100644 --- a/alfa-client/apps/alfa-e2e/src/support/user-util.ts +++ b/alfa-client/apps/alfa-e2e/src/support/user-util.ts @@ -21,7 +21,6 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { isNotEmpty } from '@alfa-client/tech-shared'; import { isEmpty } from 'lodash-es'; import { UserE2E } from '../model/user'; import { UsermanagerUserE2E } from '../model/usermanager'; @@ -52,10 +51,6 @@ export function getUserId(username: Username) { return userIds[username]; } -export function areUsersSynced(): boolean { - return isNotEmpty(userIds); -} - export function initUsermanagerUsers() { // initUsermanagerData([ // getUserManagerUserSabine(), -- GitLab