From 555688a193273e3c624337e791a073ce3aca471c Mon Sep 17 00:00:00 2001 From: OZGCloud <ozgcloud@mgm-tp.com> Date: Tue, 29 Jun 2021 11:12:56 +0200 Subject: [PATCH] remove unused/deprecated component --- goofy-client/libs/binary-file/src/index.ts | 1 - ...inary-file-upload-container.component.html | 3 - ...inary-file-upload-container.component.scss | 0 ...ry-file-upload-container.component.spec.ts | 78 ------------------- .../binary-file-upload-container.component.ts | 27 ------- .../binary-file/src/lib/binary-file.module.ts | 14 +--- 6 files changed, 2 insertions(+), 121 deletions(-) delete mode 100644 goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.html delete mode 100644 goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.scss delete mode 100644 goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.spec.ts delete mode 100644 goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.ts diff --git a/goofy-client/libs/binary-file/src/index.ts b/goofy-client/libs/binary-file/src/index.ts index d4afc7970a..8b4257633c 100644 --- a/goofy-client/libs/binary-file/src/index.ts +++ b/goofy-client/libs/binary-file/src/index.ts @@ -1,2 +1 @@ -export * from './lib/binary-file-upload-container/binary-file-upload-container.component'; export * from './lib/binary-file.module'; diff --git a/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.html b/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.html deleted file mode 100644 index d4661e4905..0000000000 --- a/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.html +++ /dev/null @@ -1,3 +0,0 @@ -<goofy-client-spinner [stateResource]="uploadInProgress$ | async"> - <goofy-client-file-upload (fileChanged)="uploadFile($event)"></goofy-client-file-upload> -</goofy-client-spinner> \ No newline at end of file diff --git a/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.scss b/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.scss deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.spec.ts b/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.spec.ts deleted file mode 100644 index 58e26bd7c1..0000000000 --- a/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.spec.ts +++ /dev/null @@ -1,78 +0,0 @@ -import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { BinaryFileService } from '@goofy-client/binary-file-shared'; -import { createEmptyStateResource, createStateResource } from '@goofy-client/tech-shared'; -import { mock } from '@goofy-client/test-utils'; -import { FileUploadComponent, SpinnerComponent } from '@goofy-client/ui'; -import { createCommandResource } from 'libs/command-shared/test/command'; -import { configureTestSuite } from 'ng-bullet'; -import { MockComponent } from 'ng-mocks'; -import { of } from 'rxjs'; -import { BinaryFileUploadContainerComponent } from './binary-file-upload-container.component'; - -describe('BinaryFileUploadContainerComponent', () => { - let component: BinaryFileUploadContainerComponent; - let fixture: ComponentFixture<BinaryFileUploadContainerComponent>; - - const service = mock(BinaryFileService); - - configureTestSuite(() => { - TestBed.configureTestingModule({ - declarations: [ - BinaryFileUploadContainerComponent, - MockComponent(FileUploadComponent), - MockComponent(SpinnerComponent) - ], - providers: [ - { - provide: BinaryFileService, - useValue: service - } - ] - }) - }) - - beforeEach(() => { - fixture = TestBed.createComponent(BinaryFileUploadContainerComponent); - component = fixture.componentInstance; - fixture.detectChanges(); - }); - - it('should create', () => { - expect(component).toBeTruthy(); - }); - - describe.skip('uploadFile', () => { - - const file: any = {}; - - beforeEach(() => { - service.uploadFile.mockReturnValue(of(file)); - }) - - it('should call service', () => { - component.uploadFile(file) - - expect(service.uploadFile).toBeCalledWith(file); - }) - }) - - describe('emit', () => { - - beforeEach(() => { - spyOn(component.uploadFinish, 'emit'); - fixture.detectChanges(); - }) - - it('should emit on loaded resource', () => { - component.emit(createStateResource(createCommandResource())); - - expect(component.uploadFinish.emit).toHaveBeenCalled(); - }) - - it('should not emit on pending resource', () => { - component.emit(createEmptyStateResource()); - - expect(component.uploadFinish.emit).not.toHaveBeenCalled(); - }) - }) -}); diff --git a/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.ts b/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.ts deleted file mode 100644 index f8aac3683e..0000000000 --- a/goofy-client/libs/binary-file/src/lib/binary-file-upload-container/binary-file-upload-container.component.ts +++ /dev/null @@ -1,27 +0,0 @@ -import { Component, EventEmitter, Output } from '@angular/core'; -import { BinaryFileService } from '@goofy-client/binary-file-shared'; -import { CommandResource } from '@goofy-client/command-shared'; -import { createEmptyStateResource, StateResource } from '@goofy-client/tech-shared'; -import { Observable, of } from 'rxjs'; - -@Component({ - selector: 'goofy-client-binary-file-upload-container', - templateUrl: './binary-file-upload-container.component.html', - styleUrls: ['./binary-file-upload-container.component.scss'] -}) -export class BinaryFileUploadContainerComponent { - - uploadInProgress$: Observable<StateResource<CommandResource>> = of(createEmptyStateResource()); - - @Output() uploadFinish: EventEmitter<File> = new EventEmitter(); - - constructor(private service: BinaryFileService) { } - - uploadFile(file: File): void { - //this.uploadInProgress$ = this.service.uploadFile(file).pipe(tap(stateResource => this.emit(stateResource))); - } - - emit(stateResource: StateResource<any>): void { - if (stateResource.loaded) this.uploadFinish.emit(stateResource.resource); - } -} \ No newline at end of file diff --git a/goofy-client/libs/binary-file/src/lib/binary-file.module.ts b/goofy-client/libs/binary-file/src/lib/binary-file.module.ts index 977f0777f4..7042a4e213 100644 --- a/goofy-client/libs/binary-file/src/lib/binary-file.module.ts +++ b/goofy-client/libs/binary-file/src/lib/binary-file.module.ts @@ -1,17 +1,7 @@ import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; -import { BinaryFileSharedModule } from '@goofy-client/binary-file-shared'; -import { UiModule } from '@goofy-client/ui'; -import { BinaryFileUploadContainerComponent } from './binary-file-upload-container/binary-file-upload-container.component'; + @NgModule({ - imports: [ - CommonModule, - BinaryFileSharedModule, - UiModule - ], - declarations: [ - BinaryFileUploadContainerComponent - ], - exports: [BinaryFileUploadContainerComponent] + imports: [CommonModule] }) export class BinaryFileModule { } -- GitLab