diff --git a/alfa-service/src/test/java/de/ozgcloud/alfa/common/file/OzgFileTestFactory.java b/alfa-service/src/test/java/de/ozgcloud/alfa/common/file/OzgFileTestFactory.java index 1e5d1935bea59eb2d158819fc19846d45ef098ad..aa59629aea36fc530a319b672521f761da816c6b 100644 --- a/alfa-service/src/test/java/de/ozgcloud/alfa/common/file/OzgFileTestFactory.java +++ b/alfa-service/src/test/java/de/ozgcloud/alfa/common/file/OzgFileTestFactory.java @@ -30,8 +30,7 @@ import de.ozgcloud.alfa.common.binaryfile.FileId; public class OzgFileTestFactory { - // See UUIDUtils.UUID_SPLIT_PATTERN - public static final FileId ID = FileId.from(UUID.randomUUID().toString().replace("-", "")); + public static final FileId ID = FileId.from(UUID.randomUUID().toString()); public static final String NAME = BinaryFileTestFactory.NAME; public static final long SIZE = BinaryFileTestFactory.SIZE; public static final String CONTENT_TYPE = BinaryFileTestFactory.CONTENT_TYPE; diff --git a/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/ExportServiceITCase.java b/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/ExportServiceITCase.java index 1399edc1887aaa8e1cce8aec34b69a4d3d4637f7..bc0499164b83f81cb28f219e92717768a4eb9710 100644 --- a/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/ExportServiceITCase.java +++ b/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/ExportServiceITCase.java @@ -1,16 +1,22 @@ package de.ozgcloud.alfa.export; +import static org.junit.jupiter.api.Assertions.*; import static org.mockito.Mockito.*; import java.io.ByteArrayOutputStream; +import java.nio.charset.StandardCharsets; +import java.util.HexFormat; import java.util.List; import java.util.UUID; +import org.apache.commons.lang3.RandomStringUtils; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.test.mock.mockito.SpyBean; +import de.ozgcloud.alfa.common.binaryfile.FileId; import de.ozgcloud.alfa.common.file.OzgFile; import de.ozgcloud.alfa.common.file.OzgFileTestFactory; import de.ozgcloud.alfa.file.ExportFileService; @@ -20,14 +26,11 @@ import de.ozgcloud.alfa.vorgang.VorgangWithEingangTestFactory; import de.ozgcloud.common.test.ITCase; @ITCase -public class ExportServiceITCase { - - private static final String VORGANG_ID = UUID.randomUUID().toString(); - private static final String FILENAME_ID = UUID.randomUUID().toString(); +class ExportServiceITCase { private final ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); private final VorgangWithEingang vorgangWithEingang = VorgangWithEingangTestFactory.create(); - private final List<OzgFile> ozgFiles = List.of(OzgFileTestFactory.create()); + private final List<OzgFile> ozgFiles = List.of(createOzgFile()); @SpyBean private ExportFileService exportFileService; @@ -36,15 +39,29 @@ public class ExportServiceITCase { @Autowired private ExportService exportService; - @BeforeEach - void setup() { - doReturn(vorgangWithEingang).when(exportVorgangService).getVorgang(anyString()); - doReturn(ozgFiles).when(exportFileService).getAllPdfs(anyString()); - doNothing().when(exportFileService).writeOzgFile(any(), any()); + @Nested + class TestWriteExport { + + @BeforeEach + void setup() { + doReturn(vorgangWithEingang).when(exportVorgangService).getVorgang(anyString()); + doReturn(ozgFiles).when(exportFileService).getAllPdfs(anyString()); + doNothing().when(exportFileService).writeOzgFile(any(), any()); + } + + @Test + void shouldNotThrowException() { + assertDoesNotThrow(() -> exportService.writeExport(UUID.randomUUID().toString(), UUID.randomUUID().toString(), outputStream)); + } + } + + private static OzgFile createOzgFile() { + return OzgFileTestFactory.createBuilder() + .id(FileId.from(createMongoDbObjectId())) + .build(); } - @Test - void shouldNotThrowException() { - exportService.writeExport(VORGANG_ID, FILENAME_ID, outputStream); + private static String createMongoDbObjectId() { + return HexFormat.of().formatHex(RandomStringUtils.randomAlphanumeric(24).getBytes(StandardCharsets.UTF_8)); } }