diff --git a/alfa-client/apps/admin-e2e/src/e2e/main-tests/benutzer_rollen/benutzer-zu-oe-hinzufuegen.cy.ts b/alfa-client/apps/admin-e2e/src/e2e/main-tests/benutzer_rollen/benutzer-zu-oe-hinzufuegen.cy.ts index 3735e511e5eb33b45987bbf61fb4aa757d02025c..9095c63279a17ffe2cbada1f4de9f956593c0638 100644 --- a/alfa-client/apps/admin-e2e/src/e2e/main-tests/benutzer_rollen/benutzer-zu-oe-hinzufuegen.cy.ts +++ b/alfa-client/apps/admin-e2e/src/e2e/main-tests/benutzer_rollen/benutzer-zu-oe-hinzufuegen.cy.ts @@ -13,7 +13,7 @@ describe('Organisationseinheit zu Benutzer hinzufügen', () => { const zustaendigeStelleSearchComponent: ZustaendigeStelleDialogE2EComponent = new ZustaendigeStelleDialogE2EComponent(); const organistationsEinheitOrdnungsamt: string = 'Ordnungsamt'; const organisationsEinheitDenkmalpflege: string = 'Denkmalpflege'; - const organisationsEinheitWentorf: string = 'grundschule wentorf'; + const organisationsEinheitLiegenschaften: string = 'Liegenschaften'; const organisationsEinheitNone: string = 'keine zuständige Stelle zugewiesen'; const vorname: string = 'Theo'; const nachname: string = 'Testuser'; @@ -91,7 +91,7 @@ describe('Organisationseinheit zu Benutzer hinzufügen', () => { it('should enable new Organisationseinheit for users after adding it', () => { mainPage.clickOrganisationsEinheitenNavigationItem(); organisationsEinheitenComponent.clickHinzufuegen(); - zustaendigeStelleSearchComponent.enterSearchTerm(organisationsEinheitWentorf); + zustaendigeStelleSearchComponent.enterSearchTerm(organisationsEinheitLiegenschaften); zustaendigeStelleSearchComponent.getZustaendigeStelleTitle(0).then((title: string) => { zustaendigeStelleSearchComponent.clickFoundItem(0); }); @@ -99,12 +99,12 @@ describe('Organisationseinheit zu Benutzer hinzufügen', () => { mainPage.clickBenutzerNavigationItem(); benutzerPage.clickUserEntry(benutzername2); - exist(benutzerPage.getOrganisationsEinheitCheckbox(organisationsEinheitWentorf)); + exist(benutzerPage.getOrganisationsEinheitCheckbox(organisationsEinheitLiegenschaften)); }); it('should add new Organisationseinheit to existing user', () => { - benutzerPage.clickOrganisationsEinheitCheckbox(organistationsEinheitOrdnungsamt); + benutzerPage.clickOrganisationsEinheitCheckbox(organisationsEinheitLiegenschaften); benutzerPage.saveUser(); - benutzerPage.stringExistsInUserEntry(organisationsEinheitWentorf, benutzername2); + benutzerPage.stringExistsInUserEntry(organisationsEinheitLiegenschaften, benutzername2); }); }); diff --git a/alfa-client/apps/admin-e2e/src/e2e/main-tests/organisationseinheiten/organisationseinheiten-laden.cy.ts b/alfa-client/apps/admin-e2e/src/e2e/main-tests/organisationseinheiten/organisationseinheiten-laden.cy.ts index ed230c60ca0575070181bc4c680f2876b231f808..91a1673e96e41b8dbdae4e4338e864a0527f816e 100644 --- a/alfa-client/apps/admin-e2e/src/e2e/main-tests/organisationseinheiten/organisationseinheiten-laden.cy.ts +++ b/alfa-client/apps/admin-e2e/src/e2e/main-tests/organisationseinheiten/organisationseinheiten-laden.cy.ts @@ -48,7 +48,7 @@ describe.skip('TODO: activate after fix for OZG-7391: show Organisationsheiten', it('should show table of Organisationseinheiten', () => { waitForSpinnerToDisappear(); - mainPage.openOrganisationsEinheiten(); + mainPage.clickOrganisationsEinheitenNavigationItem(); exist(organisationsEinheitenTab.getOrganisationsEinheitList()); }); diff --git a/alfa-client/apps/admin/src/app/app.component.ts b/alfa-client/apps/admin/src/app/app.component.ts index fe6c276c6df933b4df3e29605271a7cf31380042..6de5c0ab4da5fed7ffc763b86cdb18e253c44528 100644 --- a/alfa-client/apps/admin/src/app/app.component.ts +++ b/alfa-client/apps/admin/src/app/app.component.ts @@ -27,13 +27,19 @@ import { ROUTES } from '@admin-client/shared'; import { KeycloakTokenService } from '@admin/keycloak-shared'; import { ApiRootLinkRel, ApiRootResource, ApiRootService } from '@alfa-client/api-root-shared'; import { BuildInfoComponent } from '@alfa-client/common'; -import { isLoaded, isNotUndefined, mapToResource, StateResource, TechSharedModule } from '@alfa-client/tech-shared'; +import { HasLinkPipe, isLoaded, isNotUndefined, mapToResource, StateResource } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, inject, OnInit } from '@angular/core'; import { Router, RouterLink, RouterOutlet } from '@angular/router'; import { AuthenticationService } from '@authentication'; import { hasLink } from '@ngxp/rest'; -import { AdminLogoIconComponent, NavbarComponent, NavItemComponent, OrgaUnitIconComponent, UsersIconComponent, } from '@ods/system'; +import { + AdminLogoIconComponent, + NavbarComponent, + NavItemComponent, + OrgaUnitIconComponent, + UsersIconComponent, +} from '@ods/system'; import { filter, Observable, Subscription } from 'rxjs'; import { UserProfileButtonContainerComponent } from '../common/user-profile-button-container/user-profile.button-container.component'; import { UnavailablePageComponent } from '../pages/unavailable/unavailable-page/unavailable-page.component'; @@ -54,9 +60,9 @@ import { UnavailablePageComponent } from '../pages/unavailable/unavailable-page/ RouterOutlet, UnavailablePageComponent, BuildInfoComponent, - TechSharedModule, MenuContainerComponent, RouterLink, + HasLinkPipe, ], }) export class AppComponent implements OnInit { diff --git a/alfa-client/apps/admin/src/main.ts b/alfa-client/apps/admin/src/main.ts index 517ab0538bea573be67b1b8184ec7bb50695c242..7f198e2f5459037b727eb464f2259321948eeaed 100644 --- a/alfa-client/apps/admin/src/main.ts +++ b/alfa-client/apps/admin/src/main.ts @@ -32,7 +32,13 @@ import { HTTP_INTERCEPTORS, provideHttpClient, withInterceptorsFromDi } from '@a import localeDe from '@angular/common/locales/de'; import { bootstrapApplication, BrowserModule } from '@angular/platform-browser'; import { provideAnimations } from '@angular/platform-browser/animations'; -import { ActivatedRouteSnapshot, BaseRouteReuseStrategy, provideRouter, RouteReuseStrategy, withRouterConfig, } from '@angular/router'; +import { + ActivatedRouteSnapshot, + BaseRouteReuseStrategy, + provideRouter, + RouteReuseStrategy, + withRouterConfig, +} from '@angular/router'; import { HttpUnauthorizedInterceptor } from '@authentication'; import { EffectsModule } from '@ngrx/effects'; import { StoreRouterConnectingModule } from '@ngrx/router-store'; @@ -43,6 +49,9 @@ import { ConfigurationsProviders } from 'libs/admin/configuration-shared/src/lib import { PostfachProviders } from 'libs/admin/postfach-shared/src/lib/postfach.providers'; import { SettingsProviders } from 'libs/admin/settings-shared/src/lib/settings.providers'; import { UserProviders } from 'libs/admin/user/src/lib/user.providers'; +import { HttpBinaryFileInterceptor } from '../../../libs/tech-shared/src/lib/interceptor/http-binary-file.interceptor'; +import { HttpXsrfInterceptor } from '../../../libs/tech-shared/src/lib/interceptor/http-xsrf.interceptor'; +import { XhrInterceptor } from '../../../libs/tech-shared/src/lib/interceptor/xhr.interceptor'; import { AppComponent } from './app/app.component'; import { appRoutes } from './app/app.routes'; import { environment } from './environments/environment'; @@ -69,6 +78,21 @@ loadEnvironment(environment.environmentUrl).then((env) => { bootstrapApplication(AppComponent, { providers: [ { provide: RouteReuseStrategy, useClass: NoRouteReuseStrategy }, + { + provide: HTTP_INTERCEPTORS, + useClass: XhrInterceptor, + multi: true, + }, + { + provide: HTTP_INTERCEPTORS, + useClass: HttpXsrfInterceptor, + multi: true, + }, + { + provide: HTTP_INTERCEPTORS, + useClass: HttpBinaryFileInterceptor, + multi: true, + }, ConfigurationsProviders, PostfachProviders, SettingsProviders, diff --git a/alfa-client/apps/admin/src/pages/organisationseinheit/organisationseinheit-page/organisationseinheit-page.component.ts b/alfa-client/apps/admin/src/pages/organisationseinheit/organisationseinheit-page/organisationseinheit-page.component.ts index d2d9e1334032279c2fd0aa5b32ffc76a89944534..431f26bb8d2aa1913a5a8b67563aa75466d13ce3 100644 --- a/alfa-client/apps/admin/src/pages/organisationseinheit/organisationseinheit-page/organisationseinheit-page.component.ts +++ b/alfa-client/apps/admin/src/pages/organisationseinheit/organisationseinheit-page/organisationseinheit-page.component.ts @@ -22,12 +22,13 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { OrganisationsEinheitContainerComponent } from '@admin-client/organisations-einheit'; +import { HasLinkPipe } from '@alfa-client/tech-shared'; import { Component } from '@angular/core'; @Component({ selector: 'organisationseinheit-page', templateUrl: './organisationseinheit-page.component.html', standalone: true, - imports: [OrganisationsEinheitContainerComponent], + imports: [ OrganisationsEinheitContainerComponent, HasLinkPipe], }) export class OrganisationsEinheitPageComponent {} diff --git a/alfa-client/apps/alfa-e2e/docker-compose.yml b/alfa-client/apps/alfa-e2e/docker-compose.yml index efbb27de9070db53e35dc0e0c7c3d41ed9015966..cb3cff0ebb701a6600ea2204ea18b3928a0ddbbd 100644 --- a/alfa-client/apps/alfa-e2e/docker-compose.yml +++ b/alfa-client/apps/alfa-e2e/docker-compose.yml @@ -154,7 +154,7 @@ services: soft: 65536 hard: 65536 healthcheck: - test: [ 'CMD-SHELL', "curl -s 'http://localhost:9200/_cat/health?h=status' | egrep -q '(green|yellow)'" ] + test: ['CMD-SHELL', "curl -s 'http://localhost:9200/_cat/health?h=status' | egrep -q '(green|yellow)'"] interval: 10s timeout: 10s retries: 5 @@ -195,7 +195,7 @@ services: - 7080:8080 - 7081:8081 healthcheck: - test: [ 'CMD-SHELL', 'wget --spider localhost:8081/version' ] + test: ['CMD-SHELL', 'wget --spider localhost:8081/version'] interval: 5s timeout: 5s retries: 5 diff --git a/alfa-client/apps/alfa-e2e/src/components/ui/button-with-spinner.e2e.component.ts b/alfa-client/apps/alfa-e2e/src/components/ui/button-with-spinner.e2e.component.ts deleted file mode 100644 index 4ac9816e675cd64b552f97c41b05a685dd8307d1..0000000000000000000000000000000000000000 --- a/alfa-client/apps/alfa-e2e/src/components/ui/button-with-spinner.e2e.component.ts +++ /dev/null @@ -1,35 +0,0 @@ -/* - * Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - * Ministerpräsidenten des Landes Schleswig-Holstein - * Staatskanzlei - * Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - * - * Lizenziert unter der EUPL, Version 1.2 oder - sobald - * diese von der Europäischen Kommission genehmigt wurden - - * Folgeversionen der EUPL ("Lizenz"); - * Sie dürfen dieses Werk ausschließlich gemäß - * dieser Lizenz nutzen. - * Eine Kopie der Lizenz finden Sie hier: - * - * https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - * - * Sofern nicht durch anwendbare Rechtsvorschriften - * gefordert oder in schriftlicher Form vereinbart, wird - * die unter der Lizenz verbreitete Software "so wie sie - * ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - * ausdrücklich oder stillschweigend - verbreitet. - * Die sprachspezifischen Genehmigungen und Beschränkungen - * unter der Lizenz sind dem Lizenztext zu entnehmen. - */ -export class ButtonWithSpinnerE2EComponent { - private readonly locatorButton: string = 'icon-button'; - - public findButton(root) { - return root.findTestElementWithClass(this.locatorButton); - } - - //TODO Methode aus der MeinPage verwenden - public waitToDisappear(root) { - root.should('not.have.descendants', '[data-test-class=spinner]'); - } -} diff --git a/alfa-client/apps/alfa-e2e/src/components/wiedervorlage/wiedervorlage-page.e2e.component.ts b/alfa-client/apps/alfa-e2e/src/components/wiedervorlage/wiedervorlage-page.e2e.component.ts index 4be7b6532108923566044183f5591b1a175ee2d8..e17043afdfaa7c7de564ec7b244ff85b1761985a 100644 --- a/alfa-client/apps/alfa-e2e/src/components/wiedervorlage/wiedervorlage-page.e2e.component.ts +++ b/alfa-client/apps/alfa-e2e/src/components/wiedervorlage/wiedervorlage-page.e2e.component.ts @@ -22,7 +22,6 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { AttachmentContainerE2EComponent } from '../attachment/attachment.e2e.component'; -import { ButtonWithSpinnerE2EComponent } from '../ui/button-with-spinner.e2e.component'; export class WiedervorlageE2EComponent { private readonly locatorBetreffInput: string = 'Betreff-text-input'; @@ -33,10 +32,7 @@ export class WiedervorlageE2EComponent { private readonly locatorStatusDot: string = 'dot'; private readonly locatorSpeichernButton: string = 'speichern-button'; - private readonly buttonWithSpinnerComponent: ButtonWithSpinnerE2EComponent = - new ButtonWithSpinnerE2EComponent(); - private readonly attachmentContainer: AttachmentContainerE2EComponent = - new AttachmentContainerE2EComponent(); + private readonly attachmentContainer: AttachmentContainerE2EComponent = new AttachmentContainerE2EComponent(); public getBetreff() { return cy.getTestElement(this.locatorBetreffInput); @@ -63,9 +59,7 @@ export class WiedervorlageE2EComponent { } public getSpeichernButton() { - return this.buttonWithSpinnerComponent.findButton( - cy.getTestElement(this.locatorSpeichernButton), - ); + return cy.getTestElement(this.locatorSpeichernButton); } public getAttachmentContainer(): AttachmentContainerE2EComponent { diff --git a/alfa-client/apps/alfa-e2e/src/components/wiedervorlage/wiedervorlagen-in-vorgang.e2e.component.ts b/alfa-client/apps/alfa-e2e/src/components/wiedervorlage/wiedervorlagen-in-vorgang.e2e.component.ts index 93801c671d44ca75f7473867689c7941d6efa611..91718623842de6e64bb8c0a863ba2146606d68c4 100644 --- a/alfa-client/apps/alfa-e2e/src/components/wiedervorlage/wiedervorlagen-in-vorgang.e2e.component.ts +++ b/alfa-client/apps/alfa-e2e/src/components/wiedervorlage/wiedervorlagen-in-vorgang.e2e.component.ts @@ -21,15 +21,10 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { ButtonWithSpinnerE2EComponent } from '../ui/button-with-spinner.e2e.component'; import { WiedervorlageInVorgangE2EComponent } from './wiedervorlage-in-vorgang.e2e.component'; export class WiedervorlagenInVorgangE2EComponent { private readonly locatorCreateWiedervorlageButton: string = 'create-wiedervorlage'; - - private readonly buttonWithSpinnerComponent: ButtonWithSpinnerE2EComponent = - new ButtonWithSpinnerE2EComponent(); - private readonly locatorRoot: string = 'wiedervorlagen-in-vorgang'; public getRoot() { diff --git a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-detailansicht-formdata.cy.ts b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-detailansicht-formdata.cy.ts index 893f7d2d803a5ba3b368af963a296f6dc494620c..a7912650d925a0159a8ec3793d6cca2449715311 100644 --- a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-detailansicht-formdata.cy.ts +++ b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-detailansicht-formdata.cy.ts @@ -39,6 +39,7 @@ import { initVorgaenge, objectIds, } from '../../../support/vorgang-util'; +import { VorgangSubnavigationE2EComponent } from 'apps/alfa-e2e/src/components/vorgang/vorgang-subnavigation'; registerLocaleData(localeDe, 'de', localeDeExtra); @@ -51,6 +52,7 @@ describe('Vorgang Detailansicht with formData', () => { vorgangPage.getFormularDatenContainer(); const vorgangHeader: VorgangDetailHeaderE2EComponent = vorgangPage.getVorgangDetailHeader(); + const vorgangSubnavigation: VorgangSubnavigationE2EComponent = new VorgangSubnavigationE2EComponent(); const ort: string = 'Ort'; const sh_strasse: string = 'Strasse'; @@ -135,33 +137,12 @@ describe('Vorgang Detailansicht with formData', () => { contains(vorgangDatenFormular.getRoot(), 'sh_strasse'); }); }); - - // SKIP: Metadaten sind aktuell aus - describe('click on "Metadaten" tab', () => { - it.skip('should show on click on tab', () => { - vorgangDatenFormular.getMetadatenTab().click(); - - exist(vorgangDatenFormular.getMetadaten()); - }); - - it.skip('should show "emailadresse"', () => { - contains(vorgangDatenFormular.getRoot(), 'emailadresse'); - }); - - it.skip('should show "postleitzahl"', () => { - contains(vorgangDatenFormular.getRoot(), 'postleitzahl'); - }); - - it('should navigate back to Vorgang List', () => { - vorgangPage.getSubnavigation().getBackButton().click(); - waitForSpinnerToDisappear(); - }); - }); }); describe('navigate to vorgang detail (with labels)', () => { describe('click on vorgang in list', () => { it('should show header', () => { + vorgangSubnavigation.back(); vorgangList.getListItem(vorgangWithLabels.name).getRoot().click(); waitForSpinnerToDisappear(); @@ -193,20 +174,5 @@ describe('Vorgang Detailansicht with formData', () => { }); }); - describe.skip('click on "Metadaten" tab', () => { - it('should show on click on tab', () => { - vorgangDatenFormular.getMetadatenTab().click(); - - exist(vorgangDatenFormular.getMetadaten()); - }); - - it('should show "E-Mail Adresse"', () => { - contains(vorgangDatenFormular.getRoot(), emailadresse); - }); - - it('should show "PLZ"', () => { - contains(vorgangDatenFormular.getRoot(), postleitzahl); - }); - }); }); }); diff --git a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-detailansicht.cy.ts b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-detailansicht.cy.ts index 7fa1b271ad7f923a8757a96e1e73854837fe101c..435e7106eda6a88a896ac03e25fe1cc75f1132e7 100644 --- a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-detailansicht.cy.ts +++ b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-detailansicht.cy.ts @@ -107,19 +107,6 @@ describe('Vorgang Detailansicht', () => { }); }); - // SKIP: Metada sind aktuell disabled - describe.skip('metadaten in tab', () => { - it('should show on click on tab', () => { - vorgangDatenFormular.getMetadatenTab().click(); - - exist(vorgangDatenFormular.getMetadaten()); - }); - - it('should show "empfangendestelle"', () => { - contains(vorgangDatenFormular.getRoot(), vorgang.eingangs[0].formData.empfangendestelle.emailadresse); - }); - }); - describe('antragdaten in tab', () => { it('should show on click on tab', () => { vorgangDatenFormular.getAntragdatenTab().click(); diff --git a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-vorpruefen.cy.ts b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-vorpruefen.cy.ts index 2b9956e17ae93200b66f44edd95bca083813ea1f..ca02f561b4be2aa40d3a8dc9c65feeff9dfe6269 100644 --- a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-vorpruefen.cy.ts +++ b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-vorpruefen.cy.ts @@ -115,40 +115,23 @@ describe.skip('Vorgang vorprüfen', () => { }); it('should open "more menu"', () => { - //nur testweise - //kommentarContainer.getHinzufuegenButton().click(); - //kommentarContainer.getTextInput().clear().type(kommentarText); - //kommentarContainer.getFormularSpeichernButton().click(); waitForSpinnerToDisappear(); - // - vorgangMoreMenu.getButton().click(); exist(vorgangMoreMenu.getRoot()); }); - it('should show Prüfung item', () => { - //exist(menuItem.getRoot());? - }); - it('should show "Vorgang vorpüfen" button', () => { exist(menuItem.getButton()); }); - it('should have a positive comment after Prüfung', () => { + it.skip('AKTUELL FEHLER: should have a positive comment after Prüfung', () => { menuItem.getButton().click(); - //waitForSpinnerToDisappear(); - exist(kommentarContainer.getKommentar(kommentarText).getRoot()); - //check for positive comment }); it('should close menu after Prüfung', () => { - //am Ende entfernen vorgangMoreMenu.getButton().click(); - - //notExist(menuItem.getRoot()); - vorgangPage.getSubnavigation().getBackButton().click(); }); }); @@ -165,22 +148,10 @@ describe.skip('Vorgang vorprüfen', () => { exist(vorgangPage.getVorgangDetailHeader().getRoot()); }); - it('should have a negative comment after Prüfung', () => { + it.skip('AKTUELL FEHLER: should have a negative comment after Prüfung', () => { vorgangMoreMenu.getButton().click(); - menuItem.getButton().click(); - - //nur testweise - //kommentarContainer.getHinzufuegenButton().click(); - //kommentarContainer.getTextInput().clear().type(kommentarText); - //kommentarContainer.getFormularSpeichernButton().click(); - waitForSpinnerToDisappear(); - // - - waitForSpinnerToDisappear(); - exist(kommentarContainer.getKommentar(kommentarText).getRoot()); - //check for negative comment }); it('should close menu after Prüfung', () => { @@ -190,20 +161,12 @@ describe.skip('Vorgang vorprüfen', () => { }); }); - describe('button not available on other Vorgänge', () => { - const menuItem: VorgangMoreMenuVorpruefenItemE2EComponent = - vorgangMoreMenu.getVorpruefenItem(); - - it('should open Vorgang-Detail-Page', () => { + describe('menu not available on other Vorgänge', () => { + it('should not show more menu on other Vorgänge', () => { vorgangList.getListItem(vorgangOhnePruefung.name).getRoot().click(); waitForSpinnerToDisappear(); - exist(vorgangPage.getVorgangDetailHeader().getRoot()); - }); - - it('more menu should not contain Vorprüfen button', () => { - vorgangMoreMenu.getButton().click(); - notExist(menuItem.getRoot()); + notExist(vorgangMoreMenu.getRoot()); }); }); }); diff --git a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-wiedereroeffnen.cy.ts b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-wiedereroeffnen.cy.ts index c86efc5d90992c7d5eb14b126554bc3b1872cac1..246013c7b169d348bd6882b3cd20f1d211f1b6fa 100644 --- a/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-wiedereroeffnen.cy.ts +++ b/alfa-client/apps/alfa-e2e/src/e2e/main-tests/vorgang-detailansicht/vorgang-wiedereroeffnen.cy.ts @@ -153,8 +153,9 @@ describe('Vorgang wiedereroeffnen', () => { contains(snackbar.getMessage(), VorgangMessagesE2E.WIEDEREROEFFNET); }); - it('should close snackbar on revoke', () => { + it('should click on snackbar revoke', () => { snackbar.getRevokeButton().click(); + wait(500); waitForSpinnerToDisappear(); notExist(snackbar.getMessage()); @@ -258,7 +259,7 @@ describe('Vorgang wiedereroeffnen', () => { contains(snackbar.getMessage(), VorgangMessagesE2E.WIEDEREROEFFNET); }); - it('should close snackbar on revoke', () => { + it('should click snackbar revoke', () => { snackbar.getRevokeButton().click(); wait(500); waitForSpinnerToDisappear(); diff --git a/alfa-client/apps/alfa/src/app/app.component.ts b/alfa-client/apps/alfa/src/app/app.component.ts index 559dcfd6e2a53319d2a3710cddbf06c168e8a112..6a4820c7036735d0a1fd127463805e28aacad058 100644 --- a/alfa-client/apps/alfa/src/app/app.component.ts +++ b/alfa-client/apps/alfa/src/app/app.component.ts @@ -24,7 +24,7 @@ import { ApiRootFacade, ApiRootResource } from '@alfa-client/api-root-shared'; import { ENVIRONMENT_CONFIG } from '@alfa-client/environment-shared'; import { NavigationService } from '@alfa-client/navigation-shared'; -import { StateResource, isNotNull } from '@alfa-client/tech-shared'; +import { InjectorService, StateResource, isNotNull } from '@alfa-client/tech-shared'; import { IconService } from '@alfa-client/ui'; import { buildPathSegmentsFromLocalStorage } from '@alfa-client/vorgang-shared'; import { Component, Inject, OnInit } from '@angular/core'; @@ -49,6 +49,7 @@ export class AppComponent implements OnInit { private iconService: IconService, private oAuthService: OAuthService, private navigationService: NavigationService, + private injectorService: InjectorService, ) { this.iconService.registerIcons(); } diff --git a/alfa-client/apps/alfa/src/app/app.module.ts b/alfa-client/apps/alfa/src/app/app.module.ts index d8e90a9d20917ac50f4056a53fe9d18825cde65d..566ebc0b3fd03aa04506016be0d3c16aa1bf1fd9 100644 --- a/alfa-client/apps/alfa/src/app/app.module.ts +++ b/alfa-client/apps/alfa/src/app/app.module.ts @@ -29,11 +29,14 @@ import { HintSharedModule } from '@alfa-client/hint-shared'; import { NavigationModule } from '@alfa-client/navigation'; import { OzgCloudUrlSerializer } from '@alfa-client/navigation-shared'; import { ResourceRedirectComponent } from '@alfa-client/resource-redirect'; -import { UiModule } from '@alfa-client/ui'; +import { SpinnerComponent } from '@alfa-client/ui'; import { registerLocaleData } from '@angular/common'; -import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http'; +import { HTTP_INTERCEPTORS, provideHttpClient, withInterceptorsFromDi } from '@angular/common/http'; import localeDe from '@angular/common/locales/de'; import { LOCALE_ID, NgModule } from '@angular/core'; +import { DateFnsAdapter } from '@angular/material-date-fns-adapter'; +import { DateAdapter, MAT_DATE_FORMATS, MAT_DATE_LOCALE } from '@angular/material/core'; +import { MatIconModule } from '@angular/material/icon'; import { BrowserModule } from '@angular/platform-browser'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; import { RouterModule, Routes, UrlSerializer } from '@angular/router'; @@ -42,11 +45,29 @@ import { StoreRouterConnectingModule } from '@ngrx/router-store'; import { StoreModule } from '@ngrx/store'; import { StoreDevtoolsModule } from '@ngrx/store-devtools'; import { OAuthModule } from 'angular-oauth2-oidc'; +import { de } from 'date-fns/locale'; +import { HttpBinaryFileInterceptor } from '../../../../libs/tech-shared/src/lib/interceptor/http-binary-file.interceptor'; +import { HttpXsrfInterceptor } from '../../../../libs/tech-shared/src/lib/interceptor/http-xsrf.interceptor'; +import { XhrInterceptor } from '../../../../libs/tech-shared/src/lib/interceptor/xhr.interceptor'; +import { HttpConnectionTimeoutInterceptor } from '../../../../libs/ui/src/lib/interceptor/http-connection-timeout.interceptor'; +import { HttpErrorInterceptor } from '../../../../libs/ui/src/lib/interceptor/http-error.interceptor'; import { environment } from '../environments/environment'; import { AppComponent } from './app.component'; registerLocaleData(localeDe); +export const CUSTOM_DATE_FORMATS = { + parse: { + dateInput: 'dd.MM.yyyy', + }, + display: { + dateInput: 'dd.MM.yyyy', + monthYearLabel: 'MMM yyyy', + dateA11yLabel: 'dd.MM.yyyy', + monthYearA11yLabel: 'MM yyyy', + }, +}; + const routes: Routes = [ { path: '', @@ -61,13 +82,13 @@ const routes: Routes = [ @NgModule({ declarations: [AppComponent], imports: [ + MatIconModule, BrowserModule, BrowserAnimationsModule, RouterModule.forRoot(routes, { initialNavigation: 'disabled', onSameUrlNavigation: 'reload', }), - UiModule, EnvironmentModule, OAuthModule.forRoot({ resourceServer: { @@ -94,10 +115,49 @@ const routes: Routes = [ // Workaround: load any module depending on ApiRootActions.loadApiRootSuccess // TODO Check if a future NgRx version will solve Lazy Loading + Effects.forFeature() HintSharedModule, + SpinnerComponent, ], providers: [ { provide: LOCALE_ID, useValue: 'de' }, { provide: UrlSerializer, useClass: OzgCloudUrlSerializer }, + { + provide: HTTP_INTERCEPTORS, + useClass: HttpErrorInterceptor, + multi: true, + }, + { + provide: HTTP_INTERCEPTORS, + useClass: HttpConnectionTimeoutInterceptor, + multi: true, + }, + { + provide: HTTP_INTERCEPTORS, + useClass: XhrInterceptor, + multi: true, + }, + { + provide: HTTP_INTERCEPTORS, + useClass: HttpXsrfInterceptor, + multi: true, + }, + { + provide: HTTP_INTERCEPTORS, + useClass: HttpBinaryFileInterceptor, + multi: true, + }, + { + provide: MAT_DATE_LOCALE, + useValue: de, + }, + { + provide: MAT_DATE_FORMATS, + useValue: CUSTOM_DATE_FORMATS, + }, + { + provide: DateAdapter, + useClass: DateFnsAdapter, + deps: [MAT_DATE_LOCALE], + }, provideHttpClient(withInterceptorsFromDi()), ], bootstrap: [AppComponent], diff --git a/alfa-client/libs/admin/configuration/src/lib/menu-container/menu/menu.component.spec.ts b/alfa-client/libs/admin/configuration/src/lib/menu-container/menu/menu.component.spec.ts index 1f417e5febf09fcf523cd7c2d01a273d65630e79..6fe7f6ec6a78e51ef53b8f5b3e8c5f4fc7d129b1 100644 --- a/alfa-client/libs/admin/configuration/src/lib/menu-container/menu/menu.component.spec.ts +++ b/alfa-client/libs/admin/configuration/src/lib/menu-container/menu/menu.component.spec.ts @@ -17,8 +17,8 @@ describe('MenuComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [MenuComponent], - declarations: [HasLinkPipe, MockComponent(NavItemComponent), MockComponent(MailboxIconComponent)], + imports: [MenuComponent, HasLinkPipe], + declarations: [MockComponent(NavItemComponent), MockComponent(MailboxIconComponent)], }).compileComponents(); fixture = TestBed.createComponent(MenuComponent); diff --git a/alfa-client/libs/admin/configuration/src/lib/menu-container/menu/menu.component.ts b/alfa-client/libs/admin/configuration/src/lib/menu-container/menu/menu.component.ts index 19cc60bab45d9e098ace89450e3c7efa50e96c30..0c9cddefff0b13b58d8dd915f44352b78bd60f2b 100644 --- a/alfa-client/libs/admin/configuration/src/lib/menu-container/menu/menu.component.ts +++ b/alfa-client/libs/admin/configuration/src/lib/menu-container/menu/menu.component.ts @@ -1,5 +1,5 @@ import { ConfigurationLinkRel, ConfigurationResource } from '@admin-client/configuration-shared'; -import { StateResource, TechSharedModule } from '@alfa-client/tech-shared'; +import { HasLinkPipe, StateResource } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, Input } from '@angular/core'; import { MailboxIconComponent, NavItemComponent, StatisticIconComponent } from '@ods/system'; @@ -7,7 +7,7 @@ import { MailboxIconComponent, NavItemComponent, StatisticIconComponent } from ' @Component({ selector: 'admin-menu', standalone: true, - imports: [CommonModule, NavItemComponent, MailboxIconComponent, TechSharedModule, StatisticIconComponent], + imports: [CommonModule, NavItemComponent, MailboxIconComponent, StatisticIconComponent, HasLinkPipe], templateUrl: './menu.component.html', }) export class MenuComponent { diff --git a/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-container.component.spec.ts b/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-container.component.spec.ts index 5fd68cc789206b701f2adad2c2d0f5280917b55d..562b00dafa62d2291eae204de2e79ed2d5b8b98f 100644 --- a/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-container.component.spec.ts +++ b/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-container.component.spec.ts @@ -25,7 +25,7 @@ import { OrganisationsEinheitContainerComponent } from '@admin-client/organisati import { AdminOrganisationsEinheit, AdminOrganisationsEinheitService } from '@admin-client/organisations-einheit-shared'; import { createStateResource, StateResource, ToEmbeddedResourcesPipe } from '@alfa-client/tech-shared'; import { existsAsHtmlElement, getMockComponent, Mock, mock } from '@alfa-client/test-utils'; -import { OzgcloudDialogService, UiModule } from '@alfa-client/ui'; +import { OzgcloudDialogService } from '@alfa-client/ui'; import { OrganisationsEinheitResource } from '@alfa-client/zustaendige-stelle-shared'; import { CommonModule } from '@angular/common'; import { ViewContainerRef } from '@angular/core'; @@ -66,7 +66,7 @@ describe('OrganisationsEinheitContainerComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ declarations: [ToEmbeddedResourcesPipe], - imports: [CommonModule, UiModule, OrganisationsEinheitContainerComponent, MockComponent(OrganisationsEinheitListComponent)], + imports: [CommonModule, OrganisationsEinheitContainerComponent, MockComponent(OrganisationsEinheitListComponent)], providers: [ { provide: AdminOrganisationsEinheitService, useValue: organisationsEinheitService }, { provide: OzgcloudDialogService, useValue: dialogService }, @@ -85,7 +85,16 @@ describe('OrganisationsEinheitContainerComponent', () => { describe('component', () => { describe('ngOnInit', () => { - it('should call organisationsEinheitService getAll', (done) => { + it('should call organisationsEinheitService getList', (done) => { + component.ngOnInit(); + + component.organisationsEinheitenStateResource$.subscribe(() => { + expect(organisationsEinheitService.getAll).toHaveBeenCalled(); + done(); + }); + }); + + it('should set organisationsEinheitListStateResource$', (done) => { component.ngOnInit(); component.organisationsEinheitenStateResource$.subscribe(() => { diff --git a/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-container.component.ts b/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-container.component.ts index a1b124b07e83e6496d5409cef4cdd271e826b842..e12a8a85f72d90a48141f6794852f69ebf607085 100644 --- a/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-container.component.ts +++ b/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-container.component.ts @@ -7,9 +7,8 @@ import { ResourceSearchService, SearchResourceServiceConfig, StateResource, - TechSharedModule, } from '@alfa-client/tech-shared'; -import { OzgcloudDialogService, UiModule } from '@alfa-client/ui'; +import { OzgcloudDialogService, SpinnerComponent } from '@alfa-client/ui'; import { ZustaendigeStelleModule } from '@alfa-client/zustaendige-stelle'; import { OrganisationsEinheitListResource, @@ -31,12 +30,11 @@ import { OrganisationsEinheitListComponent } from './organisations-einheit-list/ standalone: true, imports: [ CommonModule, - UiModule, ZustaendigeStelleModule, ZustaendigeStelleSharedModule, OrganisationsEinheitListComponent, - TechSharedModule, ButtonComponent, + SpinnerComponent, ], providers: [ { diff --git a/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-list/organisations-einheit-list.component.spec.ts b/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-list/organisations-einheit-list.component.spec.ts index 6fd9e1d7f938b76081a00e071efe41067de9273b..dd2fba6125d358ef26de554cdf79d2afdc40cf9b 100644 --- a/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-list/organisations-einheit-list.component.spec.ts +++ b/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-list/organisations-einheit-list.component.spec.ts @@ -22,14 +22,14 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { AdminOrganisationsEinheit } from '@admin-client/organisations-einheit-shared'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { existsAsHtmlElement, getElementFromFixture, mock } from '@alfa-client/test-utils'; import { CommonModule } from '@angular/common'; import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { MatTooltipModule } from '@angular/material/tooltip'; import { ActivatedRoute } from '@angular/router'; import { ExclamationIconComponent, ListComponent, ListItemComponent } from '@ods/system'; import { getConvertedDataTestIdOf, getDataTestIdOf } from 'libs/tech-shared/test/data-test'; -import { MockComponent, MockModule } from 'ng-mocks'; +import { MockComponent } from 'ng-mocks'; import { createAdminOrganisationsEinheit } from '../../../../../organisations-einheit-shared/src/test/organisations-einheit'; import { OrganisationsEinheitListComponent } from './organisations-einheit-list.component'; @@ -48,13 +48,12 @@ describe('OrganisationsEinheitListComponent', () => { useValue: mock(ActivatedRoute), }, ], - imports: [ - CommonModule, + imports: [CommonModule, ConvertForDataTestPipe], + declarations: [ OrganisationsEinheitListComponent, MockComponent(ListComponent), MockComponent(ListItemComponent), MockComponent(ExclamationIconComponent), - MockModule(MatTooltipModule), ], }).compileComponents(); diff --git a/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-list/organisations-einheit-list.component.ts b/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-list/organisations-einheit-list.component.ts index 349085056be2fdeda545dda9849cac09822254c0..7efc0bbbe6727d1d558c63bad8ffe6a2d08b9d35 100644 --- a/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-list/organisations-einheit-list.component.ts +++ b/alfa-client/libs/admin/organisations-einheit/src/lib/organisations-einheit-container/organisations-einheit-list/organisations-einheit-list.component.ts @@ -22,7 +22,7 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { AdminOrganisationsEinheit } from '@admin-client/organisations-einheit-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe, ToResourceUriPipe } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, Input } from '@angular/core'; import { ExclamationIconComponent, ListComponent, ListItemComponent, TooltipDirective } from '@ods/system'; @@ -31,7 +31,15 @@ import { ExclamationIconComponent, ListComponent, ListItemComponent, TooltipDire selector: 'admin-organisations-einheit-list', templateUrl: './organisations-einheit-list.component.html', standalone: true, - imports: [CommonModule, ListComponent, ListItemComponent, ExclamationIconComponent, TooltipDirective, TechSharedModule], + imports: [ + CommonModule, + ListComponent, + ListItemComponent, + ExclamationIconComponent, + TooltipDirective, + ToResourceUriPipe, + ConvertForDataTestPipe, + ], }) export class OrganisationsEinheitListComponent { @Input() public organisationsEinheitList: AdminOrganisationsEinheit[] = []; diff --git a/alfa-client/libs/bescheid/src/lib/bescheid.module.ts b/alfa-client/libs/bescheid/src/lib/bescheid.module.ts index 1e6f131245e5bee64444aa62165617f532e2fabc..f6df6b162cf2af8a74cd04ee074f680fce851a20 100644 --- a/alfa-client/libs/bescheid/src/lib/bescheid.module.ts +++ b/alfa-client/libs/bescheid/src/lib/bescheid.module.ts @@ -24,8 +24,7 @@ import { BescheidSharedModule } from '@alfa-client/bescheid-shared'; import { BinaryFileModule } from '@alfa-client/binary-file'; import { CommandSharedModule } from '@alfa-client/command-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { GetUrlPipe, HasLinkPipe, ToEmbeddedResourcesPipe } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; import { @@ -35,6 +34,22 @@ import { TextareaEditorComponent, TextEditorComponent, } from '@ods/component'; +import { BescheidInVorgangContainerComponent } from './bescheid-in-vorgang-container/bescheid-in-vorgang-container.component'; +import { BescheidInVorgangComponent } from './bescheid-in-vorgang-container/bescheid-in-vorgang/bescheid-in-vorgang.component'; +import { BescheidListInVorgangContainerComponent } from './bescheid-list-in-vorgang-container/bescheid-list-in-vorgang-container.component'; +import { BescheidListInVorgangComponent } from './bescheid-list-in-vorgang-container/bescheid-list-in-vorgang/bescheid-list-in-vorgang.component'; +import { DocumentInBescheidContainerComponent } from './bescheid-list-in-vorgang-container/bescheid-list-in-vorgang/document-in-bescheid-container/document-in-bescheid-container.component'; +import { BeschiedenDateContainerComponent } from './beschieden-date-in-vorgang-container/beschieden-date-container/beschieden-date-container.component'; +import { BeschiedenDateInVorgangContainerComponent } from './beschieden-date-in-vorgang-container/beschieden-date-in-vorgang-container.component'; + +import { + DateEditorComponent, + ExpansionPanelComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + SpinnerComponent, +} from '@alfa-client/ui'; +import { ReactiveFormsModule } from '@angular/forms'; +import { MatIcon } from '@angular/material/icon'; import { AttachmentComponent, AttachmentWrapperComponent, @@ -51,11 +66,7 @@ import { SpinnerIconComponent, StampIconComponent, } from '@ods/system'; -import { BescheidInVorgangContainerComponent } from './bescheid-in-vorgang-container/bescheid-in-vorgang-container.component'; -import { BescheidInVorgangComponent } from './bescheid-in-vorgang-container/bescheid-in-vorgang/bescheid-in-vorgang.component'; -import { BescheidListInVorgangContainerComponent } from './bescheid-list-in-vorgang-container/bescheid-list-in-vorgang-container.component'; -import { BescheidListInVorgangComponent } from './bescheid-list-in-vorgang-container/bescheid-list-in-vorgang/bescheid-list-in-vorgang.component'; -import { DocumentInBescheidContainerComponent } from './bescheid-list-in-vorgang-container/bescheid-list-in-vorgang/document-in-bescheid-container/document-in-bescheid-container.component'; +import { FormatFullDatePipe } from '../../../tech-shared/src/lib/pipe/format-full-date.pipe'; import { BescheidWizardContainerComponent } from './bescheid-wizard-container/bescheid-wizard-container.component'; import { BescheidWizardAbschliessenButtonComponent } from './bescheid-wizard-container/bescheid-wizard/antrag-bescheiden/abschliessen-button/bescheid-wizard-abschliessen-button.component'; import { BescheidWizardAbschliessenDialogContainerComponent } from './bescheid-wizard-container/bescheid-wizard/antrag-bescheiden/abschliessen-dialog-container/bescheid-wizard-abschliessen-dialog-container.component'; @@ -88,16 +99,12 @@ import { BescheidWizardUploadAttachmentButtonComponent } from './bescheid-wizard import { BescheidWizardUploadDocumentButtonContainerComponent } from './bescheid-wizard-container/bescheid-wizard/upload-document-button-container/bescheid-wizard-upload-document-button-container.component'; import { BescheidWizardUploadDocumentButtonComponent } from './bescheid-wizard-container/bescheid-wizard/upload-document-button-container/upload-document-button/bescheid-wizard-upload-document-button.component'; import { BescheidWizardWeiterButtonComponent } from './bescheid-wizard-container/bescheid-wizard/weiter-button/bescheid-wizard-weiter-button.component'; -import { BeschiedenDateContainerComponent } from './beschieden-date-in-vorgang-container/beschieden-date-container/beschieden-date-container.component'; -import { BeschiedenDateInVorgangContainerComponent } from './beschieden-date-in-vorgang-container/beschieden-date-in-vorgang-container.component'; @NgModule({ imports: [ CommonModule, BescheidSharedModule, BinaryFileModule, - TechSharedModule, - UiModule, CommandSharedModule, BescheidStatusTextComponent, BescheidWrapperComponent, @@ -106,6 +113,17 @@ import { BeschiedenDateInVorgangContainerComponent } from './beschieden-date-in- ButtonWithSpinnerComponent, RadioButtonCardComponent, ButtonComponent, + FormatFullDatePipe, + HasLinkPipe, + GetUrlPipe, + ToEmbeddedResourcesPipe, + SpinnerComponent, + ExpansionPanelComponent, + AttachmentWrapperComponent, + MatIcon, + DateEditorComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + ReactiveFormsModule, ButtonCardComponent, BescheidGenerateIconComponent, SingleFileUploadEditorComponent, diff --git a/alfa-client/libs/binary-file-shared/src/lib/binary-file.repository.spec.ts b/alfa-client/libs/binary-file-shared/src/lib/binary-file.repository.spec.ts index 79084ec1680c27357feb742bfc44160ab2781c2f..dfec001d129c806b4212ebb4dce6f0e54d40213e 100644 --- a/alfa-client/libs/binary-file-shared/src/lib/binary-file.repository.spec.ts +++ b/alfa-client/libs/binary-file-shared/src/lib/binary-file.repository.spec.ts @@ -28,13 +28,13 @@ import { HttpErrorHandler, HttpHeader, ListResource, - TechSharedModule, } from '@alfa-client/tech-shared'; import { mock, mockClass, useFromMock } from '@alfa-client/test-utils'; import { HttpClient, HttpHeaders, HttpResponse } from '@angular/common/http'; import { faker } from '@faker-js/faker'; import { Resource, ResourceFactory, ResourceUri, getUrl } from '@ngxp/rest'; import { cold, hot } from 'jest-marbles'; +import { InjectorService } from 'libs/tech-shared/src/lib/injector/injector.service'; import { DummyLinkRel } from 'libs/tech-shared/test/dummy'; import { createHttpResponse } from 'libs/tech-shared/test/http'; import { singleCold } from 'libs/tech-shared/test/marbles'; @@ -45,7 +45,7 @@ import { BinaryFileLinkRel } from './binary-file.linkrel'; import { BinaryFileResource } from './binary-file.model'; import { BinaryFileRepository } from './binary-file.repository'; -import * as HttpUtil from '../../../tech-shared/src/lib/http.util'; +import * as HttpUtil from 'libs/tech-shared/src/lib/http.util'; describe('BinaryFileRepository', () => { let repository: BinaryFileRepository; @@ -64,7 +64,7 @@ describe('BinaryFileRepository', () => { }); function mockInterceptor(): void { - mockClass(TechSharedModule).injector = <any>{ get: () => useFromMock(mock(HttpErrorHandler)) }; + mockClass(InjectorService).injector = <any>{ get: () => useFromMock(mock(HttpErrorHandler)) }; } it('should be created', () => { diff --git a/alfa-client/libs/binary-file/src/lib/binary-file.module.ts b/alfa-client/libs/binary-file/src/lib/binary-file.module.ts index ee4cacdb5f276222620c9a4297808dc6e836c007..9327cbb0be7ef4527eff2aaf36b8f4ffac6e0cb3 100644 --- a/alfa-client/libs/binary-file/src/lib/binary-file.module.ts +++ b/alfa-client/libs/binary-file/src/lib/binary-file.module.ts @@ -21,10 +21,12 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { ConvertForDataTestPipe, FileSizePipe, HasLinkPipe, ToEmbeddedResourcesPipe } from '@alfa-client/tech-shared'; +import { IconButtonWithSpinnerComponent, SpinnerComponent } from '@alfa-client/ui'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; +import { MatIcon } from '@angular/material/icon'; +import { MatTooltip } from '@angular/material/tooltip'; import { DownloadButtonComponent } from '@ods/component'; import { AttachmentComponent, @@ -34,6 +36,8 @@ import { SpinnerIconComponent, TooltipDirective, } from '@ods/system'; +import { FileSizePlainPipe } from '../../../tech-shared/src/lib/pipe/file-size-plain.pipe'; +import { FileUploadEditorComponent } from '../../../ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component'; import { BinaryFileAttachmentContainerComponent } from './binary-file-attachment-container/binary-file-attachment-container.component'; import { BinaryFileContainerComponent } from './binary-file-container/binary-file-container.component'; import { BinaryFileComponent } from './binary-file-container/binary-file/binary-file.component'; @@ -49,14 +53,22 @@ import { VerticalBinaryFileListComponent } from './vertical-binary-file-list/ver @NgModule({ imports: [ CommonModule, - UiModule, - TechSharedModule, AttachmentComponent, AttachmentHeaderComponent, AttachmentWrapperComponent, SpinnerIconComponent, CloseIconComponent, DownloadButtonComponent, + FileUploadEditorComponent, + HasLinkPipe, + MatTooltip, + MatIcon, + SpinnerComponent, + IconButtonWithSpinnerComponent, + FileSizePipe, + ConvertForDataTestPipe, + ToEmbeddedResourcesPipe, + FileSizePlainPipe, TooltipDirective, ], declarations: [ diff --git a/alfa-client/libs/collaboration/src/lib/collaboration.module.ts b/alfa-client/libs/collaboration/src/lib/collaboration.module.ts index a99b23f737e31e8e6024ac8aa471ea53024d61b2..62308b9704c1157391003ae56408374b6ca23cb7 100644 --- a/alfa-client/libs/collaboration/src/lib/collaboration.module.ts +++ b/alfa-client/libs/collaboration/src/lib/collaboration.module.ts @@ -22,8 +22,8 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { CollaborationSharedModule } from '@alfa-client/collaboration-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { HasLinkPipe } from '@alfa-client/tech-shared'; +import { SpinnerComponent } from '@alfa-client/ui'; import { ZustaendigeStelleModule } from '@alfa-client/zustaendige-stelle'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; @@ -63,7 +63,6 @@ import { CollaborationRequestFormComponent } from './collaboration-in-vorgang-co TextareaEditorComponent, FormsModule, ReactiveFormsModule, - TechSharedModule, ButtonWithSpinnerComponent, ZustaendigeStelleModule, OfficeIconComponent, @@ -71,7 +70,8 @@ import { CollaborationRequestFormComponent } from './collaboration-in-vorgang-co PublicAdministrationIconComponent, OrganisationsEinheitListItemContainerComponent, ExterneFachstelleListItemContainerComponent, - UiModule, + HasLinkPipe, + SpinnerComponent, ], declarations: [ CollaborationInVorgangContainerComponent, diff --git a/alfa-client/libs/common/src/lib/build-info/build-info.component.spec.ts b/alfa-client/libs/common/src/lib/build-info/build-info.component.spec.ts index 0f8d5ff01398c359e4eefc7c4b635e454e1ec694..a47f70b4bf63016ac31f407352ff3973d64bca1a 100644 --- a/alfa-client/libs/common/src/lib/build-info/build-info.component.spec.ts +++ b/alfa-client/libs/common/src/lib/build-info/build-info.component.spec.ts @@ -47,8 +47,7 @@ describe('BuildInfoComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [BuildInfoComponent], - declarations: [FormatDateWithTimePipe], + imports: [BuildInfoComponent, FormatDateWithTimePipe], }).compileComponents(); }); diff --git a/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.spec.ts b/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.spec.ts index de1242c608e560f453c76ee160ddaf89dc3b9b0c..7643fbc6e08d29e0aadf7792f87d1f40348b709b 100644 --- a/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.spec.ts +++ b/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.spec.ts @@ -21,13 +21,13 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { createStateResource, StateResource } from '@alfa-client/tech-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { createCommandErrorStateResource, createCommandResource } from 'libs/command-shared/test/command'; +import { createCommandErrorStateResource } from 'libs/command-shared/test/command'; import { createApiError } from 'libs/tech-shared/test/error'; +import { createDummyResource } from '../../../../tech-shared/test/resource'; import { ButtonWithSpinnerComponent } from './button-with-spinner.component'; -import * as ResourceUtils from 'libs/tech-shared/src/lib/resource/resource.util'; - describe('ButtonWithSpinnerComponent', () => { let component: ButtonWithSpinnerComponent; let fixture: ComponentFixture<ButtonWithSpinnerComponent>; @@ -46,39 +46,25 @@ describe('ButtonWithSpinnerComponent', () => { expect(component).toBeTruthy(); }); - describe('onInit', () => { - it('should call getStateResource', () => { - component.getStateResource = jest.fn(); + describe('set stateResource', () => { + it('should set stateResource', () => { + const stateResource: StateResource<unknown> = createStateResource(createDummyResource()); - component.ngOnInit(); + component.stateResource = stateResource; - expect(component.getStateResource).toHaveBeenCalled(); + expect(component._stateResource).toBe(stateResource); }); - }); - - describe('getStateResource', () => { - it('should return stateResource', () => { - component.stateResource = ResourceUtils.createStateResource(createCommandResource()); - - component.getStateResource(); - const valid: boolean = ResourceUtils.isValidStateResource(component.stateResource); - expect(valid).toBeTruthy(); - }); - - it('should return empty stateResource', () => { - const spy = jest.spyOn(ResourceUtils, 'createEmptyStateResource'); + it('should not set stateResource', () => { component.stateResource = null; - component.getStateResource(); - - expect(spy).toHaveBeenCalled(); + expect(component._stateResource).not.toBe(null); }); }); describe('isLoading', () => { it('should return false', () => { - component.stateResource.loading = component.stateResource.reload = false; + component._stateResource.loading = component._stateResource.reload = false; const isLoading: boolean = component.isLoading; @@ -86,8 +72,8 @@ describe('ButtonWithSpinnerComponent', () => { }); it('should return true if stateResource is loading', () => { - component.stateResource.loading = true; - component.stateResource.reload = false; + component._stateResource.loading = true; + component._stateResource.reload = false; const isLoading: boolean = component.isLoading; @@ -95,8 +81,8 @@ describe('ButtonWithSpinnerComponent', () => { }); it('should return true if stateResource is reloading', () => { - component.stateResource.loading = false; - component.stateResource.reload = true; + component._stateResource.loading = false; + component._stateResource.reload = true; const isLoading: boolean = component.isLoading; @@ -106,7 +92,7 @@ describe('ButtonWithSpinnerComponent', () => { describe('isError', () => { it('should return false if error is not set', () => { - component.stateResource.error = null; + component._stateResource.error = null; const isError: boolean = component.isError; @@ -114,7 +100,7 @@ describe('ButtonWithSpinnerComponent', () => { }); it('should return false if error is set and error is ApiError', () => { - component.stateResource.error = createApiError(); + component._stateResource.error = createApiError(); const isError: boolean = component.isError; @@ -122,7 +108,7 @@ describe('ButtonWithSpinnerComponent', () => { }); it('should return true if error is set and error is not ApiError', () => { - component.stateResource = createCommandErrorStateResource(); + component._stateResource = createCommandErrorStateResource(); const isError: boolean = component.isError; diff --git a/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.ts b/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.ts index f76f1f907cecaa625c3e1c6dc950458e3f4aa640..a12b0a8ad74b49d34ec172ae36682d7d0ce01104 100644 --- a/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.ts +++ b/alfa-client/libs/design-component/src/lib/button-with-spinner/button-with-spinner.component.ts @@ -24,7 +24,7 @@ import { CommandResource, hasCommandError } from '@alfa-client/command-shared'; import { StateResource, createEmptyStateResource, isLoaded } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; +import { Component, EventEmitter, Input, Output } from '@angular/core'; import { ButtonComponent, ErrorMessageComponent, buttonVariants } from '@ods/system'; import { VariantProps } from 'class-variance-authority'; import { isNil } from 'lodash-es'; @@ -49,28 +49,24 @@ type ButtonVariants = VariantProps<typeof buttonVariants>; <ng-content icon select="[icon]" /> </ods-button>`, }) -export class ButtonWithSpinnerComponent implements OnInit { +export class ButtonWithSpinnerComponent { + @Input() set stateResource(value: StateResource<unknown>) { + if (!isNil(value)) this._stateResource = value; + } @Input() text: string = ''; @Input() dataTestId: string = ''; - @Input() stateResource: StateResource<unknown>; @Input() variant: ButtonVariants['variant'] = 'primary'; @Input() size: ButtonVariants['size'] = 'medium'; @Output() public clickEmitter: EventEmitter<MouseEvent> = new EventEmitter<MouseEvent>(); - ngOnInit(): void { - this.stateResource = this.getStateResource(); - } - - getStateResource(): StateResource<unknown> { - return isNil(this.stateResource) ? createEmptyStateResource() : this.stateResource; - } + _stateResource: StateResource<unknown> = createEmptyStateResource(); get isLoading(): boolean { - return this.stateResource.loading || this.stateResource.reload; + return this._stateResource.loading || this._stateResource.reload; } get isError(): boolean { - return isLoaded(this.stateResource) && hasCommandError(<CommandResource>this.stateResource.resource); + return isLoaded(this._stateResource) && hasCommandError(<CommandResource>this._stateResource.resource); } } diff --git a/alfa-client/libs/design-component/src/lib/form/checkbox-editor/checkbox-editor.component.ts b/alfa-client/libs/design-component/src/lib/form/checkbox-editor/checkbox-editor.component.ts index 121f52bb8d5778c67a38097c5766632adbdb3199..dfab859671455c3354bd14297d069ffde5474cde 100644 --- a/alfa-client/libs/design-component/src/lib/form/checkbox-editor/checkbox-editor.component.ts +++ b/alfa-client/libs/design-component/src/lib/form/checkbox-editor/checkbox-editor.component.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { Component, Input } from '@angular/core'; import { ReactiveFormsModule } from '@angular/forms'; import { CheckboxComponent } from '@ods/system'; @@ -31,7 +31,7 @@ import { ValidationErrorComponent } from '../validation-error/validation-error.c @Component({ selector: 'ods-checkbox-editor', standalone: true, - imports: [CheckboxComponent, ValidationErrorComponent, TechSharedModule, ReactiveFormsModule], + imports: [CheckboxComponent, ValidationErrorComponent, ReactiveFormsModule, ConvertForDataTestPipe], templateUrl: './checkbox-editor.component.html', }) export class CheckboxEditorComponent extends FormControlEditorAbstractComponent { diff --git a/alfa-client/libs/design-component/src/lib/form/file-upload-editor/file-upload-editor.component.spec.ts b/alfa-client/libs/design-component/src/lib/form/file-upload-editor/file-upload-editor.component.spec.ts index e23d68f4fd3158c668a388aad404022810f1202f..9bb05063e492ff44967a3e62cd4d23bfad2a835e 100644 --- a/alfa-client/libs/design-component/src/lib/form/file-upload-editor/file-upload-editor.component.spec.ts +++ b/alfa-client/libs/design-component/src/lib/form/file-upload-editor/file-upload-editor.component.spec.ts @@ -21,15 +21,10 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule, createEmptyStateResource } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe, createEmptyStateResource } from '@alfa-client/tech-shared'; import { getElementFromFixture } from '@alfa-client/test-utils'; import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { - AbstractControl, - FormGroupDirective, - ReactiveFormsModule, - UntypedFormBuilder, -} from '@angular/forms'; +import { AbstractControl, FormGroupDirective, ReactiveFormsModule, UntypedFormBuilder } from '@angular/forms'; import { FileUploadButtonComponent, SpinnerIconComponent } from '@ods/system'; import { getDataTestIdOf } from 'libs/tech-shared/test/data-test'; import { MockComponent } from 'ng-mocks'; @@ -48,12 +43,8 @@ describe('FileUploadEditorComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ - FileUploadEditorComponent, - MockComponent(SpinnerIconComponent), - MockComponent(FileUploadButtonComponent), - ], - imports: [ReactiveFormsModule, TechSharedModule], + declarations: [FileUploadEditorComponent, MockComponent(SpinnerIconComponent), MockComponent(FileUploadButtonComponent)], + imports: [ReactiveFormsModule, ConvertForDataTestPipe], providers: [ { provide: FormGroupDirective, diff --git a/alfa-client/libs/design-component/src/lib/form/file-upload-editor/file-upload-editor.component.ts b/alfa-client/libs/design-component/src/lib/form/file-upload-editor/file-upload-editor.component.ts index 0a9f5a53efe396aa9345b39f56d1b2f6ca1e1b63..2a412d827f7501dc914cf05bad19dbe00b85ebfe 100644 --- a/alfa-client/libs/design-component/src/lib/form/file-upload-editor/file-upload-editor.component.ts +++ b/alfa-client/libs/design-component/src/lib/form/file-upload-editor/file-upload-editor.component.ts @@ -21,22 +21,12 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { StateResource, TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe, StateResource } from '@alfa-client/tech-shared'; import { NgForOf } from '@angular/common'; import { Component, EventEmitter, HostListener, Input, OnInit, Output } from '@angular/core'; -import { - ControlContainer, - FormGroupDirective, - ReactiveFormsModule, - UntypedFormArray, - UntypedFormControl, -} from '@angular/forms'; +import { ControlContainer, FormGroupDirective, ReactiveFormsModule, UntypedFormArray, UntypedFormControl } from '@angular/forms'; import { Resource } from '@ngxp/rest'; -import { - AttachmentIconComponent, - FileUploadButtonComponent, - SpinnerIconComponent, -} from '@ods/system'; +import { AttachmentIconComponent, FileUploadButtonComponent, SpinnerIconComponent } from '@ods/system'; import { uniqueId } from 'lodash-es'; import { FormControlEditorAbstractComponent } from '../formcontrol-editor.abstract.component'; @@ -51,13 +41,10 @@ import { FormControlEditorAbstractComponent } from '../formcontrol-editor.abstra SpinnerIconComponent, ReactiveFormsModule, NgForOf, - TechSharedModule, + ConvertForDataTestPipe, ], }) -export class FileUploadEditorComponent - extends FormControlEditorAbstractComponent - implements OnInit -{ +export class FileUploadEditorComponent extends FormControlEditorAbstractComponent implements OnInit { @Input() label: string = ''; @Input() parentFormArrayName: string; @Input() accept: string = '*/*'; @@ -88,9 +75,7 @@ export class FileUploadEditorComponent buildFormArray(fileLinkList: string[]): void { this.fileLinkControls.clear(); - fileLinkList.forEach((link: string) => - this.fileLinkControls.push(new UntypedFormControl(link)), - ); + fileLinkList.forEach((link: string) => this.fileLinkControls.push(new UntypedFormControl(link))); } upload(file: File): void { diff --git a/alfa-client/libs/design-component/src/lib/form/single-file-upload-editor/single-file-upload-editor.component.ts b/alfa-client/libs/design-component/src/lib/form/single-file-upload-editor/single-file-upload-editor.component.ts index 4ae84174d1a25498142f7c5f0b8584172b5aff40..a62e384fb3c9ff9c15b453cc9927438d1e1790c4 100644 --- a/alfa-client/libs/design-component/src/lib/form/single-file-upload-editor/single-file-upload-editor.component.ts +++ b/alfa-client/libs/design-component/src/lib/form/single-file-upload-editor/single-file-upload-editor.component.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule, isNotNil } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe, isNotNil } from '@alfa-client/tech-shared'; import { Component, EventEmitter, HostListener, Input, Output } from '@angular/core'; import { ReactiveFormsModule } from '@angular/forms'; import { FileUploadButtonComponent, SpinnerIconComponent } from '@ods/system'; @@ -32,7 +32,7 @@ import { FormControlEditorAbstractComponent } from '../formcontrol-editor.abstra selector: 'ods-single-file-upload-editor', templateUrl: './single-file-upload-editor.component.html', standalone: true, - imports: [FileUploadButtonComponent, SpinnerIconComponent, ReactiveFormsModule, TechSharedModule], + imports: [FileUploadButtonComponent, SpinnerIconComponent, ReactiveFormsModule, ConvertForDataTestPipe], }) export class SingleFileUploadEditorComponent extends FormControlEditorAbstractComponent { @Input() label: string = ''; diff --git a/alfa-client/libs/design-component/src/lib/form/text-editor/text-editor.component.ts b/alfa-client/libs/design-component/src/lib/form/text-editor/text-editor.component.ts index 88059147b43c73716251cd6999184bba085a3479..cfdd66512de073b74f0dbfd2bbed633573f9651f 100644 --- a/alfa-client/libs/design-component/src/lib/form/text-editor/text-editor.component.ts +++ b/alfa-client/libs/design-component/src/lib/form/text-editor/text-editor.component.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, Input } from '@angular/core'; import { ReactiveFormsModule } from '@angular/forms'; @@ -32,13 +32,7 @@ import { ValidationErrorComponent } from '../validation-error/validation-error.c @Component({ selector: 'ods-text-editor', standalone: true, - imports: [ - CommonModule, - ReactiveFormsModule, - TechSharedModule, - TextInputComponent, - ValidationErrorComponent, - ], + imports: [CommonModule, ReactiveFormsModule, TextInputComponent, ValidationErrorComponent, ConvertForDataTestPipe], templateUrl: './text-editor.component.html', }) export class TextEditorComponent extends FormControlEditorAbstractComponent { diff --git a/alfa-client/libs/design-component/src/lib/form/textarea-editor/textarea-editor.component.ts b/alfa-client/libs/design-component/src/lib/form/textarea-editor/textarea-editor.component.ts index be0fc9b4f33d4ca6ddceb6912c8dc82c769e3ac5..c7032ef03b58627369f4857d0b2bda4546d092b5 100644 --- a/alfa-client/libs/design-component/src/lib/form/textarea-editor/textarea-editor.component.ts +++ b/alfa-client/libs/design-component/src/lib/form/textarea-editor/textarea-editor.component.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, Input } from '@angular/core'; import { ReactiveFormsModule } from '@angular/forms'; @@ -32,13 +32,7 @@ import { ValidationErrorComponent } from '../validation-error/validation-error.c @Component({ selector: 'ods-textarea-editor', standalone: true, - imports: [ - CommonModule, - ReactiveFormsModule, - TechSharedModule, - TextareaComponent, - ValidationErrorComponent, - ], + imports: [CommonModule, ReactiveFormsModule, TextareaComponent, ValidationErrorComponent, ConvertForDataTestPipe], templateUrl: './textarea-editor.component.html', }) export class TextareaEditorComponent extends FormControlEditorAbstractComponent { diff --git a/alfa-client/libs/design-system/run_helm_test.sh b/alfa-client/libs/design-system/run_helm_test.sh old mode 100755 new mode 100644 diff --git a/alfa-client/libs/design-system/src/lib/dropdown-menu/dropdown-menu-link-item/dropdown-menu-link-item.component.ts b/alfa-client/libs/design-system/src/lib/dropdown-menu/dropdown-menu-link-item/dropdown-menu-link-item.component.ts index 52b3e46d6ac1e69ce02472bec600580c6e7663af..045191b56a76618a85600a82757607f267b4c8e4 100644 --- a/alfa-client/libs/design-system/src/lib/dropdown-menu/dropdown-menu-link-item/dropdown-menu-link-item.component.ts +++ b/alfa-client/libs/design-system/src/lib/dropdown-menu/dropdown-menu-link-item/dropdown-menu-link-item.component.ts @@ -5,7 +5,7 @@ import { LinkComponent } from '../../link/link.component'; @Component({ selector: 'ods-dropdown-menu-link-item', standalone: true, - imports: [LinkComponent, OpenLinkIconComponent], + imports: [OpenLinkIconComponent, LinkComponent], styles: [':host {@apply first:mt-2}'], template: ` <ods-link [url]="url" class="bg-whitetext" [openInNewTab]="true"> <div class="flex items-center gap-2 px-4 py-3"> diff --git a/alfa-client/libs/design-system/src/lib/form/checkbox/checkbox.component.ts b/alfa-client/libs/design-system/src/lib/form/checkbox/checkbox.component.ts index 120fa956bb755ed800f6742dfe7ddfe69d5acd38..ffadf796c9031418fda5463896a1452351f2e109 100644 --- a/alfa-client/libs/design-system/src/lib/form/checkbox/checkbox.component.ts +++ b/alfa-client/libs/design-system/src/lib/form/checkbox/checkbox.component.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, Input } from '@angular/core'; import { FormControl, ReactiveFormsModule } from '@angular/forms'; @@ -29,7 +29,7 @@ import { FormControl, ReactiveFormsModule } from '@angular/forms'; @Component({ selector: 'ods-checkbox', standalone: true, - imports: [CommonModule, ReactiveFormsModule, TechSharedModule], + imports: [CommonModule, ReactiveFormsModule, ConvertForDataTestPipe], template: ` <div> <div class="relative flex items-start gap-3 text-start"> diff --git a/alfa-client/libs/design-system/src/lib/form/file-upload-button/file-upload-button.component.spec.ts b/alfa-client/libs/design-system/src/lib/form/file-upload-button/file-upload-button.component.spec.ts index b4cc192ce058ef1c05db17ce82400820c7aa456a..54b7d3b7dde522ce018e0efae8b4210f6e2e2cff 100644 --- a/alfa-client/libs/design-system/src/lib/form/file-upload-button/file-upload-button.component.spec.ts +++ b/alfa-client/libs/design-system/src/lib/form/file-upload-button/file-upload-button.component.spec.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { getElementFromFixture } from '@alfa-client/test-utils'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { faker } from '@faker-js/faker'; @@ -38,7 +38,7 @@ describe('FileUploadButtonComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [FileUploadButtonComponent, TechSharedModule], + imports: [FileUploadButtonComponent, ConvertForDataTestPipe], }).compileComponents(); fixture = TestBed.createComponent(FileUploadButtonComponent); diff --git a/alfa-client/libs/design-system/src/lib/form/file-upload-button/file-upload-button.component.ts b/alfa-client/libs/design-system/src/lib/form/file-upload-button/file-upload-button.component.ts index 5de4efb83e1c6e6088d513cb262b7b3182346c05..2371918f9cdba62e0ea0ee3a5e315ee9f1d9e378 100644 --- a/alfa-client/libs/design-system/src/lib/form/file-upload-button/file-upload-button.component.ts +++ b/alfa-client/libs/design-system/src/lib/form/file-upload-button/file-upload-button.component.ts @@ -21,14 +21,14 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, ElementRef, Input, ViewChild } from '@angular/core'; @Component({ selector: 'ods-file-upload-button', standalone: true, - imports: [CommonModule, TechSharedModule], + imports: [CommonModule, ConvertForDataTestPipe], styles: [':host {@apply inline-flex}'], templateUrl: './file-upload-button.component.html', }) diff --git a/alfa-client/libs/design-system/src/lib/form/text-input/text-input.component.spec.ts b/alfa-client/libs/design-system/src/lib/form/text-input/text-input.component.spec.ts index 6d1f5b7eb8b1fab21996dd2991b2b09780edf82e..974db9b7c5c5dc93f83768157da9d570cfb0a2d3 100644 --- a/alfa-client/libs/design-system/src/lib/form/text-input/text-input.component.spec.ts +++ b/alfa-client/libs/design-system/src/lib/form/text-input/text-input.component.spec.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { convertForDataTest } from '@alfa-client/tech-shared'; +import { convertForDataTest, ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { getElementFromFixture } from '@alfa-client/test-utils'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { FormControl, ReactiveFormsModule } from '@angular/forms'; @@ -37,7 +37,7 @@ describe('TextInputComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [ReactiveFormsModule, TextInputComponent], + imports: [ReactiveFormsModule, TextInputComponent, ConvertForDataTestPipe], }).compileComponents(); fixture = TestBed.createComponent(TextInputComponent); diff --git a/alfa-client/libs/design-system/src/lib/form/text-input/text-input.component.ts b/alfa-client/libs/design-system/src/lib/form/text-input/text-input.component.ts index 1b038667fb82ad7c9832ded8ed18185eb1cd8780..5de77014fc3466b2a8a5768e2f003c61347d9dad 100644 --- a/alfa-client/libs/design-system/src/lib/form/text-input/text-input.component.ts +++ b/alfa-client/libs/design-system/src/lib/form/text-input/text-input.component.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { convertForDataTest, EMPTY_STRING, TechSharedModule } from '@alfa-client/tech-shared'; +import { convertForDataTest, ConvertForDataTestPipe, EMPTY_STRING } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, ElementRef, EventEmitter, Input, Output, ViewChild } from '@angular/core'; import { FormControl, ReactiveFormsModule } from '@angular/forms'; @@ -50,7 +50,7 @@ type TextInputVariants = VariantProps<typeof textInputVariants>; @Component({ selector: 'ods-text-input', standalone: true, - imports: [CommonModule, ReactiveFormsModule, TechSharedModule], + imports: [CommonModule, ReactiveFormsModule, ConvertForDataTestPipe], template: ` <div class="relative"> <label *ngIf="showLabel" [for]="id" class="text-md mb-2 block font-medium text-text"> diff --git a/alfa-client/libs/design-system/src/lib/form/textarea/textarea.component.spec.ts b/alfa-client/libs/design-system/src/lib/form/textarea/textarea.component.spec.ts index 872bec5354754d00e3f7d64eb724b20ed447e56c..580f9cab71a29070581554c29320b4ca86cd83fe 100644 --- a/alfa-client/libs/design-system/src/lib/form/textarea/textarea.component.spec.ts +++ b/alfa-client/libs/design-system/src/lib/form/textarea/textarea.component.spec.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { convertForDataTest } from '@alfa-client/tech-shared'; +import { convertForDataTest, ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { getElementFromFixture } from '@alfa-client/test-utils'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { FormControl, ReactiveFormsModule } from '@angular/forms'; @@ -37,7 +37,7 @@ describe('TextareaComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [ReactiveFormsModule, TextareaComponent], + imports: [ReactiveFormsModule, TextareaComponent, ConvertForDataTestPipe], }).compileComponents(); fixture = TestBed.createComponent(TextareaComponent); diff --git a/alfa-client/libs/design-system/src/lib/form/textarea/textarea.component.ts b/alfa-client/libs/design-system/src/lib/form/textarea/textarea.component.ts index d586185f3b3b3fc3329ee66325f746976e7753ab..f3eb84af9d638567a3bcbdc644b400abf344643e 100644 --- a/alfa-client/libs/design-system/src/lib/form/textarea/textarea.component.ts +++ b/alfa-client/libs/design-system/src/lib/form/textarea/textarea.component.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { EMPTY_STRING, TechSharedModule, convertForDataTest } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe, EMPTY_STRING, convertForDataTest } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, ElementRef, Input, ViewChild } from '@angular/core'; import { FormControl, ReactiveFormsModule } from '@angular/forms'; @@ -50,7 +50,7 @@ type TextareaVariants = VariantProps<typeof textareaVariants>; @Component({ selector: 'ods-textarea', standalone: true, - imports: [CommonModule, ReactiveFormsModule, TechSharedModule], + imports: [CommonModule, ReactiveFormsModule, ConvertForDataTestPipe], template: ` <div class="mt-2"> <label *ngIf="showLabel" [for]="id" class="text-md mb-2 block font-medium text-text"> diff --git a/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.spec.ts b/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.spec.ts index 81485f802c48588260d6b38b383de316984fa55d..f4fd0fc39d030ec83824c3c8c0a7daefe3764de6 100644 --- a/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.spec.ts +++ b/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.spec.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { convertForDataTest, TechSharedModule } from '@alfa-client/tech-shared'; +import { convertForDataTest, ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { getElementFromFixture, Mock, mock } from '@alfa-client/test-utils'; import { importProvidersFrom } from '@angular/core'; import { ComponentFixture, TestBed } from '@angular/core/testing'; @@ -37,7 +37,7 @@ describe('NavItemComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [NavItemComponent, TechSharedModule], + imports: [NavItemComponent, ConvertForDataTestPipe], providers: [ { provide: Router, diff --git a/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.ts b/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.ts index ac28440c045dd78e514f7f898d0f241b8e88921c..a3bd688e8120d42fba03efcde48d23510fdc66e7 100644 --- a/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.ts +++ b/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { Component, HostBinding, Input } from '@angular/core'; import { RouterLink, RouterLinkActive } from '@angular/router'; @@ -29,13 +29,11 @@ import { RouterLink, RouterLinkActive } from '@angular/router'; @Component({ selector: 'ods-nav-item', standalone: true, - imports: [CommonModule, RouterLink, RouterLinkActive, TechSharedModule], + imports: [CommonModule, RouterLink, RouterLinkActive, ConvertForDataTestPipe], template: `<a [routerLink]="path" routerLinkActive="bg-selected-light border-selected" - class="flex min-h-8 items-center gap-2 rounded-2xl border border-transparent - px-4 py-2 outline-2 outline-offset-2 outline-focus hover:border-primary - focus-visible:border-background-200 focus-visible:outline" + class="flex min-h-8 items-center gap-2 rounded-2xl border border-transparent px-4 py-2 outline-2 outline-offset-2 outline-focus hover:border-primary focus-visible:border-background-200 focus-visible:outline" [attr.data-test-id]="'link-path-' + path | convertForDataTest" > <ng-content select="[icon]" /> diff --git a/alfa-client/libs/externe-fachstelle/src/lib/externe-fachstelle-list-item-container/externe-fachstelle-list-item/externe-fachstelle-list-item.component.ts b/alfa-client/libs/externe-fachstelle/src/lib/externe-fachstelle-list-item-container/externe-fachstelle-list-item/externe-fachstelle-list-item.component.ts index 51d26eecb5813638527dc472c75d3ea22b744233..274c1b9090b1b6e299db74c41b9a1e08cb1dd62c 100644 --- a/alfa-client/libs/externe-fachstelle/src/lib/externe-fachstelle-list-item-container/externe-fachstelle-list-item/externe-fachstelle-list-item.component.ts +++ b/alfa-client/libs/externe-fachstelle/src/lib/externe-fachstelle-list-item-container/externe-fachstelle-list-item/externe-fachstelle-list-item.component.ts @@ -22,7 +22,7 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { StateResource } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { SpinnerComponent } from '@alfa-client/ui'; import { ExterneFachstelleResource } from '@alfa-client/zustaendige-stelle-shared'; import { Component, Input } from '@angular/core'; import { ExternalUnitIconComponent, PublicAdministrationIconComponent } from '@ods/system'; @@ -30,7 +30,7 @@ import { ExternalUnitIconComponent, PublicAdministrationIconComponent } from '@o @Component({ selector: 'alfa-externe-fachstelle-list-item', standalone: true, - imports: [PublicAdministrationIconComponent, ExternalUnitIconComponent, UiModule], + imports: [PublicAdministrationIconComponent, ExternalUnitIconComponent, SpinnerComponent], templateUrl: './externe-fachstelle-list-item.component.html', }) export class ExterneFachstelleListItemComponent { diff --git a/alfa-client/libs/forwarding/src/lib/forward-by-ozgcloud-button-container/forward-by-ozgcloud-button-container.component.spec.ts b/alfa-client/libs/forwarding/src/lib/forward-by-ozgcloud-button-container/forward-by-ozgcloud-button-container.component.spec.ts index 0bdb21fd38ad815027918f1b3e13b7a1818f57d4..8aab319a28e6ed8a3cd49270fdd27a42e2ed09f3 100644 --- a/alfa-client/libs/forwarding/src/lib/forward-by-ozgcloud-button-container/forward-by-ozgcloud-button-container.component.spec.ts +++ b/alfa-client/libs/forwarding/src/lib/forward-by-ozgcloud-button-container/forward-by-ozgcloud-button-container.component.spec.ts @@ -1,3 +1,4 @@ +import { HasLinkPipe } from '@alfa-client/tech-shared'; import { existsAsHtmlElement, notExistsAsHtmlElement } from '@alfa-client/test-utils'; import { VorgangWithEingangLinkRel } from '@alfa-client/vorgang-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; @@ -17,7 +18,7 @@ describe('ForwardByOzgcloudButtonContainerComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [ForwardByOzgcloudButtonContainerComponent], + imports: [ForwardByOzgcloudButtonContainerComponent, HasLinkPipe], declarations: [ MockComponent(ButtonWithSpinnerComponent), MockComponent(ForwardVorgangIconComponent), diff --git a/alfa-client/libs/forwarding/src/lib/forward-by-ozgcloud-button-container/forward-by-ozgcloud-button-container.component.ts b/alfa-client/libs/forwarding/src/lib/forward-by-ozgcloud-button-container/forward-by-ozgcloud-button-container.component.ts index b00da7ddb3c481ac14502f9091ec29c4b9af2748..f5fbad7ed1280171822f6746847c08887dbaff75 100644 --- a/alfa-client/libs/forwarding/src/lib/forward-by-ozgcloud-button-container/forward-by-ozgcloud-button-container.component.ts +++ b/alfa-client/libs/forwarding/src/lib/forward-by-ozgcloud-button-container/forward-by-ozgcloud-button-container.component.ts @@ -1,4 +1,4 @@ -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { HasLinkPipe } from '@alfa-client/tech-shared'; import { VorgangWithEingangLinkRel, VorgangWithEingangResource } from '@alfa-client/vorgang-shared'; import { CommonModule } from '@angular/common'; import { Component, Input } from '@angular/core'; @@ -8,7 +8,7 @@ import { ForwardVorgangIconComponent, TooltipDirective } from '@ods/system'; @Component({ selector: 'alfa-forward-by-ozgcloud-button-container', standalone: true, - imports: [CommonModule, TechSharedModule, ButtonWithSpinnerComponent, ForwardVorgangIconComponent, TooltipDirective], + imports: [CommonModule, ButtonWithSpinnerComponent, ForwardVorgangIconComponent, TooltipDirective, HasLinkPipe], templateUrl: './forward-by-ozgcloud-button-container.component.html', styles: [':host {@apply empty:hidden}'], }) diff --git a/alfa-client/libs/forwarding/src/lib/forwarding.module.ts b/alfa-client/libs/forwarding/src/lib/forwarding.module.ts index 56ba3f3ad8c2a79a91c9cbe1dd619140d63a9427..973cf7b7a1603273e98ca30ee0bd511c57bb9cc1 100644 --- a/alfa-client/libs/forwarding/src/lib/forwarding.module.ts +++ b/alfa-client/libs/forwarding/src/lib/forwarding.module.ts @@ -21,12 +21,19 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { CommonModule } from '@angular/common'; -import { NgModule } from '@angular/core'; import { CommandSharedModule } from '@alfa-client/command-shared'; import { ForwardingSharedModule } from '@alfa-client/forwarding-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { FormatDateWithTimePipe, HasLinkPipe, ToEmbeddedResourcesPipe } from '@alfa-client/tech-shared'; +import { + ExpansionPanelComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + OzgcloudTextEditorComponent, + SpinnerComponent, +} from '@alfa-client/ui'; +import { CommonModule } from '@angular/common'; +import { NgModule } from '@angular/core'; +import { ReactiveFormsModule } from '@angular/forms'; +import { MatIcon } from '@angular/material/icon'; import { VorgangForwardFormComponent } from './vorgang-forwarding-container/vorgang-forward-formular/vorgang-forward-form/vorgang-forward-form.component'; import { VorgangForwardFormularComponent } from './vorgang-forwarding-container/vorgang-forward-formular/vorgang-forward-formular.component'; import { VorgangForwardingContainerComponent } from './vorgang-forwarding-container/vorgang-forwarding-container.component'; @@ -35,7 +42,20 @@ import { VorgangForwardingInfoComponent } from './vorgang-forwarding-container/v import { VorgangForwardZustellenContainerComponent } from './vorgang-forwarding-zustellen-container/vorgang-forward-zustellen-container.component'; @NgModule({ - imports: [CommonModule, TechSharedModule, ForwardingSharedModule, CommandSharedModule, UiModule], + imports: [ + CommonModule, + ForwardingSharedModule, + CommandSharedModule, + OzgcloudTextEditorComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + SpinnerComponent, + FormatDateWithTimePipe, + MatIcon, + HasLinkPipe, + ToEmbeddedResourcesPipe, + ExpansionPanelComponent, + ReactiveFormsModule, + ], declarations: [ VorgangForwardZustellenContainerComponent, VorgangForwardingContainerComponent, diff --git a/alfa-client/libs/forwarding/src/lib/vorgang-forwarding-container/vorgang-forward-formular/vorgang-forward-form/vorgang-forward-form.component.spec.ts b/alfa-client/libs/forwarding/src/lib/vorgang-forwarding-container/vorgang-forward-formular/vorgang-forward-form/vorgang-forward-form.component.spec.ts index 19d141bc8d2ff6553331a408380f77d29ee028cd..d4de767de8c460d74794b21ec61a5152ee38d2c6 100644 --- a/alfa-client/libs/forwarding/src/lib/vorgang-forwarding-container/vorgang-forward-formular/vorgang-forward-form/vorgang-forward-form.component.spec.ts +++ b/alfa-client/libs/forwarding/src/lib/vorgang-forwarding-container/vorgang-forward-formular/vorgang-forward-form/vorgang-forward-form.component.spec.ts @@ -21,15 +21,15 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { mock } from '@alfa-client/test-utils'; +import { OzgcloudStrokedButtonWithSpinnerComponent, OzgcloudTextEditorComponent } from '@alfa-client/ui'; +import { VorgangWithEingangResource } from '@alfa-client/vorgang-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { ReactiveFormsModule, UntypedFormControl, UntypedFormGroup } from '@angular/forms'; import { MatFormFieldModule } from '@angular/material/form-field'; import { MatIcon } from '@angular/material/icon'; import { MatInputModule } from '@angular/material/input'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; -import { mock } from '@alfa-client/test-utils'; -import { OzgcloudStrokedButtonWithSpinnerComponent, TextEditorComponent } from '@alfa-client/ui'; -import { VorgangWithEingangResource } from '@alfa-client/vorgang-shared'; import { createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang'; import { MockComponent } from 'ng-mocks'; import { VorgangForwardFormComponent } from './vorgang-forward-form.component'; @@ -54,7 +54,7 @@ describe('VorgangForwardFormComponent', () => { VorgangForwardFormComponent, MatIcon, MockComponent(OzgcloudStrokedButtonWithSpinnerComponent), - MockComponent(TextEditorComponent), + MockComponent(OzgcloudTextEditorComponent), ], imports: [MatFormFieldModule, MatInputModule, ReactiveFormsModule, BrowserAnimationsModule], providers: [ @@ -112,10 +112,7 @@ describe('VorgangForwardFormComponent', () => { component.patchEmail(); - expect(formService.patchField).toHaveBeenCalledWith( - 'email', - vorgangWithEingang.eingang.zustaendigeStelle.email, - ); + expect(formService.patchField).toHaveBeenCalledWith('email', vorgangWithEingang.eingang.zustaendigeStelle.email); }); }); }); diff --git a/alfa-client/libs/hint-shared/src/lib/hint-shared.module.ts b/alfa-client/libs/hint-shared/src/lib/hint-shared.module.ts index e0304dd1d6259a58a58fa0f66405cb22c7c64ba8..482c311a15767e88f3c95d8db8d7f8c2523611c9 100644 --- a/alfa-client/libs/hint-shared/src/lib/hint-shared.module.ts +++ b/alfa-client/libs/hint-shared/src/lib/hint-shared.module.ts @@ -21,10 +21,9 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { ApiRootModule } from '@alfa-client/api-root-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; -import { ApiRootModule } from '@alfa-client/api-root-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; import { EffectsModule } from '@ngrx/effects'; import { StoreModule } from '@ngrx/store'; import { HintEffects } from './+state/hint.effects'; @@ -38,7 +37,6 @@ import { HintService } from './hint.service'; CommonModule, StoreModule.forFeature(HINT_FEATURE_KEY, reducer), EffectsModule.forFeature([HintEffects]), - TechSharedModule, ApiRootModule, ], providers: [HintService, HintFacade, HintRepository], diff --git a/alfa-client/libs/hint/src/lib/hint.module.ts b/alfa-client/libs/hint/src/lib/hint.module.ts index 37fa3fb082fb9ee488c5ee44648ac4cda32f3d93..d72695756dffe723cb6532ff1a558ce17477e2ef 100644 --- a/alfa-client/libs/hint/src/lib/hint.module.ts +++ b/alfa-client/libs/hint/src/lib/hint.module.ts @@ -21,16 +21,15 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { CommonModule } from '@angular/common'; -import { NgModule } from '@angular/core'; import { ApiRootModule } from '@alfa-client/api-root-shared'; import { HintSharedModule } from '@alfa-client/hint-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; +import { CommonModule } from '@angular/common'; +import { NgModule } from '@angular/core'; import { HintContainerComponent } from './hint-container/hint-container.component'; import { UserNoOrganisationsEinheitIdHintComponent } from './hint-container/user-no-organisations-einheit-id-hint/user-no-organisations-einheit-id-hint.component'; @NgModule({ - imports: [CommonModule, TechSharedModule, ApiRootModule, HintSharedModule], + imports: [CommonModule, ApiRootModule, HintSharedModule], declarations: [UserNoOrganisationsEinheitIdHintComponent, HintContainerComponent], exports: [HintContainerComponent], }) diff --git a/alfa-client/libs/historie/src/lib/historie-container/historie-list/historie-item-bescheid/historie-item-bescheid-status/historie-item-bescheid-status.component.spec.ts b/alfa-client/libs/historie/src/lib/historie-container/historie-list/historie-item-bescheid/historie-item-bescheid-status/historie-item-bescheid-status.component.spec.ts index a47331f8708e9ef6f86be744fe00a40eb307d539..cea37b23a9a580a7daf7f10cadda775444d6cebe 100644 --- a/alfa-client/libs/historie/src/lib/historie-container/historie-list/historie-item-bescheid/historie-item-bescheid-status/historie-item-bescheid-status.component.spec.ts +++ b/alfa-client/libs/historie/src/lib/historie-container/historie-list/historie-item-bescheid/historie-item-bescheid-status/historie-item-bescheid-status.component.spec.ts @@ -42,7 +42,8 @@ describe('HistorieItemBescheidStatusComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [HistorieItemBescheidStatusComponent, ConvertToBooleanPipe, FormatFullDatePipe], + imports: [ConvertToBooleanPipe, FormatFullDatePipe], + declarations: [HistorieItemBescheidStatusComponent], }).compileComponents(); fixture = TestBed.createComponent(HistorieItemBescheidStatusComponent); diff --git a/alfa-client/libs/historie/src/lib/historie-container/historie-list/historie-item-vorgang-created/historie-item-vorgang-created.component.spec.ts b/alfa-client/libs/historie/src/lib/historie-container/historie-list/historie-item-vorgang-created/historie-item-vorgang-created.component.spec.ts index 97a69102871a05a4114818db1c0b44bdfb113c79..1fb501bf07dfb0fbf0c966f35582ac9894178582 100644 --- a/alfa-client/libs/historie/src/lib/historie-container/historie-list/historie-item-vorgang-created/historie-item-vorgang-created.component.spec.ts +++ b/alfa-client/libs/historie/src/lib/historie-container/historie-list/historie-item-vorgang-created/historie-item-vorgang-created.component.spec.ts @@ -21,12 +21,12 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { registerLocaleData } from '@angular/common'; -import localeDe from '@angular/common/locales/de'; -import { ComponentFixture, TestBed } from '@angular/core/testing'; import { FormatDateWithTimePipe } from '@alfa-client/tech-shared'; import { getElementFromFixture } from '@alfa-client/test-utils'; import { VorgangWithEingangResource } from '@alfa-client/vorgang-shared'; +import { registerLocaleData } from '@angular/common'; +import localeDe from '@angular/common/locales/de'; +import { ComponentFixture, TestBed } from '@angular/core/testing'; import { getDataTestIdOf } from 'libs/tech-shared/test/data-test'; import { createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang'; import { HistorieItemVorgangCreatedComponent } from './historie-item-vorgang-created.component'; @@ -43,7 +43,8 @@ describe('HistorieItemVorgangCreatedComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [FormatDateWithTimePipe, HistorieItemVorgangCreatedComponent], + imports: [FormatDateWithTimePipe], + declarations: [HistorieItemVorgangCreatedComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/historie/src/lib/historie.module.ts b/alfa-client/libs/historie/src/lib/historie.module.ts index 7c064391c2e621a96da017383c07edb67ec65f7e..c9675a36427c958658176eac4776cbc1fdf23c9d 100644 --- a/alfa-client/libs/historie/src/lib/historie.module.ts +++ b/alfa-client/libs/historie/src/lib/historie.module.ts @@ -23,11 +23,20 @@ */ import { CommandSharedModule } from '@alfa-client/command-shared'; import { HistorieSharedModule } from '@alfa-client/historie-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { + ConvertToBooleanPipe, + FormatDateWithTimePipe, + FormatToPrettyDatePipe, + HasLinkPipe, + ToEmbeddedResourcesPipe, +} from '@alfa-client/tech-shared'; +import { AccordionComponent, AppIconComponent, SpinnerComponent } from '@alfa-client/ui'; import { UserProfileModule } from '@alfa-client/user-profile'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; +import { MatExpansionPanel, MatExpansionPanelTitle } from '@angular/material/expansion'; +import { MatIcon } from '@angular/material/icon'; +import { FormatFullDatePipe } from '../../../tech-shared/src/lib/pipe/format-full-date.pipe'; import { HistorieContainerComponent } from './historie-container/historie-container.component'; import { ExpansionPanelWithUserComponent } from './historie-container/historie-list/expansion-panel-with-user/expansion-panel-with-user.component'; import { HistorieItemAktenzeichenComponent } from './historie-container/historie-list/historie-item-aktenzeichen/historie-item-aktenzeichen.component'; @@ -52,11 +61,21 @@ import { HistorieListComponent } from './historie-container/historie-list/histor @NgModule({ imports: [ CommonModule, - TechSharedModule, HistorieSharedModule, UserProfileModule, - UiModule, CommandSharedModule, + MatExpansionPanel, + MatExpansionPanelTitle, + MatIcon, + ConvertToBooleanPipe, + FormatFullDatePipe, + HasLinkPipe, + AppIconComponent, + FormatDateWithTimePipe, + FormatToPrettyDatePipe, + SpinnerComponent, + AccordionComponent, + ToEmbeddedResourcesPipe, ], declarations: [ HistorieContainerComponent, diff --git a/alfa-client/libs/kommentar-shared/src/lib/kommentar-shared.module.ts b/alfa-client/libs/kommentar-shared/src/lib/kommentar-shared.module.ts index f87a70b3cbc9d588e2f2ea0b002d0590724279ef..de0954a3f8febb42069459356746526f8a9bc977 100644 --- a/alfa-client/libs/kommentar-shared/src/lib/kommentar-shared.module.ts +++ b/alfa-client/libs/kommentar-shared/src/lib/kommentar-shared.module.ts @@ -21,12 +21,11 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { VorgangSharedModule } from '@alfa-client/vorgang-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { VorgangSharedModule } from '@alfa-client/vorgang-shared'; @NgModule({ - imports: [CommonModule, TechSharedModule, VorgangSharedModule], + imports: [CommonModule, VorgangSharedModule], }) export class KommentarSharedModule {} diff --git a/alfa-client/libs/kommentar/src/lib/kommentar.module.ts b/alfa-client/libs/kommentar/src/lib/kommentar.module.ts index 9c5bf2a3b4ec706b007afa7165a09113d53d562e..ec85e4d48fc4dea3fb28b113fa16678bb771d6d0 100644 --- a/alfa-client/libs/kommentar/src/lib/kommentar.module.ts +++ b/alfa-client/libs/kommentar/src/lib/kommentar.module.ts @@ -23,12 +23,13 @@ */ import { BinaryFileModule } from '@alfa-client/binary-file'; import { KommentarSharedModule } from '@alfa-client/kommentar-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { ConvertForDataTestPipe, FormatDateWithTimePipe, HasLinkPipe } from '@alfa-client/tech-shared'; +import { ExpansionPanelComponent, OzgcloudStrokedButtonWithSpinnerComponent, TextAreaEditorComponent } from '@alfa-client/ui'; import { UserProfileModule } from '@alfa-client/user-profile'; import { VorgangSharedModule } from '@alfa-client/vorgang-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; +import { ReactiveFormsModule } from '@angular/forms'; import { MultiFileUploadEditorComponent } from '../../../binary-file/src/lib/multi-file-upload-editor/multi-file-upload-editor.component'; import { MultiFileUploadListContainerComponent } from '../../../binary-file/src/lib/multi-file-upload-list-container/multi-file-upload-list-container.component'; import { KommentarFormComponent } from './kommentar-list-in-vorgang-container/kommentar-form/kommentar-form.component'; @@ -40,13 +41,18 @@ import { KommentarListItemInVorgangComponent } from './kommentar-list-in-vorgang imports: [ CommonModule, VorgangSharedModule, - UiModule, KommentarSharedModule, - TechSharedModule, UserProfileModule, BinaryFileModule, MultiFileUploadEditorComponent, MultiFileUploadListContainerComponent, + ReactiveFormsModule, + TextAreaEditorComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + ConvertForDataTestPipe, + HasLinkPipe, + FormatDateWithTimePipe, + ExpansionPanelComponent, ], declarations: [ KommentarListInVorgangContainerComponent, diff --git a/alfa-client/libs/loesch-anforderung/src/lib/loesch-anforderung.module.ts b/alfa-client/libs/loesch-anforderung/src/lib/loesch-anforderung.module.ts index 4841c7b2b27decf170b93076d58369f9aa9d4a58..ff527cfc478f145690f5a846abb7fbfb1bff33ec 100644 --- a/alfa-client/libs/loesch-anforderung/src/lib/loesch-anforderung.module.ts +++ b/alfa-client/libs/loesch-anforderung/src/lib/loesch-anforderung.module.ts @@ -22,8 +22,8 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { LoeschAnforderungSharedModule } from '@alfa-client/loesch-anforderung-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { HasLinkPipe } from '@alfa-client/tech-shared'; +import { IconButtonWithSpinnerComponent, OzgcloudStrokedButtonWithSpinnerComponent } from '@alfa-client/ui'; import { VorgangSharedModule } from '@alfa-client/vorgang-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; @@ -45,9 +45,10 @@ import { LoeschenAnfordernButtonComponent } from './loeschen-anfordern-button-co imports: [ CommonModule, LoeschAnforderungSharedModule, - TechSharedModule, - UiModule, VorgangSharedModule, + OzgcloudStrokedButtonWithSpinnerComponent, + IconButtonWithSpinnerComponent, + HasLinkPipe, RequestVorgangDeletionIconComponent, ButtonWithSpinnerComponent, DeleteVorgangFinallyIconComponent, diff --git a/alfa-client/libs/navigation-shared/src/lib/navigation-shared.module.ts b/alfa-client/libs/navigation-shared/src/lib/navigation-shared.module.ts index b596ca2b99d19f47cd1e08dfdffbf0c9307b2130..16fde28370c70d812f2e55f778b474ac5afc834e 100644 --- a/alfa-client/libs/navigation-shared/src/lib/navigation-shared.module.ts +++ b/alfa-client/libs/navigation-shared/src/lib/navigation-shared.module.ts @@ -23,7 +23,6 @@ */ import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; -import { TechSharedModule } from '@alfa-client/tech-shared'; import { EffectsModule } from '@ngrx/effects'; import { StoreModule } from '@ngrx/store'; import { NavigationEffects } from './+state/navigation.effects'; @@ -36,7 +35,6 @@ import { NavigationService } from './navigation.service'; CommonModule, StoreModule.forFeature(fromNavigation.NAVIGATION_FEATURE_KEY, fromNavigation.reducer), EffectsModule.forFeature([NavigationEffects]), - TechSharedModule, ], providers: [NavigationFacade, NavigationService], }) diff --git a/alfa-client/libs/navigation/src/lib/header-container/header/header.component.spec.ts b/alfa-client/libs/navigation/src/lib/header-container/header/header.component.spec.ts index 34bfb94cc20aad98d03a09e66c82578fb694ea97..3566cb04a61f9fac5fbfb37af6fa8e8faefc19bf 100644 --- a/alfa-client/libs/navigation/src/lib/header-container/header/header.component.spec.ts +++ b/alfa-client/libs/navigation/src/lib/header-container/header/header.component.spec.ts @@ -22,7 +22,6 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { AccessibilityButtonComponent } from '@alfa-client/common'; -import { UiModule } from '@alfa-client/ui'; import { HelpMenuComponent } from '@alfa-client/user-assistance'; import { UserProfileInHeaderContainerComponent } from '@alfa-client/user-profile'; import { UserSettingsContainerComponent } from '@alfa-client/user-settings'; @@ -38,7 +37,6 @@ describe('HeaderComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [UiModule], declarations: [ HeaderComponent, MockComponent(HeaderLogoComponent), diff --git a/alfa-client/libs/navigation/src/lib/navigation.module.spec.ts b/alfa-client/libs/navigation/src/lib/navigation.module.spec.ts index 8cb65e6da40705f8e87e00a461202ff56ce23fb7..a4f111d64e4aef9ee2f22a302917397ce923cbd5 100644 --- a/alfa-client/libs/navigation/src/lib/navigation.module.spec.ts +++ b/alfa-client/libs/navigation/src/lib/navigation.module.spec.ts @@ -24,7 +24,7 @@ import { TestBed } from '@angular/core/testing'; import { NavigationModule } from './navigation.module'; -describe('UiModule', () => { +describe('NavigationModule', () => { beforeEach(async () => { await TestBed.configureTestingModule({ imports: [NavigationModule], diff --git a/alfa-client/libs/navigation/src/lib/navigation.module.ts b/alfa-client/libs/navigation/src/lib/navigation.module.ts index 67cd2f216c40a0e850204b31089771c3912fffda..37ee7178625f6fbd7ffb92228dfb25f04cffacd7 100644 --- a/alfa-client/libs/navigation/src/lib/navigation.module.ts +++ b/alfa-client/libs/navigation/src/lib/navigation.module.ts @@ -22,7 +22,6 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { AccessibilityButtonComponent } from '@alfa-client/common'; -import { UiModule } from '@alfa-client/ui'; import { UserAssistanceModule } from '@alfa-client/user-assistance'; import { UserProfileModule } from '@alfa-client/user-profile'; import { UserSettingsModule } from '@alfa-client/user-settings'; @@ -38,7 +37,6 @@ import { HeaderComponent } from './header-container/header/header.component'; declarations: [HeaderComponent, HeaderContainerComponent, HeaderLogoComponent], imports: [ CommonModule, - UiModule, RouterModule, VorgangSharedUiModule, UserProfileModule, diff --git a/alfa-client/libs/organisations-einheit/src/lib/organisations-einheit-list-item-container/organisations-einheit-list-item/organisations-einheit-list-item.component.ts b/alfa-client/libs/organisations-einheit/src/lib/organisations-einheit-list-item-container/organisations-einheit-list-item/organisations-einheit-list-item.component.ts index f4fc21b66bd7915eeb58bcc6537f4c644a78a509..05558ae4b77e69cb7b278d5862fa0662c4823a93 100644 --- a/alfa-client/libs/organisations-einheit/src/lib/organisations-einheit-list-item-container/organisations-einheit-list-item/organisations-einheit-list-item.component.ts +++ b/alfa-client/libs/organisations-einheit/src/lib/organisations-einheit-list-item-container/organisations-einheit-list-item/organisations-einheit-list-item.component.ts @@ -22,7 +22,7 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { StateResource } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { SpinnerComponent } from '@alfa-client/ui'; import { OrganisationsEinheitResource } from '@alfa-client/zustaendige-stelle-shared'; import { Component, Input } from '@angular/core'; import { ExternalUnitIconComponent, PublicAdministrationIconComponent } from '@ods/system'; @@ -30,7 +30,7 @@ import { ExternalUnitIconComponent, PublicAdministrationIconComponent } from '@o @Component({ selector: 'alfa-organisations-einheit-list-item', standalone: true, - imports: [ExternalUnitIconComponent, PublicAdministrationIconComponent, UiModule], + imports: [ExternalUnitIconComponent, PublicAdministrationIconComponent, SpinnerComponent], templateUrl: './organisations-einheit-list-item.component.html', }) export class OrganisationsEinheitListItemComponent { diff --git a/alfa-client/libs/postfach/src/lib/postfach-mail-form/postfach-mail-form.component.spec.ts b/alfa-client/libs/postfach/src/lib/postfach-mail-form/postfach-mail-form.component.spec.ts index c3fd2f97ae173d6ef591e90cc8c3eedc2194bf8f..5b5beec8bf365ee4a043970eb471f592faeb4ed7 100644 --- a/alfa-client/libs/postfach/src/lib/postfach-mail-form/postfach-mail-form.component.spec.ts +++ b/alfa-client/libs/postfach/src/lib/postfach-mail-form/postfach-mail-form.component.spec.ts @@ -29,9 +29,9 @@ import { FileUploadComponent, IconButtonWithSpinnerComponent, OzgcloudStrokedButtonWithSpinnerComponent, + OzgcloudTextEditorComponent, SpinnerComponent, TextAreaEditorComponent, - TextEditorComponent, } from '@alfa-client/ui'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { FormBuilder, ReactiveFormsModule } from '@angular/forms'; @@ -58,10 +58,7 @@ describe('PostfachMailFormComponent', () => { ...mock(PostfachService), getSettings: jest.fn().mockReturnValue(of(createPostfachSettings())), }; - const formService: PostfachMailFormservice = new PostfachMailFormservice( - new FormBuilder(), - useFromMock(postfachService), - ); + const formService: PostfachMailFormservice = new PostfachMailFormservice(new FormBuilder(), useFromMock(postfachService)); const dialogService: Mock<DialogService> = mock(DialogService); beforeEach(async () => { @@ -69,7 +66,7 @@ describe('PostfachMailFormComponent', () => { declarations: [ PostfachMailFormComponent, MockComponent(TextAreaEditorComponent), - MockComponent(TextEditorComponent), + MockComponent(OzgcloudTextEditorComponent), MockComponent(IconButtonWithSpinnerComponent), MockComponent(OzgcloudStrokedButtonWithSpinnerComponent), MockComponent(PostfachNachrichtReplyEditorContainerComponent), diff --git a/alfa-client/libs/postfach/src/lib/postfach-mail-list-container/postfach-mail-list/postfach-mail/postfach-mail-date/postfach-mail-date.component.spec.ts b/alfa-client/libs/postfach/src/lib/postfach-mail-list-container/postfach-mail-list/postfach-mail/postfach-mail-date/postfach-mail-date.component.spec.ts index 5a488822426b781de116fa4204e9133a6c3d3565..ca8fd42b29448ed3b4e56f55c00eca3f50d758a5 100644 --- a/alfa-client/libs/postfach/src/lib/postfach-mail-list-container/postfach-mail-list/postfach-mail/postfach-mail-date/postfach-mail-date.component.spec.ts +++ b/alfa-client/libs/postfach/src/lib/postfach-mail-list-container/postfach-mail-list/postfach-mail/postfach-mail-date/postfach-mail-date.component.spec.ts @@ -21,12 +21,12 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { registerLocaleData } from '@angular/common'; -import localeDe from '@angular/common/locales/de'; -import { ComponentFixture, TestBed } from '@angular/core/testing'; import { Direction } from '@alfa-client/postfach-shared'; import { FormatDateWithTimePipe, HasLinkPipe } from '@alfa-client/tech-shared'; import { getElementFromFixture } from '@alfa-client/test-utils'; +import { registerLocaleData } from '@angular/common'; +import localeDe from '@angular/common/locales/de'; +import { ComponentFixture, TestBed } from '@angular/core/testing'; import { createPostfachMailResource } from 'libs/postfach-shared/test/postfach'; import { PostfachMailDateComponent } from './postfach-mail-date.component'; @@ -41,7 +41,8 @@ describe('PostfachMailDateComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [PostfachMailDateComponent, HasLinkPipe, FormatDateWithTimePipe], + imports: [HasLinkPipe, FormatDateWithTimePipe], + declarations: [PostfachMailDateComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/postfach/src/lib/postfach.module.ts b/alfa-client/libs/postfach/src/lib/postfach.module.ts index e206c35d6c8efaad6336bf8f3740e1f075f5ada7..2a6fe82af2922461a8ed345f322b54e754f2ccec 100644 --- a/alfa-client/libs/postfach/src/lib/postfach.module.ts +++ b/alfa-client/libs/postfach/src/lib/postfach.module.ts @@ -23,11 +23,24 @@ */ import { BinaryFileModule } from '@alfa-client/binary-file'; import { ON_PAGE, PostfachSharedModule } from '@alfa-client/postfach-shared'; -import { UiModule } from '@alfa-client/ui'; +import { ConvertForDataTestPipe, FormatDateWithTimePipe, HasLinkPipe, ToEmbeddedResourcesPipe } from '@alfa-client/tech-shared'; +import { + BackButtonComponent, + CheckboxEnumEditorComponent, + IconButtonWithSpinnerComponent, + OzgcloudIconComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + OzgcloudTextEditorComponent, + SpinnerComponent, + SubnavigationComponent, + TextAreaEditorComponent, +} from '@alfa-client/ui'; import { UserProfileModule } from '@alfa-client/user-profile'; import { VorgangSharedUiModule } from '@alfa-client/vorgang-shared-ui'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; +import { ReactiveFormsModule } from '@angular/forms'; +import { MatIcon } from '@angular/material/icon'; import { RouterModule, Routes } from '@angular/router'; import { ButtonComponent, MailboxIconComponent, PlusIconComponent, TooltipDirective } from '@ods/system'; import { PostfachMailButtonContainerComponent } from './postfach-mail-button-container/postfach-mail-button-container.component'; @@ -63,11 +76,25 @@ const routes: Routes = [ imports: [ CommonModule, RouterModule.forChild(routes), - UiModule, PostfachSharedModule, UserProfileModule, VorgangSharedUiModule, BinaryFileModule, + OzgcloudStrokedButtonWithSpinnerComponent, + HasLinkPipe, + CheckboxEnumEditorComponent, + ReactiveFormsModule, + OzgcloudTextEditorComponent, + TextAreaEditorComponent, + MatIcon, + OzgcloudIconComponent, + FormatDateWithTimePipe, + SpinnerComponent, + ToEmbeddedResourcesPipe, + ConvertForDataTestPipe, + SubnavigationComponent, + BackButtonComponent, + IconButtonWithSpinnerComponent, ButtonComponent, PlusIconComponent, MailboxIconComponent, diff --git a/alfa-client/libs/resource-redirect-shared/src/lib/resource-redirect-shared.module.ts b/alfa-client/libs/resource-redirect-shared/src/lib/resource-redirect-shared.module.ts index c595c6eed1d99ffe27153f717583e2f99b8f4248..33ef83703dab9eb294a07b39e499349780932399 100644 --- a/alfa-client/libs/resource-redirect-shared/src/lib/resource-redirect-shared.module.ts +++ b/alfa-client/libs/resource-redirect-shared/src/lib/resource-redirect-shared.module.ts @@ -21,10 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; import { NgModule } from '@angular/core'; -@NgModule({ - imports: [TechSharedModule], -}) +@NgModule({}) export class ResourceRedirectSharedModule {} diff --git a/alfa-client/libs/tech-shared/src/index.ts b/alfa-client/libs/tech-shared/src/index.ts index f2c01ec546c183620b05b39ad37f6af73368cddd..6fbc4e5294b1490dd9924a225715b0007c0ba80f 100644 --- a/alfa-client/libs/tech-shared/src/index.ts +++ b/alfa-client/libs/tech-shared/src/index.ts @@ -29,6 +29,7 @@ export * from './lib/error/error.handler'; export * from './lib/error/error.util'; export * from './lib/form.util'; export * from './lib/http.util'; +export * from './lib/injector/injector.service'; export * from './lib/keyboard.util'; export * from './lib/message-code'; export * from './lib/ngrx/actions'; @@ -57,7 +58,6 @@ export * from './lib/resource/resource.rxjs.operator'; export * from './lib/resource/resource.service'; export * from './lib/resource/resource.util'; export * from './lib/service/formservice.abstract'; -export * from './lib/tech-shared.module'; export * from './lib/tech.model'; export * from './lib/tech.util'; export * from './lib/validation/tech.validation.util'; diff --git a/alfa-client/libs/tech-shared/src/lib/decorator/error.decorator.util.ts b/alfa-client/libs/tech-shared/src/lib/decorator/error.decorator.util.ts index 669b6872398a4d9a3539741ec84fad461375f445..f02936d4fbd11d5a37b30d5e1864323bc0fa9cb1 100644 --- a/alfa-client/libs/tech-shared/src/lib/decorator/error.decorator.util.ts +++ b/alfa-client/libs/tech-shared/src/lib/decorator/error.decorator.util.ts @@ -22,10 +22,10 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { HttpErrorHandler } from '../error/error.handler'; -import { TechSharedModule } from '../tech-shared.module'; +import { InjectorService } from '../injector/injector.service'; export function injectHttpErrorHandler(): HttpErrorHandler { - return TechSharedModule.injector.get(HttpErrorHandler); + return InjectorService.getInjector().get(HttpErrorHandler); } export function enableInterceptorDefaultHandling(httpErrorHandler: HttpErrorHandler): void { diff --git a/alfa-client/libs/tech-shared/src/lib/injector/injector.service.spec.ts b/alfa-client/libs/tech-shared/src/lib/injector/injector.service.spec.ts new file mode 100644 index 0000000000000000000000000000000000000000..1833f3fd12e12fa277a131186d3a27623a3c2251 --- /dev/null +++ b/alfa-client/libs/tech-shared/src/lib/injector/injector.service.spec.ts @@ -0,0 +1,30 @@ +import { Injector } from '@angular/core'; +import { TestBed } from '@angular/core/testing'; +import { InjectorService } from './injector.service'; + +describe('InjectorService', () => { + let injector: Injector; + let injectorService: InjectorService; + + beforeEach(() => { + TestBed.configureTestingModule({ + providers: [InjectorService, { provide: Injector, useValue: {} }], + }); + injector = TestBed.inject(Injector); + injectorService = TestBed.inject(InjectorService); + }); + + it('should be created', () => { + expect(injectorService).toBeTruthy(); + }); + + it('should set and get the injector', () => { + expect(InjectorService.getInjector()).toBe(injector); + }); + + describe('getInjector', () => { + it('should return the injector', () => { + expect(InjectorService.getInjector()).toBe(injector); + }); + }); +}); diff --git a/alfa-client/libs/tech-shared/src/lib/injector/injector.service.ts b/alfa-client/libs/tech-shared/src/lib/injector/injector.service.ts new file mode 100644 index 0000000000000000000000000000000000000000..eb2ad9d101376adff380bc8930f5e0274503ddbb --- /dev/null +++ b/alfa-client/libs/tech-shared/src/lib/injector/injector.service.ts @@ -0,0 +1,16 @@ +import { Injectable, Injector } from '@angular/core'; + +@Injectable({ + providedIn: 'root', +}) +export class InjectorService { + private static injector: Injector; + + constructor(injector: Injector) { + InjectorService.injector = injector; + } + + public static getInjector(): Injector { + return InjectorService.injector; + } +} diff --git a/alfa-client/libs/tech-shared/src/lib/keyboard.util.spec.ts b/alfa-client/libs/tech-shared/src/lib/keyboard.util.spec.ts index 10b46493b6c1d89755bddaefb378a4691ac82cae..92ba5f3e69a27a05a50ee8fbdf1ec33f70b776cf 100644 --- a/alfa-client/libs/tech-shared/src/lib/keyboard.util.spec.ts +++ b/alfa-client/libs/tech-shared/src/lib/keyboard.util.spec.ts @@ -21,7 +21,7 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { createKeydownKeyboardEvent } from '../../../test-utils/src/lib/keyboard'; +import { createKeydownKeyboardEvent } from 'libs/test-utils/src/lib/keyboard'; import { ARROW_DOWN_KEY, ARROW_UP_KEY, diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/convert-api-error-to-error-messages.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/convert-api-error-to-error-messages.pipe.ts index 20392c34d74bdcd980c5f3ba961f6f4be8484dae..e57e531260cb15aa718a6193fd624b5fc277c917 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/convert-api-error-to-error-messages.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/convert-api-error-to-error-messages.pipe.ts @@ -25,7 +25,10 @@ import { ApiError, EMPTY_STRING, getMessageForIssue, Issue } from '@alfa-client/ import { Pipe, PipeTransform } from '@angular/core'; import { isNil } from 'lodash-es'; -@Pipe({ name: 'convertApiErrorToErrorMessages' }) +@Pipe({ + name: 'convertApiErrorToErrorMessages', + standalone: true, +}) export class ConvertApiErrorToErrorMessagesPipe implements PipeTransform { transform(value: ApiError) { if (isNil(value)) { diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/convert-for-data-test.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/convert-for-data-test.pipe.ts index b1873901646b2c270a3e353158821aed99a19059..dd6bb93c51596fd3d4e6f40973e1050c94f83330 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/convert-for-data-test.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/convert-for-data-test.pipe.ts @@ -25,7 +25,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { isNil } from 'lodash-es'; import { convertForDataTest } from '../tech.util'; -@Pipe({ name: 'convertForDataTest' }) +@Pipe({ + name: 'convertForDataTest', + standalone: true, +}) export class ConvertForDataTestPipe implements PipeTransform { transform(value: string): string { return isNil(value) ? null : convertForDataTest(value); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/convert-problem-detail-to-error-messages.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/convert-problem-detail-to-error-messages.pipe.ts index 24f50446e27078791793cb671bee05d3cef19868..7ce05836fe5a7e410c9467cc4a676c7fa13c9338 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/convert-problem-detail-to-error-messages.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/convert-problem-detail-to-error-messages.pipe.ts @@ -27,14 +27,15 @@ import { InvalidParam, ProblemDetail } from '../tech.model'; import { EMPTY_STRING } from '../tech.util'; import { getMessageForInvalidParam } from '../validation/tech.validation.util'; -@Pipe({ name: 'convertProblemDetailToErrorMessages' }) +@Pipe({ + name: 'convertProblemDetailToErrorMessages', + standalone: true, +}) export class ConvertProblemDetailToErrorMessagesPipe implements PipeTransform { transform(value: ProblemDetail) { if (isNil(value)) { return []; } - return value.invalidParams.map((invalidParam: InvalidParam) => - getMessageForInvalidParam(EMPTY_STRING, invalidParam), - ); + return value.invalidParams.map((invalidParam: InvalidParam) => getMessageForInvalidParam(EMPTY_STRING, invalidParam)); } } diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/convert-to-boolean.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/convert-to-boolean.pipe.ts index daac6384c220168403ffc3fdb50395bbee2dc4e1..ad5da3e0789786d617ee3e61d7ac56c075c43cae 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/convert-to-boolean.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/convert-to-boolean.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { convertToBoolean } from '../tech.util'; -@Pipe({ name: 'convertToBoolean' }) +@Pipe({ + name: 'convertToBoolean', + standalone: true, +}) export class ConvertToBooleanPipe implements PipeTransform { public transform(booleanStr: string): boolean { return convertToBoolean(booleanStr); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/enum-to-label.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/enum-to-label.pipe.ts index 194e92483d10610441c53b3924f84e0d550cf307..38033a71822e29d42e25b491e28b5dd956d062e8 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/enum-to-label.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/enum-to-label.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { isNil } from 'lodash-es'; -@Pipe({ name: 'enumToLabel' }) +@Pipe({ + name: 'enumToLabel', + standalone: true, +}) export class EnumToLabelPipe implements PipeTransform { transform(enumValue: any, enumLabel: any) { return isNil(enumValue) || isNil(enumLabel) ? null : enumLabel[enumValue]; diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/file-size-plain.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/file-size-plain.pipe.ts index 186326278800e742fb80e860f070d0d7c308afc9..d18d294fa363a63a4e54686a8e8370d042195304 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/file-size-plain.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/file-size-plain.pipe.ts @@ -23,7 +23,10 @@ */ import { Pipe, PipeTransform } from '@angular/core'; -@Pipe({ name: 'fileSizePlain' }) +@Pipe({ + name: 'fileSizePlain', + standalone: true, +}) export class FileSizePlainPipe implements PipeTransform { readonly kB = 1024; readonly MB = Math.pow(this.kB, 2); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/file-size.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/file-size.pipe.ts index 327058ea9ccd0dc223546898463addb963061d7f..db4f54706322fda80474fca4e0a6876876e84d50 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/file-size.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/file-size.pipe.ts @@ -23,7 +23,10 @@ */ import { Pipe, PipeTransform } from '@angular/core'; -@Pipe({ name: 'fileSize' }) +@Pipe({ + name: 'fileSize', + standalone: true, +}) export class FileSizePipe implements PipeTransform { readonly kB = 1024; readonly MB = Math.pow(this.kB, 2); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/format-date-with-time.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/format-date-with-time.pipe.ts index fc33dcc8a3fa493b49c8b944a23231aed86e2e21..7d95383257bd84540653acef2140d74ecac8d267 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/format-date-with-time.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/format-date-with-time.pipe.ts @@ -24,11 +24,12 @@ import { Pipe, PipeTransform } from '@angular/core'; import { formatFullDateWithTimeAndDay, formatFullDateWithTimeWithoutSeconds } from '../date.util'; -@Pipe({ name: 'formatDateWithTimePipe' }) +@Pipe({ + name: 'formatDateWithTimePipe', + standalone: true, +}) export class FormatDateWithTimePipe implements PipeTransform { transform(date: Date, withSeconds: boolean = true): string { - return withSeconds ? - formatFullDateWithTimeAndDay(date) - : formatFullDateWithTimeWithoutSeconds(date); + return withSeconds ? formatFullDateWithTimeAndDay(date) : formatFullDateWithTimeWithoutSeconds(date); } } diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/format-date-without-year-with-time.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/format-date-without-year-with-time.pipe.ts index 42694b05a7c55be2d0069129125e25d85ad2c107..f2835bd7e653ec1d7e0ebab6388e7cd1bf086c44 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/format-date-without-year-with-time.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/format-date-without-year-with-time.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { formatDateWithoutYearWithTime } from '../date.util'; -@Pipe({ name: 'formatDateWithoutYearWithTime' }) +@Pipe({ + name: 'formatDateWithoutYearWithTime', + standalone: true, +}) export class FormatDateWithoutYearWithTimePipe implements PipeTransform { transform(date: Date): string { return formatDateWithoutYearWithTime(date); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/format-full-date.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/format-full-date.pipe.ts index 250167b0bcf28a441ee744360e5f687676778da5..c9bec878f1e56d9fdb740cbcb1bc971d4cb4501a 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/format-full-date.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/format-full-date.pipe.ts @@ -25,7 +25,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { isString } from 'lodash-es'; import { formatFullDate } from '../date.util'; -@Pipe({ name: 'formatFullDatePipe' }) +@Pipe({ + name: 'formatFullDatePipe', + standalone: true, +}) export class FormatFullDatePipe implements PipeTransform { transform(date: Date | string): string { date = isString(date) ? new Date(date) : date; diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/format-to-pretty-date.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/format-to-pretty-date.pipe.ts index 054f4f8b9c6226fd82eacc6b4b368a8955bfdef9..0d16ccd7a7dd6cd3c9c1404070de177f621e86b9 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/format-to-pretty-date.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/format-to-pretty-date.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { formatToPrettyDate } from '../date.util'; -@Pipe({ name: 'formatToPrettyDate' }) +@Pipe({ + name: 'formatToPrettyDate', + standalone: true, +}) export class FormatToPrettyDatePipe implements PipeTransform { transform(date: Date): string { return formatToPrettyDate(date); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/get-url.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/get-url.pipe.ts index c41e3024cd91c233094847e8ba43771d50c965a7..d936124c617e2ad94b4c901be87a9987714fc76c 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/get-url.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/get-url.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { Resource, ResourceUri, getUrl } from '@ngxp/rest'; -@Pipe({ name: 'getUrl' }) +@Pipe({ + name: 'getUrl', + standalone: true, +}) export class GetUrlPipe implements PipeTransform { transform(resource: Resource, link: string): ResourceUri { return getUrl(resource, link); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/has-any-link.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/has-any-link.pipe.ts index 1bf5a803a8af9e39cce2211b854db6871ed8907d..ec9083014c9e2527df574f2367d2bfd8b4e7d6dc 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/has-any-link.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/has-any-link.pipe.ts @@ -26,7 +26,10 @@ import { Resource } from '@ngxp/rest'; import { LinkRelationName } from '../resource/resource.model'; import { hasAnyLink } from '../tech.util'; -@Pipe({ name: 'hasAnyLink' }) +@Pipe({ + name: 'hasAnyLink', + standalone: true, +}) export class HasAnyLinkPipe implements PipeTransform { transform(resource: Resource, ...links: LinkRelationName[]): boolean { return hasAnyLink(resource, ...links); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/has-link.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/has-link.pipe.ts index d2d15cb1eaa008c7ec87667924c230c1d9546365..34abe1a2f2d071b4419c93e64cd8950d9f96a6a4 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/has-link.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/has-link.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { Resource, hasLink } from '@ngxp/rest'; -@Pipe({ name: 'hasLink' }) +@Pipe({ + name: 'hasLink', + standalone: true, +}) export class HasLinkPipe implements PipeTransform { transform(resource: Resource, link: string): boolean { return hasLink(resource, link); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/not-has-any-link.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/not-has-any-link.pipe.ts index 19d64e5599d3b377cb9e4bac93782ce5e1cb988b..b04c9a7b613a2e6b03f1fec4f0115f902aa2629e 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/not-has-any-link.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/not-has-any-link.pipe.ts @@ -26,7 +26,10 @@ import { Resource } from '@ngxp/rest'; import { LinkRelationName } from '../resource/resource.model'; import { notHasAnyLink } from '../tech.util'; -@Pipe({ name: 'notHasAnyLink' }) +@Pipe({ + name: 'notHasAnyLink', + standalone: true, +}) export class NotHasAnyLinkPipe implements PipeTransform { transform(resource: Resource, ...links: LinkRelationName[]): boolean { return notHasAnyLink(resource, ...links); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/not-has-link.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/not-has-link.pipe.ts index 8c8f879b0388c490b209dfdbf1a9abe126a721bc..018d49e877e90b56dd0ad0438c86b09b186af2f8 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/not-has-link.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/not-has-link.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { Resource, hasLink } from '@ngxp/rest'; -@Pipe({ name: 'notHasLink' }) +@Pipe({ + name: 'notHasLink', + standalone: true, +}) export class NotHasLinkPipe implements PipeTransform { transform(resource: Resource, link: string): boolean { return !hasLink(resource, link); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/to-embedded-resource.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/to-embedded-resource.pipe.ts index 5cd6483973472690d47039582bcbfe501c7a8367..7b746907bf222789faf57e003583e46bcb5e16ed 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/to-embedded-resource.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/to-embedded-resource.pipe.ts @@ -27,7 +27,10 @@ import { isNil, isNull } from 'lodash-es'; import { LinkRelationName } from '../resource/resource.model'; import { ListResource } from '../resource/resource.util'; -@Pipe({ name: 'toEmbeddedResources' }) +@Pipe({ + name: 'toEmbeddedResources', + standalone: true, +}) export class ToEmbeddedResourcesPipe implements PipeTransform { transform(listResource: ListResource, linkRel: LinkRelationName): Resource[] { if (isNil(listResource) || isNil(linkRel)) return []; diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/to-resource-uri.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/to-resource-uri.pipe.ts index d102cc20129903fa363c4c5b7708ee4c7cb70e6b..9ac1e3aaa42f8121843ce0effb45caa1c020edeb 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/to-resource-uri.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/to-resource-uri.pipe.ts @@ -26,7 +26,10 @@ import { Resource, ResourceUri } from '@ngxp/rest'; import { isNil } from 'lodash-es'; import { toResourceUri } from '../resource/resource.util'; -@Pipe({ name: 'toResourceUri' }) +@Pipe({ + name: 'toResourceUri', + standalone: true, +}) export class ToResourceUriPipe implements PipeTransform { transform(resource: Resource, linkRel?: string): ResourceUri { if (isNil(resource)) { diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/to-traffic-light-tooltip.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/to-traffic-light-tooltip.pipe.ts index f0e66e4fd889a11a9908cb32a760c95eb6e454e3..ab1c286a7c1e5a1a593a4c4d58f41593be42ef21 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/to-traffic-light-tooltip.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/to-traffic-light-tooltip.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { isPast, isToday, isValid, parseISO } from 'date-fns'; -@Pipe({ name: 'toTrafficLightTooltip' }) +@Pipe({ + name: 'toTrafficLightTooltip', + standalone: true, +}) export class ToTrafficLightTooltipPipe implements PipeTransform { transform(date: Date): string { date = isValid(date) ? date : parseISO(date as unknown as string); diff --git a/alfa-client/libs/tech-shared/src/lib/pipe/to-traffic-light.pipe.ts b/alfa-client/libs/tech-shared/src/lib/pipe/to-traffic-light.pipe.ts index 83f4e421d1ec0453adeb716aec47eb06689407dc..1763a26143e09e51458b019dab3a402e78ea0e3d 100644 --- a/alfa-client/libs/tech-shared/src/lib/pipe/to-traffic-light.pipe.ts +++ b/alfa-client/libs/tech-shared/src/lib/pipe/to-traffic-light.pipe.ts @@ -24,7 +24,10 @@ import { Pipe, PipeTransform } from '@angular/core'; import { isPast, isToday, isValid, parseISO } from 'date-fns'; -@Pipe({ name: 'toTrafficLight' }) +@Pipe({ + name: 'toTrafficLight', + standalone: true, +}) export class ToTrafficLightPipe implements PipeTransform { transform(date: Date): string { date = isValid(date) ? date : parseISO(date as unknown as string); diff --git a/alfa-client/libs/tech-shared/src/lib/resource/list-resource.service.spec.ts b/alfa-client/libs/tech-shared/src/lib/resource/list-resource.service.spec.ts index 8de0536becd0d556430e9961706723ea6065d232..e4f93c1a3a44ce6d3a22eac3b91f239bdc65c59f 100644 --- a/alfa-client/libs/tech-shared/src/lib/resource/list-resource.service.spec.ts +++ b/alfa-client/libs/tech-shared/src/lib/resource/list-resource.service.spec.ts @@ -83,16 +83,22 @@ describe('ListResourceService', () => { isInvalidResourceCombinationSpy = jest.spyOn(ResourceUtil, 'isInvalidResourceCombination').mockReturnValue(true); }); + it('should have debounce', () => { + service.getList().subscribe(); + + expect(service.handleChanges).not.toHaveBeenCalled(); + }); + it('should handle config resource changed', fakeAsync(() => { service.getList().subscribe(); - tick(); + tick(50); expect(service.handleChanges).toHaveBeenCalledWith(listStateResource, baseResource); })); it('should call isInvalidResourceCombinationSpy', fakeAsync(() => { service.getList().subscribe(); - tick(); + tick(50); expect(isInvalidResourceCombinationSpy).toHaveBeenCalled(); })); diff --git a/alfa-client/libs/tech-shared/src/lib/resource/list-resource.service.ts b/alfa-client/libs/tech-shared/src/lib/resource/list-resource.service.ts index 50cee3aa72fb828211d7a70dadc5cdca3d5f55c2..13df5d4cf6fa8f06588a096d454e598faa8a4fa3 100644 --- a/alfa-client/libs/tech-shared/src/lib/resource/list-resource.service.ts +++ b/alfa-client/libs/tech-shared/src/lib/resource/list-resource.service.ts @@ -23,7 +23,7 @@ */ import { Resource, ResourceUri, getUrl, hasLink } from '@ngxp/rest'; import { isEqual, isNil, isNull } from 'lodash-es'; -import { BehaviorSubject, Observable, combineLatest, filter, first, map, startWith, tap } from 'rxjs'; +import { BehaviorSubject, Observable, combineLatest, debounceTime, filter, first, map, startWith, tap } from 'rxjs'; import { isNotNull, isNotUndefined } from '../tech.util'; import { CreateResourceData, ListItemResource, ListResourceServiceConfig } from './resource.model'; import { ResourceRepository } from './resource.repository'; @@ -63,6 +63,7 @@ export class ResourceListService<B extends Resource, T extends ListResource, I e public getList(): Observable<StateResource<T>> { return combineLatest([this.listResource.asObservable(), this.getConfigResource()]).pipe( + debounceTime(50), tap(([stateResource, configResource]) => { this.handleChanges(stateResource, configResource); }), diff --git a/alfa-client/libs/tech-shared/src/lib/resource/resource.repository.spec.ts b/alfa-client/libs/tech-shared/src/lib/resource/resource.repository.spec.ts index bbd264a3587623c8af04f1f293fb0c5e3c6a639c..cade44ce12d85185a6b00d1804d6bc22ba4f27e3 100644 --- a/alfa-client/libs/tech-shared/src/lib/resource/resource.repository.spec.ts +++ b/alfa-client/libs/tech-shared/src/lib/resource/resource.repository.spec.ts @@ -22,6 +22,7 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { mock, useFromMock } from '@alfa-client/test-utils'; +import { TestBed } from '@angular/core/testing'; import { faker } from '@faker-js/faker'; import { Resource, ResourceFactory, ResourceUri, getUrl } from '@ngxp/rest'; import { DummyLinkRel, DummyListLinkRel } from 'libs/tech-shared/test/dummy'; @@ -42,7 +43,11 @@ describe('ResourceRepository', () => { resourceFactory.from.mockReturnValue(resourceWrapper); resourceFactory.fromId.mockReturnValue(resourceWrapper); - repository = new ResourceRepository(useFromMock(resourceFactory)); + TestBed.configureTestingModule({ + providers: [{ provide: ResourceFactory, useValue: useFromMock(resourceFactory) }], + }); + + repository = TestBed.inject(ResourceRepository); }); it('should be created', () => { diff --git a/alfa-client/libs/tech-shared/src/lib/resource/resource.repository.ts b/alfa-client/libs/tech-shared/src/lib/resource/resource.repository.ts index d8f90a78eb269f096a4f159237d07926ad130881..8a4081f31be113eaf2986e867f294603a9d56a6a 100644 --- a/alfa-client/libs/tech-shared/src/lib/resource/resource.repository.ts +++ b/alfa-client/libs/tech-shared/src/lib/resource/resource.repository.ts @@ -21,17 +21,17 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Injectable } from '@angular/core'; -import { Resource, ResourceFactory, ResourceUri, getUrl } from '@ngxp/rest'; +import { inject, Injectable } from '@angular/core'; +import { getUrl, Resource, ResourceFactory, ResourceUri } from '@ngxp/rest'; import { Observable } from 'rxjs'; import { CreateResourceData, LinkRelationName, SaveResourceData } from './resource.model'; import { ListResource } from './resource.util'; @Injectable({ providedIn: 'root' }) export class ResourceRepository { - static SEARCH_PARAM: string = 'searchBy'; + private resourceFactory = inject(ResourceFactory); - constructor(private resourceFactory: ResourceFactory) {} + static SEARCH_PARAM: string = 'searchBy'; public getListResource(resource: Resource, linkRel: string): Observable<ListResource> { const uriWithoutParameter: string = this.getUrlWithoutParameter(getUrl(resource, linkRel)); diff --git a/alfa-client/libs/tech-shared/src/lib/resource/resource.service.spec.ts b/alfa-client/libs/tech-shared/src/lib/resource/resource.service.spec.ts index 7a045fa7514ae98cf24c58209a709551fb0def98..d7d188b8c526a9d439b934397b54c32e2332227a 100644 --- a/alfa-client/libs/tech-shared/src/lib/resource/resource.service.spec.ts +++ b/alfa-client/libs/tech-shared/src/lib/resource/resource.service.spec.ts @@ -82,16 +82,22 @@ describe('ResourceService', () => { isInvalidResourceCombinationSpy = jest.spyOn(ResourceUtil, 'isInvalidResourceCombination').mockReturnValue(true); }); + it('should have debounce', () => { + service.get().subscribe(); + + expect(service.handleResourceChanges).not.toHaveBeenCalled(); + }); + it('should handle config resource changed', fakeAsync(() => { service.get().subscribe(); - tick(); + tick(50); expect(service.handleResourceChanges).toHaveBeenCalledWith(stateResource, configResource); })); it('should call isInvalidResourceCombinationSpy', fakeAsync(() => { service.get().subscribe(); - tick(); + tick(50); expect(isInvalidResourceCombinationSpy).toHaveBeenCalled(); })); diff --git a/alfa-client/libs/tech-shared/src/lib/resource/resource.service.ts b/alfa-client/libs/tech-shared/src/lib/resource/resource.service.ts index 990005991995cce82ed108fe0c6f7cd64a1ac1c0..1953e85ff4691dec3b95771a73f1bc1c7283efd1 100644 --- a/alfa-client/libs/tech-shared/src/lib/resource/resource.service.ts +++ b/alfa-client/libs/tech-shared/src/lib/resource/resource.service.ts @@ -24,7 +24,20 @@ import { HttpErrorResponse } from '@angular/common/http'; import { getUrl, hasLink, Resource, ResourceUri } from '@ngxp/rest'; import { isEqual, isNull } from 'lodash-es'; -import { BehaviorSubject, catchError, combineLatest, filter, first, map, Observable, of, startWith, tap, throwError } from 'rxjs'; +import { + BehaviorSubject, + catchError, + combineLatest, + debounceTime, + filter, + first, + map, + Observable, + of, + startWith, + tap, + throwError, +} from 'rxjs'; import { isUnprocessableEntity } from '../http.util'; import { HttpError } from '../tech.model'; import { isNotNull } from '../tech.util'; @@ -57,6 +70,7 @@ export abstract class ResourceService<B extends Resource, T extends Resource> { public get(): Observable<StateResource<T>> { return combineLatest([this.stateResource.asObservable(), this.getConfigResource()]).pipe( + debounceTime(50), tap(([stateResource, configResource]) => this.handleResourceChanges(stateResource, configResource)), filter(([stateResource]) => !isInvalidResourceCombination(stateResource, this.configResource)), mapToFirst<T, B>(), diff --git a/alfa-client/libs/tech-shared/src/lib/resource/resource.util.spec.ts b/alfa-client/libs/tech-shared/src/lib/resource/resource.util.spec.ts index 31e75c124c2b59266b3e8a5ff7d239ac087a92b6..5e5a9f2b37a30aeda80c61e09986d021e556cd41 100644 --- a/alfa-client/libs/tech-shared/src/lib/resource/resource.util.spec.ts +++ b/alfa-client/libs/tech-shared/src/lib/resource/resource.util.spec.ts @@ -22,7 +22,7 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Resource } from '@ngxp/rest'; -import { createCommandStateResource } from '../../../../command-shared/test/command'; +import { createCommandStateResource } from 'libs/command-shared/test/command'; import { DummyListLinkRel } from '../../../test/dummy'; import { createApiError } from '../../../test/error'; import { createDummyListResource, createDummyResource, toResource } from '../../../test/resource'; diff --git a/alfa-client/libs/tech-shared/src/lib/service/formservice.abstract.spec.ts b/alfa-client/libs/tech-shared/src/lib/service/formservice.abstract.spec.ts index 47119c7a1b2aba5e369af100593d58569dee002a..05e53e161df3758106375d53082cbf77dcd697e2 100644 --- a/alfa-client/libs/tech-shared/src/lib/service/formservice.abstract.spec.ts +++ b/alfa-client/libs/tech-shared/src/lib/service/formservice.abstract.spec.ts @@ -25,9 +25,9 @@ import { CommandResource } from '@alfa-client/command-shared'; import { UntypedFormBuilder, UntypedFormControl, UntypedFormGroup } from '@angular/forms'; import { Resource } from '@ngxp/rest'; import { cold } from 'jest-marbles'; +import { createCommandResource } from 'libs/command-shared/test/command'; import { createInvalidParam, createProblemDetail } from 'libs/tech-shared/test/error'; import { Observable, of } from 'rxjs'; -import { createCommandResource } from '../../../../command-shared/test/command'; import { StateResource, createEmptyStateResource, diff --git a/alfa-client/libs/tech-shared/src/lib/tech-shared.module.spec.ts b/alfa-client/libs/tech-shared/src/lib/tech-shared.module.spec.ts deleted file mode 100644 index 740aaee232ce8c6bcebc45bf4b5f585cd504e530..0000000000000000000000000000000000000000 --- a/alfa-client/libs/tech-shared/src/lib/tech-shared.module.spec.ts +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - * Ministerpräsidenten des Landes Schleswig-Holstein - * Staatskanzlei - * Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - * - * Lizenziert unter der EUPL, Version 1.2 oder - sobald - * diese von der Europäischen Kommission genehmigt wurden - - * Folgeversionen der EUPL ("Lizenz"); - * Sie dürfen dieses Werk ausschließlich gemäß - * dieser Lizenz nutzen. - * Eine Kopie der Lizenz finden Sie hier: - * - * https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - * - * Sofern nicht durch anwendbare Rechtsvorschriften - * gefordert oder in schriftlicher Form vereinbart, wird - * die unter der Lizenz verbreitete Software "so wie sie - * ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - * ausdrücklich oder stillschweigend - verbreitet. - * Die sprachspezifischen Genehmigungen und Beschränkungen - * unter der Lizenz sind dem Lizenztext zu entnehmen. - */ -import { TechSharedModule } from './tech-shared.module'; -import { TestBed } from '@angular/core/testing'; - -describe('TechSharedModule', () => { - beforeEach(() => { - TestBed.configureTestingModule({ - imports: [TechSharedModule], - }).compileComponents(); - }); - - it('should create', () => { - expect(TechSharedModule).toBeDefined(); - }); -}); diff --git a/alfa-client/libs/tech-shared/src/lib/tech-shared.module.ts b/alfa-client/libs/tech-shared/src/lib/tech-shared.module.ts deleted file mode 100644 index be795a66c9f36138e235125f6bd2995ce64da5da..0000000000000000000000000000000000000000 --- a/alfa-client/libs/tech-shared/src/lib/tech-shared.module.ts +++ /dev/null @@ -1,121 +0,0 @@ -/* - * Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - * Ministerpräsidenten des Landes Schleswig-Holstein - * Staatskanzlei - * Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - * - * Lizenziert unter der EUPL, Version 1.2 oder - sobald - * diese von der Europäischen Kommission genehmigt wurden - - * Folgeversionen der EUPL ("Lizenz"); - * Sie dürfen dieses Werk ausschließlich gemäß - * dieser Lizenz nutzen. - * Eine Kopie der Lizenz finden Sie hier: - * - * https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - * - * Sofern nicht durch anwendbare Rechtsvorschriften - * gefordert oder in schriftlicher Form vereinbart, wird - * die unter der Lizenz verbreitete Software "so wie sie - * ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - * ausdrücklich oder stillschweigend - verbreitet. - * Die sprachspezifischen Genehmigungen und Beschränkungen - * unter der Lizenz sind dem Lizenztext zu entnehmen. - */ -import { CommonModule } from '@angular/common'; -import { HTTP_INTERCEPTORS } from '@angular/common/http'; -import { Injector, NgModule } from '@angular/core'; -import { HttpBinaryFileInterceptor } from './interceptor/http-binary-file.interceptor'; -import { HttpXsrfInterceptor } from './interceptor/http-xsrf.interceptor'; -import { XhrInterceptor } from './interceptor/xhr.interceptor'; -import { ConvertApiErrorToErrorMessagesPipe } from './pipe/convert-api-error-to-error-messages.pipe'; -import { ConvertForDataTestPipe } from './pipe/convert-for-data-test.pipe'; -import { ConvertProblemDetailToErrorMessagesPipe } from './pipe/convert-problem-detail-to-error-messages.pipe'; -import { ConvertToBooleanPipe } from './pipe/convert-to-boolean.pipe'; -import { EnumToLabelPipe } from './pipe/enum-to-label.pipe'; -import { FileSizePlainPipe } from './pipe/file-size-plain.pipe'; -import { FileSizePipe } from './pipe/file-size.pipe'; -import { FormatDateWithTimePipe } from './pipe/format-date-with-time.pipe'; -import { FormatDateWithoutYearWithTimePipe } from './pipe/format-date-without-year-with-time.pipe'; -import { FormatFullDatePipe } from './pipe/format-full-date.pipe'; -import { FormatToPrettyDatePipe } from './pipe/format-to-pretty-date.pipe'; -import { GetUrlPipe } from './pipe/get-url.pipe'; -import { HasAnyLinkPipe } from './pipe/has-any-link.pipe'; -import { HasLinkPipe } from './pipe/has-link.pipe'; -import { NotHasAnyLinkPipe } from './pipe/not-has-any-link.pipe'; -import { NotHasLinkPipe } from './pipe/not-has-link.pipe'; -import { ToEmbeddedResourcesPipe } from './pipe/to-embedded-resource.pipe'; -import { ToResourceUriPipe } from './pipe/to-resource-uri.pipe'; -import { ToTrafficLightTooltipPipe } from './pipe/to-traffic-light-tooltip.pipe'; -import { ToTrafficLightPipe } from './pipe/to-traffic-light.pipe'; - -@NgModule({ - imports: [CommonModule], - declarations: [ - FormatToPrettyDatePipe, - FormatFullDatePipe, - EnumToLabelPipe, - FormatDateWithTimePipe, - FormatDateWithoutYearWithTimePipe, - HasLinkPipe, - HasAnyLinkPipe, - NotHasLinkPipe, - NotHasAnyLinkPipe, - ToResourceUriPipe, - ToTrafficLightPipe, - ToTrafficLightTooltipPipe, - ToEmbeddedResourcesPipe, - ConvertForDataTestPipe, - FileSizePipe, - FileSizePlainPipe, - GetUrlPipe, - ConvertToBooleanPipe, - ConvertApiErrorToErrorMessagesPipe, - ConvertProblemDetailToErrorMessagesPipe, - ], - exports: [ - FormatToPrettyDatePipe, - FormatFullDatePipe, - EnumToLabelPipe, - FormatDateWithTimePipe, - FormatDateWithoutYearWithTimePipe, - HasLinkPipe, - HasAnyLinkPipe, - NotHasLinkPipe, - NotHasAnyLinkPipe, - ToResourceUriPipe, - ToTrafficLightPipe, - ToTrafficLightTooltipPipe, - ToEmbeddedResourcesPipe, - ConvertForDataTestPipe, - FileSizePipe, - FileSizePlainPipe, - GetUrlPipe, - ConvertToBooleanPipe, - ConvertApiErrorToErrorMessagesPipe, - ConvertProblemDetailToErrorMessagesPipe, - ], - providers: [ - { - provide: HTTP_INTERCEPTORS, - useClass: XhrInterceptor, - multi: true, - }, - { - provide: HTTP_INTERCEPTORS, - useClass: HttpXsrfInterceptor, - multi: true, - }, - { - provide: HTTP_INTERCEPTORS, - useClass: HttpBinaryFileInterceptor, - multi: true, - }, - ], -}) -export class TechSharedModule { - public static injector: Injector; - - constructor(private injector: Injector) { - TechSharedModule.injector = this.injector; - } -} diff --git a/alfa-client/libs/ui/src/index.ts b/alfa-client/libs/ui/src/index.ts index 8571055878c35b394402ba51f45953717cc14090..2db371a18e23b0b2d01eb93bcf1738bd8ef43f61 100644 --- a/alfa-client/libs/ui/src/index.ts +++ b/alfa-client/libs/ui/src/index.ts @@ -35,7 +35,7 @@ export * from './lib/ui/editor/autocomplete-editor/autocomplete-editor.component export * from './lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component'; export * from './lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.model'; export * from './lib/ui/editor/date-editor/date-editor.component'; -export * from './lib/ui/editor/text-editor/text-editor.component'; +export * from './lib/ui/editor/text-editor/ozgcloud-text-editor.component'; export * from './lib/ui/editor/textarea-editor/textarea-editor.component'; export * from './lib/ui/expansion-panel/expansion-panel.component'; export * from './lib/ui/file-upload/file-upload.component'; @@ -50,10 +50,11 @@ export * from './lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozg export * from './lib/ui/ozgcloud-dialog/ozgcloud-dialog.result'; export * from './lib/ui/ozgcloud-dialog/ozgcloud-dialog.service'; export * from './lib/ui/ozgcloud-icon/ozgcloud-icon.component'; +export * from './lib/ui/ozgcloud-menu/ozgcloud-menu.component'; export * from './lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component'; export * from './lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component'; export * from './lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component'; +export * from './lib/ui/slide-toggle/slide-toggle.component'; export * from './lib/ui/spinner-transparency/spinner-transparency.component'; export * from './lib/ui/spinner/spinner.component'; export * from './lib/ui/subnavigation/subnavigation.component'; -export * from './lib/ui/ui.module'; diff --git a/alfa-client/libs/ui/src/lib/icon/app-icon/app-icon.component.spec.ts b/alfa-client/libs/ui/src/lib/icon/app-icon/app-icon.component.spec.ts index b39b315dbd6786a3a84db361281b369d5936319f..c773235e923ae95da36cb21391770c50c7abff31 100644 --- a/alfa-client/libs/ui/src/lib/icon/app-icon/app-icon.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/icon/app-icon/app-icon.component.spec.ts @@ -32,8 +32,7 @@ describe('AppIconComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [AppIconComponent], - imports: [MatIcon, MatIconTestingModule], + imports: [MatIcon, MatIconTestingModule, AppIconComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/icon/app-icon/app-icon.component.ts b/alfa-client/libs/ui/src/lib/icon/app-icon/app-icon.component.ts index 0b93d2c2448eebae700b8a64cefa5972962c63d2..a09417be79e311588262813e850535ef718acc62 100644 --- a/alfa-client/libs/ui/src/lib/icon/app-icon/app-icon.component.ts +++ b/alfa-client/libs/ui/src/lib/icon/app-icon/app-icon.component.ts @@ -22,10 +22,13 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component } from '@angular/core'; +import { MatIcon } from '@angular/material/icon'; @Component({ selector: 'ozgcloud-app-icon', templateUrl: './app-icon.component.html', styleUrls: ['./app-icon.component.scss'], + standalone: true, + imports: [MatIcon], }) export class AppIconComponent {} diff --git a/alfa-client/libs/ui/src/lib/icon/postfach-icon/postfach-icon.component.spec.ts b/alfa-client/libs/ui/src/lib/icon/postfach-icon/postfach-icon.component.spec.ts index 7d0696427c9216a9e49c27678c1f5f4a4705fc39..a5ce3c8c702872b119526e7d95378a83519890a4 100644 --- a/alfa-client/libs/ui/src/lib/icon/postfach-icon/postfach-icon.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/icon/postfach-icon/postfach-icon.component.spec.ts @@ -37,8 +37,7 @@ describe('PostfachIconComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [PostfachIconComponent], - imports: [MatIconTestingModule, MatBadgeModule, MatBadge, MatIcon], + imports: [MatIconTestingModule, MatBadgeModule, MatBadge, MatIcon, PostfachIconComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/icon/postfach-icon/postfach-icon.component.ts b/alfa-client/libs/ui/src/lib/icon/postfach-icon/postfach-icon.component.ts index 3ad4d01502824949af23604158bf16a87a285663..684c8781ea0697ab90cba9389672c905ca6eac66 100644 --- a/alfa-client/libs/ui/src/lib/icon/postfach-icon/postfach-icon.component.ts +++ b/alfa-client/libs/ui/src/lib/icon/postfach-icon/postfach-icon.component.ts @@ -22,11 +22,15 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatBadge } from '@angular/material/badge'; +import { MatIcon } from '@angular/material/icon'; @Component({ selector: 'ozgcloud-postfach-icon', templateUrl: './postfach-icon.component.html', styleUrls: ['./postfach-icon.component.scss'], + standalone: true, + imports: [MatIcon, MatBadge], }) export class PostfachIconComponent { @Input() showBadge: boolean = false; diff --git a/alfa-client/libs/ui/src/lib/snackbar/snackbar-close-button/snackbar-close-button.component.spec.ts b/alfa-client/libs/ui/src/lib/snackbar/snackbar-close-button/snackbar-close-button.component.spec.ts index a591c897b1738a689568c6a03ced8812f7dcf382..51f5f1b134195d3ac4b0805afe63784571e084ae 100644 --- a/alfa-client/libs/ui/src/lib/snackbar/snackbar-close-button/snackbar-close-button.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/snackbar/snackbar-close-button/snackbar-close-button.component.spec.ts @@ -36,8 +36,7 @@ describe('SnackbarCloseButtonComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [SnackbarCloseButtonComponent], - imports: [MatIcon], + imports: [MatIcon, SnackbarCloseButtonComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/snackbar/snackbar-close-button/snackbar-close-button.component.ts b/alfa-client/libs/ui/src/lib/snackbar/snackbar-close-button/snackbar-close-button.component.ts index 53d5bc40186fedcf833b1c0fff3d36043b9e94a5..6a4ea9b58c108f02f1d77900517f673d8d6abc85 100644 --- a/alfa-client/libs/ui/src/lib/snackbar/snackbar-close-button/snackbar-close-button.component.ts +++ b/alfa-client/libs/ui/src/lib/snackbar/snackbar-close-button/snackbar-close-button.component.ts @@ -22,11 +22,15 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, EventEmitter, Output } from '@angular/core'; +import { MatIconButton } from '@angular/material/button'; +import { MatIcon } from '@angular/material/icon'; @Component({ selector: 'ozgcloud-snackbar-close-button', templateUrl: './snackbar-close-button.component.html', styleUrls: ['./snackbar-close-button.component.scss'], + standalone: true, + imports: [MatIconButton, MatIcon], }) export class SnackbarCloseButtonComponent { @Output() close: EventEmitter<void> = new EventEmitter(); diff --git a/alfa-client/libs/ui/src/lib/snackbar/snackbar-error/snackbar-error.component.spec.ts b/alfa-client/libs/ui/src/lib/snackbar/snackbar-error/snackbar-error.component.spec.ts index 1421a91855149895f44da33bfd0ca59bde2562b3..c18e96c89e4b583be68444c10eb324c6a6def687 100644 --- a/alfa-client/libs/ui/src/lib/snackbar/snackbar-error/snackbar-error.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/snackbar/snackbar-error/snackbar-error.component.spec.ts @@ -21,10 +21,10 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { mock } from '@alfa-client/test-utils'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MatIconModule } from '@angular/material/icon'; import { MAT_SNACK_BAR_DATA, MatSnackBarRef } from '@angular/material/snack-bar'; -import { mock } from '@alfa-client/test-utils'; import { MockComponent } from 'ng-mocks'; import { SnackbarCloseButtonComponent } from '../snackbar-close-button/snackbar-close-button.component'; import { SnackBarData } from '../snackbar.model'; @@ -39,8 +39,7 @@ describe('SnackbarErrorComponent', () => { beforeEach(async () => { TestBed.configureTestingModule({ - imports: [MatIconModule], - declarations: [SnackbarErrorComponent, MockComponent(SnackbarCloseButtonComponent)], + imports: [MatIconModule, SnackbarErrorComponent, MockComponent(SnackbarCloseButtonComponent)], providers: [ { provide: MAT_SNACK_BAR_DATA, diff --git a/alfa-client/libs/ui/src/lib/snackbar/snackbar-error/snackbar-error.component.ts b/alfa-client/libs/ui/src/lib/snackbar/snackbar-error/snackbar-error.component.ts index 19a27fa8e545a2a41163231130c27e314c36546e..06b3709ca34f4d498af78de05fd014f6051fa089 100644 --- a/alfa-client/libs/ui/src/lib/snackbar/snackbar-error/snackbar-error.component.ts +++ b/alfa-client/libs/ui/src/lib/snackbar/snackbar-error/snackbar-error.component.ts @@ -21,20 +21,21 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, Inject } from '@angular/core'; +import { Component, inject } from '@angular/core'; import { MAT_SNACK_BAR_DATA, MatSnackBarRef } from '@angular/material/snack-bar'; +import { SnackbarCloseButtonComponent } from '../snackbar-close-button/snackbar-close-button.component'; import { SnackBarData } from '../snackbar.model'; @Component({ selector: 'ozgcloud-snackbar-error', templateUrl: './snackbar-error.component.html', styleUrls: ['./snackbar-error.component.scss'], + standalone: true, + imports: [SnackbarCloseButtonComponent], }) export class SnackbarErrorComponent { - constructor( - @Inject(MAT_SNACK_BAR_DATA) public data: SnackBarData, - public snackBarRef: MatSnackBarRef<SnackbarErrorComponent>, - ) {} + public snackBarRef = inject(MatSnackBarRef<SnackbarErrorComponent>); + public data = inject<SnackBarData>(MAT_SNACK_BAR_DATA); get message(): string { return this.data.message; diff --git a/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.html b/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.html index 82103c833a2a75df2b91c919f2525931faffcd0e..fbf8300ce5d82495204a97a46483af9dcfe385c6 100644 --- a/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.html +++ b/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.html @@ -25,14 +25,8 @@ --> <div data-test-id="snackbar-message">{{ message }}</div> -<button - *ngIf="showRevokeButton()" - data-test-id="snackbar-revoke-button" - mat-button - color="primary" - (click)="revoke()" -> - Rückgängig -</button> +@if (showRevokeButton()) { + <button data-test-id="snackbar-revoke-button" mat-button color="primary" (click)="revoke()">Rückgängig</button> +} <ozgcloud-snackbar-close-button (close)="close()"></ozgcloud-snackbar-close-button> diff --git a/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.spec.ts b/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.spec.ts index 55ce0007b68eb332719107661899b82c67c8cd59..62d87fd9bfd6983d7f217c6484a9ae937f237fc2 100644 --- a/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.spec.ts @@ -21,10 +21,10 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { mock } from '@alfa-client/test-utils'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MatIconModule } from '@angular/material/icon'; import { MAT_SNACK_BAR_DATA, MatSnackBarModule, MatSnackBarRef } from '@angular/material/snack-bar'; -import { mock } from '@alfa-client/test-utils'; import { CommandLinkRel } from 'libs/command-shared/src/lib/command.linkrel'; import { createCommandResource } from 'libs/command-shared/test/command'; import { getDataTestIdOf } from 'libs/tech-shared/test/data-test'; @@ -47,8 +47,7 @@ describe('SnackbarInfoComponent', () => { beforeEach(async () => { TestBed.configureTestingModule({ - imports: [MatSnackBarModule, MatIconModule], - declarations: [SnackbarInfoComponent, MockComponent(SnackbarCloseButtonComponent)], + imports: [MatSnackBarModule, MatIconModule, SnackbarInfoComponent, MockComponent(SnackbarCloseButtonComponent)], providers: [ { provide: MAT_SNACK_BAR_DATA, diff --git a/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.ts b/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.ts index e1431695e2ff15b6959bf0e7d6a30623f9cb6248..cad0471768531cac51e1227280b62d528f967309 100644 --- a/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.ts +++ b/alfa-client/libs/ui/src/lib/snackbar/snackbar-info/snackbar-info.component.ts @@ -21,22 +21,24 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, Inject } from '@angular/core'; -import { MAT_SNACK_BAR_DATA, MatSnackBarRef } from '@angular/material/snack-bar'; import { isRevokeable } from '@alfa-client/command-shared'; +import { Component, inject } from '@angular/core'; +import { MatButton } from '@angular/material/button'; +import { MAT_SNACK_BAR_DATA, MatSnackBarRef } from '@angular/material/snack-bar'; import { isUndefined } from 'lodash-es'; +import { SnackbarCloseButtonComponent } from '../snackbar-close-button/snackbar-close-button.component'; import { SnackBarData } from '../snackbar.model'; @Component({ selector: 'ozgcloud-snackbar-info', templateUrl: './snackbar-info.component.html', styleUrls: ['./snackbar-info.component.scss'], + standalone: true, + imports: [MatButton, SnackbarCloseButtonComponent], }) export class SnackbarInfoComponent { - constructor( - @Inject(MAT_SNACK_BAR_DATA) public data: SnackBarData, - public snackBarRef: MatSnackBarRef<SnackbarInfoComponent>, - ) {} + public snackBarRef = inject(MatSnackBarRef<SnackbarInfoComponent>); + public data = inject<SnackBarData>(MAT_SNACK_BAR_DATA); get message(): string { return this.data.message; diff --git a/alfa-client/libs/ui/src/lib/snackbar/snackbar.service.ts b/alfa-client/libs/ui/src/lib/snackbar/snackbar.service.ts index 98b7170fe7e634e14ac0528a86f8f1467fedaabf..6e0ecf60e609bb66d8fe6fbbf2d823fcd2208266 100644 --- a/alfa-client/libs/ui/src/lib/snackbar/snackbar.service.ts +++ b/alfa-client/libs/ui/src/lib/snackbar/snackbar.service.ts @@ -21,11 +21,11 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { ComponentType } from '@angular/cdk/overlay'; -import { Injectable } from '@angular/core'; -import { MatSnackBar, MatSnackBarConfig, MatSnackBarRef } from '@angular/material/snack-bar'; import { CommandResource, CommandStatus } from '@alfa-client/command-shared'; import { isNotUndefined } from '@alfa-client/tech-shared'; +import { ComponentType } from '@angular/cdk/overlay'; +import { inject, Injectable } from '@angular/core'; +import { MatSnackBar, MatSnackBarConfig, MatSnackBarRef } from '@angular/material/snack-bar'; import { isUndefined } from 'lodash-es'; import { Subscription } from 'rxjs'; import { SnackbarErrorComponent } from './snackbar-error/snackbar-error.component'; @@ -33,14 +33,14 @@ import { SnackbarInfoComponent } from './snackbar-info/snackbar-info.component'; @Injectable({ providedIn: 'root' }) export class SnackBarService { + private snackBar = inject(MatSnackBar); + private subscription: Subscription; snackBarRef: MatSnackBarRef<SnackbarInfoComponent | SnackbarErrorComponent>; private durationTime: number = 10000; - constructor(private snackBar: MatSnackBar) {} - public show(commandResource: CommandResource, message: string, revokeAction?: () => void): void { if (commandResource.status === CommandStatus.ERROR) { this.showError(message); diff --git a/alfa-client/libs/ui/src/lib/ui/accordion/accordion.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/accordion/accordion.component.spec.ts index 8c9259c77a6edab755a16d357e8ac422b5154e5e..7a5b60d6c39ba17230d0bab3aa5088c9c5d54e62 100644 --- a/alfa-client/libs/ui/src/lib/ui/accordion/accordion.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/accordion/accordion.component.spec.ts @@ -31,8 +31,7 @@ describe('AccordionComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [AccordionComponent], - imports: [MatAccordion], + imports: [MatAccordion, AccordionComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/ui/accordion/accordion.component.ts b/alfa-client/libs/ui/src/lib/ui/accordion/accordion.component.ts index 36001957eb55aef18fb3bb4013e4f3eac6973149..2327c0401e3f59cef0999f8b5e263bdb5148fe69 100644 --- a/alfa-client/libs/ui/src/lib/ui/accordion/accordion.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/accordion/accordion.component.ts @@ -22,11 +22,14 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatAccordion } from '@angular/material/expansion'; @Component({ selector: 'ozgcloud-accordion', templateUrl: './accordion.component.html', styleUrls: ['./accordion.component.scss'], + standalone: true, + imports: [MatAccordion], }) export class AccordionComponent { @Input() multi: boolean = false; diff --git a/alfa-client/libs/ui/src/lib/ui/back-button/back-button.component.ts b/alfa-client/libs/ui/src/lib/ui/back-button/back-button.component.ts index 14ad27f618eb07409005dabcb61ce581a6462134..a5c00893b3fa0fe9c3745afa4a750f395f06df70 100644 --- a/alfa-client/libs/ui/src/lib/ui/back-button/back-button.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/back-button/back-button.component.ts @@ -22,11 +22,18 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatIconAnchor } from '@angular/material/button'; +import { MatIcon } from '@angular/material/icon'; +import { MatTooltip } from '@angular/material/tooltip'; +import { RouterLink } from '@angular/router'; +import { ArrowBackIconComponent, ButtonComponent, TooltipDirective } from '@ods/system'; @Component({ selector: 'ozgcloud-back-button', templateUrl: './back-button.component.html', styleUrls: ['./back-button.component.scss'], + standalone: true, + imports: [MatIconAnchor, RouterLink, MatTooltip, MatIcon, TooltipDirective, ButtonComponent, ArrowBackIconComponent], }) export class BackButtonComponent { @Input() label: string; diff --git a/alfa-client/libs/ui/src/lib/ui/basic-dialog/basic-dialog.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/basic-dialog/basic-dialog.component.spec.ts index ec797a1c52d453daa90d440babf58f3f188a02a5..23ca3dbbc8807eff625e692c251d00cf53b93fdc 100644 --- a/alfa-client/libs/ui/src/lib/ui/basic-dialog/basic-dialog.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/basic-dialog/basic-dialog.component.spec.ts @@ -21,13 +21,10 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { IconButtonWithSpinnerComponent, OzgcloudStrokedButtonWithSpinnerComponent } from '@alfa-client/ui'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MAT_DIALOG_DATA, MatDialogModule, MatDialogRef } from '@angular/material/dialog'; import { MatIcon } from '@angular/material/icon'; -import { - IconButtonWithSpinnerComponent, - OzgcloudStrokedButtonWithSpinnerComponent, -} from '@alfa-client/ui'; import { MockComponent } from 'ng-mocks'; import { BasicDialogComponent } from './basic-dialog.component'; @@ -37,8 +34,8 @@ describe('BasicDialogComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [MatDialogModule], - declarations: [ + imports: [ + MatDialogModule, BasicDialogComponent, MatIcon, MockComponent(OzgcloudStrokedButtonWithSpinnerComponent), diff --git a/alfa-client/libs/ui/src/lib/ui/basic-dialog/basic-dialog.component.ts b/alfa-client/libs/ui/src/lib/ui/basic-dialog/basic-dialog.component.ts index e9519e80425254082dbb78cb7c75baf6e23ebe2b..cbe53ff122890939ac29bdda8e991855e3a78a53 100644 --- a/alfa-client/libs/ui/src/lib/ui/basic-dialog/basic-dialog.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/basic-dialog/basic-dialog.component.ts @@ -21,20 +21,36 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, Inject } from '@angular/core'; -import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog'; +import { CdkScrollable } from '@angular/cdk/scrolling'; +import { Component, inject } from '@angular/core'; +import { + MAT_DIALOG_DATA, + MatDialogActions, + MatDialogClose, + MatDialogContent, + MatDialogRef, + MatDialogTitle, +} from '@angular/material/dialog'; +import { OzgcloudStrokedButtonWithSpinnerComponent } from '../ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component'; import { BasicDialogData } from './basic-dialog-data.model'; @Component({ selector: 'ozgcloud-basic-dialog', templateUrl: './basic-dialog.component.html', styleUrls: ['./basic-dialog.component.scss'], + standalone: true, + imports: [ + MatDialogTitle, + CdkScrollable, + MatDialogContent, + MatDialogActions, + OzgcloudStrokedButtonWithSpinnerComponent, + MatDialogClose, + ], }) export class BasicDialogComponent { - constructor( - public dialogRef: MatDialogRef<BasicDialogComponent>, - @Inject(MAT_DIALOG_DATA) public data: BasicDialogData, - ) {} + public dialogRef = inject(MatDialogRef<BasicDialogComponent>); + public data = inject<BasicDialogData>(MAT_DIALOG_DATA); onNoClick(): void { this.dialogRef.close(); diff --git a/alfa-client/libs/ui/src/lib/ui/dialog/dialog.service.ts b/alfa-client/libs/ui/src/lib/ui/dialog/dialog.service.ts index dfe376a9f5fb12120a0be495df47fb865610f175..cd72feef7dac8d6194e6fb83ab08e9b76e38ffa7 100644 --- a/alfa-client/libs/ui/src/lib/ui/dialog/dialog.service.ts +++ b/alfa-client/libs/ui/src/lib/ui/dialog/dialog.service.ts @@ -21,22 +21,19 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { ApiError, isNotUndefined } from '@alfa-client/tech-shared'; +import { BasicDialogComponent, BasicDialogData, FixedDialogComponent, FixedDialogData } from '@alfa-client/ui'; import { NoopScrollStrategy } from '@angular/cdk/overlay'; import { ComponentType } from '@angular/cdk/portal'; -import { Injectable } from '@angular/core'; +import { inject, Injectable } from '@angular/core'; import { MatDialog, MatDialogConfig, MatDialogRef } from '@angular/material/dialog'; -import { ApiError, isNotUndefined } from '@alfa-client/tech-shared'; -import { - BasicDialogComponent, - BasicDialogData, - FixedDialogComponent, - FixedDialogData, -} from '@alfa-client/ui'; import { InternalServerErrorDialogComponent } from '../notification/internal-server-error-dialog/internal-server-error-dialog.component'; import { RetryInTimeDialog } from './retry-in-time.dialog'; @Injectable({ providedIn: 'root' }) export class DialogService { + private dialog = inject(MatDialog); + fixedSingleDialogRef: MatDialogRef<FixedDialogComponent>; readonly FIXED_DIALOG_CONFIG: MatDialogConfig = { @@ -67,8 +64,6 @@ export class DialogService { restoreFocus: false, }; - constructor(private dialog: MatDialog) {} - public openWidely<T>(component: ComponentType<T>, config?: MatDialogConfig): MatDialogRef<T> { return this.open<T>(component, { ...config, ...this.WIDE_DIALOG_CONFIG }); } diff --git a/alfa-client/libs/ui/src/lib/ui/download-button/download-button.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/download-button/download-button.component.spec.ts index d1215dcb80ea593e83277a49ba20d20e7988f671..2771e503131afefce51f6073b52866178fbc34ad 100644 --- a/alfa-client/libs/ui/src/lib/ui/download-button/download-button.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/download-button/download-button.component.spec.ts @@ -23,8 +23,8 @@ */ import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { DownloadButtonComponent } from './download-button.component'; import { MockComponent } from 'ng-mocks'; +import { DownloadButtonComponent } from './download-button.component'; describe('DownloadButtonComponent', () => { let component: DownloadButtonComponent; @@ -32,7 +32,7 @@ describe('DownloadButtonComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [DownloadButtonComponent, MockComponent(DownloadButtonComponent)], + imports: [DownloadButtonComponent, MockComponent(DownloadButtonComponent)], }).compileComponents(); fixture = TestBed.createComponent(DownloadButtonComponent); diff --git a/alfa-client/libs/ui/src/lib/ui/download-button/download-button.component.ts b/alfa-client/libs/ui/src/lib/ui/download-button/download-button.component.ts index d1b4e7fed82b0d06bc0c814137c2caabe34fc01f..be55bf7f0df760e20fb83d53c81560dd255ff90d 100644 --- a/alfa-client/libs/ui/src/lib/ui/download-button/download-button.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/download-button/download-button.component.ts @@ -22,11 +22,17 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatAnchor } from '@angular/material/button'; +import { MatIcon } from '@angular/material/icon'; +import { MatTooltip } from '@angular/material/tooltip'; +import { TooltipDirective } from '@ods/system'; @Component({ selector: 'ozgcloud-download-button', templateUrl: './download-button.component.html', styleUrls: ['./download-button.component.scss'], + standalone: true, + imports: [MatAnchor, MatTooltip, MatIcon, TooltipDirective], }) export class DownloadButtonComponent { @Input() icon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.html b/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.html index b60743ee96c5c2e579c266efbabb320bad129ddb..43edcd913d44feaaf9af68ae7e94df89215df6b9 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.html +++ b/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.html @@ -1,26 +1,26 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: - - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung + +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: + +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 + +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> <mat-form-field appearance="outline"> @@ -40,15 +40,16 @@ /> <mat-autocomplete autoActiveFirstOption #auto="matAutocomplete"> - <mat-option - *ngFor="let value of values" - [attr.data-test-id]="(value.label | convertForDataTest) + '-autocomplete-option'" - [value]="value.value" - (keyup.enter)="onSelection(value)" - (onSelectionChange)="onSelection(value)" - > - {{ value.label }} - </mat-option> + @for (value of values; track value) { + <mat-option + [attr.data-test-id]="(value.label | convertForDataTest) + '-autocomplete-option'" + [value]="value.value" + (keyup.enter)="onSelection(value)" + (onSelectionChange)="onSelection(value)" + > + {{ value.label }} + </mat-option> + } </mat-autocomplete> <mat-error> diff --git a/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.spec.ts index 609ef74f56da69e125e481e7dc187a00c383069f..c590cbe105096627b2432f84f3052e54058e09d8 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.spec.ts @@ -21,13 +21,13 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { NgControl, ReactiveFormsModule, UntypedFormControl } from '@angular/forms'; import { MatAutocompleteModule } from '@angular/material/autocomplete'; import { MatFormFieldModule } from '@angular/material/form-field'; import { MatInputModule } from '@angular/material/input'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; -import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { MockComponent } from 'ng-mocks'; import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; import { AutocompleteEditorComponent } from './autocomplete-editor.component'; @@ -38,17 +38,15 @@ describe('AutocompleteEditorComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ - AutocompleteEditorComponent, - ConvertForDataTestPipe, - MockComponent(ValidationErrorComponent), - ], imports: [ MatAutocompleteModule, MatFormFieldModule, MatInputModule, ReactiveFormsModule, BrowserAnimationsModule, + AutocompleteEditorComponent, + ConvertForDataTestPipe, + MockComponent(ValidationErrorComponent), ], providers: [ { diff --git a/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.ts b/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.ts index 1cb488f0f7025cd34f7e53a541c9b430aa557082..87aba70b5394eb65499915b9a29feef3154df301 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/autocomplete-editor/autocomplete-editor.component.ts @@ -21,28 +21,38 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { - AfterViewInit, - Component, - ElementRef, - EventEmitter, - Input, - Output, - ViewChild, -} from '@angular/core'; +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; +import { AfterViewInit, Component, ElementRef, EventEmitter, Input, Output, ViewChild } from '@angular/core'; +import { FormsModule, ReactiveFormsModule } from '@angular/forms'; +import { MatAutocomplete, MatAutocompleteTrigger } from '@angular/material/autocomplete'; +import { MatOption } from '@angular/material/core'; +import { MatError, MatFormField, MatLabel } from '@angular/material/form-field'; +import { MatInput } from '@angular/material/input'; import { ResourceUri } from '@ngxp/rest'; import { FormControlEditorAbstractComponent } from 'libs/design-component/src/lib/form/formcontrol-editor.abstract.component'; import { isEmpty, isEqual, isNil } from 'lodash-es'; +import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; @Component({ selector: 'ozgcloud-autocomplete-editor', templateUrl: './autocomplete-editor.component.html', styleUrls: ['./autocomplete-editor.component.scss'], + standalone: true, + imports: [ + MatFormField, + MatLabel, + MatInput, + MatAutocompleteTrigger, + FormsModule, + ReactiveFormsModule, + MatAutocomplete, + MatOption, + MatError, + ValidationErrorComponent, + ConvertForDataTestPipe, + ], }) -export class AutocompleteEditorComponent - extends FormControlEditorAbstractComponent - implements AfterViewInit -{ +export class AutocompleteEditorComponent extends FormControlEditorAbstractComponent implements AfterViewInit { @Input() label: string; @Input() values: Selectable[] = []; @Input() required: boolean = false; @@ -64,9 +74,7 @@ export class AutocompleteEditorComponent onEnter(): void { const selectedValue: ResourceUri = this.fieldControl.value; - isEmpty(selectedValue) ? - this.enterOnNoSelection.emit() - : this.onSelection(this.getUserProfile()); + isEmpty(selectedValue) ? this.enterOnNoSelection.emit() : this.onSelection(this.getUserProfile()); } private getUserProfile(): Selectable { diff --git a/alfa-client/libs/ui/src/lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component.spec.ts index 2a7caecd0e32ea384511381f74daa36eaecc7644..91a6537c22606b24f3358d8de8d5dbec08f7ba9b 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component.spec.ts @@ -21,16 +21,15 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { ReactiveFormsModule } from '@angular/forms'; -import { MatIcon } from '@angular/material/icon'; import { MatFormFieldModule } from '@angular/material/form-field'; +import { MatIcon } from '@angular/material/icon'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; -import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { MockComponent } from 'ng-mocks'; import { IconButtonWithSpinnerComponent } from '../../icon-button-with-spinner/icon-button-with-spinner.component'; import { CheckboxEnumEditorComponent } from './checkbox-enum-editor.component'; -import { UiModule } from '../../ui.module'; describe('CheckboxEnumEditorComponent', () => { let component: CheckboxEnumEditorComponent; @@ -38,13 +37,15 @@ describe('CheckboxEnumEditorComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ + declarations: [ConvertForDataTestPipe], + imports: [ + MatFormFieldModule, + ReactiveFormsModule, + BrowserAnimationsModule, CheckboxEnumEditorComponent, MatIcon, - ConvertForDataTestPipe, MockComponent(IconButtonWithSpinnerComponent), ], - imports: [UiModule, MatFormFieldModule, ReactiveFormsModule, BrowserAnimationsModule], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component.ts b/alfa-client/libs/ui/src/lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component.ts index 26e505719f2ffab18108f1f278bbc984d5e79622..0943452372c17eb48ba64b6c3e97bf9ee4067ae9 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/checkbox-enum-editor/checkbox-enum-editor.component.ts @@ -22,7 +22,7 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input, OnInit } from '@angular/core'; -import { MatCheckboxChange } from '@angular/material/checkbox'; +import { MatCheckbox, MatCheckboxChange } from '@angular/material/checkbox'; import { FormControlEditorAbstractComponent } from 'libs/design-component/src/lib/form/formcontrol-editor.abstract.component'; import { CheckboxEnumEditorItem } from './checkbox-enum-editor.model'; @@ -34,11 +34,10 @@ import { CheckboxEnumEditorItem } from './checkbox-enum-editor.model'; selector: 'ozgcloud-checkbox-enum-editor', templateUrl: './checkbox-enum-editor.component.html', styleUrls: ['./checkbox-enum-editor.component.scss'], + standalone: true, + imports: [MatCheckbox], }) -export class CheckboxEnumEditorComponent - extends FormControlEditorAbstractComponent - implements OnInit -{ +export class CheckboxEnumEditorComponent extends FormControlEditorAbstractComponent implements OnInit { @Input() label: string; @Input() defaultItem: CheckboxEnumEditorItem; @Input() checkedItem: CheckboxEnumEditorItem; diff --git a/alfa-client/libs/ui/src/lib/ui/editor/date-editor/date-editor.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/editor/date-editor/date-editor.component.spec.ts index 2af729384632e5d72440e7a4dd862b921b3aea52..e8fb9e83f6c6a820f348e86b6841ef6bf00532a3 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/date-editor/date-editor.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/date-editor/date-editor.component.spec.ts @@ -43,12 +43,9 @@ describe('DateEditorComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ - DateEditorComponent, - ConvertForDataTestPipe, - MockComponent(ValidationErrorComponent), - ], + declarations: [ConvertForDataTestPipe], imports: [ + ConvertForDataTestPipe, MatFormFieldModule, MatInputModule, MatIconModule, @@ -56,6 +53,8 @@ describe('DateEditorComponent', () => { MatNativeDateModule, ReactiveFormsModule, BrowserAnimationsModule, + DateEditorComponent, + MockComponent(ValidationErrorComponent), ], }).compileComponents(); }); @@ -75,9 +74,7 @@ describe('DateEditorComponent', () => { component.label = 'Ein Label'; fixture.detectChanges(); - const element: HTMLElement = fixture.nativeElement.querySelector( - '[data-test-id="Ein_Label-date-input"]', - ); + const element: HTMLElement = fixture.nativeElement.querySelector('[data-test-id="Ein_Label-date-input"]'); expect(element).toBeInstanceOf(HTMLElement); }); diff --git a/alfa-client/libs/ui/src/lib/ui/editor/date-editor/date-editor.component.ts b/alfa-client/libs/ui/src/lib/ui/editor/date-editor/date-editor.component.ts index c632ccf07fb72d02712a391901d9d0cc8a0d9d9b..b7dd27fb2f94c53cf4f4acfdb6bad040798348da 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/date-editor/date-editor.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/date-editor/date-editor.component.ts @@ -21,16 +21,32 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { add2000Years } from '@alfa-client/tech-shared'; +import { add2000Years, ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { Component, Input } from '@angular/core'; -import { MatDatepickerInputEvent } from '@angular/material/datepicker'; +import { FormsModule, ReactiveFormsModule } from '@angular/forms'; +import { MatDatepickerInputEvent, MatDatepickerModule } from '@angular/material/datepicker'; +import { MatFormFieldModule } from '@angular/material/form-field'; +import { MatIcon } from '@angular/material/icon'; +import { MatInputModule } from '@angular/material/input'; import { isDate } from 'date-fns'; import { FormControlEditorAbstractComponent } from 'libs/design-component/src/lib/form/formcontrol-editor.abstract.component'; +import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; @Component({ selector: 'ozgcloud-date-editor', templateUrl: './date-editor.component.html', styleUrls: ['./date-editor.component.scss'], + standalone: true, + imports: [ + MatFormFieldModule, + MatInputModule, + FormsModule, + ReactiveFormsModule, + MatIcon, + ValidationErrorComponent, + MatDatepickerModule, + ConvertForDataTestPipe, + ], }) export class DateEditorComponent extends FormControlEditorAbstractComponent { @Input() label: string; diff --git a/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.html b/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.html index 123269b8cb6c410f812da2ce9cc447e9c043c7bc..c8501ddaa8dee9c1e93721b8f7408b5652903bde 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.html +++ b/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.html @@ -1,32 +1,32 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: - - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung + +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: + +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 + +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> <ng-container [formArrayName]="parentFormArrayName"> - <ng-container *ngFor="let hiddenInput of fileLinkControls.controls; let i = index"> + @for (hiddenInput of fileLinkControls.controls; track hiddenInput; let i = $index) { <input id="file-link-{{ i }}" type="hidden" [formControlName]="i" /> - </ng-container> + } </ng-container> <input @@ -39,10 +39,11 @@ /> <label [attr.for]="uploadFileId" matRipple [attr.aria-label]="label"> - <mat-icon *ngIf="!uploadInProgress.loading">attach_file</mat-icon> + @if (!uploadInProgress.loading) { + <mat-icon>attach_file</mat-icon> + } - <ozgcloud-spinner [stateResource]="uploadInProgress" [diameter]="22" padding="0"> - </ozgcloud-spinner> + <ozgcloud-spinner [stateResource]="uploadInProgress" [diameter]="22" padding="0"> </ozgcloud-spinner> </label> <mat-error> diff --git a/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.spec.ts index a6c2b5c8d87ad575a680c408b349146e8f21966f..2dc06d2e3d1f7ffc486f6a8f4525427281e4247e 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.spec.ts @@ -21,20 +21,15 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { ConvertForDataTestPipe, createEmptyStateResource } from '@alfa-client/tech-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { - AbstractControl, - FormGroupDirective, - ReactiveFormsModule, - UntypedFormBuilder, -} from '@angular/forms'; +import { AbstractControl, FormGroupDirective, ReactiveFormsModule, UntypedFormBuilder } from '@angular/forms'; import { MatNativeDateModule } from '@angular/material/core'; import { MatDatepickerModule } from '@angular/material/datepicker'; -import { MatIconModule } from '@angular/material/icon'; import { MatFormFieldModule } from '@angular/material/form-field'; +import { MatIconModule } from '@angular/material/icon'; import { MatInputModule } from '@angular/material/input'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; -import { ConvertForDataTestPipe, createEmptyStateResource } from '@alfa-client/tech-shared'; import { MockComponent } from 'ng-mocks'; import { SpinnerComponent } from '../../spinner/spinner.component'; import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; @@ -51,12 +46,6 @@ describe('FileUploadEditorComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ - FileUploadEditorComponent, - ConvertForDataTestPipe, - MockComponent(ValidationErrorComponent), - MockComponent(SpinnerComponent), - ], imports: [ MatFormFieldModule, MatInputModule, @@ -65,6 +54,10 @@ describe('FileUploadEditorComponent', () => { MatNativeDateModule, ReactiveFormsModule, BrowserAnimationsModule, + FileUploadEditorComponent, + ConvertForDataTestPipe, + MockComponent(ValidationErrorComponent), + MockComponent(SpinnerComponent), ], providers: [ FormGroupDirective, @@ -100,9 +93,7 @@ describe('FileUploadEditorComponent', () => { component.label = 'Ein Label'; fixture.detectChanges(); - const element: HTMLElement = fixture.nativeElement.querySelector( - '[data-test-id="Ein_Label-file-upload-input"]', - ); + const element: HTMLElement = fixture.nativeElement.querySelector('[data-test-id="Ein_Label-file-upload-input"]'); expect(element).toBeInstanceOf(HTMLElement); }); diff --git a/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.ts b/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.ts index 148f7d0dd06e17e7b790ff81139f1fbca85ffc52..5c75b22163ad44971eb6bef5821b66b717336d51 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/file-upload-editor/file-upload-editor.component.ts @@ -21,36 +21,44 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { StateResource } from '@alfa-client/tech-shared'; -import { - Component, - ElementRef, - EventEmitter, - HostListener, - Input, - OnInit, - Output, - ViewChild, -} from '@angular/core'; +import { ConvertForDataTestPipe, StateResource } from '@alfa-client/tech-shared'; +import { Component, ElementRef, EventEmitter, HostListener, inject, Input, OnInit, Output, ViewChild } from '@angular/core'; import { ControlContainer, FormGroupDirective, + FormsModule, + ReactiveFormsModule, UntypedFormArray, UntypedFormControl, } from '@angular/forms'; +import { MatRipple } from '@angular/material/core'; +import { MatError } from '@angular/material/form-field'; +import { MatIcon } from '@angular/material/icon'; import { FormControlEditorAbstractComponent } from 'libs/design-component/src/lib/form/formcontrol-editor.abstract.component'; import { uniqueId } from 'lodash-es'; +import { SpinnerComponent } from '../../spinner/spinner.component'; +import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; @Component({ selector: 'ozgcloud-file-upload-editor', templateUrl: './file-upload-editor.component.html', styleUrls: ['./file-upload-editor.component.scss'], viewProviders: [{ provide: ControlContainer, useExisting: FormGroupDirective }], + standalone: true, + imports: [ + FormsModule, + ReactiveFormsModule, + MatRipple, + MatIcon, + SpinnerComponent, + MatError, + ValidationErrorComponent, + ConvertForDataTestPipe, + ], }) -export class FileUploadEditorComponent - extends FormControlEditorAbstractComponent - implements OnInit -{ +export class FileUploadEditorComponent extends FormControlEditorAbstractComponent implements OnInit { + public parentForm = inject(FormGroupDirective); + @Input() label: string = ''; @Input() parentFormArrayName: string; @Input() accept: string = '*/*'; @@ -72,19 +80,13 @@ export class FileUploadEditorComponent this.setErrors(); } - constructor(public parentForm: FormGroupDirective) { - super(null); - } - override ngOnInit(): void { this.fileLinkControls = this.parentForm.form.get(this.parentFormArrayName) as UntypedFormArray; } buildFormArray(fileLinkList: string[]): void { this.fileLinkControls.clear(); - fileLinkList.forEach((link: string) => - this.fileLinkControls.push(new UntypedFormControl(link)), - ); + fileLinkList.forEach((link: string) => this.fileLinkControls.push(new UntypedFormControl(link))); } resetInput(): void { diff --git a/alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.html b/alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.html new file mode 100644 index 0000000000000000000000000000000000000000..8dab6eb918bef8d15c6a555ef6ab253f27942700 --- /dev/null +++ b/alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.html @@ -0,0 +1,66 @@ +<!-- + +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung + +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: + +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 + +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. + +--> +<mat-form-field + [subscriptSizing]="subscriptSizing" + class="compact-input" + appearance="{{ appearance }}" + [floatLabel]="readOnly || autoFocus ? 'always' : 'auto'" +> + <mat-label>{{ label }}</mat-label> + <div class="wrapper"> + <input + #inputElement + matInput + placeholder="{{ placeholder }}" + [formControl]="fieldControl" + [autocomplete]="autocomplete" + [readonly]="readOnly" + (blur)="touch()" + [required]="required" + [attr.data-test-id]="(label | convertForDataTest) + '-text-input'" + [class.with-clear-button]="showClearButton$ | async" + /> + @if (showClearButton$ | async) { + <button + data-test-id="clear-button" + class="clear-button" + type="button" + (click)="onClear()" + mat-icon-button + aria-label="Leeren" + > + <mat-icon>close</mat-icon> + </button> + } + </div> + <mat-error> + <ozgcloud-validation-error + [attr.data-test-id]="(getPlaceholderLabel() | convertForDataTest) + '-text-error'" + [invalidParams]="invalidParams" + [label]="getPlaceholderLabel()" + ></ozgcloud-validation-error> + </mat-error> +</mat-form-field> diff --git a/alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.scss b/alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.scss similarity index 100% rename from alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.scss rename to alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.scss diff --git a/alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.spec.ts similarity index 84% rename from alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.spec.ts rename to alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.spec.ts index e2000c8388d7734d74f703d0748d531580e7454d..52c2e538297a8d30167ad14f5760bf8a79888cd9 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.spec.ts @@ -29,18 +29,26 @@ import { MatInputModule } from '@angular/material/input'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; import { MockComponent } from 'ng-mocks'; import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; -import { TextEditorComponent } from './text-editor.component'; +import { OzgcloudTextEditorComponent } from './ozgcloud-text-editor.component'; -describe('TextEditorComponent', () => { - let component: TextEditorComponent; - let fixture: ComponentFixture<TextEditorComponent>; +describe('OzgcloudTextEditorComponent', () => { + let component: OzgcloudTextEditorComponent; + let fixture: ComponentFixture<OzgcloudTextEditorComponent>; const input: string = '[data-test-id="Ein_Label-text-input"]'; - beforeEach(async () => { - await TestBed.configureTestingModule({ - declarations: [TextEditorComponent, ConvertForDataTestPipe, MockComponent(ValidationErrorComponent)], - imports: [MatFormFieldModule, MatInputModule, ReactiveFormsModule, BrowserAnimationsModule], + beforeEach(() => { + TestBed.configureTestingModule({ + declarations: [ + OzgcloudTextEditorComponent, + MatFormFieldModule, + MatInputModule, + ReactiveFormsModule, + BrowserAnimationsModule, + ConvertForDataTestPipe, + MockComponent(ValidationErrorComponent), + ], + imports: [], providers: [ { provide: NgControl, @@ -51,7 +59,7 @@ describe('TextEditorComponent', () => { }); beforeEach(() => { - fixture = TestBed.createComponent(TextEditorComponent); + fixture = TestBed.createComponent(OzgcloudTextEditorComponent); component = fixture.componentInstance; component.label = 'Ein Label'; fixture.detectChanges(); diff --git a/alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.ts b/alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.ts similarity index 69% rename from alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.ts rename to alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.ts index 5e3227127c9e7b3cc451ad530262da5f36fe1cf5..9e1294a6059d8baa85f7faccdf45401af6a08c6e 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/text-editor/ozgcloud-text-editor.component.ts @@ -21,21 +21,38 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { hasContent } from '@alfa-client/tech-shared'; +import { ConvertForDataTestPipe, hasContent } from '@alfa-client/tech-shared'; +import { AsyncPipe } from '@angular/common'; import { AfterViewInit, Component, ElementRef, Input, OnInit, ViewChild } from '@angular/core'; -import { SubscriptSizing } from '@angular/material/form-field'; +import { FormsModule, ReactiveFormsModule } from '@angular/forms'; +import { MatIconButton } from '@angular/material/button'; +import { MatError, MatFormField, MatLabel, SubscriptSizing } from '@angular/material/form-field'; +import { MatIcon } from '@angular/material/icon'; +import { MatInput } from '@angular/material/input'; import { FormControlEditorAbstractComponent } from 'libs/design-component/src/lib/form/formcontrol-editor.abstract.component'; import { Observable, map, startWith } from 'rxjs'; +import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; @Component({ selector: 'ozgcloud-text-editor', - templateUrl: './text-editor.component.html', - styleUrls: ['./text-editor.component.scss'], + templateUrl: './ozgcloud-text-editor.component.html', + styleUrls: ['./ozgcloud-text-editor.component.scss'], + standalone: true, + imports: [ + MatFormField, + MatLabel, + MatInput, + FormsModule, + ReactiveFormsModule, + MatIconButton, + MatIcon, + MatError, + ValidationErrorComponent, + AsyncPipe, + ConvertForDataTestPipe, + ], }) -export class TextEditorComponent - extends FormControlEditorAbstractComponent - implements OnInit, AfterViewInit -{ +export class OzgcloudTextEditorComponent extends FormControlEditorAbstractComponent implements OnInit, AfterViewInit { @ViewChild('inputElement') inputElement: ElementRef; @Input() label: string; diff --git a/alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.html b/alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.html deleted file mode 100644 index 303e1315d5e643ebce97e74e5f9477b1ca105866..0000000000000000000000000000000000000000 --- a/alfa-client/libs/ui/src/lib/ui/editor/text-editor/text-editor.component.html +++ /dev/null @@ -1,65 +0,0 @@ -<!-- - - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: - - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. - ---> -<mat-form-field - [subscriptSizing]="subscriptSizing" - class="compact-input" - appearance="{{ appearance }}" - [floatLabel]="readOnly || autoFocus ? 'always' : 'auto'" -> - <mat-label>{{ label }}</mat-label> - <div class="wrapper"> - <input - #inputElement - matInput - placeholder="{{ placeholder }}" - [formControl]="fieldControl" - [autocomplete]="autocomplete" - [readonly]="readOnly" - (blur)="touch()" - [required]="required" - [attr.data-test-id]="(label | convertForDataTest) + '-text-input'" - [class.with-clear-button]="showClearButton$ | async" - /> - <button - *ngIf="showClearButton$ | async" - data-test-id="clear-button" - class="clear-button" - type="button" - (click)="onClear()" - mat-icon-button - aria-label="Leeren" - > - <mat-icon>close</mat-icon> - </button> - </div> - <mat-error> - <ozgcloud-validation-error - [attr.data-test-id]="(getPlaceholderLabel() | convertForDataTest) + '-text-error'" - [invalidParams]="invalidParams" - [label]="getPlaceholderLabel()" - ></ozgcloud-validation-error> - </mat-error> -</mat-form-field> diff --git a/alfa-client/libs/ui/src/lib/ui/editor/textarea-editor/textarea-editor.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/editor/textarea-editor/textarea-editor.component.spec.ts index 49217b8c8117ce625d8e2ff8edd9e9ab82dab845..670590d080bda2dfd50caa88d4b5894c729416a6 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/textarea-editor/textarea-editor.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/textarea-editor/textarea-editor.component.spec.ts @@ -21,12 +21,12 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { NgControl, ReactiveFormsModule, UntypedFormControl } from '@angular/forms'; import { MatFormFieldModule } from '@angular/material/form-field'; import { MatInputModule } from '@angular/material/input'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; -import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { MockComponent } from 'ng-mocks'; import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; import { TextAreaEditorComponent } from './textarea-editor.component'; @@ -37,12 +37,15 @@ describe('TextAreaEditorComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ + imports: [ + MatFormFieldModule, + MatInputModule, + ReactiveFormsModule, + BrowserAnimationsModule, TextAreaEditorComponent, ConvertForDataTestPipe, MockComponent(ValidationErrorComponent), ], - imports: [MatFormFieldModule, MatInputModule, ReactiveFormsModule, BrowserAnimationsModule], providers: [ { provide: NgControl, @@ -67,9 +70,7 @@ describe('TextAreaEditorComponent', () => { component.label = 'Ein Label'; fixture.detectChanges(); - const element: HTMLElement = fixture.nativeElement.querySelector( - '[data-test-id="Ein_Label-textarea-input"]', - ); + const element: HTMLElement = fixture.nativeElement.querySelector('[data-test-id="Ein_Label-textarea-input"]'); expect(element).toBeInstanceOf(HTMLElement); }); diff --git a/alfa-client/libs/ui/src/lib/ui/editor/textarea-editor/textarea-editor.component.ts b/alfa-client/libs/ui/src/lib/ui/editor/textarea-editor/textarea-editor.component.ts index 27644f18242584d91fa7adf2008ed2de99e02857..a58f6a04d44fcf30053bc0a931d9920500165897 100644 --- a/alfa-client/libs/ui/src/lib/ui/editor/textarea-editor/textarea-editor.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/editor/textarea-editor/textarea-editor.component.ts @@ -21,19 +21,33 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { ConvertForDataTestPipe } from '@alfa-client/tech-shared'; import { CdkTextareaAutosize } from '@angular/cdk/text-field'; import { AfterViewInit, Component, Input, ViewChild } from '@angular/core'; +import { FormsModule, ReactiveFormsModule } from '@angular/forms'; +import { MatError, MatFormField, MatLabel } from '@angular/material/form-field'; +import { MatInput } from '@angular/material/input'; import { FormControlEditorAbstractComponent } from 'libs/design-component/src/lib/form/formcontrol-editor.abstract.component'; +import { ValidationErrorComponent } from '../../validation-error/validation-error.component'; @Component({ selector: 'ozgcloud-textarea-editor', templateUrl: './textarea-editor.component.html', styleUrls: ['./textarea-editor.component.scss'], + standalone: true, + imports: [ + MatFormField, + MatLabel, + MatInput, + CdkTextareaAutosize, + FormsModule, + ReactiveFormsModule, + MatError, + ValidationErrorComponent, + ConvertForDataTestPipe, + ], }) -export class TextAreaEditorComponent - extends FormControlEditorAbstractComponent - implements AfterViewInit -{ +export class TextAreaEditorComponent extends FormControlEditorAbstractComponent implements AfterViewInit { @ViewChild('autosize') autosize: CdkTextareaAutosize; @Input() placeholder: string; diff --git a/alfa-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.spec.ts index 4f5bc141b8ff9bbb08eaf3969caa702a88c12ec7..f8b285231242f9377479de52bdb11307422cb136 100644 --- a/alfa-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.spec.ts @@ -23,12 +23,7 @@ */ import { PortalModule } from '@angular/cdk/portal'; import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { - MatAccordion, - MatExpansionPanel, - MatExpansionPanelHeader, - MatExpansionPanelTitle, -} from '@angular/material/expansion'; +import { MatAccordion, MatExpansionPanel, MatExpansionPanelHeader, MatExpansionPanelTitle } from '@angular/material/expansion'; import { MatIcon } from '@angular/material/icon'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; import { ExpansionPanelComponent } from './expansion-panel.component'; @@ -47,8 +42,8 @@ describe('VorgangDetailExpansionPanelComponent', () => { MatAccordion, MatIcon, MatExpansionPanelHeader, + ExpansionPanelComponent, ], - declarations: [ExpansionPanelComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.ts b/alfa-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.ts index 451efa23326b6f5d0cfbed82263a40282170c1fa..c1056c852eeb7440011bf8d9c3aa0ccf03f3764a 100644 --- a/alfa-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/expansion-panel/expansion-panel.component.ts @@ -21,12 +21,18 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { NgStyle } from '@angular/common'; import { Component, Input } from '@angular/core'; +import { MatIconButton } from '@angular/material/button'; +import { MatAccordion, MatExpansionPanel, MatExpansionPanelHeader, MatExpansionPanelTitle } from '@angular/material/expansion'; +import { MatIcon } from '@angular/material/icon'; @Component({ selector: 'ozgcloud-expansion-panel', templateUrl: './expansion-panel.component.html', styleUrls: ['./expansion-panel.component.scss'], + standalone: true, + imports: [MatAccordion, MatExpansionPanel, MatExpansionPanelHeader, MatExpansionPanelTitle, MatIconButton, MatIcon, NgStyle], }) export class ExpansionPanelComponent { @Input() headline: string; diff --git a/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.html b/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.html index 3421e957279595f13a6c27001c7437ef9416ebb6..6cd69f6200e7cfb864bce83488cf60467d90aad3 100644 --- a/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.html +++ b/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.html @@ -1,40 +1,34 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<ng-container *ngIf="uploadInProgress$ | async as uploadInProgress"> - <input - data-test-id="file-upload-input" - [id]="myId" - type="file" - [accept]="accept" - (change)="onFileChanged($event)" - /> +@if (uploadInProgress$ | async; as uploadInProgress) { + <input data-test-id="file-upload-input" [id]="myId" type="file" [accept]="accept" (change)="onFileChanged($event)" /> <label [attr.for]="myId" matRipple aria-label="Anhang hinzufügen"> - <mat-icon *ngIf="!uploadInProgress.loading">attach_file</mat-icon> - - <ozgcloud-spinner [stateResource]="uploadInProgress" [diameter]="22" padding="0"> - </ozgcloud-spinner> + @if (!uploadInProgress.loading) { + <mat-icon>attach_file</mat-icon> + } + <ozgcloud-spinner [stateResource]="uploadInProgress" [diameter]="22" padding="0"> </ozgcloud-spinner> </label> -</ng-container> +} diff --git a/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.spec.ts index b823f373c545cdc4aeee52bf6a8948914942608c..a8ead2a90d69f7d2c78fab8d2f929b20d0b21c50 100644 --- a/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.spec.ts @@ -23,10 +23,10 @@ */ import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { FileUploadComponent } from './file-upload.component'; +import { SpinnerComponent } from '@alfa-client/ui'; import { MatIcon } from '@angular/material/icon'; import { MockComponent } from 'ng-mocks'; -import { SpinnerComponent } from '@alfa-client/ui'; +import { FileUploadComponent } from './file-upload.component'; describe('FileUploadComponent', () => { let component: FileUploadComponent; @@ -34,7 +34,7 @@ describe('FileUploadComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [FileUploadComponent, MatIcon, MockComponent(SpinnerComponent)], + imports: [FileUploadComponent, MatIcon, MockComponent(SpinnerComponent)], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.ts b/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.ts index cfafed7120d1cc08ad23b9a6e9ccee79067d6d62..37c1e62075effcb3be1de49b949d143e7e439cc7 100644 --- a/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/file-upload/file-upload.component.ts @@ -21,15 +21,21 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, EventEmitter, Input, Output } from '@angular/core'; import { StateResource } from '@alfa-client/tech-shared'; +import { AsyncPipe } from '@angular/common'; +import { Component, EventEmitter, Input, Output } from '@angular/core'; +import { MatRipple } from '@angular/material/core'; +import { MatIcon } from '@angular/material/icon'; import { uniqueId } from 'lodash-es'; import { Observable } from 'rxjs'; +import { SpinnerComponent } from '../spinner/spinner.component'; @Component({ selector: 'ozgcloud-file-upload', templateUrl: './file-upload.component.html', styleUrls: ['./file-upload.component.scss'], + standalone: true, + imports: [MatRipple, MatIcon, SpinnerComponent, AsyncPipe], }) export class FileUploadComponent { @Input() accept: string = '*/*'; diff --git a/alfa-client/libs/ui/src/lib/ui/fixed-dialog/fixed-dialog.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/fixed-dialog/fixed-dialog.component.spec.ts index f74f63c0b94e179f81f32830d8ef6af5d26d7b31..119257aa82d807ddea222ba3f2534ff3a348484d 100644 --- a/alfa-client/libs/ui/src/lib/ui/fixed-dialog/fixed-dialog.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/fixed-dialog/fixed-dialog.component.spec.ts @@ -32,8 +32,7 @@ describe('FixedDialogComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [MatDialogModule, MatIcon], - declarations: [FixedDialogComponent], + imports: [MatDialogModule, MatIcon, FixedDialogComponent], providers: [ { provide: MatDialogRef, diff --git a/alfa-client/libs/ui/src/lib/ui/fixed-dialog/fixed-dialog.component.ts b/alfa-client/libs/ui/src/lib/ui/fixed-dialog/fixed-dialog.component.ts index 0a0d03890fdb4837814cc105643b81ce5277239d..a4bb9d6af8e17ec21ca27cab2fdc2027ea4d3595 100644 --- a/alfa-client/libs/ui/src/lib/ui/fixed-dialog/fixed-dialog.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/fixed-dialog/fixed-dialog.component.ts @@ -21,26 +21,32 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, Inject, Injector } from '@angular/core'; -import { MAT_DIALOG_DATA } from '@angular/material/dialog'; +import { CdkScrollable } from '@angular/cdk/scrolling'; +import { NgClass, NgComponentOutlet } from '@angular/common'; +import { Component, inject, Injector, OnInit } from '@angular/core'; +import { MatIconButton } from '@angular/material/button'; +import { MAT_DIALOG_DATA, MatDialogClose, MatDialogContent, MatDialogTitle } from '@angular/material/dialog'; +import { MatIcon } from '@angular/material/icon'; import { FixedDialogData } from './fixed-dialog-data.model'; @Component({ selector: 'ozgcloud-fixed-dialog', templateUrl: './fixed-dialog.component.html', + standalone: true, + imports: [MatDialogTitle, MatIconButton, NgClass, MatIcon, MatDialogClose, CdkScrollable, MatDialogContent, NgComponentOutlet], }) -export class FixedDialogComponent { +export class FixedDialogComponent implements OnInit { + public data = inject<FixedDialogData>(MAT_DIALOG_DATA); + private injector = inject(Injector); + componentInjector: Injector; isMinimized: boolean; - constructor( - @Inject(MAT_DIALOG_DATA) public data: FixedDialogData, - injector: Injector, - ) { + ngOnInit(): void { this.componentInjector = Injector.create({ providers: [], - parent: injector, + parent: this.injector, }); } diff --git a/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component.spec.ts index 29d0ea1951593261b40071943e1f45a5016a9371..650e50ec93147e8958d2727ec40dc1ebc0fd906b 100644 --- a/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component.spec.ts @@ -21,10 +21,10 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { OzgcloudStrokedButtonWithSpinnerComponent } from '@alfa-client/ui'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MatDialogModule } from '@angular/material/dialog'; import { MatIcon } from '@angular/material/icon'; -import { OzgcloudStrokedButtonWithSpinnerComponent } from '@alfa-client/ui'; import { MockComponent } from 'ng-mocks'; import { ConnectionTimeoutRetryDialogComponent } from './connection-timeout-retry-dialog.component'; @@ -34,8 +34,8 @@ describe('ConnectionTimeoutRetryDialogComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [MatDialogModule], - declarations: [ + imports: [ + MatDialogModule, ConnectionTimeoutRetryDialogComponent, MatIcon, MockComponent(OzgcloudStrokedButtonWithSpinnerComponent), diff --git a/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component.ts b/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component.ts index eb209e7c7b10c791b2252a93823748739558a813..c2cc728cf695acc35facdf24b8f87e6e6fd8bdf9 100644 --- a/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component.ts @@ -21,11 +21,16 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { CdkScrollable } from '@angular/cdk/scrolling'; import { Component } from '@angular/core'; +import { MatDialogContent, MatDialogTitle } from '@angular/material/dialog'; +import { MatIcon } from '@angular/material/icon'; @Component({ selector: 'ozgcloud-connection-timeout-retry-dialog', templateUrl: './connection-timeout-retry-dialog.component.html', styleUrls: ['./connection-timeout-retry-dialog.component.scss'], + standalone: true, + imports: [MatDialogTitle, MatIcon, CdkScrollable, MatDialogContent], }) export class ConnectionTimeoutRetryDialogComponent {} diff --git a/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component.spec.ts index 42d3c9febfeeb164d2561b4d68dbbbb5f49dd895..6c41b694c5489b832e31696fe38554ce0cb76011 100644 --- a/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component.spec.ts @@ -21,10 +21,10 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { OzgcloudStrokedButtonWithSpinnerComponent } from '@alfa-client/ui'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MatDialogModule } from '@angular/material/dialog'; import { MatIcon } from '@angular/material/icon'; -import { OzgcloudStrokedButtonWithSpinnerComponent } from '@alfa-client/ui'; import { MockComponent } from 'ng-mocks'; import { ConnectionTimeoutRetryFailDialogComponent } from './connection-timeout-retry-fail-dialog.component'; @@ -34,8 +34,8 @@ describe('ConnectionTimeoutRetryFailDialogComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [MatDialogModule], - declarations: [ + imports: [ + MatDialogModule, ConnectionTimeoutRetryFailDialogComponent, MatIcon, MockComponent(OzgcloudStrokedButtonWithSpinnerComponent), diff --git a/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component.ts b/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component.ts index 858098b7e7ded139ba3b18ecf5baa1c4aef4b92c..62646a5aadf7797653253d18a866b7a33d09fe7d 100644 --- a/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component.ts @@ -21,12 +21,18 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { CdkScrollable } from '@angular/cdk/scrolling'; import { Component } from '@angular/core'; +import { MatDialogContent, MatDialogTitle } from '@angular/material/dialog'; +import { MatIcon } from '@angular/material/icon'; +import { OzgcloudStrokedButtonWithSpinnerComponent } from '../../ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component'; @Component({ selector: 'ozgcloud-connection-timeout-retry-fail-dialog', templateUrl: './connection-timeout-retry-fail-dialog.component.html', styleUrls: ['./connection-timeout-retry-fail-dialog.component.scss'], + standalone: true, + imports: [MatDialogTitle, MatIcon, CdkScrollable, MatDialogContent, OzgcloudStrokedButtonWithSpinnerComponent], }) export class ConnectionTimeoutRetryFailDialogComponent { reload(): void { diff --git a/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.html b/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.html index 1bb8fb6c9424bb9fb420a5f0007d61a88ffe6beb..ce20ce0990fb781b6eb31e3ce4247c1b3a4f9ca2 100644 --- a/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.html +++ b/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.html @@ -33,11 +33,15 @@ (click)="clickEmitter.emit($event)" type="button" > - <mat-icon *ngIf="icon" data-test-class="icon" [style.visibility]="isDisabled ? 'hidden' : 'visible'"> - {{ icon }} - </mat-icon> + @if (icon) { + <mat-icon data-test-class="icon" [style.visibility]="isDisabled ? 'hidden' : 'visible'"> + {{ icon }} + </mat-icon> + } - <mat-icon *ngIf="svgIcon" data-test-class="icon" [svgIcon]="svgIcon" [style.visibility]="isDisabled ? 'hidden' : 'visible'" /> + @if (svgIcon) { + <mat-icon data-test-class="icon" [svgIcon]="svgIcon" [style.visibility]="isDisabled ? 'hidden' : 'visible'" /> + } <ozgcloud-spinner [stateResource]="getStateResource()" [diameter]="22" [show]="showSpinner" padding="0" /> </button> diff --git a/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.spec.ts index 7cf06e5752ca8ebf4c3b0b797b97631bc3e04c25..365f71d7a8d7a2f24ddbe67e18e6a785b445f9a2 100644 --- a/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.spec.ts @@ -26,7 +26,7 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MatIcon } from '@angular/material/icon'; import { MatMenuModule } from '@angular/material/menu'; import { TooltipDirective } from '@ods/system'; -import { MockComponent, MockDirective, MockModule } from 'ng-mocks'; +import { MockComponent, MockDirective } from 'ng-mocks'; import { SpinnerComponent } from '../spinner/spinner.component'; import { IconButtonWithSpinnerComponent } from './icon-button-with-spinner.component'; @@ -37,15 +37,10 @@ describe('IconButtonWithSpinnerComponent', () => { const buttonSelector = '[data-test-class="icon-button"]'; const iconSelector = '[data-test-class="icon"]'; - beforeEach(async () => { - await TestBed.configureTestingModule({ - declarations: [ - IconButtonWithSpinnerComponent, - MatIcon, - MockComponent(SpinnerComponent), - MockDirective(TooltipDirective), - MockModule(MatMenuModule), - ], + beforeEach(() => { + TestBed.configureTestingModule({ + imports: [IconButtonWithSpinnerComponent, MatIcon, MatMenuModule], + declarations: [MockComponent(SpinnerComponent), MockDirective(TooltipDirective)], }); }); diff --git a/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.ts b/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.ts index e2b8c90813ed8a2a6bf5a29ed86055569895b5ef..f83e6bfcc75341f27eaa8baa149a9c65f3fa7c57 100644 --- a/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/icon-button-with-spinner/icon-button-with-spinner.component.ts @@ -23,13 +23,21 @@ */ import { StateResource, createEmptyStateResource } from '@alfa-client/tech-shared'; import { Component, EventEmitter, Input, Output } from '@angular/core'; +import { MatIconButton } from '@angular/material/button'; +import { MatIcon } from '@angular/material/icon'; +import { MatMenuTrigger } from '@angular/material/menu'; +import { MatTooltip } from '@angular/material/tooltip'; import { Resource } from '@ngxp/rest'; +import { TooltipDirective } from '@ods/system'; import { isNil } from 'lodash-es'; +import { SpinnerComponent } from '../spinner/spinner.component'; @Component({ selector: 'ozgcloud-icon-button-with-spinner', templateUrl: './icon-button-with-spinner.component.html', styleUrls: ['./icon-button-with-spinner.component.scss'], + standalone: true, + imports: [MatIconButton, MatTooltip, MatMenuTrigger, MatIcon, SpinnerComponent, TooltipDirective], }) export class IconButtonWithSpinnerComponent { @Input() icon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.html b/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.html index 3ffd5acf9942d680fec448cb79b10ed6017e7b9f..7c9621388efb76c4ae8bea4640288b1ac1264150 100644 --- a/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.html +++ b/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.html @@ -1,26 +1,26 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> <h1 mat-dialog-title> @@ -30,14 +30,13 @@ <mat-dialog-content> <p data-test-id="error-message" class="error-message"> Wir sind nicht ganz sicher, was schiefgelaufen ist. Der Fehler - <span *ngIf="showId()">(ID: {{ data.issues[0].exceptionId }})</span> wurde unserem Support - gemeldet. Bitte starten sie die Anwendung neu. + @if (showId()) { + <span>(ID: {{ data.issues[0].exceptionId }})</span> + } + wurde unserem Support gemeldet. Bitte starten sie die Anwendung neu. </p> <a href="/" tabindex="-1" class="button"> - <ozgcloud-stroked-button-with-spinner - icon="refresh" - text="Neu starten" - ></ozgcloud-stroked-button-with-spinner> + <ozgcloud-stroked-button-with-spinner icon="refresh" text="Neu starten"></ozgcloud-stroked-button-with-spinner> </a> <ozgcloud-stroked-button-with-spinner icon="logout" diff --git a/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.spec.ts index ebc6907e4a0ecc725e963035137e93c5649ef558..3eb87f3f9084ad31fbd7bd508b208ec917edee1d 100644 --- a/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.spec.ts @@ -21,12 +21,12 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ +import { mock } from '@alfa-client/test-utils'; +import { OzgcloudStrokedButtonWithSpinnerComponent } from '@alfa-client/ui'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MAT_DIALOG_DATA, MatDialogModule, MatDialogRef } from '@angular/material/dialog'; import { MatIcon } from '@angular/material/icon'; import { faker } from '@faker-js/faker'; -import { mock } from '@alfa-client/test-utils'; -import { OzgcloudStrokedButtonWithSpinnerComponent } from '@alfa-client/ui'; import { OAuthService } from 'angular-oauth2-oidc'; import { createIssue } from 'libs/tech-shared/test/error'; import { MockComponent } from 'ng-mocks'; @@ -40,12 +40,12 @@ describe('InternalServerErrorDialogComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ + imports: [ + MatDialogModule, InternalServerErrorDialogComponent, MatIcon, MockComponent(OzgcloudStrokedButtonWithSpinnerComponent), ], - imports: [MatDialogModule], providers: [ { provide: MatDialogRef, @@ -83,9 +83,7 @@ describe('InternalServerErrorDialogComponent', () => { dialogData = { error: { ...{ issues: [createIssue()] }, id: exceptionId } }; fixture.detectChanges(); - expect(fixture.nativeElement).not.toHaveTextContent( - `ID: ${dialogData.error.issues[0].exceptionId}`, - ); + expect(fixture.nativeElement).not.toHaveTextContent(`ID: ${dialogData.error.issues[0].exceptionId}`); }); }); }); diff --git a/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.ts b/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.ts index cfcbff45dbacdbb63cff491fec6ac4226bbca0e5..e55158c9e1e892cd4d863842d64897b7aa82341c 100644 --- a/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/notification/internal-server-error-dialog/internal-server-error-dialog.component.ts @@ -21,21 +21,24 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, Inject } from '@angular/core'; -import { MAT_DIALOG_DATA } from '@angular/material/dialog'; import { ApiError, hasExceptionId } from '@alfa-client/tech-shared'; +import { CdkScrollable } from '@angular/cdk/scrolling'; +import { Component, inject } from '@angular/core'; +import { MAT_DIALOG_DATA, MatDialogContent, MatDialogTitle } from '@angular/material/dialog'; +import { MatIcon } from '@angular/material/icon'; import { OAuthService } from 'angular-oauth2-oidc'; +import { OzgcloudStrokedButtonWithSpinnerComponent } from '../../ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component'; @Component({ selector: 'ozgcloud-internal-server-error-dialog', templateUrl: './internal-server-error-dialog.component.html', styleUrls: ['./internal-server-error-dialog.component.scss'], + standalone: true, + imports: [MatDialogTitle, MatIcon, CdkScrollable, MatDialogContent, OzgcloudStrokedButtonWithSpinnerComponent], }) export class InternalServerErrorDialogComponent { - constructor( - @Inject(MAT_DIALOG_DATA) public data: ApiError, - public authService: OAuthService, - ) {} + public data: ApiError = inject<ApiError>(MAT_DIALOG_DATA); + public authService = inject(OAuthService); showId(): boolean { return hasExceptionId(this.data); diff --git a/alfa-client/libs/ui/src/lib/ui/open-url-button/open-url-button.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/open-url-button/open-url-button.component.spec.ts index f5fbf2d6c35beb79bccaf3e8c87c0e62f0fd3e00..b53d242247b71270aa5585099561d595492f51cd 100644 --- a/alfa-client/libs/ui/src/lib/ui/open-url-button/open-url-button.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/open-url-button/open-url-button.component.spec.ts @@ -23,8 +23,8 @@ */ import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { OpenUrlButtonComponent } from './open-url-button.component'; import { MockComponent } from 'ng-mocks'; +import { OpenUrlButtonComponent } from './open-url-button.component'; describe('OpenUrlButtonComponent', () => { let component: OpenUrlButtonComponent; @@ -32,7 +32,7 @@ describe('OpenUrlButtonComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [OpenUrlButtonComponent, MockComponent(OpenUrlButtonComponent)], + imports: [OpenUrlButtonComponent, MockComponent(OpenUrlButtonComponent)], }).compileComponents(); fixture = TestBed.createComponent(OpenUrlButtonComponent); diff --git a/alfa-client/libs/ui/src/lib/ui/open-url-button/open-url-button.component.ts b/alfa-client/libs/ui/src/lib/ui/open-url-button/open-url-button.component.ts index 4663a18ab9485c6db0358a3ad4f2203c950548f4..f080acaa278a60d150fa32083f2be3ecd8325b69 100644 --- a/alfa-client/libs/ui/src/lib/ui/open-url-button/open-url-button.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/open-url-button/open-url-button.component.ts @@ -22,11 +22,16 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatAnchor } from '@angular/material/button'; +import { MatIcon } from '@angular/material/icon'; +import { MatTooltip } from '@angular/material/tooltip'; @Component({ selector: 'ozgcloud-open-url-button', templateUrl: './open-url-button.component.html', styleUrls: ['./open-url-button.component.scss'], + standalone: true, + imports: [MatAnchor, MatTooltip, MatIcon], }) export class OpenUrlButtonComponent { @Input() icon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component.spec.ts index ee97fa55891a3b5ea04917c80ea255458f58d68b..5447abd13a916be618548326cef55e254a232963 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component.spec.ts @@ -41,7 +41,7 @@ describe('OzgcloudButtonWithSpinnerComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ + imports: [ MatButton, MatRipple, OzgcloudButtonWithSpinnerComponent, diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component.ts index 497704e4b948a92527d4cdaf02050658142a1aaf..fb46489bd43247e86059d332972cabfd88db9364 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component.ts @@ -21,15 +21,21 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; import { StateResource, createEmptyStateResource } from '@alfa-client/tech-shared'; +import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; +import { MatButton } from '@angular/material/button'; +import { MatTooltip } from '@angular/material/tooltip'; import { Resource } from '@ngxp/rest'; +import { TooltipDirective } from '@ods/system'; import { isNil } from 'lodash-es'; +import { OzgcloudButtonContentComponent } from '../shared/ozgcloud-button-content/ozgcloud-button-content.component'; @Component({ selector: 'ozgcloud-button-with-spinner', templateUrl: './ozgcloud-button-with-spinner.component.html', styleUrls: ['./ozgcloud-button-with-spinner.component.scss'], + standalone: true, + imports: [MatButton, MatTooltip, OzgcloudButtonContentComponent, TooltipDirective], }) export class OzgcloudButtonWithSpinnerComponent implements OnInit { @Input() icon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component.spec.ts index 976c0b0c396b7dfc68b3f7e53148d1d75cf1baa8..48f65db0143ecaf0c0e6a564f1f6cd1619092934 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component.spec.ts @@ -61,10 +61,7 @@ describe('IconButtonPrimaryWithSpinnerComponent', () => { it('should create aria label', () => { component.ngOnInit(); - expect(createAriaLabelForIconButtonMock).toHaveBeenCalledWith( - component.tooltip, - component.svgIcon, - ); + expect(createAriaLabelForIconButtonMock).toHaveBeenCalledWith(component.tooltip, component.svgIcon); }); it('should set aria label', () => { diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component.ts index f6dd2b5094a3d5521945be70c70d6d2ac88192dd..d5fc959cc46fcc27629b9e8c48555d26cb877146 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component.ts @@ -21,14 +21,20 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; import { createAriaLabelForIconButton, StateResource } from '@alfa-client/tech-shared'; +import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; +import { MatIconButton } from '@angular/material/button'; +import { MatIcon } from '@angular/material/icon'; +import { MatTooltip } from '@angular/material/tooltip'; import { Resource } from '@ngxp/rest'; +import { TooltipDirective } from '@ods/system'; @Component({ selector: 'ozgcloud-icon-button-primary', templateUrl: './ozgcloud-icon-button-primary.component.html', styleUrls: ['./ozgcloud-icon-button-primary.component.scss'], + standalone: true, + imports: [MatIconButton, MatTooltip, MatIcon, TooltipDirective], }) export class OzgcloudIconButtonPrimaryComponent implements OnInit { @Input() svgIcon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component.spec.ts index 208868555e600c7fd81f6edc4bd1e8fd541827e6..ac0307f0125ad487682e40acba742c9245774b94 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component.spec.ts @@ -41,7 +41,7 @@ describe('OzgcloudStrokedButtonWithSpinnerComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ + imports: [ MatButton, MatRipple, OzgcloudStrokedButtonWithSpinnerComponent, diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component.ts index 218915f94f34808e4423af8fbffec4ee4c180349..36f102a0d7d92d5953a97f1a7b47caa9988b4591 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component.ts @@ -21,15 +21,21 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; import { StateResource, createEmptyStateResource } from '@alfa-client/tech-shared'; +import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; +import { MatButton } from '@angular/material/button'; +import { MatTooltip } from '@angular/material/tooltip'; import { Resource } from '@ngxp/rest'; +import { TooltipDirective } from '@ods/system'; import { isNil } from 'lodash-es'; +import { OzgcloudButtonContentComponent } from '../shared/ozgcloud-button-content/ozgcloud-button-content.component'; @Component({ selector: 'ozgcloud-stroked-button-with-spinner', templateUrl: './ozgcloud-stroked-button-with-spinner.component.html', styleUrls: ['./ozgcloud-stroked-button-with-spinner.component.scss'], + standalone: true, + imports: [MatButton, MatTooltip, OzgcloudButtonContentComponent, TooltipDirective], }) export class OzgcloudStrokedButtonWithSpinnerComponent implements OnInit { @Input() icon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.html b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.html index 168a6bfdaae0891449b9dd1d88b57edb7662325d..88d174c6a844f216987f40801c6e7c6cfcc35b76 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.html +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.html @@ -1,47 +1,46 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: - - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung + +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: + +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 + +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<mat-icon - *ngIf="icon" - data-test-class="icon" - [class.with-text]="text" - [style.visibility]="isDisabled ? 'hidden' : 'visible'" -> - {{ icon }} -</mat-icon> - -<mat-icon - *ngIf="svgIcon" - data-test-class="icon" - [class.with-text]="text" - [svgIcon]="svgIcon" - [style.visibility]="isDisabled ? 'hidden' : 'visible'" -> -</mat-icon> - -<span *ngIf="text" class="text-sm" data-test-class="button-with-spinner-text">{{ text }}</span> - -<ozgcloud-spinner [diameter]="22" padding="0" [stateResource]="stateResource" [show]="showSpinner"> -</ozgcloud-spinner> +@if (icon) { + <mat-icon data-test-class="icon" [class.with-text]="text" [style.visibility]="isDisabled ? 'hidden' : 'visible'"> + {{ icon }} + </mat-icon> +} + +@if (svgIcon) { + <mat-icon + data-test-class="icon" + [class.with-text]="text" + [svgIcon]="svgIcon" + [style.visibility]="isDisabled ? 'hidden' : 'visible'" + > + </mat-icon> +} + +@if (text) { + <span class="text-sm" data-test-class="button-with-spinner-text">{{ text }}</span> +} + +<ozgcloud-spinner [diameter]="22" padding="0" [stateResource]="stateResource" [show]="showSpinner"> </ozgcloud-spinner> diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.spec.ts index 0a313a7ef672ecb3b215ce916ed709cb9aa83cb4..14e079e54c2bc4faa5cb355342b24850d15e9acc 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.spec.ts @@ -37,7 +37,7 @@ describe('OzgcloudButtonContentComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [MatIcon, MockComponent(SpinnerComponent), OzgcloudButtonContentComponent], + imports: [MatIcon, MockComponent(SpinnerComponent), OzgcloudButtonContentComponent], }).compileComponents(); fixture = TestBed.createComponent(OzgcloudButtonContentComponent); diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.ts index 32283456c72d2ffd653f89880ac1f42c789f9a79..4e2b5fec9f852c47df972ecaaa22531ca7a25069 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component.ts @@ -21,14 +21,18 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, Input } from '@angular/core'; import { StateResource } from '@alfa-client/tech-shared'; +import { Component, Input } from '@angular/core'; +import { MatIcon } from '@angular/material/icon'; import { Resource } from '@ngxp/rest'; +import { SpinnerComponent } from '../../../spinner/spinner.component'; @Component({ selector: 'ozgcloud-button-content', templateUrl: './ozgcloud-button-content.component.html', styleUrls: ['./ozgcloud-button-content.component.scss'], + standalone: true, + imports: [MatIcon, SpinnerComponent], }) export class OzgcloudButtonContentComponent { @Input() icon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-dialog/ozgcloud-dialog.service.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-dialog/ozgcloud-dialog.service.ts index da2fb2923e846b00101f7dca2dab0500a8a5c971..077780a3e1d01c0e198efc1de9f12244315b1194 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-dialog/ozgcloud-dialog.service.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-dialog/ozgcloud-dialog.service.ts @@ -23,13 +23,15 @@ */ import { Dialog, DialogConfig, DialogRef } from '@angular/cdk/dialog'; import { ComponentType } from '@angular/cdk/portal'; -import { Injectable, ViewContainerRef } from '@angular/core'; +import { inject, Injectable, ViewContainerRef } from '@angular/core'; import { isNil } from 'lodash-es'; @Injectable({ providedIn: 'root', }) export class OzgcloudDialogService { + private dialog = inject(Dialog); + readonly WIZARD_DIALOG_CONFIG: DialogConfig = { width: '1000px', restoreFocus: false, @@ -41,8 +43,6 @@ export class OzgcloudDialogService { disableClose: true, }; - constructor(private dialog: Dialog) {} - public openWizard<C, D, R = unknown>(component: ComponentType<C>, data?: D): DialogRef<R> { return this.openDialog<C, R>(component, this.buildDialogConfigWithData<D>(data, this.WIZARD_DIALOG_CONFIG)); } diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-icon/ozgcloud-icon.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-icon/ozgcloud-icon.component.spec.ts index 2f46c2cd4b354c756077397db94a28bb07382214..348a842ef697927273e2af4f7fe4337735b53e6f 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-icon/ozgcloud-icon.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-icon/ozgcloud-icon.component.spec.ts @@ -31,8 +31,7 @@ describe('OzgcloudIconComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [OzgcloudIconComponent], - imports: [MatIcon], + imports: [MatIcon, OzgcloudIconComponent], }).compileComponents(); fixture = TestBed.createComponent(OzgcloudIconComponent); diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-icon/ozgcloud-icon.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-icon/ozgcloud-icon.component.ts index 888c31801bbcf6a6c03fda6f6ed43d9529fbd0bb..b2e99d1f83445d4f007910fe6986c749f2600808 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-icon/ozgcloud-icon.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-icon/ozgcloud-icon.component.ts @@ -22,11 +22,14 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatIcon } from '@angular/material/icon'; @Component({ selector: 'ozgcloud-icon', templateUrl: './ozgcloud-icon.component.html', styleUrls: ['./ozgcloud-icon.component.scss'], + standalone: true, + imports: [MatIcon], }) export class OzgcloudIconComponent { @Input() icon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component.spec.ts index e967e79c2ae45c7305d4255e199f52f27220fa4e..454e44cb8d1cbbb063e1228cda44e601a1423053 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component.spec.ts @@ -31,8 +31,7 @@ describe('OzgcloudMenuComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [OzgcloudMenuComponent], - imports: [MatMenuModule], + imports: [MatMenuModule, OzgcloudMenuComponent], }).compileComponents(); fixture = TestBed.createComponent(OzgcloudMenuComponent); diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component.ts index bd007c306911e007bc515da3fab56fcc2ebc9a52..d267a8ffe01c0d07ff12b0e83d699140856b25bf 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component.ts @@ -28,6 +28,8 @@ import { MatMenu } from '@angular/material/menu'; selector: 'ozgcloud-menu', templateUrl: './ozgcloud-menu.component.html', styleUrls: ['./ozgcloud-menu.component.scss'], + standalone: true, + imports: [MatMenu], }) export class OzgcloudMenuComponent { @ViewChild('menu', { static: true }) matMenu: MatMenu; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.html b/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.html index 604b9441202c5c72a07489dc8715d69c339cb489..f6dd97a4e59aad87b62bc7cfa87277a51dbdd9e5 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.html +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.html @@ -1,34 +1,35 @@ <!-- - Copyright (C) 2024 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung +Copyright (C) 2024 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<ozgcloud-icon-button-primary - *ngIf="isPasteSupported" - [tooltip]="tooltip" - svgIcon="paste_from_clipboard" - class="paste_icon" - (clickEmitter)="onPaste()" - data-test-id="paste_from_clipboard" -> -</ozgcloud-icon-button-primary> +@if (isPasteSupported) { + <ozgcloud-icon-button-primary + [tooltip]="tooltip" + svgIcon="paste_from_clipboard" + class="paste_icon" + (clickEmitter)="onPaste()" + data-test-id="paste_from_clipboard" + > + </ozgcloud-icon-button-primary> +} diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.spec.ts index e91b91840bb1f855e5821d6eaac5949bc815181c..918ec8d7c1c8122a7f8fbf5489f3031e66f664bf 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.spec.ts @@ -50,8 +50,8 @@ describe('OzgcloudPasteTextButtonComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [MatIconTestingModule], - declarations: [ + imports: [ + MatIconTestingModule, OzgcloudPasteTextButtonComponent, MockComponent(MatIcon), MockComponent(OzgcloudIconButtonPrimaryComponent), diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.ts index de10060dbe49cd7f048adbf90f267b26a357d65f..3fa9c14b0b00126d3074923b4871ecf52594a4b1 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-paste-text-button/ozgcloud-paste-text-button.component.ts @@ -21,13 +21,16 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; import { isClipboardReadSupported } from '@alfa-client/tech-shared'; +import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'; +import { OzgcloudIconButtonPrimaryComponent } from '../ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component'; @Component({ selector: 'ozgcloud-paste-text-button', templateUrl: './ozgcloud-paste-text-button.component.html', styleUrls: ['./ozgcloud-paste-text-button.component.scss'], + standalone: true, + imports: [OzgcloudIconButtonPrimaryComponent], }) export class OzgcloudPasteTextButtonComponent implements OnInit { @Input() tooltip: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component.spec.ts index e29ecd69fcee6fb293c466bdb7ff426d83666b4d..b789f1e69acc310ec87cedebd84a2cb2f3dad0a4 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component.spec.ts @@ -31,8 +31,7 @@ describe('OzgcloudRoutingButtonComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [OzgcloudRoutingButtonComponent], - imports: [RouterTestingModule], + imports: [RouterTestingModule, OzgcloudRoutingButtonComponent], }).compileComponents(); fixture = TestBed.createComponent(OzgcloudRoutingButtonComponent); diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component.ts index fa61fa8f609a3cc7129eaad33e8656bba754d345..92d82c8800f117c3bb8b1c9256880294c6cbc9cf 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-routing-button/ozgcloud-routing-button.component.ts @@ -22,11 +22,15 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatAnchor } from '@angular/material/button'; +import { RouterLink } from '@angular/router'; @Component({ selector: 'ozgcloud-routing-button', templateUrl: './ozgcloud-routing-button.component.html', styleUrls: ['./ozgcloud-routing-button.component.scss'], + standalone: true, + imports: [MatAnchor, RouterLink], }) export class OzgcloudRoutingButtonComponent { @Input() routerLinkPath: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon-big/ozgcloud-svgicon-big.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon-big/ozgcloud-svgicon-big.component.spec.ts index 734f2aa0c6dabdf0b55381f37365e4f23a6002f6..6189dfc0e3720ac7d4dcfcaff706f181af7474e2 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon-big/ozgcloud-svgicon-big.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon-big/ozgcloud-svgicon-big.component.spec.ts @@ -31,8 +31,7 @@ describe('OzgcloudSvgIconBigComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [OzgcloudSvgIconBigComponent], - imports: [MatIcon], + imports: [MatIcon, OzgcloudSvgIconBigComponent], }).compileComponents(); fixture = TestBed.createComponent(OzgcloudSvgIconBigComponent); diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon-big/ozgcloud-svgicon-big.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon-big/ozgcloud-svgicon-big.component.ts index e99ad4a83f0a0bd6344267d353e06f994640f37b..5d7c397f0a5b0c8b0693da1b5ed8f012ec23b75b 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon-big/ozgcloud-svgicon-big.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon-big/ozgcloud-svgicon-big.component.ts @@ -22,11 +22,14 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatIcon } from '@angular/material/icon'; @Component({ selector: 'ozgcloud-svgicon-big', templateUrl: './ozgcloud-svgicon-big.component.html', styleUrls: ['./ozgcloud-svgicon-big.component.scss'], + standalone: true, + imports: [MatIcon], }) export class OzgcloudSvgIconBigComponent { @Input() svgIcon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component.spec.ts index 9ce6d63d48290d7145975d7ef01d570759571aa9..d3f63f4b2c1cb7be217ce69efbd180891efb496f 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component.spec.ts @@ -31,8 +31,7 @@ describe('OzgcloudSvgIconComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [OzgcloudSvgIconComponent], - imports: [MatIcon], + imports: [MatIcon, OzgcloudSvgIconComponent], }).compileComponents(); fixture = TestBed.createComponent(OzgcloudSvgIconComponent); diff --git a/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component.ts b/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component.ts index 7aa1d869fca7f17ad41926120aa9c5bf088bd5e8..c35c9ab18d1b5ede13f37f06f980dd88c0d2ce24 100644 --- a/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/ozgcloud-svgicon/ozgcloud-svgicon.component.ts @@ -22,11 +22,14 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { Component, Input } from '@angular/core'; +import { MatIcon } from '@angular/material/icon'; @Component({ selector: 'ozgcloud-svgicon', templateUrl: './ozgcloud-svgicon.component.html', styleUrls: ['./ozgcloud-svgicon.component.scss'], + standalone: true, + imports: [MatIcon], }) export class OzgcloudSvgIconComponent { @Input() svgIcon: string; diff --git a/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.html b/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.html index 6f992fe024c1d15d17114491373d81a50b8c0c20..3a7dda71335ccefb8982d0452826a35d8032de5d 100644 --- a/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.html +++ b/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.html @@ -1,28 +1,30 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<div *ngIf="isVisible" class="progressbar-overlay" data-test-class="progressbar-overlay"> - <mat-progress-bar data-test-id="progress-bar" mode="indeterminate"></mat-progress-bar> -</div> +@if (isVisible) { + <div class="progressbar-overlay" data-test-class="progressbar-overlay"> + <mat-progress-bar data-test-id="progress-bar" mode="indeterminate"></mat-progress-bar> + </div> +} diff --git a/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.spec.ts index 87b2dca90e9adc2001bd595db8b24c924d93c9a4..a98db10dc48b1241047e761fd2f05a5d962d6c34 100644 --- a/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.spec.ts @@ -34,8 +34,7 @@ describe('ProgressBarComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ProgressBarComponent], - imports: [MatProgressBar], + imports: [MatProgressBar, ProgressBarComponent], }); }); diff --git a/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.ts b/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.ts index 69bf1807b1661c741d23ae7747d964a8c699d366..0ce2009d9f4ac65aa2299249d25930c753fde058 100644 --- a/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/progress-bar/progress-bar.component.ts @@ -21,14 +21,17 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, Input } from '@angular/core'; import { createEmptyStateResource, StateResource } from '@alfa-client/tech-shared'; +import { Component, Input } from '@angular/core'; +import { MatProgressBar } from '@angular/material/progress-bar'; import { Resource } from '@ngxp/rest'; @Component({ selector: 'ozgcloud-progress-bar', templateUrl: './progress-bar.component.html', styleUrls: ['./progress-bar.component.scss'], + standalone: true, + imports: [MatProgressBar], }) export class ProgressBarComponent { @Input() stateResource: StateResource<Resource> = createEmptyStateResource<Resource>(); diff --git a/alfa-client/libs/ui/src/lib/ui/slide-toggle/slide-toggle.component.ts b/alfa-client/libs/ui/src/lib/ui/slide-toggle/slide-toggle.component.ts index 951d47620e165deecf550d90f43930cb30405653..862f4c7ec87f24a558689fca192955ba6e95fc9c 100644 --- a/alfa-client/libs/ui/src/lib/ui/slide-toggle/slide-toggle.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/slide-toggle/slide-toggle.component.ts @@ -21,13 +21,18 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, EventEmitter, Input, Output } from '@angular/core'; import { EMPTY_STRING } from '@alfa-client/tech-shared'; +import { Component, EventEmitter, Input, Output } from '@angular/core'; +import { MatSlideToggle } from '@angular/material/slide-toggle'; +import { MatTooltip } from '@angular/material/tooltip'; +import { TooltipDirective } from '@ods/system'; @Component({ selector: 'ozgcloud-slide-toggle', templateUrl: './slide-toggle.component.html', styleUrls: ['./slide-toggle.component.scss'], + standalone: true, + imports: [MatSlideToggle, MatTooltip, TooltipDirective], }) export class SlideToggleComponent { @Input() checked: boolean = false; diff --git a/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.html b/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.html index fa88c4170ccd839d86ed250e89eef62cccf7101f..488dfee2c9a4a858064cca4461e25ceeb64a43b9 100644 --- a/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.html +++ b/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.html @@ -1,35 +1,32 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<div - *ngIf="showSpinner" - data-test-class="spinner-transparency" - class="spinner" - [style.padding]="'16px'" -> - <mat-spinner [diameter]="70"></mat-spinner> -</div> - -<ng-content *ngIf="!showSpinner" data-test-class="spinner-transparency-content"></ng-content> +@if (showSpinner) { + <div data-test-class="spinner-transparency" class="spinner" [style.padding]="'16px'"> + <mat-spinner [diameter]="70"></mat-spinner> + </div> +} @else { + <ng-content data-test-class="spinner-transparency-content"></ng-content> +} diff --git a/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.spec.ts index 2c1395076163f92d48f781151f13cfa4c7967888..c5c81db6154375f630b88bc874dee34a3a16ad22 100644 --- a/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.spec.ts @@ -38,8 +38,7 @@ describe('SpinnerTransparencyComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [SpinnerTransparencyComponent, SpinnerComponent], - imports: [MatIcon, MatProgressSpinner], + imports: [MatIcon, MatProgressSpinner, SpinnerTransparencyComponent, SpinnerComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.ts b/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.ts index bf70ce6a7764c20ab9c2bce95f7191182ec920a2..34fa02963b6363318252902d45fe6b0853fe9334 100644 --- a/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/spinner-transparency/spinner-transparency.component.ts @@ -21,14 +21,17 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { Component, Input } from '@angular/core'; import { StateResource, createEmptyStateResource } from '@alfa-client/tech-shared'; +import { Component, Input } from '@angular/core'; +import { MatProgressSpinner } from '@angular/material/progress-spinner'; import { Resource } from '@ngxp/rest'; @Component({ selector: 'ozgcloud-spinner-transparency', templateUrl: './spinner-transparency.component.html', styleUrls: ['./spinner-transparency.component.scss'], + standalone: true, + imports: [MatProgressSpinner], }) export class SpinnerTransparencyComponent { @Input() stateResource: StateResource<Resource> = createEmptyStateResource<Resource>(); diff --git a/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.html b/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.html index eaa2ab439802985584c0b7595703072d095dcae9..5a426212ea07aa4413b5f7105c1790e7498ba8a6 100644 --- a/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.html +++ b/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.html @@ -1,31 +1,37 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<div *ngIf="showSpinner" class="spinner" [style.padding]="padding + 'px'"> - <mat-spinner [diameter]="diameter" data-test-class="spinner"> </mat-spinner> - <span *ngIf="text">{{ text }}</span> -</div> +@if (showSpinner) { + <div class="spinner" [style.padding]="padding + 'px'"> + <mat-spinner [diameter]="diameter" data-test-class="spinner"> </mat-spinner> + @if (text) { + <span>{{ text }}</span> + } + </div> +} -<ng-content *ngIf="!showSpinner" data-test-class="spinner-content"></ng-content> +@if (!showSpinner) { + <ng-content data-test-class="spinner-content"></ng-content> +} diff --git a/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.spec.ts index 8bc40b8d5ba9850a5c36c603e91fcc13827d4420..27b80e6f55c7fa9994ebaba67688ff5417f6272b 100644 --- a/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.spec.ts @@ -37,8 +37,7 @@ describe('SpinnerComponent', () => { beforeEach(async () => { TestBed.configureTestingModule({ - declarations: [SpinnerComponent], - imports: [MatIcon, MatProgressSpinner], + imports: [MatIcon, MatProgressSpinner, SpinnerComponent], }); }); diff --git a/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.ts b/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.ts index cfd3cfd4d3d6b17b4d046826c700c288bcb6cfe7..15350296561bdd96791a7b97e448e8be0ab6183f 100644 --- a/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/spinner/spinner.component.ts @@ -23,11 +23,14 @@ */ import { createEmptyStateResource, StateResource } from '@alfa-client/tech-shared'; import { Component, Input } from '@angular/core'; +import { MatProgressSpinner } from '@angular/material/progress-spinner'; @Component({ selector: 'ozgcloud-spinner', templateUrl: './spinner.component.html', styleUrls: ['./spinner.component.scss'], + standalone: true, + imports: [MatProgressSpinner], }) export class SpinnerComponent { @Input() stateResource: StateResource<unknown> = createEmptyStateResource<unknown>(); diff --git a/alfa-client/libs/ui/src/lib/ui/subnavigation/subnavigation.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/subnavigation/subnavigation.component.spec.ts index b021131cd7dae57a09c8821f81b6e0c6efa37813..6586a170653c455343d86b2c44d436a4c0defeab 100644 --- a/alfa-client/libs/ui/src/lib/ui/subnavigation/subnavigation.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/subnavigation/subnavigation.component.spec.ts @@ -30,7 +30,7 @@ describe('SubnavigationComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [SubnavigationComponent], + imports: [SubnavigationComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/ui/subnavigation/subnavigation.component.ts b/alfa-client/libs/ui/src/lib/ui/subnavigation/subnavigation.component.ts index 631e4713fa20d357b911ab7c3fbb5514b5847a00..1e2deca56f9669732b166fc82adb23af30b9f699 100644 --- a/alfa-client/libs/ui/src/lib/ui/subnavigation/subnavigation.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/subnavigation/subnavigation.component.ts @@ -27,5 +27,6 @@ import { Component } from '@angular/core'; selector: 'ozgcloud-subnavigation', templateUrl: './subnavigation.component.html', styleUrls: ['./subnavigation.component.scss'], + standalone: true, }) export class SubnavigationComponent {} diff --git a/alfa-client/libs/ui/src/lib/ui/ui.module.spec.ts b/alfa-client/libs/ui/src/lib/ui/ui.module.spec.ts deleted file mode 100644 index 1133667573970cdae3c5f413d6d064c62ca94891..0000000000000000000000000000000000000000 --- a/alfa-client/libs/ui/src/lib/ui/ui.module.spec.ts +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - * Ministerpräsidenten des Landes Schleswig-Holstein - * Staatskanzlei - * Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - * - * Lizenziert unter der EUPL, Version 1.2 oder - sobald - * diese von der Europäischen Kommission genehmigt wurden - - * Folgeversionen der EUPL ("Lizenz"); - * Sie dürfen dieses Werk ausschließlich gemäß - * dieser Lizenz nutzen. - * Eine Kopie der Lizenz finden Sie hier: - * - * https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - * - * Sofern nicht durch anwendbare Rechtsvorschriften - * gefordert oder in schriftlicher Form vereinbart, wird - * die unter der Lizenz verbreitete Software "so wie sie - * ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - * ausdrücklich oder stillschweigend - verbreitet. - * Die sprachspezifischen Genehmigungen und Beschränkungen - * unter der Lizenz sind dem Lizenztext zu entnehmen. - */ -import { TestBed } from '@angular/core/testing'; -import { UiModule } from './ui.module'; - -describe('UiModule', () => { - beforeEach(() => { - TestBed.configureTestingModule({ - imports: [UiModule], - }).compileComponents(); - }); - - it('should create', () => { - expect(UiModule).toBeDefined(); - }); -}); diff --git a/alfa-client/libs/ui/src/lib/ui/ui.module.ts b/alfa-client/libs/ui/src/lib/ui/ui.module.ts deleted file mode 100644 index e7c19b188d8e38ab7c45f080f52b4b3536550cc4..0000000000000000000000000000000000000000 --- a/alfa-client/libs/ui/src/lib/ui/ui.module.ts +++ /dev/null @@ -1,263 +0,0 @@ -/* - * Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - * Ministerpräsidenten des Landes Schleswig-Holstein - * Staatskanzlei - * Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - * - * Lizenziert unter der EUPL, Version 1.2 oder - sobald - * diese von der Europäischen Kommission genehmigt wurden - - * Folgeversionen der EUPL ("Lizenz"); - * Sie dürfen dieses Werk ausschließlich gemäß - * dieser Lizenz nutzen. - * Eine Kopie der Lizenz finden Sie hier: - * - * https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - * - * Sofern nicht durch anwendbare Rechtsvorschriften - * gefordert oder in schriftlicher Form vereinbart, wird - * die unter der Lizenz verbreitete Software "so wie sie - * ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - * ausdrücklich oder stillschweigend - verbreitet. - * Die sprachspezifischen Genehmigungen und Beschränkungen - * unter der Lizenz sind dem Lizenztext zu entnehmen. - */ -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { CommonModule } from '@angular/common'; -import { HTTP_INTERCEPTORS } from '@angular/common/http'; -import { NgModule } from '@angular/core'; -import { FormsModule, ReactiveFormsModule } from '@angular/forms'; -import { DateFnsAdapter, MatDateFnsModule } from '@angular/material-date-fns-adapter'; -import { MatAutocompleteModule } from '@angular/material/autocomplete'; -import { MatBadgeModule } from '@angular/material/badge'; -import { MatButtonModule } from '@angular/material/button'; -import { MatButtonToggleModule } from '@angular/material/button-toggle'; -import { MatCheckboxModule } from '@angular/material/checkbox'; -import { DateAdapter, MAT_DATE_LOCALE, MatRippleModule } from '@angular/material/core'; -import { MatDatepickerModule } from '@angular/material/datepicker'; -import { MatDialogModule } from '@angular/material/dialog'; -import { MatExpansionModule } from '@angular/material/expansion'; -import { MatFormFieldModule } from '@angular/material/form-field'; -import { MatIconModule } from '@angular/material/icon'; -import { MatInputModule } from '@angular/material/input'; -import { MatListModule } from '@angular/material/list'; -import { MatMenuModule } from '@angular/material/menu'; -import { MatProgressBarModule } from '@angular/material/progress-bar'; -import { MatProgressSpinnerModule } from '@angular/material/progress-spinner'; -import { MatSlideToggleModule } from '@angular/material/slide-toggle'; -import { MatSnackBarModule } from '@angular/material/snack-bar'; -import { MatTabsModule } from '@angular/material/tabs'; -import { RouterModule } from '@angular/router'; -import { - ArrowBackIconComponent, - ButtonComponent, - FileUploadButtonComponent, - SpinnerIconComponent, - TooltipDirective, -} from '@ods/system'; -import { de } from 'date-fns/locale'; -import { AppIconComponent } from '../icon/app-icon/app-icon.component'; -import { PostfachIconComponent } from '../icon/postfach-icon/postfach-icon.component'; -import { HttpConnectionTimeoutInterceptor } from '../interceptor/http-connection-timeout.interceptor'; -import { HttpErrorInterceptor } from '../interceptor/http-error.interceptor'; -import { SnackbarCloseButtonComponent } from '../snackbar/snackbar-close-button/snackbar-close-button.component'; -import { SnackbarErrorComponent } from '../snackbar/snackbar-error/snackbar-error.component'; -import { SnackbarInfoComponent } from '../snackbar/snackbar-info/snackbar-info.component'; -import { AccordionComponent } from './accordion/accordion.component'; -import { BackButtonComponent } from './back-button/back-button.component'; -import { BasicDialogComponent } from './basic-dialog/basic-dialog.component'; -import { DownloadButtonComponent } from './download-button/download-button.component'; -import { AutocompleteEditorComponent } from './editor/autocomplete-editor/autocomplete-editor.component'; -import { CheckboxEnumEditorComponent } from './editor/checkbox-enum-editor/checkbox-enum-editor.component'; -import { DateEditorComponent } from './editor/date-editor/date-editor.component'; -import { FileUploadEditorComponent } from './editor/file-upload-editor/file-upload-editor.component'; -import { TextEditorComponent } from './editor/text-editor/text-editor.component'; -import { TextAreaEditorComponent } from './editor/textarea-editor/textarea-editor.component'; -import { ExpansionPanelComponent } from './expansion-panel/expansion-panel.component'; -import { FileUploadComponent } from './file-upload/file-upload.component'; -import { FixedDialogComponent } from './fixed-dialog/fixed-dialog.component'; -import { ConnectionTimeoutRetryDialogComponent } from './http-error-dialog/connection-timeout-retry-dialog/connection-timeout-retry-dialog.component'; -import { ConnectionTimeoutRetryFailDialogComponent } from './http-error-dialog/connection-timeout-retry-fail-dialog/connection-timeout-retry-fail-dialog.component'; -import { IconButtonWithSpinnerComponent } from './icon-button-with-spinner/icon-button-with-spinner.component'; -import { InternalServerErrorDialogComponent } from './notification/internal-server-error-dialog/internal-server-error-dialog.component'; -import { OpenUrlButtonComponent } from './open-url-button/open-url-button.component'; -import { OzgcloudButtonWithSpinnerComponent } from './ozgcloud-button/ozgcloud-button-with-spinner/ozgcloud-button-with-spinner.component'; -import { OzgcloudIconButtonPrimaryComponent } from './ozgcloud-button/ozgcloud-icon-button-primary/ozgcloud-icon-button-primary.component'; -import { OzgcloudStrokedButtonWithSpinnerComponent } from './ozgcloud-button/ozgcloud-stroked-button-with-spinner/ozgcloud-stroked-button-with-spinner.component'; -import { OzgcloudButtonContentComponent } from './ozgcloud-button/shared/ozgcloud-button-content/ozgcloud-button-content.component'; -import { OzgcloudIconComponent } from './ozgcloud-icon/ozgcloud-icon.component'; -import { OzgcloudMenuComponent } from './ozgcloud-menu/ozgcloud-menu.component'; -import { OzgcloudPasteTextButtonComponent } from './ozgcloud-paste-text-button/ozgcloud-paste-text-button.component'; -import { OzgcloudRoutingButtonComponent } from './ozgcloud-routing-button/ozgcloud-routing-button.component'; -import { OzgcloudSvgIconBigComponent } from './ozgcloud-svgicon-big/ozgcloud-svgicon-big.component'; -import { OzgcloudSvgIconComponent } from './ozgcloud-svgicon/ozgcloud-svgicon.component'; -import { ProgressBarComponent } from './progress-bar/progress-bar.component'; -import { SlideToggleComponent } from './slide-toggle/slide-toggle.component'; -import { SpinnerTransparencyComponent } from './spinner-transparency/spinner-transparency.component'; -import { SpinnerComponent } from './spinner/spinner.component'; -import { SubnavigationComponent } from './subnavigation/subnavigation.component'; -import { ValidationErrorComponent } from './validation-error/validation-error.component'; - -@NgModule({ - declarations: [ - SubnavigationComponent, - SpinnerComponent, - OzgcloudButtonWithSpinnerComponent, - OzgcloudStrokedButtonWithSpinnerComponent, - IconButtonWithSpinnerComponent, - ProgressBarComponent, - ExpansionPanelComponent, - SnackbarInfoComponent, - SnackbarErrorComponent, - FileUploadComponent, - DateEditorComponent, - TextEditorComponent, - TextAreaEditorComponent, - ValidationErrorComponent, - AutocompleteEditorComponent, - FixedDialogComponent, - InternalServerErrorDialogComponent, - FileUploadEditorComponent, - PostfachIconComponent, - AccordionComponent, - AppIconComponent, - SlideToggleComponent, - BackButtonComponent, - OzgcloudIconButtonPrimaryComponent, - OzgcloudIconComponent, - OzgcloudRoutingButtonComponent, - OzgcloudSvgIconComponent, - OzgcloudSvgIconBigComponent, - SpinnerTransparencyComponent, - OpenUrlButtonComponent, - DownloadButtonComponent, - ConnectionTimeoutRetryDialogComponent, - ConnectionTimeoutRetryFailDialogComponent, - SnackbarCloseButtonComponent, - BasicDialogComponent, - OzgcloudButtonContentComponent, - OzgcloudPasteTextButtonComponent, - CheckboxEnumEditorComponent, - OzgcloudMenuComponent, - ], - imports: [ - MatButtonModule, - MatIconModule, - MatProgressBarModule, - MatProgressSpinnerModule, - MatMenuModule, - MatSlideToggleModule, - MatExpansionModule, - MatRippleModule, - MatSnackBarModule, - MatCheckboxModule, - MatFormFieldModule, - MatInputModule, - MatListModule, - MatDatepickerModule, - MatDateFnsModule, - FormsModule, - ReactiveFormsModule, - MatAutocompleteModule, - MatDialogModule, - MatTabsModule, - MatBadgeModule, - CommonModule, - TechSharedModule, - RouterModule, - MatButtonToggleModule, - FileUploadButtonComponent, - SpinnerIconComponent, - TooltipDirective, - ButtonComponent, - ArrowBackIconComponent, - ], - exports: [ - MatButtonModule, - MatIconModule, - MatProgressBarModule, - MatProgressSpinnerModule, - MatMenuModule, - MatSlideToggleModule, - MatExpansionModule, - MatRippleModule, - MatSnackBarModule, - MatCheckboxModule, - MatFormFieldModule, - MatInputModule, - MatListModule, - MatDatepickerModule, - MatDateFnsModule, - FormsModule, - ReactiveFormsModule, - MatAutocompleteModule, - MatDialogModule, - MatTabsModule, - MatBadgeModule, - CommonModule, - TechSharedModule, - RouterModule, - MatButtonToggleModule, - SubnavigationComponent, - SpinnerComponent, - OzgcloudIconButtonPrimaryComponent, - OzgcloudButtonWithSpinnerComponent, - OzgcloudStrokedButtonWithSpinnerComponent, - IconButtonWithSpinnerComponent, - ProgressBarComponent, - ExpansionPanelComponent, - SnackbarInfoComponent, - SnackbarErrorComponent, - FileUploadComponent, - DateEditorComponent, - TextEditorComponent, - TextAreaEditorComponent, - ValidationErrorComponent, - AutocompleteEditorComponent, - FixedDialogComponent, - InternalServerErrorDialogComponent, - FileUploadEditorComponent, - PostfachIconComponent, - AccordionComponent, - AppIconComponent, - SlideToggleComponent, - BackButtonComponent, - OzgcloudIconComponent, - OzgcloudRoutingButtonComponent, - OzgcloudSvgIconComponent, - OzgcloudSvgIconBigComponent, - SpinnerTransparencyComponent, - OpenUrlButtonComponent, - DownloadButtonComponent, - ConnectionTimeoutRetryDialogComponent, - ConnectionTimeoutRetryFailDialogComponent, - SnackbarCloseButtonComponent, - BasicDialogComponent, - OzgcloudPasteTextButtonComponent, - CheckboxEnumEditorComponent, - FileUploadButtonComponent, - OzgcloudButtonContentComponent, - OzgcloudMenuComponent, - ], - providers: [ - { - provide: HTTP_INTERCEPTORS, - useClass: HttpErrorInterceptor, - multi: true, - }, - { - provide: HTTP_INTERCEPTORS, - useClass: HttpConnectionTimeoutInterceptor, - multi: true, - }, - { - provide: MAT_DATE_LOCALE, - useValue: de, - }, - { - provide: DateAdapter, - useClass: DateFnsAdapter, - deps: [MAT_DATE_LOCALE], - }, - ], -}) -export class UiModule {} diff --git a/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.html b/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.html index cdf207ba37ef266413d4dc72d8762f1a6e1e1913..673ecf065e1b890e163cf98fab0335c180bea627 100644 --- a/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.html +++ b/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.html @@ -1,26 +1,28 @@ <!-- - Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den - Ministerpräsidenten des Landes Schleswig-Holstein - Staatskanzlei - Abteilung Digitalisierung und zentrales IT-Management der Landesregierung +Copyright (C) 2023 Das Land Schleswig-Holstein vertreten durch den +Ministerpräsidenten des Landes Schleswig-Holstein +Staatskanzlei +Abteilung Digitalisierung und zentrales IT-Management der Landesregierung - Lizenziert unter der EUPL, Version 1.2 oder - sobald - diese von der Europäischen Kommission genehmigt wurden - - Folgeversionen der EUPL ("Lizenz"); - Sie dürfen dieses Werk ausschließlich gemäß - dieser Lizenz nutzen. - Eine Kopie der Lizenz finden Sie hier: +Lizenziert unter der EUPL, Version 1.2 oder - sobald +diese von der Europäischen Kommission genehmigt wurden - +Folgeversionen der EUPL ("Lizenz"); +Sie dürfen dieses Werk ausschließlich gemäß +dieser Lizenz nutzen. +Eine Kopie der Lizenz finden Sie hier: - https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 +https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12 - Sofern nicht durch anwendbare Rechtsvorschriften - gefordert oder in schriftlicher Form vereinbart, wird - die unter der Lizenz verbreitete Software "so wie sie - ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - - ausdrücklich oder stillschweigend - verbreitet. - Die sprachspezifischen Genehmigungen und Beschränkungen - unter der Lizenz sind dem Lizenztext zu entnehmen. +Sofern nicht durch anwendbare Rechtsvorschriften +gefordert oder in schriftlicher Form vereinbart, wird +die unter der Lizenz verbreitete Software "so wie sie +ist", OHNE JEGLICHE GEWÄHRLEISTUNG ODER BEDINGUNGEN - +ausdrücklich oder stillschweigend - verbreitet. +Die sprachspezifischen Genehmigungen und Beschränkungen +unter der Lizenz sind dem Lizenztext zu entnehmen. --> -<span *ngFor="let invalidParam of invalidParams">{{ message(invalidParam) }}</span> +@for (invalidParam of invalidParams; track invalidParam) { + <span>{{ message(invalidParam) }}</span> +} diff --git a/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.spec.ts b/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.spec.ts index 0b265b44ec24e326187ef0b8605fcf1a7f8f688e..2e851164cb169a9e9c085c4b1e2ca483a970d921 100644 --- a/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.spec.ts +++ b/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.spec.ts @@ -33,7 +33,7 @@ describe('ValidationErrorComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [ValidationErrorComponent], + imports: [ValidationErrorComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.ts b/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.ts index 285a9989ed250d9f14f62a7b2a8b5bc7834b907c..eae4c1e99487d7fe169a73fee93d07af75f55676 100644 --- a/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.ts +++ b/alfa-client/libs/ui/src/lib/ui/validation-error/validation-error.component.ts @@ -28,6 +28,7 @@ import { Component, Input } from '@angular/core'; selector: 'ozgcloud-validation-error', templateUrl: './validation-error.component.html', styleUrls: ['./validation-error.component.scss'], + standalone: true, }) export class ValidationErrorComponent { @Input() label: string; diff --git a/alfa-client/libs/user-assistance/src/lib/help-menu/documentation/open-documentation-button/open-documentation-button.component.html b/alfa-client/libs/user-assistance/src/lib/help-menu/documentation/open-documentation-button/open-documentation-button.component.html index 0179cbc7aac26bf1464207fa7557006d3294e87a..d3f460b90b5c7c7232d01e2b4e0674ddee2a8a8c 100644 --- a/alfa-client/libs/user-assistance/src/lib/help-menu/documentation/open-documentation-button/open-documentation-button.component.html +++ b/alfa-client/libs/user-assistance/src/lib/help-menu/documentation/open-documentation-button/open-documentation-button.component.html @@ -29,4 +29,4 @@ [targetName]="'_blank'" [tooltip]="'Öffnet in einem neuen Tab'" data-test-id="open-documentation-button" -></ozgcloud-open-url-button> +/> diff --git a/alfa-client/libs/user-assistance/src/lib/help-menu/help-menu.component.spec.ts b/alfa-client/libs/user-assistance/src/lib/help-menu/help-menu.component.spec.ts index ba0e572d4edad3c8e610cd869d31b40b186d8d5d..870deee5a210330b9a267bac71c674ddce7e3ae0 100644 --- a/alfa-client/libs/user-assistance/src/lib/help-menu/help-menu.component.spec.ts +++ b/alfa-client/libs/user-assistance/src/lib/help-menu/help-menu.component.spec.ts @@ -24,8 +24,9 @@ import { ApiRootLinkRel } from '@alfa-client/api-root-shared'; import { GetUrlPipe, HasLinkPipe, createStateResource } from '@alfa-client/tech-shared'; import { getElementFromDomRoot } from '@alfa-client/test-utils'; -import { UiModule } from '@alfa-client/ui'; +import { OzgcloudIconComponent, OzgcloudMenuComponent } from '@alfa-client/ui'; import { ComponentFixture, TestBed } from '@angular/core/testing'; +import { MatMenuTrigger } from '@angular/material/menu'; import { NoopAnimationsModule } from '@angular/platform-browser/animations'; import { DropdownMenuComponent, @@ -34,9 +35,9 @@ import { FileIconComponent, HelpIconComponent, } from '@ods/system'; +import { createApiRootResource } from 'libs/api-root-shared/test/api-root'; import { getDataTestIdOf } from 'libs/tech-shared/test/data-test'; import { MockComponent } from 'ng-mocks'; -import { createApiRootResource } from '../../../../../libs/api-root-shared/test/api-root'; import { DocumentationComponent } from './documentation/documentation.component'; import { HelpButtonComponent } from './help-button/help-button.component'; import { HelpMenuComponent } from './help-menu.component'; @@ -54,6 +55,10 @@ describe('HelpMenuComponent', () => { HelpMenuComponent, HasLinkPipe, GetUrlPipe, + MatMenuTrigger, + MockComponent(OzgcloudMenuComponent), + MockComponent(DocumentationComponent), + MockComponent(OzgcloudIconComponent), MockComponent(DocumentationComponent), MockComponent(FileIconComponent), MockComponent(HelpIconComponent), @@ -62,7 +67,7 @@ describe('HelpMenuComponent', () => { MockComponent(DropdownMenuLinkItemComponent), MockComponent(HelpButtonComponent), ], - imports: [NoopAnimationsModule, UiModule], + imports: [NoopAnimationsModule], }).compileComponents(); fixture = TestBed.createComponent(HelpMenuComponent); diff --git a/alfa-client/libs/user-assistance/src/lib/user-assistance.module.ts b/alfa-client/libs/user-assistance/src/lib/user-assistance.module.ts index 1eda492b4fe8af82af049e37d1548a419912e98f..63fc01ce61325ce4935a8292df7314a550e83940 100644 --- a/alfa-client/libs/user-assistance/src/lib/user-assistance.module.ts +++ b/alfa-client/libs/user-assistance/src/lib/user-assistance.module.ts @@ -21,9 +21,8 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; import { CommonModule } from '@angular/common'; +import { GetUrlPipe, HasLinkPipe } from '@alfa-client/tech-shared'; import { NgModule } from '@angular/core'; import { DropdownMenuComponent, @@ -32,21 +31,27 @@ import { FileIconComponent, HelpIconComponent, } from '@ods/system'; +import { MatFabButton } from '@angular/material/button'; +import { MatMenuTrigger } from '@angular/material/menu'; import { DocumentationComponent } from './help-menu/documentation/documentation.component'; import { OpenDocumentationButtonComponent } from './help-menu/documentation/open-documentation-button/open-documentation-button.component'; import { HelpButtonComponent } from './help-menu/help-button/help-button.component'; import { HelpMenuComponent } from './help-menu/help-menu.component'; +import { OpenUrlButtonComponent } from '@alfa-client/ui'; @NgModule({ imports: [ CommonModule, - TechSharedModule, + MatMenuTrigger, + HasLinkPipe, + GetUrlPipe, + MatFabButton, FileIconComponent, HelpIconComponent, DropdownMenuComponent, DropdownMenuTextItemComponent, - UiModule, DropdownMenuLinkItemComponent, + OpenUrlButtonComponent, ], declarations: [HelpMenuComponent, DocumentationComponent, OpenDocumentationButtonComponent, HelpButtonComponent], exports: [HelpMenuComponent], diff --git a/alfa-client/libs/user-profile-shared/src/lib/user-profile.repository.spec.ts b/alfa-client/libs/user-profile-shared/src/lib/user-profile.repository.spec.ts index 844d2d4ad75212bd6cd5eb3bc6ab48b5c2b84409..9b9cc5c3f622ddf766e1a43eaccbf21ea1620efc 100644 --- a/alfa-client/libs/user-profile-shared/src/lib/user-profile.repository.spec.ts +++ b/alfa-client/libs/user-profile-shared/src/lib/user-profile.repository.spec.ts @@ -22,7 +22,7 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { ApiRootLinkRel, ApiRootResource } from '@alfa-client/api-root-shared'; -import { HttpErrorHandler, TechSharedModule } from '@alfa-client/tech-shared'; +import { HttpErrorHandler } from '@alfa-client/tech-shared'; import { mock, mockClass, useFromMock } from '@alfa-client/test-utils'; import { VorgangHeaderLinkRel, @@ -33,10 +33,8 @@ import { import { ResourceFactory } from '@ngxp/rest'; import { cold, hot } from 'jest-marbles'; import { createApiRootResource } from 'libs/api-root-shared/test/api-root'; -import { - createVorgangResource, - createVorgangWithEingangResource, -} from 'libs/vorgang-shared/test/vorgang'; +import { InjectorService } from 'libs/tech-shared/src/lib/injector/injector.service'; +import { createVorgangResource, createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang'; import { createUserProfileListResource, createUserProfileResource } from '../../test/user-profile'; import { UserProfileListResource, UserProfileResource } from './user-profile.model'; import { UserProfileRepository } from './user-profile.repository'; @@ -51,7 +49,7 @@ describe('User profile repository', () => { const userProfile: UserProfileResource = createUserProfileResource(); beforeEach(() => { - const classMock = mockClass(TechSharedModule); + const classMock = mockClass(InjectorService); classMock.injector = <any>{ get: () => useFromMock(mock(HttpErrorHandler)) }; repository = new UserProfileRepository(useFromMock(resourceFactory)); diff --git a/alfa-client/libs/user-profile/src/lib/user-profile-in-header-container/user-profile-in-header/user-profile-in-header.component.spec.ts b/alfa-client/libs/user-profile/src/lib/user-profile-in-header-container/user-profile-in-header/user-profile-in-header.component.spec.ts index 1f91ba4533ee9c3ee1b09102a7df8deb9de9b849..ab53c008163ee44d5f785b065da91de6f203363c 100644 --- a/alfa-client/libs/user-profile/src/lib/user-profile-in-header-container/user-profile-in-header/user-profile-in-header.component.spec.ts +++ b/alfa-client/libs/user-profile/src/lib/user-profile-in-header-container/user-profile-in-header/user-profile-in-header.component.spec.ts @@ -28,6 +28,7 @@ import { getUserName, UserProfileResource } from '@alfa-client/user-profile-shar import { EventEmitter } from '@angular/core'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { MatIcon } from '@angular/material/icon'; +import { MatMenuTrigger } from '@angular/material/menu'; import { NoopAnimationsModule } from '@angular/platform-browser/animations'; import { DropdownMenuButtonItemComponent, DropdownMenuComponent, LogoutIconComponent } from '@ods/system'; import { getDataTestIdAttributeOf, getDataTestIdOf } from 'libs/tech-shared/test/data-test'; @@ -49,6 +50,7 @@ describe('UserProfileInHeaderComponent', () => { declarations: [ UserProfileInHeaderComponent, MatIcon, + MatMenuTrigger, MockComponent(UserIconComponent), MockComponent(DropdownMenuComponent), MockComponent(DropdownMenuButtonItemComponent), diff --git a/alfa-client/libs/user-profile/src/lib/user-profile-in-vorgang-container/user-profile-in-vorgang/user-profile-button-container/user-profile-button-container.component.spec.ts b/alfa-client/libs/user-profile/src/lib/user-profile-in-vorgang-container/user-profile-in-vorgang/user-profile-button-container/user-profile-button-container.component.spec.ts index e8c3f33af47eabac0cc2b88028a83637a92384b1..9d67b5fbb32f740a2ae6928d0126bf1a1ac8def9 100644 --- a/alfa-client/libs/user-profile/src/lib/user-profile-in-vorgang-container/user-profile-in-vorgang/user-profile-button-container/user-profile-button-container.component.spec.ts +++ b/alfa-client/libs/user-profile/src/lib/user-profile-in-vorgang-container/user-profile-in-vorgang/user-profile-button-container/user-profile-button-container.component.spec.ts @@ -23,9 +23,9 @@ */ import { createEmptyStateResource, StateResource } from '@alfa-client/tech-shared'; import { mock } from '@alfa-client/test-utils'; -import { UiModule } from '@alfa-client/ui'; import { UserProfileResource, UserProfileService } from '@alfa-client/user-profile-shared'; import { ComponentFixture, TestBed } from '@angular/core/testing'; +import { MatMenuTrigger } from '@angular/material/menu'; import { MockComponent } from 'ng-mocks'; import { BehaviorSubject } from 'rxjs'; import { OzgcloudMenuComponent } from '../../../../../../ui/src/lib/ui/ozgcloud-menu/ozgcloud-menu.component'; @@ -47,6 +47,7 @@ describe('UserProfileButtonContainerComponent', () => { TestBed.configureTestingModule({ declarations: [ UserProfileButtonContainerComponent, + MatMenuTrigger, MockComponent(UserIconComponent), MockComponent(UserProfileSearchContainerComponent), MockComponent(OzgcloudMenuComponent), @@ -57,7 +58,6 @@ describe('UserProfileButtonContainerComponent', () => { useValue: userProfileService, }, ], - imports: [UiModule], }); }); diff --git a/alfa-client/libs/user-profile/src/lib/user-profile.module.ts b/alfa-client/libs/user-profile/src/lib/user-profile.module.ts index 408ace4cfbf611228fe69933743b717961982f55..0f595e41c37ed96b7e0084656973cf7c4fc7dfa0 100644 --- a/alfa-client/libs/user-profile/src/lib/user-profile.module.ts +++ b/alfa-client/libs/user-profile/src/lib/user-profile.module.ts @@ -21,11 +21,20 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { HasLinkPipe } from '@alfa-client/tech-shared'; +import { + AutocompleteEditorComponent, + IconButtonWithSpinnerComponent, + OzgcloudMenuComponent, + SpinnerComponent, +} from '@alfa-client/ui'; import { UserProfileSharedModule } from '@alfa-client/user-profile-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; +import { ReactiveFormsModule } from '@angular/forms'; +import { MatIcon } from '@angular/material/icon'; +import { MatMenuTrigger } from '@angular/material/menu'; +import { MatTooltip } from '@angular/material/tooltip'; import { RouterModule } from '@angular/router'; import { ButtonWithSpinnerComponent } from '@ods/component'; import { @@ -61,13 +70,20 @@ import { UserProfileComponent } from './user-profile/user-profile.component'; @NgModule({ imports: [ CommonModule, - TechSharedModule, - UiModule, UserProfileSharedModule, RouterModule, OdsUserIconComponent, LogoutIconComponent, ErrorIconComponent, + IconButtonWithSpinnerComponent, + HasLinkPipe, + MatTooltip, + SpinnerComponent, + MatMenuTrigger, + OzgcloudMenuComponent, + MatIcon, + AutocompleteEditorComponent, + ReactiveFormsModule, DropdownMenuComponent, DropdownMenuItemComponent, DropdownMenuButtonItemComponent, diff --git a/alfa-client/libs/user-settings/src/lib/user-settings-container/user-settings/user-settings.component.spec.ts b/alfa-client/libs/user-settings/src/lib/user-settings-container/user-settings/user-settings.component.spec.ts index de1ccc1a69c0a17b62d37208226bc6ca96feb68c..f40d240d635937892fe39335610f9f599986b724 100644 --- a/alfa-client/libs/user-settings/src/lib/user-settings-container/user-settings/user-settings.component.spec.ts +++ b/alfa-client/libs/user-settings/src/lib/user-settings-container/user-settings/user-settings.component.spec.ts @@ -22,7 +22,6 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { HasLinkPipe, createEmptyStateResource } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { NoopAnimationsModule } from '@angular/platform-browser/animations'; import { DropdownMenuComponent } from '@ods/system'; @@ -37,7 +36,7 @@ describe('UserSettingsComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - imports: [NoopAnimationsModule, UiModule], + imports: [NoopAnimationsModule], declarations: [ HasLinkPipe, UserSettingsComponent, diff --git a/alfa-client/libs/user-settings/src/lib/user-settings.module.ts b/alfa-client/libs/user-settings/src/lib/user-settings.module.ts index bafeb748dc5a3c6c145397e031924740372c07be..fce1e22c3ef1c4ba98c956b33bd3504545dc49ae 100644 --- a/alfa-client/libs/user-settings/src/lib/user-settings.module.ts +++ b/alfa-client/libs/user-settings/src/lib/user-settings.module.ts @@ -21,7 +21,8 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { UiModule } from '@alfa-client/ui'; +import { HasLinkPipe } from '@alfa-client/tech-shared'; +import { SlideToggleComponent } from '@alfa-client/ui'; import { UserSettingsSharedModule } from '@alfa-client/user-settings-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; @@ -35,7 +36,15 @@ import { UserSettingsEmailBenachrichtigungComponent } from './user-settings-cont import { UserSettingsComponent } from './user-settings-container/user-settings/user-settings.component'; @NgModule({ - imports: [CommonModule, UiModule, UserSettingsSharedModule, DropdownMenuComponent, CloseIconComponent, SettingsIconComponent], + imports: [ + CommonModule, + UserSettingsSharedModule, + DropdownMenuComponent, + CloseIconComponent, + SettingsIconComponent, + SlideToggleComponent, + HasLinkPipe, + ], declarations: [ UserSettingsContainerComponent, UserSettingsEmailBenachrichtigungComponent, diff --git a/alfa-client/libs/vorgang-detail/src/lib/aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component.spec.ts b/alfa-client/libs/vorgang-detail/src/lib/aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component.spec.ts index ebf2fa64f17b56d95828a63bb475020d4178ab76..174d105fae1120efbb26eee2df3cd12c779db4a5 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component.spec.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component.spec.ts @@ -21,45 +21,28 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { AktenzeichenEditDialogComponent } from './aktenzeichen-edit-dialog.component'; -import { ComponentFixture, TestBed } from '@angular/core/testing'; +import { COMMAND_ERROR_MESSAGES, CommandErrorMessage, hasCommandError, isSuccessfulDone } from '@alfa-client/command-shared'; +import { createEmptyStateResource, hasContent, isClipboardReadSupported } from '@alfa-client/tech-shared'; import { mock } from '@alfa-client/test-utils'; import { OzgcloudPasteTextButtonComponent, OzgcloudStrokedButtonWithSpinnerComponent, + OzgcloudTextEditorComponent, SnackBarService, - TextEditorComponent, } from '@alfa-client/ui'; -import { MockComponent, MockDirective } from 'ng-mocks'; import { VorgangService } from '@alfa-client/vorgang-shared'; -import { - MAT_DIALOG_DATA, - MatDialogActions, - MatDialogContent, - MatDialogRef, -} from '@angular/material/dialog'; +import { ComponentFixture, TestBed } from '@angular/core/testing'; +import { FormBuilder, ReactiveFormsModule, UntypedFormControl } from '@angular/forms'; +import { MAT_DIALOG_DATA, MatDialogActions, MatDialogContent, MatDialogRef } from '@angular/material/dialog'; import { MatIcon } from '@angular/material/icon'; +import { cold, hot } from 'jest-marbles'; import { createVorgangWithEingangResource } from 'libs/vorgang-shared/test/vorgang'; -import { - createEmptyStateResource, - hasContent, - isClipboardReadSupported, -} from '@alfa-client/tech-shared'; +import { MockComponent, MockDirective } from 'ng-mocks'; import { EMPTY, NEVER } from 'rxjs'; -import { FormBuilder, ReactiveFormsModule, UntypedFormControl } from '@angular/forms'; -import { cold, hot } from 'jest-marbles'; -import { - createCommandErrorResource, - createCommandResource, -} from '../../../../command-shared/test/command'; -import { - COMMAND_ERROR_MESSAGES, - CommandErrorMessage, - hasCommandError, - isSuccessfulDone, -} from '@alfa-client/command-shared'; -import { AktenzeichenEditDialogMessages } from './aktenzeichen-edit-dialog.message'; +import { createCommandErrorResource, createCommandResource } from '../../../../command-shared/test/command'; +import { AktenzeichenEditDialogComponent } from './aktenzeichen-edit-dialog.component'; import { AktenzeichenEditDialogFormservice } from './aktenzeichen-edit-dialog.formservice'; +import { AktenzeichenEditDialogMessages } from './aktenzeichen-edit-dialog.message'; jest.mock('@alfa-client/tech-shared'); const isClipboardReadSupportedMock = isClipboardReadSupported as jest.Mock; @@ -99,7 +82,7 @@ describe('AktenzeichenEditDialogComponent', () => { MockDirective(MatDialogContent), MockDirective(MatDialogActions), MockComponent(MatIcon), - MockComponent(TextEditorComponent), + MockComponent(OzgcloudTextEditorComponent), MockComponent(OzgcloudPasteTextButtonComponent), MockComponent(OzgcloudStrokedButtonWithSpinnerComponent), ], diff --git a/alfa-client/libs/vorgang-detail/src/lib/aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component.ts b/alfa-client/libs/vorgang-detail/src/lib/aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component.ts index 79dce7d7da127e4e47ae8086e912dcba4d95b8ae..35789e92ba4c39d3dda980b3450d5f27fff0d73c 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component.ts @@ -21,40 +21,27 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { - COMMAND_ERROR_MESSAGES, - CommandResource, - hasCommandError, - isSuccessfulDone, -} from '@alfa-client/command-shared'; -import { - createEmptyStateResource, - hasContent, - isClipboardReadSupported, - StateResource, -} from '@alfa-client/tech-shared'; +import { COMMAND_ERROR_MESSAGES, CommandResource, hasCommandError, isSuccessfulDone } from '@alfa-client/command-shared'; +import { createEmptyStateResource, hasContent, isClipboardReadSupported, StateResource } from '@alfa-client/tech-shared'; import { SnackBarService } from '@alfa-client/ui'; import { VorgangService, VorgangWithEingangResource } from '@alfa-client/vorgang-shared'; import { Component, Inject, OnInit } from '@angular/core'; +import { UntypedFormGroup } from '@angular/forms'; import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog'; import { map, Observable, of, startWith, tap } from 'rxjs'; import { AktenzeichenEditDialogData } from './aktenzeichen-edit-dialog.data'; -import { AktenzeichenEditDialogMessages } from './aktenzeichen-edit-dialog.message'; -import { UntypedFormGroup } from '@angular/forms'; import { AktenzeichenEditDialogFormservice } from './aktenzeichen-edit-dialog.formservice'; +import { AktenzeichenEditDialogMessages } from './aktenzeichen-edit-dialog.message'; @Component({ selector: 'alfa-aktenzeichen-edit-dialog', templateUrl: './aktenzeichen-edit-dialog.component.html', styleUrls: ['./aktenzeichen-edit-dialog.component.scss'], - providers: [AktenzeichenEditDialogFormservice], }) export class AktenzeichenEditDialogComponent implements OnInit { vorgang: VorgangWithEingangResource; - setAktenzeichenPending$: Observable<StateResource<CommandResource>> = of( - createEmptyStateResource<CommandResource>(), - ); + setAktenzeichenPending$: Observable<StateResource<CommandResource>> = of(createEmptyStateResource<CommandResource>()); hasAktenzeichen$: Observable<boolean>; isPasteSupported = false; @@ -73,10 +60,7 @@ export class AktenzeichenEditDialogComponent implements OnInit { ngOnInit(): void { this.isPasteSupported = isClipboardReadSupported(); this.formService.setAktenzeichen(this.vorgang.aktenzeichen); - this.hasAktenzeichen$ = this.formService - .valueChanges() - .pipe(startWith(this.vorgang.aktenzeichen)) - .pipe(map(hasContent)); + this.hasAktenzeichen$ = this.formService.valueChanges().pipe(startWith(this.vorgang.aktenzeichen)).pipe(map(hasContent)); } public onCancel(): void { @@ -88,11 +72,7 @@ export class AktenzeichenEditDialogComponent implements OnInit { this.setAktenzeichenPending$ = this.formService .submit() .pipe(startWith(createEmptyStateResource<CommandResource>(true))) - .pipe( - tap((commandStateResource: StateResource<CommandResource>) => - this.onResponse(commandStateResource.resource), - ), - ); + .pipe(tap((commandStateResource: StateResource<CommandResource>) => this.onResponse(commandStateResource.resource))); } onResponse(commandResource: CommandResource) { @@ -111,10 +91,7 @@ export class AktenzeichenEditDialogComponent implements OnInit { } getErrorMessage(commandResource: CommandResource): string { - return ( - COMMAND_ERROR_MESSAGES[commandResource.errorMessage] || - AktenzeichenEditDialogMessages.SET_FAILED - ); + return COMMAND_ERROR_MESSAGES[commandResource.errorMessage] || AktenzeichenEditDialogMessages.SET_FAILED; } paste(clipboardContent: string) { diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden-steps/vorgang-detail-bescheiden-steps-content/vorgang-detail-bescheiden-dokumente-hinzufuegen/vorgang-detail-bescheiden-dokument-hochladen/vorgang-detail-bescheiden-dokument-hochladen.component.spec.ts b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden-steps/vorgang-detail-bescheiden-steps-content/vorgang-detail-bescheiden-dokumente-hinzufuegen/vorgang-detail-bescheiden-dokument-hochladen/vorgang-detail-bescheiden-dokument-hochladen.component.spec.ts index 471467b8ea09fd329b97ba5a71b353556501d909..5b089dac014abc5a0da5991e964ba167b50edcf9 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden-steps/vorgang-detail-bescheiden-steps-content/vorgang-detail-bescheiden-dokumente-hinzufuegen/vorgang-detail-bescheiden-dokument-hochladen/vorgang-detail-bescheiden-dokument-hochladen.component.spec.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail-page/vorgang-detail-bescheiden/vorgang-detail-bescheiden-steps/vorgang-detail-bescheiden-steps-content/vorgang-detail-bescheiden-dokumente-hinzufuegen/vorgang-detail-bescheiden-dokument-hochladen/vorgang-detail-bescheiden-dokument-hochladen.component.spec.ts @@ -22,7 +22,7 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { BescheidService } from '@alfa-client/bescheid-shared'; -import { HasLinkPipe, TechSharedModule } from '@alfa-client/tech-shared'; +import { HasLinkPipe } from '@alfa-client/tech-shared'; import { Mock, mock, useFromMock } from '@alfa-client/test-utils'; import { ComponentFixture, TestBed } from '@angular/core/testing'; import { ReactiveFormsModule, UntypedFormBuilder } from '@angular/forms'; @@ -59,7 +59,7 @@ describe('VorgangDetailBescheidenDokumentHochladenComponent', () => { MockComponent(SingleFileUploadEditorComponent), MockComponent(SpinnerIconComponent), ], - imports: [ReactiveFormsModule, TechSharedModule], + imports: [ReactiveFormsModule], providers: [ { provide: BescheidenFormService, @@ -119,10 +119,7 @@ describe('VorgangDetailBescheidenDokumentHochladenComponent', () => { component.uploadFile(file); - expect(bescheidService.uploadBescheidDocument).toHaveBeenCalledWith( - bescheidStateResource.resource, - file, - ); + expect(bescheidService.uploadBescheidDocument).toHaveBeenCalledWith(bescheidStateResource.resource, file); }); }); }); diff --git a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail.module.ts b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail.module.ts index 32aba2314074dfd4c1db59679594e9cd00767f4e..cd9df94996e413452d38811bdde387db2224cf3d 100644 --- a/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail.module.ts +++ b/alfa-client/libs/vorgang-detail/src/lib/vorgang-detail.module.ts @@ -31,8 +31,22 @@ import { LoeschAnforderungModule } from '@alfa-client/loesch-anforderung'; import { LoeschAnforderungSharedModule } from '@alfa-client/loesch-anforderung-shared'; import { PostfachModule } from '@alfa-client/postfach'; import { PostfachSharedModule } from '@alfa-client/postfach-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { ConvertForDataTestPipe, ConvertProblemDetailToErrorMessagesPipe, HasLinkPipe } from '@alfa-client/tech-shared'; +import { + BackButtonComponent, + DateEditorComponent, + ExpansionPanelComponent, + IconButtonWithSpinnerComponent, + OzgcloudIconButtonPrimaryComponent, + OzgcloudIconComponent, + OzgcloudMenuComponent, + OzgcloudPasteTextButtonComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + OzgcloudTextEditorComponent, + SpinnerComponent, + SpinnerTransparencyComponent, + SubnavigationComponent, +} from '@alfa-client/ui'; import { UserProfileModule } from '@alfa-client/user-profile'; import { UserProfileSharedModule } from '@alfa-client/user-profile-shared'; import { VorgangSharedModule } from '@alfa-client/vorgang-shared'; @@ -40,13 +54,18 @@ import { VorgangSharedUiModule } from '@alfa-client/vorgang-shared-ui'; import { WiedervorlageModule } from '@alfa-client/wiedervorlage'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; +import { ReactiveFormsModule } from '@angular/forms'; +import { MatDialogActions, MatDialogContent } from '@angular/material/dialog'; +import { MatIcon } from '@angular/material/icon'; +import { MatMenuTrigger } from '@angular/material/menu'; +import { MatTab, MatTabGroup } from '@angular/material/tabs'; import { RouterModule, Routes } from '@angular/router'; import { ButtonWithSpinnerComponent, FileUploadEditorComponent, SingleFileUploadEditorComponent, - TextEditorComponent, TextareaEditorComponent, + TextEditorComponent, } from '@ods/component'; import { ArchiveIconComponent, @@ -76,6 +95,8 @@ import { TooltipDirective, UndoIconComponent, } from '@ods/system'; +import { NotHasAnyLinkPipe } from '../../../tech-shared/src/lib/pipe/not-has-any-link.pipe'; +import { ProgressBarComponent } from '../../../ui/src/lib/ui/progress-bar/progress-bar.component'; import { AktenzeichenEditDialogComponent } from './aktenzeichen-edit-dialog/aktenzeichen-edit-dialog.component'; import { AktenzeichenEditableComponent } from './aktenzeichen-editable/aktenzeichen-editable.component'; import { AbschliessenButtonComponent } from './buttons/abschliessen-button/abschliessen-button.component'; @@ -141,8 +162,6 @@ const routes: Routes = [ CommonModule, RouterModule.forChild(routes), VorgangSharedModule, - UiModule, - TechSharedModule, WiedervorlageModule, BinaryFileModule, ForwardingModule, @@ -182,6 +201,31 @@ const routes: Routes = [ ArchiveIconComponent, CheckCircleIconComponent, CheckIconComponent, + MatDialogContent, + ReactiveFormsModule, + MatIcon, + OzgcloudPasteTextButtonComponent, + MatDialogActions, + OzgcloudStrokedButtonWithSpinnerComponent, + OzgcloudIconButtonPrimaryComponent, + HasLinkPipe, + IconButtonWithSpinnerComponent, + ExpansionPanelComponent, + MatTabGroup, + MatTab, + NotHasAnyLinkPipe, + BackButtonComponent, + ConvertForDataTestPipe, + ConvertProblemDetailToErrorMessagesPipe, + DateEditorComponent, + MatMenuTrigger, + OzgcloudIconComponent, + OzgcloudMenuComponent, + SubnavigationComponent, + ProgressBarComponent, + SpinnerTransparencyComponent, + SpinnerComponent, + OzgcloudTextEditorComponent, DropdownMenuComponent, DropdownMenuTextItemComponent, MoreIconComponent, diff --git a/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-shared-ui.module.ts b/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-shared-ui.module.ts index a6549aff7c59fa5979d55f7fbb7bb130b9c068fc..1624a507647c7817aece4450f2a4067d9b6b75af 100644 --- a/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-shared-ui.module.ts +++ b/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-shared-ui.module.ts @@ -21,11 +21,22 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { + ConvertForDataTestPipe, + EnumToLabelPipe, + FormatToPrettyDatePipe, + HasLinkPipe, + ToEmbeddedResourcesPipe, +} from '@alfa-client/tech-shared'; +import { OzgcloudSvgIconComponent, SpinnerComponent } from '@alfa-client/ui'; import { VorgangSharedModule } from '@alfa-client/vorgang-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; +import { ReactiveFormsModule } from '@angular/forms'; +import { MatAutocomplete, MatAutocompleteTrigger, MatOption } from '@angular/material/autocomplete'; +import { MatFormField, MatFormFieldModule } from '@angular/material/form-field'; +import { MatIcon, MatIconModule } from '@angular/material/icon'; +import { MatInputModule } from '@angular/material/input'; import { RouterModule } from '@angular/router'; import { TooltipDirective } from '@ods/system'; import { AktenzeichenComponent } from './aktenzeichen/aktenzeichen.component'; @@ -39,7 +50,28 @@ import { VorgangStatusTextComponent } from './vorgang-status-text/vorgang-status import { WiedervorlageIconComponent } from './wiedervorlage-icon/wiedervorlage-icon.component'; @NgModule({ - imports: [CommonModule, VorgangSharedModule, UiModule, RouterModule, TechSharedModule, TooltipDirective], + imports: [ + CommonModule, + VorgangSharedModule, + RouterModule, + FormatToPrettyDatePipe, + MatIcon, + MatIconModule, + MatInputModule, + MatFormField, + MatFormFieldModule, + ReactiveFormsModule, + MatAutocompleteTrigger, + MatAutocomplete, + SpinnerComponent, + MatOption, + ToEmbeddedResourcesPipe, + HasLinkPipe, + ConvertForDataTestPipe, + EnumToLabelPipe, + OzgcloudSvgIconComponent, + TooltipDirective, + ], declarations: [ VorgangSearchContainerComponent, VorgangSearchComponent, diff --git a/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-status-dot/vorgang-status-dot.component.spec.ts b/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-status-dot/vorgang-status-dot.component.spec.ts index fc9be609db475e87f46dad098cf66db0129cef8e..9b833b88003f980053c56d8787bd94dfbe46aab2 100644 --- a/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-status-dot/vorgang-status-dot.component.spec.ts +++ b/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-status-dot/vorgang-status-dot.component.spec.ts @@ -21,9 +21,9 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { ComponentFixture, TestBed } from '@angular/core/testing'; import { EnumToLabelPipe } from '@alfa-client/tech-shared'; import { VorgangResource } from '@alfa-client/vorgang-shared'; +import { ComponentFixture, TestBed } from '@angular/core/testing'; import { getDataTestIdOf } from 'libs/tech-shared/test/data-test'; import { createVorgangResource } from 'libs/vorgang-shared/test/vorgang'; import { VorgangStatusDotComponent } from './vorgang-status-dot.component'; @@ -37,7 +37,8 @@ describe('VorgangStatusDotComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [VorgangStatusDotComponent, EnumToLabelPipe], + imports: [EnumToLabelPipe], + declarations: [VorgangStatusDotComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-status-text/vorgang-status-text.component.spec.ts b/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-status-text/vorgang-status-text.component.spec.ts index c49336ccf22b1bb28fdbe874b9f898f9d1b21cf7..ec5f8e7063df5a226688de7e69752b20d5d17696 100644 --- a/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-status-text/vorgang-status-text.component.spec.ts +++ b/alfa-client/libs/vorgang-shared-ui/src/lib/vorgang-status-text/vorgang-status-text.component.spec.ts @@ -37,7 +37,8 @@ describe('VorgangStatusTextComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [EnumToLabelPipe, VorgangStatusTextComponent], + imports: [EnumToLabelPipe], + declarations: [VorgangStatusTextComponent], }).compileComponents(); }); diff --git a/alfa-client/libs/vorgang-shared/src/lib/+state/vorgang.repository.spec.ts b/alfa-client/libs/vorgang-shared/src/lib/+state/vorgang.repository.spec.ts index fa699a030e07f79ddd830ef5b171ce14be24cdc3..f322aa355155dfd54fc231023a4f7b349382b1b4 100644 --- a/alfa-client/libs/vorgang-shared/src/lib/+state/vorgang.repository.spec.ts +++ b/alfa-client/libs/vorgang-shared/src/lib/+state/vorgang.repository.spec.ts @@ -21,34 +21,22 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { HttpClient, HttpHeaders, HttpResponse } from '@angular/common/http'; import { ApiRootLinkRel, ApiRootResource } from '@alfa-client/api-root-shared'; -import { - ContentType, - GetRequestOptions, - HttpErrorHandler, - HttpHeader, -} from '@alfa-client/tech-shared'; +import { BlobWithFileName, ContentType, GetRequestOptions, HttpErrorHandler, HttpHeader } from '@alfa-client/tech-shared'; import { mock, mockClass, useFromMock } from '@alfa-client/test-utils'; +import { HttpClient, HttpHeaders, HttpResponse } from '@angular/common/http'; import { LinkRel, ResourceFactory, ResourceUri, getUrl } from '@ngxp/rest'; -import { cold, hot } from 'jest-marbles'; import { createApiRootResource } from 'libs/api-root-shared/test/api-root'; -import { TechSharedModule } from 'libs/tech-shared/src/lib/tech-shared.module'; +import { InjectorService } from 'libs/tech-shared/src/lib/injector/injector.service'; import { createVorgangListResource, createVorgangResource, createVorgangWithEingangResource, } from 'libs/vorgang-shared/test/vorgang'; -import { - VorgangHeaderLinkRel, - VorgangListLinkRel, - VorgangWithEingangLinkRel, -} from './../vorgang.linkrel'; -import { - VorgangListResource, - VorgangResource, - VorgangWithEingangResource, -} from './../vorgang.model'; +import { Observable } from 'rxjs'; +import { singleCold, singleHot } from '../../../../tech-shared/test/marbles'; +import { VorgangHeaderLinkRel, VorgangListLinkRel, VorgangWithEingangLinkRel } from './../vorgang.linkrel'; +import { VorgangListResource, VorgangResource, VorgangWithEingangResource } from './../vorgang.model'; import { VorgangRepository } from './vorgang.repository'; describe('VorgangRepository', () => { @@ -70,7 +58,7 @@ describe('VorgangRepository', () => { const linkRel: string = 'dummyLinkRel'; beforeEach(() => { - resourceWrapper.get.mockReturnValue(hot('a', { a: vorgangListResource })); + resourceWrapper.get.mockReturnValue(singleHot(vorgangListResource)); }); it('should call resourceFactory with resource', () => { @@ -86,20 +74,17 @@ describe('VorgangRepository', () => { }); it('should return result', () => { - let result = repository.loadVorgangList(apiRootResource, linkRel); + let result: Observable<VorgangListResource> = repository.loadVorgangList(apiRootResource, linkRel); - expect(result).not.toBeNull(); - expect(result).toBeObservable(cold('a', { a: vorgangListResource })); + expect(result).toBeObservable(singleCold(vorgangListResource)); }); }); describe('getNextVorgangListPage', () => { - const vorgangListResource: VorgangListResource = createVorgangListResource([ - VorgangListLinkRel.NEXT, - ]); + const vorgangListResource: VorgangListResource = createVorgangListResource([VorgangListLinkRel.NEXT]); beforeEach(() => { - resourceWrapper.get.mockReturnValue(hot('a', { a: vorgangListResource })); + resourceWrapper.get.mockReturnValue(singleHot(vorgangListResource)); }); it('should call resourceFactory with resource', () => { @@ -115,29 +100,22 @@ describe('VorgangRepository', () => { }); it('should return result', () => { - let result = repository.getNextVorgangListPage(vorgangListResource); + let result: Observable<VorgangListResource> = repository.getNextVorgangListPage(vorgangListResource); - expect(result).not.toBeNull(); - expect(result).toBeObservable(cold('a', { a: vorgangListResource })); + expect(result).toBeObservable(singleCold(vorgangListResource)); }); }); describe('getVorgangWithEingang', () => { - const vorgangResource: VorgangResource = createVorgangResource([ - VorgangHeaderLinkRel.VORGANG_WITH_EINGANG, - ]); - const vorgangWithEingangUrl = getUrl( - vorgangResource, - VorgangHeaderLinkRel.VORGANG_WITH_EINGANG, - ); - const vorgangWithEingangResource: VorgangWithEingangResource = - createVorgangWithEingangResource(); + const vorgangResource: VorgangResource = createVorgangResource([VorgangHeaderLinkRel.VORGANG_WITH_EINGANG]); + const vorgangWithEingangUrl: string = getUrl(vorgangResource, VorgangHeaderLinkRel.VORGANG_WITH_EINGANG); + const vorgangWithEingangResource: VorgangWithEingangResource = createVorgangWithEingangResource(); beforeEach(() => { - const classMock = mockClass(TechSharedModule); + const classMock = mockClass(InjectorService); classMock.injector = <any>{ get: () => useFromMock(mock(HttpErrorHandler)) }; - resourceWrapper.get.mockReturnValue(hot('a', { a: vorgangWithEingangResource })); + resourceWrapper.get.mockReturnValue(singleHot(vorgangWithEingangResource)); }); it('should call resourceFactory with resource', () => { @@ -155,18 +133,17 @@ describe('VorgangRepository', () => { it('should return result', () => { let result = repository.getVorgang(vorgangWithEingangUrl); - expect(result).not.toBeNull(); - expect(result).toBeObservable(cold('a', { a: vorgangWithEingangResource })); + expect(result).toBeObservable(singleCold(vorgangWithEingangResource)); }); }); describe('getAttachments', () => { - const vorgangWithEingangResource: VorgangWithEingangResource = createVorgangWithEingangResource( - [VorgangWithEingangLinkRel.ATTACHMENTS], - ); + const vorgangWithEingangResource: VorgangWithEingangResource = createVorgangWithEingangResource([ + VorgangWithEingangLinkRel.ATTACHMENTS, + ]); beforeEach(() => { - resourceWrapper.get.mockReturnValue(hot('a', { a: vorgangWithEingangResource })); + resourceWrapper.get.mockReturnValue(singleHot(vorgangWithEingangResource)); }); it('should call resourceFactory with resource', () => { @@ -185,7 +162,7 @@ describe('VorgangRepository', () => { let result = repository.getAttachments(vorgangWithEingangResource); expect(result).not.toBeNull(); - expect(result).toBeObservable(cold('a', { a: vorgangWithEingangResource })); + expect(result).toBeObservable(singleCold(vorgangWithEingangResource)); }); }); @@ -194,7 +171,7 @@ describe('VorgangRepository', () => { const apiRootResource: ApiRootResource = createApiRootResource(); beforeEach(() => { - resourceWrapper.get.mockReturnValue(hot('a', { a: vorgangListResource })); + resourceWrapper.get.mockReturnValue(singleHot(vorgangListResource)); repository.buildSearchByUrl = jest.fn(); }); @@ -213,19 +190,9 @@ describe('VorgangRepository', () => { it('should call buildSearchByUrl', () => { const searchString: string = 'i search for...'; const limit: number = 7; - repository.searchVorgaengeBy( - apiRootResource, - searchString, - ApiRootLinkRel.SEARCH_ALLE, - limit, - ); - - expect(repository.buildSearchByUrl).toHaveBeenCalledWith( - apiRootResource, - searchString, - ApiRootLinkRel.SEARCH_ALLE, - limit, - ); + repository.searchVorgaengeBy(apiRootResource, searchString, ApiRootLinkRel.SEARCH_ALLE, limit); + + expect(repository.buildSearchByUrl).toHaveBeenCalledWith(apiRootResource, searchString, ApiRootLinkRel.SEARCH_ALLE, limit); }); }); @@ -242,11 +209,7 @@ describe('VorgangRepository', () => { _links, }; - const searchUrl: ResourceUri = repository.buildSearchByUrl( - apiRootResource, - 'searchParam', - ApiRootLinkRel.SEARCH_ALLE, - ); + const searchUrl: ResourceUri = repository.buildSearchByUrl(apiRootResource, 'searchParam', ApiRootLinkRel.SEARCH_ALLE); expect(searchUrl).toEqual(baseUrl + '&' + VorgangRepository.SEARCH_PARAM + '=searchParam'); }); @@ -254,11 +217,7 @@ describe('VorgangRepository', () => { it('should ignore unused, optional parameters', () => { const apiRoot: ApiRootResource = buildLinksWithSearch(baseUrl + '{&searchBy,limit}'); - const searchUrl: ResourceUri = repository.buildSearchByUrl( - apiRoot, - 'search', - ApiRootLinkRel.SEARCH_ALLE, - ); + const searchUrl: ResourceUri = repository.buildSearchByUrl(apiRoot, 'search', ApiRootLinkRel.SEARCH_ALLE); expect(searchUrl).toEqual(baseUrl + '&' + VorgangRepository.SEARCH_PARAM + '=search'); }); @@ -267,16 +226,9 @@ describe('VorgangRepository', () => { const limit = 5; const res = buildLinksWithSearch(baseUrl + '{&searchBy,limit}'); - const searchUrl: ResourceUri = repository.buildSearchByUrl( - res, - 'search', - ApiRootLinkRel.SEARCH_ALLE, - limit, - ); + const searchUrl: ResourceUri = repository.buildSearchByUrl(res, 'search', ApiRootLinkRel.SEARCH_ALLE, limit); - expect(searchUrl).toEqual( - baseUrl + '&' + VorgangRepository.SEARCH_PARAM + '=search&limit=' + limit, - ); + expect(searchUrl).toEqual(baseUrl + '&' + VorgangRepository.SEARCH_PARAM + '=search&limit=' + limit); }); function buildLinksWithSearch(searchHref: string): ApiRootResource { @@ -288,21 +240,16 @@ describe('VorgangRepository', () => { describe('loadMeineVorgaengeList', () => { const vorgangListResource: VorgangListResource = createVorgangListResource(); - const apiRootResource: ApiRootResource = createApiRootResource([ - ApiRootLinkRel.MEINE_VORGAENGE, - ]); + const apiRootResource: ApiRootResource = createApiRootResource([ApiRootLinkRel.MEINE_VORGAENGE]); beforeEach(() => { - resourceWrapper.get.mockReturnValue(hot('a', { a: vorgangListResource })); + resourceWrapper.get.mockReturnValue(singleHot(vorgangListResource)); }); it('should call resourceFactory with uri', () => { repository.loadMeineVorgaengeList(apiRootResource); - const urlWithoutParameter: URL = repository.getUrlWithoutParameter( - apiRootResource, - ApiRootLinkRel.MEINE_VORGAENGE, - ); + const urlWithoutParameter: URL = repository.getUrlWithoutParameter(apiRootResource, ApiRootLinkRel.MEINE_VORGAENGE); expect(resourceFactory.fromId).toHaveBeenCalledWith(urlWithoutParameter.href); }); @@ -313,17 +260,14 @@ describe('VorgangRepository', () => { }); it('should return result', () => { - let result = repository.loadMeineVorgaengeList(apiRootResource); + let result: Observable<VorgangListResource> = repository.loadMeineVorgaengeList(apiRootResource); - expect(result).not.toBeNull(); - expect(result).toBeObservable(cold('a', { a: vorgangListResource })); + expect(result).toBeObservable(singleCold(vorgangListResource)); }); }); describe('export', () => { - const vorgangWithEingang: VorgangWithEingangResource = createVorgangWithEingangResource([ - VorgangWithEingangLinkRel.EXPORT, - ]); + const vorgangWithEingang: VorgangWithEingangResource = createVorgangWithEingangResource([VorgangWithEingangLinkRel.EXPORT]); const body: Blob = new Blob(); const fileName: string = '927ee047-0123-4c36-911c-52e984accc87_Abgabe.Abgabe.0401.xdomea'; @@ -331,7 +275,7 @@ describe('VorgangRepository', () => { const httpResponse: HttpResponse<Blob> = <any>{ body, headers: { get: () => headerString } }; beforeEach(() => { - httpClient.get.mockReturnValue(hot('a', { a: httpResponse })); + httpClient.get.mockReturnValue(singleHot(httpResponse)); }); it('should call httpClient', () => { @@ -341,16 +285,13 @@ describe('VorgangRepository', () => { repository.export(vorgangWithEingang); - expect(httpClient.get).toHaveBeenCalledWith( - getUrl(vorgangWithEingang, VorgangWithEingangLinkRel.EXPORT), - requestOptions, - ); + expect(httpClient.get).toHaveBeenCalledWith(getUrl(vorgangWithEingang, VorgangWithEingangLinkRel.EXPORT), requestOptions); }); it('should return value', () => { - const result = repository.export(vorgangWithEingang); + const result: Observable<BlobWithFileName> = repository.export(vorgangWithEingang); - expect(result).toBeObservable(cold('b', { b: { blob: body, fileName } })); + expect(result).toBeObservable(singleCold({ blob: body, fileName })); }); }); diff --git a/alfa-client/libs/vorgang-shared/src/lib/vorgang-shared.module.ts b/alfa-client/libs/vorgang-shared/src/lib/vorgang-shared.module.ts index 57caef25627930944e573e0a19fa44715c2df489..b2dd59e65837996bceeedffe8e605c8d2911813f 100644 --- a/alfa-client/libs/vorgang-shared/src/lib/vorgang-shared.module.ts +++ b/alfa-client/libs/vorgang-shared/src/lib/vorgang-shared.module.ts @@ -24,7 +24,6 @@ import { BinaryFileSharedModule } from '@alfa-client/binary-file-shared'; import { CommandSharedModule } from '@alfa-client/command-shared'; import { NavigationSharedModule } from '@alfa-client/navigation-shared'; -import { TechSharedModule } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; import { RouterModule } from '@angular/router'; @@ -41,7 +40,6 @@ import * as fromVorgang from './+state/vorgang.reducer'; imports: [ CommonModule, RestModule, - TechSharedModule, CommandSharedModule, BinaryFileSharedModule, RouterModule, diff --git a/alfa-client/libs/vorgang/src/lib/vorgang.module.ts b/alfa-client/libs/vorgang/src/lib/vorgang.module.ts index cf3421cb9ed957b151e3cf8948828bde38b7f6b1..d1668cea27cf0e97e402293ebfdbf49d4c396980 100644 --- a/alfa-client/libs/vorgang/src/lib/vorgang.module.ts +++ b/alfa-client/libs/vorgang/src/lib/vorgang.module.ts @@ -22,8 +22,15 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { HintModule } from '@alfa-client/hint'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { + ConvertForDataTestPipe, + FormatDateWithoutYearWithTimePipe, + FormatDateWithTimePipe, + FormatToPrettyDatePipe, + HasLinkPipe, + ToResourceUriPipe, +} from '@alfa-client/tech-shared'; +import { OzgcloudIconComponent, OzgcloudRoutingButtonComponent, PostfachIconComponent, SpinnerComponent } from '@alfa-client/ui'; import { UserProfileModule } from '@alfa-client/user-profile'; import { VorgangSharedModule } from '@alfa-client/vorgang-shared'; import { VorgangSharedUiModule } from '@alfa-client/vorgang-shared-ui'; @@ -31,9 +38,13 @@ import { WiedervorlageModule } from '@alfa-client/wiedervorlage'; import { ScrollingModule } from '@angular/cdk/scrolling'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; +import { ReactiveFormsModule } from '@angular/forms'; import { MatButtonToggleModule } from '@angular/material/button-toggle'; +import { MatIcon, MatIconModule } from '@angular/material/icon'; +import { MatTooltip } from '@angular/material/tooltip'; import { RouterModule, Routes } from '@angular/router'; import { ButtonToggleGroupComponent } from '@ods/component'; +import { HasAnyLinkPipe } from '../../../tech-shared/src/lib/pipe/has-any-link.pipe'; import { ArchiveIconComponent, ButtonToggleComponent, TooltipDirective } from '@ods/system'; import { vorgangFilterViewGuard } from './vorgang-filter-view.guard'; import { VorgangListContainerComponent } from './vorgang-list-container/vorgang-list-container.component'; @@ -169,9 +180,7 @@ const routes: Routes = [ @NgModule({ imports: [ CommonModule, - TechSharedModule, ScrollingModule, - UiModule, RouterModule.forChild(routes), VorgangSharedModule, WiedervorlageModule, @@ -182,6 +191,21 @@ const routes: Routes = [ ButtonToggleComponent, ButtonToggleGroupComponent, ArchiveIconComponent, + FormatDateWithTimePipe, + FormatDateWithoutYearWithTimePipe, + MatIcon, + MatTooltip, + MatIconModule, + FormatToPrettyDatePipe, + ToResourceUriPipe, + ConvertForDataTestPipe, + HasLinkPipe, + PostfachIconComponent, + SpinnerComponent, + ReactiveFormsModule, + OzgcloudRoutingButtonComponent, + OzgcloudIconComponent, + HasAnyLinkPipe, TooltipDirective, ], declarations: [ diff --git a/alfa-client/libs/wiedervorlage/src/lib/submit-wiedervorlage-button/submit-wiedervorlage-button.component.html b/alfa-client/libs/wiedervorlage/src/lib/submit-wiedervorlage-button/submit-wiedervorlage-button.component.html index 322b8313078161b76335fcbb5936987686522411..df18f4361bbd25449d00c65d6ae30df918cc7617 100644 --- a/alfa-client/libs/wiedervorlage/src/lib/submit-wiedervorlage-button/submit-wiedervorlage-button.component.html +++ b/alfa-client/libs/wiedervorlage/src/lib/submit-wiedervorlage-button/submit-wiedervorlage-button.component.html @@ -26,20 +26,21 @@ @if (showAsIconButton) { <ods-button-with-spinner [stateResource]="submitInProgress$ | async" + (clickEmitter)="submit()" tooltip="Wiedervorlage speichern" variant="ghost" size="fit" - (clickEmitter)="submit()" + dataTestId="speichern-icon-button" > <ods-save-icon icon class="fill-text" /> </ods-button-with-spinner> } @else { <ods-button-with-spinner - data-test-id="speichern-button" [stateResource]="submitInProgress$ | async" + (clickEmitter)="submit()" text="Speichern" variant="outline" - (clickEmitter)="submit()" + dataTestId="speichern-button" > <ods-save-icon icon /> </ods-button-with-spinner> diff --git a/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/wiedervorlage-form/wiedervorlage-form.component.spec.ts b/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/wiedervorlage-form/wiedervorlage-form.component.spec.ts index 2d573153c6a323f3a4d30f421a75af0e10cfb818..f7dfb80e9b4ab4478fc2063574cda7411e15498d 100644 --- a/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/wiedervorlage-form/wiedervorlage-form.component.spec.ts +++ b/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage-page-container/wiedervorlage-page/wiedervorlage-form/wiedervorlage-form.component.spec.ts @@ -21,18 +21,14 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { SimpleChanges } from '@angular/core'; -import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { UntypedFormBuilder, ReactiveFormsModule } from '@angular/forms'; import { BinaryFileAttachmentContainerComponent } from '@alfa-client/binary-file'; import { BinaryFileListResource } from '@alfa-client/binary-file-shared'; import { Mock, mock, useFromMock } from '@alfa-client/test-utils'; -import { DateEditorComponent, TextAreaEditorComponent, TextEditorComponent } from '@alfa-client/ui'; -import { - WiedervorlageLinkRel, - WiedervorlageResource, - WiedervorlageService, -} from '@alfa-client/wiedervorlage-shared'; +import { DateEditorComponent, OzgcloudTextEditorComponent, TextAreaEditorComponent } from '@alfa-client/ui'; +import { WiedervorlageLinkRel, WiedervorlageResource, WiedervorlageService } from '@alfa-client/wiedervorlage-shared'; +import { SimpleChanges } from '@angular/core'; +import { ComponentFixture, TestBed } from '@angular/core/testing'; +import { ReactiveFormsModule, UntypedFormBuilder } from '@angular/forms'; import { createBinaryFileListResource } from 'libs/binary-file-shared/test/binary-file'; import { createWiedervorlageResource } from 'libs/wiedervorlage-shared/test/wiedervorlage'; import { MockComponent } from 'ng-mocks'; @@ -45,10 +41,7 @@ describe('WiedervorlageFormComponent', () => { let component: WiedervorlageFormComponent; let fixture: ComponentFixture<WiedervorlageFormComponent>; - const formService = new WiedervorlageFormService( - new UntypedFormBuilder(), - useFromMock(mock(WiedervorlageService)), - ); + const formService = new WiedervorlageFormService(new UntypedFormBuilder(), useFromMock(mock(WiedervorlageService))); const wiedervorlageService: Mock<WiedervorlageService> = mock(WiedervorlageService); const wiedervorlage: WiedervorlageResource = createWiedervorlageResource(); @@ -57,7 +50,7 @@ describe('WiedervorlageFormComponent', () => { declarations: [ WiedervorlageFormComponent, MockComponent(DateEditorComponent), - MockComponent(TextEditorComponent), + MockComponent(OzgcloudTextEditorComponent), MockComponent(TextAreaEditorComponent), MockComponent(BinaryFileAttachmentContainerComponent), MockComponent(SubmitWiedervorlageButtonComponent), @@ -118,16 +111,12 @@ describe('WiedervorlageFormComponent', () => { }); it('should call wiedervorlage service to get attachments if links exists', () => { - const wiedervorlageWithAttachments: WiedervorlageResource = createWiedervorlageResource([ - WiedervorlageLinkRel.ATTACHMENTS, - ]); + const wiedervorlageWithAttachments: WiedervorlageResource = createWiedervorlageResource([WiedervorlageLinkRel.ATTACHMENTS]); component.wiedervorlage = wiedervorlageWithAttachments; component.updateAttachments(); - expect(wiedervorlageService.getAttachmentList).toHaveBeenCalledWith( - wiedervorlageWithAttachments, - ); + expect(wiedervorlageService.getAttachmentList).toHaveBeenCalledWith(wiedervorlageWithAttachments); }); it('should NOT call wiedervorlage service if link is not present', () => { diff --git a/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage-status/wiedervorlage-status.component.spec.ts b/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage-status/wiedervorlage-status.component.spec.ts index ab2dd54f9740cb097bff0679157bc920bf8e762e..86383128c2a8cf444467208cd4b0fab3acdfb3fa 100644 --- a/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage-status/wiedervorlage-status.component.spec.ts +++ b/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage-status/wiedervorlage-status.component.spec.ts @@ -35,8 +35,8 @@ describe('WiedervorlageStatusComponent', () => { beforeEach(async () => { await TestBed.configureTestingModule({ - declarations: [WiedervorlageStatusComponent, ToTrafficLightPipe], - imports: [MatIcon], + declarations: [WiedervorlageStatusComponent], + imports: [MatIcon, ToTrafficLightPipe], }).compileComponents(); }); diff --git a/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage.module.ts b/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage.module.ts index 7729ab5f2f68770e3b6e2e850fc9279f3a731406..2057849d9d85c3365877c9d58fd022a8137029dc 100644 --- a/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage.module.ts +++ b/alfa-client/libs/wiedervorlage/src/lib/wiedervorlage.module.ts @@ -22,13 +22,34 @@ * unter der Lizenz sind dem Lizenztext zu entnehmen. */ import { BinaryFileModule } from '@alfa-client/binary-file'; -import { TechSharedModule } from '@alfa-client/tech-shared'; -import { UiModule } from '@alfa-client/ui'; +import { + ConvertForDataTestPipe, + FormatToPrettyDatePipe, + HasLinkPipe, + ToEmbeddedResourcesPipe, + ToResourceUriPipe, + ToTrafficLightPipe, + ToTrafficLightTooltipPipe, +} from '@alfa-client/tech-shared'; +import { + BackButtonComponent, + DateEditorComponent, + ExpansionPanelComponent, + IconButtonWithSpinnerComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + OzgcloudTextEditorComponent, + SpinnerComponent, + SubnavigationComponent, + TextAreaEditorComponent, +} from '@alfa-client/ui'; import { UserProfileModule } from '@alfa-client/user-profile'; import { VorgangSharedModule } from '@alfa-client/vorgang-shared'; import { VorgangSharedUiModule } from '@alfa-client/vorgang-shared-ui'; import { CommonModule, DatePipe } from '@angular/common'; import { NgModule } from '@angular/core'; +import { ReactiveFormsModule } from '@angular/forms'; +import { MatIcon } from '@angular/material/icon'; +import { MatTooltip } from '@angular/material/tooltip'; import { RouterModule, Routes } from '@angular/router'; import { ButtonWithSpinnerComponent } from '@ods/component'; import { @@ -71,12 +92,29 @@ const routes: Routes = [ imports: [ CommonModule, RouterModule.forChild(routes), - UiModule, VorgangSharedModule, - TechSharedModule, VorgangSharedUiModule, BinaryFileModule, UserProfileModule, + HasLinkPipe, + IconButtonWithSpinnerComponent, + OzgcloudStrokedButtonWithSpinnerComponent, + MatIcon, + MatTooltip, + ToTrafficLightTooltipPipe, + ToResourceUriPipe, + FormatToPrettyDatePipe, + SpinnerComponent, + ExpansionPanelComponent, + ToEmbeddedResourcesPipe, + BackButtonComponent, + ReactiveFormsModule, + OzgcloudTextEditorComponent, + TextAreaEditorComponent, + DateEditorComponent, + SubnavigationComponent, + ToTrafficLightPipe, + ConvertForDataTestPipe, ButtonWithSpinnerComponent, TooltipDirective, UpdateIconComponent, diff --git a/alfa-client/libs/zustaendige-stelle/src/lib/zustaendige-stelle.module.ts b/alfa-client/libs/zustaendige-stelle/src/lib/zustaendige-stelle.module.ts index 0ca329814a60a3bcc0ef1724dd6e82e3cd93b162..820da330c99f8e0d184b5c6b38096db8c03604bb 100644 --- a/alfa-client/libs/zustaendige-stelle/src/lib/zustaendige-stelle.module.ts +++ b/alfa-client/libs/zustaendige-stelle/src/lib/zustaendige-stelle.module.ts @@ -21,7 +21,6 @@ * Die sprachspezifischen Genehmigungen und Beschränkungen * unter der Lizenz sind dem Lizenztext zu entnehmen. */ -import { TechSharedModule } from '@alfa-client/tech-shared'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; import { FormsModule, ReactiveFormsModule } from '@angular/forms'; @@ -50,7 +49,6 @@ import { ZustaendigeStelleHeaderComponent } from './zustaendige-stelle-header/zu CommonModule, ButtonComponent, CloseIconComponent, - TechSharedModule, InstantSearchComponent, FormsModule, ReactiveFormsModule, diff --git a/alfa-client/nx.json b/alfa-client/nx.json index 45e3e58f414b34a448360de13c8e82e818c03c45..4153173c1960cf6aeb57131d786bfb1554f09e83 100644 --- a/alfa-client/nx.json +++ b/alfa-client/nx.json @@ -103,6 +103,7 @@ } }, "useInferencePlugins": false, + "defaultBase": "main", "release": { "projects": ["admin", "alfa", "info"], "projectsRelationship": "independent"