From 34d445f02d55c583aa9f2f468f5f05e498438da8 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Wed, 21 Feb 2024 18:20:14 +0100
Subject: [PATCH] OZG-4994 OZG-5066 improve tests
---
.../alfa/statistic/StatisticServiceTest.java | 25 +++++++++++++------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/alfa-service/src/test/java/de/ozgcloud/alfa/statistic/StatisticServiceTest.java b/alfa-service/src/test/java/de/ozgcloud/alfa/statistic/StatisticServiceTest.java
index 979495718d..1b030d675d 100644
--- a/alfa-service/src/test/java/de/ozgcloud/alfa/statistic/StatisticServiceTest.java
+++ b/alfa-service/src/test/java/de/ozgcloud/alfa/statistic/StatisticServiceTest.java
@@ -188,10 +188,22 @@ class StatisticServiceTest {
@Nested
class TestGetVorgaengeStatistics {
+ private final Statistic statistic = StatisticTestFactory.create();
+ private final Map<String, StatisticResult> getVorgangStatisticsResponse = Map.of(COUNT_WIEDERVORLAGE_NEXT_FRIST_RESULT_NAME,
+ StatisticResultTestFactory.create());
+
@BeforeEach
void beforeEach() {
- when(remoteService.buildCountByStatusResultName(any())).thenCallRealMethod();
doReturn(COUNT_BY_VORGANG_STATUS_VERWALTUNG_USER).when(service).getCountByVorgangStatusList();
+ when(remoteService.getVorgaengeStatistics(COUNT_BY_VORGANG_STATUS_VERWALTUNG_USER)).thenReturn(getVorgangStatisticsResponse);
+ doReturn(statistic).when(service).buildGetVorgaengeStatisticResult(getVorgangStatisticsResponse);
+ }
+
+ @Test
+ void shouldCallGetCountByVorgangStatusList() {
+ service.getVorgaengeStatistic();
+
+ verify(service).getCountByVorgangStatusList();
}
@Test
@@ -203,19 +215,16 @@ class StatisticServiceTest {
@Test
void shouldBuildResult() {
- var response = Map.of(COUNT_WIEDERVORLAGE_NEXT_FRIST_RESULT_NAME, StatisticResultTestFactory.create());
- when(remoteService.getVorgaengeStatistics(COUNT_BY_VORGANG_STATUS_VERWALTUNG_USER)).thenReturn(response);
-
service.getVorgaengeStatistic();
- verify(service).buildGetVorgaengeStatisticResult(response);
+ verify(service).buildGetVorgaengeStatisticResult(getVorgangStatisticsResponse);
}
@Test
- void shouldCallGetCountByVorgangStatusList() {
- service.getVorgaengeStatistic();
+ void shouldReturnStatistic() {
+ var result = service.getVorgaengeStatistic();
- verify(service).getCountByVorgangStatusList();
+ assertThat(result).isEqualTo(statistic);
}
}
}
--
GitLab