From 27caea772d7d7df8ebb60d2c292cd68ae5e69728 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Thu, 2 Nov 2023 16:34:21 +0100
Subject: [PATCH] OZG-4292 avoid unnecessary call
---
.../src/lib/vorgang-list.service.spec.ts | 6 +++---
.../vorgang-shared/src/lib/vorgang-list.service.ts | 10 +++-------
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/goofy-client/libs/vorgang-shared/src/lib/vorgang-list.service.spec.ts b/goofy-client/libs/vorgang-shared/src/lib/vorgang-list.service.spec.ts
index 39b4f88807..092a226b82 100644
--- a/goofy-client/libs/vorgang-shared/src/lib/vorgang-list.service.spec.ts
+++ b/goofy-client/libs/vorgang-shared/src/lib/vorgang-list.service.spec.ts
@@ -210,9 +210,9 @@ describe('VorgangListService', () => {
expect(vorgangFacade.getVorgangStatistic).toHaveBeenCalled();
})
- it('should getVorgangList', (done) => {
- service.getVorgangStatistic().subscribe(() => {
- expect(service.getVorgangList).toHaveBeenCalled();
+ it('should return vorgangStatistic', (done) => {
+ service.getVorgangStatistic().subscribe(vorgangStatistic => {
+ expect(vorgangStatistic).toEqual(vorgangStatisticStateResource);
done();
})
})
diff --git a/goofy-client/libs/vorgang-shared/src/lib/vorgang-list.service.ts b/goofy-client/libs/vorgang-shared/src/lib/vorgang-list.service.ts
index 4f9f2c340a..78336077a6 100644
--- a/goofy-client/libs/vorgang-shared/src/lib/vorgang-list.service.ts
+++ b/goofy-client/libs/vorgang-shared/src/lib/vorgang-list.service.ts
@@ -23,9 +23,9 @@
*/
import { Injectable } from '@angular/core';
import { ApiRootFacade, ApiRootResource } from '@goofy-client/api-root-shared';
-import { EMPTY_STRING, StateResource, createEmptyStateResource, doIfLoadingRequired, isLoaded, isNotNull } from '@goofy-client/tech-shared';
+import { EMPTY_STRING, StateResource, createEmptyStateResource, doIfLoadingRequired, isNotNull } from '@goofy-client/tech-shared';
import { Observable, combineLatest } from 'rxjs';
-import { filter, map, startWith, tap, withLatestFrom } from 'rxjs/operators';
+import { map, startWith, tap, withLatestFrom } from 'rxjs/operators';
import { VorgangFacade } from './+state/vorgang.facade';
import { ROUTE_PARAM_BY_VORGANG_FILTER, buildLinkRel, getSearchLinkRel } from './vorgang-navigation.util';
import { VorgangFilter, VorgangListResource, VorgangResource, VorgangStatistic, VorgangView } from './vorgang.model';
@@ -64,11 +64,7 @@ export class VorgangListService {
}
public getVorgangStatistic(): Observable<StateResource<VorgangStatistic>> {
- return this.vorgangFacade.getVorgangStatistic().pipe(
- withLatestFrom(this.getVorgangList()),
- filter(([, vorgangListResource]) => isLoaded(vorgangListResource)),
- map(([statistic,]) => statistic),
- );
+ return this.vorgangFacade.getVorgangStatistic();
}
public getSelectedFilterAsRouteParam(): Observable<string> {
--
GitLab