From 1979301a8b376f5d04a4ca49509e4e7ac4cba945 Mon Sep 17 00:00:00 2001
From: sebo <sebastian.bergandy@external.mgm-cp.com>
Date: Wed, 26 Feb 2025 17:27:13 +0100
Subject: [PATCH] OZG-5977 improve code after review
---
.../src/components/attachment/attachment.e2e.component.ts | 6 +++---
.../multi-file-upload/multi-file-upload.component.spec.ts | 2 +-
.../lib/multi-file-upload/multi-file-upload.component.ts | 3 ++-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/alfa-client/apps/alfa-e2e/src/components/attachment/attachment.e2e.component.ts b/alfa-client/apps/alfa-e2e/src/components/attachment/attachment.e2e.component.ts
index 090ce7a95a..14bad966ec 100644
--- a/alfa-client/apps/alfa-e2e/src/components/attachment/attachment.e2e.component.ts
+++ b/alfa-client/apps/alfa-e2e/src/components/attachment/attachment.e2e.component.ts
@@ -85,14 +85,14 @@ class AttachmentE2EItem {
}
class LoadingErrorAttachmentE2EItem {
- private locatorRoot: string;
+ private readonly root: string;
private readonly attachmentSuffixLocattor: string = '-file-upload-list-item-attachment-upload';
constructor(private fileName: string) {
- this.locatorRoot = convertToDataTestId(this.fileName) + this.attachmentSuffixLocattor;
+ this.root = convertToDataTestId(this.fileName) + this.attachmentSuffixLocattor;
}
public getRoot() {
- return cy.getTestElement(this.locatorRoot);
+ return cy.getTestElement(this.root);
}
}
diff --git a/alfa-client/libs/binary-file/src/lib/multi-file-upload/multi-file-upload.component.spec.ts b/alfa-client/libs/binary-file/src/lib/multi-file-upload/multi-file-upload.component.spec.ts
index 6eaf4f614d..70679e7411 100644
--- a/alfa-client/libs/binary-file/src/lib/multi-file-upload/multi-file-upload.component.spec.ts
+++ b/alfa-client/libs/binary-file/src/lib/multi-file-upload/multi-file-upload.component.spec.ts
@@ -11,7 +11,7 @@ import { DummyLinkRel } from '../../../../tech-shared/test/dummy';
import { createDummyResource } from '../../../../tech-shared/test/resource';
import { MultiFileUploadComponent } from './multi-file-upload.component';
-describe('OdsMultiFileUploadComponent', () => {
+describe('MultiFileUploadComponent', () => {
let component: MultiFileUploadComponent;
let fixture: ComponentFixture<MultiFileUploadComponent>;
diff --git a/alfa-client/libs/binary-file/src/lib/multi-file-upload/multi-file-upload.component.ts b/alfa-client/libs/binary-file/src/lib/multi-file-upload/multi-file-upload.component.ts
index 3b5e580b9b..56234cb550 100644
--- a/alfa-client/libs/binary-file/src/lib/multi-file-upload/multi-file-upload.component.ts
+++ b/alfa-client/libs/binary-file/src/lib/multi-file-upload/multi-file-upload.component.ts
@@ -1,8 +1,9 @@
-import { FileUploadListContainerComponent, MultiFileUploadEditorComponent } from '@alfa-client/binary-file';
import { FileUploadType } from '@alfa-client/binary-file-shared';
import { Component, Input } from '@angular/core';
import { Resource } from '@ngxp/rest';
import { BinaryFileListOrientation } from '../directive/binary-file-list-orientation/binary-file-list-orientation.directive';
+import { FileUploadListContainerComponent } from '../file-upload-list-container/file-upload-list-container.component';
+import { MultiFileUploadEditorComponent } from '../multi-file-upload-editor/multi-file-upload-editor.component';
@Component({
selector: 'ods-multi-file-upload',
--
GitLab