From 7a0f8c9504f0f16b5f56f0c254341c35641d3026 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Wed, 15 May 2024 17:11:11 +0200
Subject: [PATCH] OZG-5677 improve unit tests
---
.../formdata/FormStructureParserTest.java | 35 +++++++------------
1 file changed, 13 insertions(+), 22 deletions(-)
diff --git a/src/test/java/de/ozgcloud/formcycle/formdata/FormStructureParserTest.java b/src/test/java/de/ozgcloud/formcycle/formdata/FormStructureParserTest.java
index 6d4fdc6..de1666d 100644
--- a/src/test/java/de/ozgcloud/formcycle/formdata/FormStructureParserTest.java
+++ b/src/test/java/de/ozgcloud/formcycle/formdata/FormStructureParserTest.java
@@ -39,17 +39,6 @@ class FormStructureParserTest {
assertThat(result).isEmpty();
}
- @Test
- void shouldCallIsInputNode() {
- try (var itemClassMock = mockStatic(ItemClass.class)) {
- var items = createItem(TEXT_FIELD);
-
- createParser(items).parse();
-
- itemClassMock.verify(() -> ItemClass.isInputNode(TEXT_FIELD));
- }
-
- }
@Test
void shouldCallHandleInputNode() {
var items = createItem(TEXT_FIELD);
@@ -58,17 +47,7 @@ class FormStructureParserTest {
structureParser.parse();
verify(structureParser).handleInputNode(items.get(ITEM_ID));
- }
-
- @Test
- void shouldCallIsNestedContainer() {
- try (var itemClassMock = mockStatic(ItemClass.class)) {
- var items = createItem(FIELD_SET);
-
- createParser(items).parse();
-
- itemClassMock.verify(() -> ItemClass.isNestedContainer(FIELD_SET));
- }
+ verify(structureParser, never()).handleContainerNode(any());
}
@Test
@@ -79,6 +58,7 @@ class FormStructureParserTest {
structureParser.parse();
verify(structureParser).handleContainerNode(items.get(ITEM_ID));
+ verify(structureParser, never()).handleInputNode(any());
}
@Test
@@ -101,6 +81,11 @@ class FormStructureParserTest {
@Nested
class TestHandleInputNode {
+ @BeforeEach
+ void init() {
+ structureParser = spy(new FormStructureParser(createItem(FIELD_SET)));
+ }
+
@Test
void shouldCallGetResultNodes() {
var xItem = getMock(TEXT_FIELD);
@@ -258,6 +243,7 @@ class FormStructureParserTest {
@BeforeEach
void init() {
+ structureParser = spy(new FormStructureParser(createItem(FIELD_SET)));
injectResultNodes(expectedResultNodes);
}
@@ -316,6 +302,11 @@ class FormStructureParserTest {
@Nested
class TestGetNextContainerNode {
+ @BeforeEach
+ void init() {
+ structureParser = spy(new FormStructureParser(createItem(FIELD_SET)));
+ }
+
@Test
void shouldReturnEmptyWhenNodeStackEmpty() {
var nextContainerNode = structureParser.getNextContainerNode(ITEM_ID);
--
GitLab