From 8a14122a76290ccb0e5e30728a9a43af472a9b41 Mon Sep 17 00:00:00 2001
From: OZG-Cloud Team <noreply@ozg-sh.de>
Date: Wed, 9 Oct 2024 09:19:57 +0200
Subject: [PATCH] OZG-6748 Init FormData with ZustaendigeStelle in test factory
---
.../common/formdata/FormDataTestFactory.java | 1 +
.../router/GrpcEingangMapperITCase.java | 29 +++++--------------
.../eingang/router/VorgangServiceTest.java | 1 -
.../ZustaendigeStelleMetadataMapperTest.java | 3 +-
...rmittelEngineBasedSemantikAdapterTest.java | 17 ++++-------
...ntelantragZustaendigeStelleMapperTest.java | 1 +
6 files changed, 16 insertions(+), 36 deletions(-)
diff --git a/common/src/test/java/de/ozgcloud/eingang/common/formdata/FormDataTestFactory.java b/common/src/test/java/de/ozgcloud/eingang/common/formdata/FormDataTestFactory.java
index e496826b..f051953b 100644
--- a/common/src/test/java/de/ozgcloud/eingang/common/formdata/FormDataTestFactory.java
+++ b/common/src/test/java/de/ozgcloud/eingang/common/formdata/FormDataTestFactory.java
@@ -61,6 +61,7 @@ public class FormDataTestFactory {
return FormData.builder()
.header(FormHeaderTestFactory.create())
.antragsteller(AntragstellerTestFactory.create())
+ .zustaendigeStelles(List.of(ZustaendigeStelleTestFactory.create()))
.formData(Map.of(
SIMPLE_VALUE_KEY, SIMPLE_VALUE,
SUBFORM_KEY, SUBFORM_VALUE,
diff --git a/router/src/test/java/de/ozgcloud/eingang/router/GrpcEingangMapperITCase.java b/router/src/test/java/de/ozgcloud/eingang/router/GrpcEingangMapperITCase.java
index fbb17f29..f3c15dea 100644
--- a/router/src/test/java/de/ozgcloud/eingang/router/GrpcEingangMapperITCase.java
+++ b/router/src/test/java/de/ozgcloud/eingang/router/GrpcEingangMapperITCase.java
@@ -37,7 +37,6 @@ import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
import de.ozgcloud.eingang.common.formdata.AntragstellerTestFactory;
-import de.ozgcloud.eingang.common.formdata.FormData;
import de.ozgcloud.eingang.common.formdata.FormDataTestFactory;
import de.ozgcloud.eingang.common.formdata.IncomingFileTestFactory;
import de.ozgcloud.eingang.common.formdata.ZustaendigeStelleTestFactory;
@@ -50,15 +49,6 @@ class GrpcEingangMapperITCase {
@Autowired
private GrpcEingangMapper grpcEingangMapper;
- private FormData inputFormData;
-
- @BeforeEach
- void mock() {
- inputFormData = FormDataTestFactory.createBuilder()
- .zustaendigeStelle(ZustaendigeStelleTestFactory.create())
- .build();
- }
-
@DisplayName("Mapped GrpcEingang")
@Nested
class TestToEingang {
@@ -69,8 +59,7 @@ class GrpcEingangMapperITCase {
@Test
void antragstellerShouldBeMapped() {
- var antragSteller = grpcEingangMapper.toEingang(inputFormData,
- Optional.of(ZustaendigeStelleTestFactory.ORGANISATIONSEINHEIT_ID)).getAntragsteller();
+ var antragSteller = grpcEingangMapper.toEingang(FormDataTestFactory.create(), Optional.of(ZustaendigeStelleTestFactory.ORGANISATIONSEINHEIT_ID)).getAntragsteller();
assertThat(antragSteller.getPostfachId()).isEqualTo(AntragstellerTestFactory.POSTFACH_ID);
assertThat(antragSteller.getVorname()).isEqualTo(AntragstellerTestFactory.VORNAME);
@@ -79,8 +68,7 @@ class GrpcEingangMapperITCase {
@Test
void dataShouldBeMapped() {
- var antragsteller = grpcEingangMapper.toEingang(inputFormData,
- Optional.of(ZustaendigeStelleTestFactory.ORGANISATIONSEINHEIT_ID)).getAntragsteller();
+ var antragsteller = grpcEingangMapper.toEingang(FormDataTestFactory.create(), Optional.of(ZustaendigeStelleTestFactory.ORGANISATIONSEINHEIT_ID)).getAntragsteller();
assertThat(antragsteller.getOtherData().getFieldList()).hasSize(1);
assertThat(antragsteller.getOtherData().getField(0).getName()).isEqualTo(AntragstellerTestFactory.GEBIET_BEZEICHNUNG_KEY);
@@ -93,8 +81,7 @@ class GrpcEingangMapperITCase {
class TestZustaendigeStelle {
@Test
void eingangShouldHaveZustaendigeStelle() {
- var zustaendigeStelle = grpcEingangMapper.toEingang(inputFormData, Optional.of(ZustaendigeStelleTestFactory.ORGANISATIONSEINHEIT_ID))
- .getZustaendigeStelle();
+ var zustaendigeStelle = grpcEingangMapper.toEingang(FormDataTestFactory.create(), Optional.of(ZustaendigeStelleTestFactory.ORGANISATIONSEINHEIT_ID)).getZustaendigeStelle();
assertThat(zustaendigeStelle).isNotNull();
assertThat(zustaendigeStelle.getOrganisationseinheitenId()).isEqualTo(ZustaendigeStelleTestFactory.ORGANISATIONSEINHEIT_ID);
@@ -104,7 +91,7 @@ class GrpcEingangMapperITCase {
@DisplayName("should map empty organisationeinheitId if missing")
@Test
void shouldMapEmptyOrganisationeinheitIdIfMissing() {
- var zustaendigeStelle = grpcEingangMapper.toEingang(inputFormData, Optional.empty()).getZustaendigeStelle();
+ var zustaendigeStelle = grpcEingangMapper.toEingang(FormDataTestFactory.create(), Optional.empty()).getZustaendigeStelle();
assertThat(zustaendigeStelle).isNotNull();
assertThat(zustaendigeStelle.getOrganisationseinheitenId()).isEmpty();
@@ -120,7 +107,7 @@ class GrpcEingangMapperITCase {
@BeforeEach
void init() {
- eingang = grpcEingangMapper.toEingang(inputFormData, Optional.empty());
+ eingang = grpcEingangMapper.toEingang(FormDataTestFactory.create(), Optional.empty());
}
@Test
@@ -200,8 +187,7 @@ class GrpcEingangMapperITCase {
void valueListShouldGenerateFields() {
GrpcEingang eingang = grpcEingangMapper
- .toEingang(FormDataTestFactory.createBuilder().formData(Map.of("key", List.of("value1", "value2"))).build(),
- Optional.empty());
+ .toEingang(FormDataTestFactory.createBuilder().formData(Map.of("key", List.of("value1", "value2"))).build(), Optional.empty());
assertThat(eingang.getFormData().getFieldCount()).isEqualTo(2);
}
@@ -211,8 +197,7 @@ class GrpcEingangMapperITCase {
GrpcEingang eingang = grpcEingangMapper
.toEingang(FormDataTestFactory.createBuilder()
- .formData(Map.of("key-1", List.of(Map.of("sub_key", "value1"), Map.of("sub_key", "value2")))).build(),
- Optional.empty());
+ .formData(Map.of("key-1", List.of(Map.of("sub_key", "value1"), Map.of("sub_key", "value2")))).build(), Optional.empty());
assertThat(eingang.getFormData().getFormCount()).isEqualTo(2);
assertThat(eingang.getFormData().getForm(0).getFieldCount()).isEqualTo(1);
diff --git a/router/src/test/java/de/ozgcloud/eingang/router/VorgangServiceTest.java b/router/src/test/java/de/ozgcloud/eingang/router/VorgangServiceTest.java
index bb1294f2..e3b42018 100644
--- a/router/src/test/java/de/ozgcloud/eingang/router/VorgangServiceTest.java
+++ b/router/src/test/java/de/ozgcloud/eingang/router/VorgangServiceTest.java
@@ -234,7 +234,6 @@ class VorgangServiceTest {
@BeforeEach
void mock() {
preservedFormData = FormDataTestFactory.createBuilder()
- .zustaendigeStelle(ZustaendigeStelleTestFactory.create())
.zustaendigeStelle(ZustaendigeStelleTestFactory.createBuilder()
.organisationseinheitenId(ORGANISATIONSEINHEIT_ID_2)
.build())
diff --git a/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/ZustaendigeStelleMetadataMapperTest.java b/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/ZustaendigeStelleMetadataMapperTest.java
index d2b0412c..56058ec1 100644
--- a/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/ZustaendigeStelleMetadataMapperTest.java
+++ b/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/ZustaendigeStelleMetadataMapperTest.java
@@ -44,6 +44,7 @@ class ZustaendigeStelleMetadataMapperTest {
behoerdeMetadataFile = IncomingFileTestFactory.createBuilder().name(ZustaendigeStelleMetadataMapper.BEHOERDE_METADATA_FILE_NAME)
.build();
formData = FormDataTestFactory.createBuilder()
+ .clearZustaendigeStelles()
.representation(behoerdeMetadataFile).build();
}
@@ -75,7 +76,7 @@ class ZustaendigeStelleMetadataMapperTest {
var result = mapper.parseZustaendigeStelleData(formData);
- assertThat(result.getZustaendigeStelles().getFirst()).isEqualTo(zustaendigeStelle);
+ assertThat(result.getZustaendigeStelles()).containsExactly(zustaendigeStelle);
}
}
diff --git a/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/dfoerdermittel/DFoerdermittelEngineBasedSemantikAdapterTest.java b/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/dfoerdermittel/DFoerdermittelEngineBasedSemantikAdapterTest.java
index 1d078b3f..512d0a84 100644
--- a/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/dfoerdermittel/DFoerdermittelEngineBasedSemantikAdapterTest.java
+++ b/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/dfoerdermittel/DFoerdermittelEngineBasedSemantikAdapterTest.java
@@ -224,7 +224,9 @@ class DFoerdermittelEngineBasedSemantikAdapterTest {
class TestWithNoExistingZustaendigeStelles {
@Test
void shouldHaveOrganisationsEinheitId() {
- var inputFormData = DFoerdermittelFormDataTestFactory.create();
+ var inputFormData = DFoerdermittelFormDataTestFactory.createBuilder()
+ .clearZustaendigeStelles()
+ .build();
var formData = adapter.addOrganisationsEinheitId(inputFormData);
@@ -238,18 +240,9 @@ class DFoerdermittelEngineBasedSemantikAdapterTest {
@Nested
class TestWithOneExistingZustaendigeStelle {
- private FormData inputFormData;
-
- @BeforeEach
- void mock() {
- inputFormData = DFoerdermittelFormDataTestFactory.createBuilder()
- .zustaendigeStelle(ZustaendigeStelleTestFactory.create())
- .build();
- }
-
@Test
void shouldHaveOrganisationsEinheitId() {
- var formData = adapter.addOrganisationsEinheitId(inputFormData);
+ var formData = adapter.addOrganisationsEinheitId(DFoerdermittelFormDataTestFactory.create());
assertThat(formData.getZustaendigeStelles())
.extracting(ZustaendigeStelle::getOrganisationseinheitenId)
@@ -259,7 +252,7 @@ class DFoerdermittelEngineBasedSemantikAdapterTest {
@DisplayName("should log error for existing zustaendige stelle")
@Test
void shouldLogErrorForExistingZustaendigeStelle() {
- adapter.addOrganisationsEinheitId(inputFormData);
+ adapter.addOrganisationsEinheitId(DFoerdermittelFormDataTestFactory.create());
verify(adapter).logErrorForExistingZustaendigeStelle();
}
diff --git a/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/formbased/mantelantrag/MantelantragZustaendigeStelleMapperTest.java b/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/formbased/mantelantrag/MantelantragZustaendigeStelleMapperTest.java
index 57a4cc13..377ff70a 100644
--- a/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/formbased/mantelantrag/MantelantragZustaendigeStelleMapperTest.java
+++ b/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/formbased/mantelantrag/MantelantragZustaendigeStelleMapperTest.java
@@ -181,6 +181,7 @@ class MantelantragZustaendigeStelleMapperTest {
getOrganisationseinheitIDFieldName(10), "1111111"
));
formData = FormDataTestFactory.createBuilder()
+ .clearZustaendigeStelles()
.formData(fieldMap)
.build();
}
--
GitLab