From 7cc4533271e64cfe8d312cad7127d8519c35f32a Mon Sep 17 00:00:00 2001 From: OZG-Cloud Team <noreply@ozg-sh.de> Date: Wed, 31 Jan 2024 16:10:27 +0100 Subject: [PATCH] OZG-4367 extend tests --- .../formcycle/FormDataControllerTest.java | 22 ++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/ozgcloud/eingang/formcycle/FormDataControllerTest.java b/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/ozgcloud/eingang/formcycle/FormDataControllerTest.java index 4ff5e495..7e6dcd1b 100644 --- a/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/ozgcloud/eingang/formcycle/FormDataControllerTest.java +++ b/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/ozgcloud/eingang/formcycle/FormDataControllerTest.java @@ -71,6 +71,8 @@ class FormDataControllerTest { private SemantikAdapter semantikAdapter; @Mock private VorgangNummerSupplier vorgangNummerSupplier; + @Mock + private FormDataHtmlCleaner htmlCleaner; private MockMvc mockMvc; @@ -93,6 +95,7 @@ class FormDataControllerTest { @BeforeEach void init() { + when(htmlCleaner.clean(any())).thenReturn(mappedFormData); when(mapper.toFormData(any())).thenReturn(mappedFormData); when(vorgangNummerSupplier.get()).thenReturn(VORGANG_NUMMER); } @@ -111,7 +114,7 @@ class FormDataControllerTest { @Test @SneakyThrows - void shouldRespondeWithVorgangNummer() { + void shouldResponseWithVorgangNummer() { var confirmation = FormCycleConfirmationResponse.parseFrom( doPostRequest().andReturn().getResponse().getContentAsByteArray()); @@ -127,6 +130,13 @@ class FormDataControllerTest { assertThat(formDataCaptor.getValue().getHeader().getRequestId()).isEqualTo(VORGANG_NUMMER); } + @Test + void shouldCallHtmlCleaner() { + doPostRequest(); + + verify(htmlCleaner).clean(any()); + } + @Test void shouldCallMapper() { doPostRequest(); @@ -157,8 +167,9 @@ class FormDataControllerTest { @BeforeEach void init() { - when(mapper.toFormData(any())) - .thenReturn(FormDataTestFactory.createBuilder().clearRepresentations().numberOfRepresentations(0).build()); + var formData = FormDataTestFactory.createBuilder().clearRepresentations().numberOfRepresentations(0).build(); + when(mapper.toFormData(any())).thenReturn(formData); + when(htmlCleaner.clean(any())).thenReturn(formData); } @Test @@ -195,8 +206,9 @@ class FormDataControllerTest { class Attachments { @BeforeEach void init() { - when(mapper.toFormData(any())) - .thenReturn(FormDataTestFactory.createBuilder().clearAttachments().numberOfAttachments(0).build()); + var formData = FormDataTestFactory.createBuilder().clearAttachments().numberOfAttachments(0).build(); + when(mapper.toFormData(any())).thenReturn(formData); + when(htmlCleaner.clean(any())).thenReturn(formData); } @Test -- GitLab