diff --git a/formcycle-adapter/formcycle-adapter-impl/pom.xml b/formcycle-adapter/formcycle-adapter-impl/pom.xml index abbf0e50cfa9e0aa06500e2c44570092d09bb101..3b139c4bc45dcfa1febd8af4cd1d360a12bed127 100644 --- a/formcycle-adapter/formcycle-adapter-impl/pom.xml +++ b/formcycle-adapter/formcycle-adapter-impl/pom.xml @@ -30,6 +30,7 @@ <groupId>de.itvsh.kop.eingangsadapter</groupId> <artifactId>formcycle-adapter</artifactId> <version>1.10.1-SNAPSHOT</version> + <relativePath>../</relativePath> </parent> <artifactId>formcycle-adapter-impl</artifactId> diff --git a/formcycle-adapter/formcycle-adapter-impl/src/main/java/de/itvsh/kop/eingang/formcycle/VorgangNummerSupplier.java b/formcycle-adapter/formcycle-adapter-impl/src/main/java/de/itvsh/kop/eingang/formcycle/VorgangNummerSupplier.java index cebe8c74bb4d6fe3fa94035b24eb5caf0818c57d..ac9fd684ce4055ab4c6bdab68c68a850d15f277f 100644 --- a/formcycle-adapter/formcycle-adapter-impl/src/main/java/de/itvsh/kop/eingang/formcycle/VorgangNummerSupplier.java +++ b/formcycle-adapter/formcycle-adapter-impl/src/main/java/de/itvsh/kop/eingang/formcycle/VorgangNummerSupplier.java @@ -15,7 +15,7 @@ class VorgangNummerSupplier { var resultBuilder = initWithPrefix(); long currentTimeSeconds = Instant.now().toEpochMilli(); for (int i = 0; i < SUFFIX_LENGTH; i++) { - resultBuilder.append(BASE30_ALPHABET.charAt((int) currentTimeSeconds % 30)); + resultBuilder.append(BASE30_ALPHABET.charAt((int) (currentTimeSeconds % 30))); currentTimeSeconds /= 30; } return resultBuilder.toString(); diff --git a/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/itvsh/kop/eingang/formcycle/FormDataControllerTest.java b/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/itvsh/kop/eingang/formcycle/FormDataControllerTest.java index 4c496eb5cd37d49195bfda49d00a24a09c00a1f2..b3eccf99f11d05d5dc0413647c814366074449a1 100644 --- a/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/itvsh/kop/eingang/formcycle/FormDataControllerTest.java +++ b/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/itvsh/kop/eingang/formcycle/FormDataControllerTest.java @@ -101,7 +101,6 @@ class FormDataControllerTest { doPostRequest().andExpect(status().is2xxSuccessful()); } - @Test void shouldCallVorgangNummerSupplier() { doPostRequest(); @@ -139,7 +138,8 @@ class FormDataControllerTest { doPostRequest(); verify(semantikAdapter).processFormData(formDataCaptor.capture()); - assertThat(formDataCaptor.getValue()).usingRecursiveComparison().ignoringFields("representations", "attachments", "numberOfAttachments", "header.requestId") + assertThat(formDataCaptor.getValue()).usingRecursiveComparison() + .ignoringFields("representations", "attachments", "numberOfAttachments", "header.requestId") .isEqualTo(mappedFormData); } @@ -176,7 +176,7 @@ class FormDataControllerTest { verify(semantikAdapter).processFormData(formDataCaptor.capture()); assertThat(formDataCaptor.getValue().getRepresentations()).first().usingRecursiveComparison() - .ignoringFields("id", "vendorId", "contentStream") + .ignoringFields("id", "vendorId", "file") .isEqualTo(IncomingFileTestFactory.create()); } @@ -260,7 +260,8 @@ class FormDataControllerTest { var group = groupsBuilder.buildGroup(FormCycleAttachmentGroupTestFactory.create()); assertThat(group.getFiles()).hasSize(1).first() - .usingRecursiveComparison().ignoringFields("id", "vendorId", "contentStream").isEqualTo(IncomingFileTestFactory.create()); + .usingRecursiveComparison().ignoringFields("id", "vendorId", "file") + .isEqualTo(IncomingFileTestFactory.create()); } @Test diff --git a/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/itvsh/kop/eingang/formcycle/VorgangNummerSupplierTest.java b/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/itvsh/kop/eingang/formcycle/VorgangNummerSupplierTest.java index 42a7be6008e89a9b316a933cf5dcaac7c78ab229..220ebbbf1bddd7d6f92d6c8105d596fc1ea7653d 100644 --- a/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/itvsh/kop/eingang/formcycle/VorgangNummerSupplierTest.java +++ b/formcycle-adapter/formcycle-adapter-impl/src/test/java/de/itvsh/kop/eingang/formcycle/VorgangNummerSupplierTest.java @@ -8,12 +8,14 @@ import java.time.LocalDate; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; +import org.mockito.InjectMocks; import org.mockito.Spy; class VorgangNummerSupplierTest { @Spy - private VorgangNummerSupplier vorgangNummerSupplier = new VorgangNummerSupplier(); + @InjectMocks + private VorgangNummerSupplier vorgangNummerSupplier; @Nested @DisplayName("Get Vorgang Nummer") @@ -38,25 +40,26 @@ class VorgangNummerSupplierTest { } @Nested - class TestAddPrefix{ + class TestAddPrefix { @Test - void shouldHaveSize(){ + void shouldHaveSize() { var resultBuilder = vorgangNummerSupplier.initWithPrefix(); assertThat(resultBuilder).hasSize(6); } + @Test - void shouldAddLastYearNumberFirst(){ + void shouldAddLastYearNumberFirst() { var lastYearNumber = "" + LocalDate.now().getYear() % 10; var resultBuilder = vorgangNummerSupplier.initWithPrefix(); - assertThat(resultBuilder.substring(0,1)).isEqualTo(lastYearNumber); + assertThat(resultBuilder.substring(0, 1)).isEqualTo(lastYearNumber); } @Test - void shouldAddMonthValueSecond(){ + void shouldAddMonthValueSecond() { var monthValue = "%02d".formatted(LocalDate.now().getMonthValue()); var resultBuilder = vorgangNummerSupplier.initWithPrefix(); @@ -65,7 +68,7 @@ class VorgangNummerSupplierTest { } @Test - void shouldAddDayValueThird(){ + void shouldAddDayValueThird() { var dayValue = "%02d".formatted(LocalDate.now().getDayOfMonth()); var resultBuilder = vorgangNummerSupplier.initWithPrefix(); @@ -74,7 +77,7 @@ class VorgangNummerSupplierTest { } @Test - void shouldAddHyphenAtEnd(){ + void shouldAddHyphenAtEnd() { var resultBuilder = vorgangNummerSupplier.initWithPrefix(); assertThat(resultBuilder.charAt(5)).isEqualTo('-'); diff --git a/formsolutions-adapter/src/main/java/de/itvsh/kop/eingangsadapter/formsolutions/FormSolutionsAttachmentsMapper.java b/formsolutions-adapter/src/main/java/de/itvsh/kop/eingangsadapter/formsolutions/FormSolutionsAttachmentsMapper.java index 8b1cec63b3749e014bb49f84a1b3f0afdc16f678..3c55f9a4782c5d7e8d6ffd28b00e8ecb1c729e13 100644 --- a/formsolutions-adapter/src/main/java/de/itvsh/kop/eingangsadapter/formsolutions/FormSolutionsAttachmentsMapper.java +++ b/formsolutions-adapter/src/main/java/de/itvsh/kop/eingangsadapter/formsolutions/FormSolutionsAttachmentsMapper.java @@ -44,9 +44,7 @@ class FormSolutionsAttachmentsMapper { public static final String FILE_GROUP_ZIP_NAME = "gezippte Anhänge"; List<IncomingFileGroup> mapAttachments(Map<String, Object> data) { - var result = mapZipRepresentation(Optional.ofNullable((String) data.get(ZIP))); - data.remove(ZIP); - return result; + return mapZipRepresentation(Optional.ofNullable((String) data.get(ZIP))); } List<IncomingFileGroup> mapZipRepresentation(Optional<String> encodedZip) {