diff --git a/semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmAttachedFilesMapper.java b/semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmFileCountMapper.java similarity index 68% rename from semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmAttachedFilesMapper.java rename to semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmFileCountMapper.java index 6daeceab9dfd7e9f397b46fa087792ae4dff7560..e706d63e31d8161b639826fe9f22b06beeda65d1 100644 --- a/semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmAttachedFilesMapper.java +++ b/semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmFileCountMapper.java @@ -29,19 +29,14 @@ import de.ozgcloud.eingang.common.formdata.FormData; import de.ozgcloud.eingang.semantik.enginebased.FilesMapperHelper; @Component -class AfmAttachedFilesMapper implements AfmEngineBasedMapper { +class AfmFileCountMapper implements AfmEngineBasedMapper { @Override public FormData parseFormData(FormData formData) { - var formDataBuilder = formData.toBuilder(); - FilesMapperHelper.getAttachedFileGroups(formData) - .ifPresent(fileGroups -> formDataBuilder - .attachments(fileGroups) - .numberOfAttachments(FilesMapperHelper.countAttachedFiles(fileGroups))); - FilesMapperHelper.getRepresentations(formData) - .ifPresent(representations -> formDataBuilder.representations(representations).numberOfRepresentations(representations.size())); - - return FilesMapperHelper.removeProcessedData(formDataBuilder.build()); + return formData.toBuilder() + .numberOfRepresentations(formData.getRepresentations().size()) + .numberOfAttachments(FilesMapperHelper.countAttachedFiles(formData.getAttachments())) + .build(); } -} \ No newline at end of file +} diff --git a/semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/intelliform/IntelliFormRepresentationAdapter.java b/semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/intelliform/IntelliFormRepresentationAdapter.java index 26bae7ab72ab5d78a80ecffad59e1a8b143d2d19..36fb9fa6507228103bb71f8c0d2612d39b868c11 100644 --- a/semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/intelliform/IntelliFormRepresentationAdapter.java +++ b/semantik-adapter/src/main/java/de/ozgcloud/eingang/semantik/enginebased/afm/intelliform/IntelliFormRepresentationAdapter.java @@ -103,7 +103,6 @@ public class IntelliFormRepresentationAdapter { Map.of( HEADER_FIELD, createHeaderMap(document) ).entrySet().stream() - ).collect(ORDERED_MAP_ENTRY_COLLECTOR)) .build(); } diff --git a/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmAttachedFilesMapperTest.java b/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmFileCountMapperTest.java similarity index 75% rename from semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmAttachedFilesMapperTest.java rename to semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmFileCountMapperTest.java index 2643740ae163291151e0573b6b9537514ce0b831..7c63ef8ed048579653880f4ef7904f0b97d9554a 100644 --- a/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmAttachedFilesMapperTest.java +++ b/semantik-adapter/src/test/java/de/ozgcloud/eingang/semantik/enginebased/afm/AfmFileCountMapperTest.java @@ -26,44 +26,40 @@ package de.ozgcloud.eingang.semantik.enginebased.afm; import static org.assertj.core.api.Assertions.*; import java.util.List; -import java.util.Map; import de.ozgcloud.eingang.common.formdata.FormData; import de.ozgcloud.eingang.common.formdata.FormDataTestFactory; import de.ozgcloud.eingang.common.formdata.IncomingFileGroup; import de.ozgcloud.eingang.common.formdata.IncomingFileGroupTestFactory; import de.ozgcloud.eingang.common.formdata.IncomingFileTestFactory; -import de.ozgcloud.eingang.semantik.enginebased.FilesMapperHelper; -import de.ozgcloud.eingang.semantik.enginebased.afm.AfmAttachedFilesMapper; import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; import org.mockito.InjectMocks; import org.mockito.Spy; -class AfmAttachedFilesMapperTest { +class AfmFileCountMapperTest { @Spy @InjectMocks - private AfmAttachedFilesMapper mapper; + private AfmFileCountMapper mapper; - private IncomingFileGroup attachmentWithMultipleFiles = IncomingFileGroupTestFactory.createBuilder() + private final IncomingFileGroup attachmentWithMultipleFiles = IncomingFileGroupTestFactory.createBuilder() .name("anotherAttachment") .clearFiles() .files(List.of(IncomingFileTestFactory.create(), IncomingFileTestFactory.create())) .build(); - private FormData formData = FormDataTestFactory.createBuilder() + private final FormData formData = FormDataTestFactory.createBuilder() .clearAttachments() - .formData(Map.of(FilesMapperHelper.FIELD_NAME_MAPPED_FILES, - Map.of(FilesMapperHelper.ATTACHMENTS, List.of(IncomingFileGroupTestFactory.create(), attachmentWithMultipleFiles)))) + .attachments(List.of(IncomingFileGroupTestFactory.create(), attachmentWithMultipleFiles)) .build(); @Nested class TestParseFormData { @Test - void shouldMapAttachments() { + void shouldKeepAttachments() { var parsedFormData = parseFormData(); assertThat(parsedFormData.getAttachments()).hasSize(2); @@ -79,7 +75,7 @@ class AfmAttachedFilesMapperTest { } @Test - void shouldMapRepresentations() { + void shouldKeepRepresentations() { var parsedFormData = parseFormData(); assertThat(parsedFormData.getRepresentations()).hasSize(1); @@ -92,15 +88,8 @@ class AfmAttachedFilesMapperTest { assertThat(parsedFormData.getNumberOfRepresentations()).isEqualTo(1); } - @Test - void shouldRemoveFilesFromMap() { - var parsedFormData = parseFormData(); - - assertThat(parsedFormData.getFormData().get(FilesMapperHelper.FIELD_NAME_MAPPED_FILES)).isNull(); - } - private FormData parseFormData() { return mapper.parseFormData(formData); } } -} \ No newline at end of file +}