diff --git a/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/CollaborationRequest.java b/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/CollaborationRequest.java index 05cff61ad6237e0c79833f0aa3ed99bf32618d24..05d26d739c4cb777a8ee6d6892e61f4c3a0e5a40 100644 --- a/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/CollaborationRequest.java +++ b/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/CollaborationRequest.java @@ -25,6 +25,7 @@ package de.ozgcloud.collaboration; import jakarta.validation.Valid; import jakarta.validation.constraints.NotBlank; +import jakarta.validation.constraints.NotNull; import de.ozgcloud.collaboration.fachstelle.Fachstelle; import de.ozgcloud.collaboration.request.CollaborationRequestId; @@ -62,5 +63,6 @@ public class CollaborationRequest { @NotBlank private String beschreibung; @Valid + @NotNull private Fachstelle zustaendigeStelle; } diff --git a/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/CollaborationServiceITCase.java b/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/CollaborationServiceITCase.java index a054e1b0bfa1a70307f72de9cb915dcb772ea2a9..c701bc469f5d9386e876b92869f0762a05325297 100644 --- a/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/CollaborationServiceITCase.java +++ b/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/CollaborationServiceITCase.java @@ -30,6 +30,7 @@ import jakarta.validation.ConstraintViolationException; import org.apache.commons.lang3.StringUtils; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Nested; +import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.NullAndEmptySource; import org.junit.jupiter.params.provider.ValueSource; @@ -81,7 +82,7 @@ class CollaborationServiceITCase { assertThrows(ConstraintViolationException.class, () -> service.createCollaborationRequest(request)); } - @DisplayName("should validate zustaendigeStelle") + @DisplayName("should validate subjectId of zustaendigeStelle") @ParameterizedTest(name = "fail when subjectId: \"{0}\"") @NullAndEmptySource @ValueSource(strings = { StringUtils.SPACE }) @@ -92,6 +93,16 @@ class CollaborationServiceITCase { assertThrows(ConstraintViolationException.class, () -> service.createCollaborationRequest(request)); } + + @DisplayName("should validate zustaendigeStelle") + @Test + void shouldValidateCollaborationZustaendigeStelle() { + var request = CollaborationRequestTestFactory.createBuilder() + .zustaendigeStelle(null) + .build(); + + assertThrows(ConstraintViolationException.class, () -> service.createCollaborationRequest(request)); + } } @Nested