From 55e2e22d25922fffa7e447cc98ee32381bcbbf83 Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Thu, 19 Dec 2024 15:15:46 +0100
Subject: [PATCH] OZG-7350 add not null validation to type of Fachstelle
---
.../ozgcloud/collaboration/fachstelle/Fachstelle.java | 2 ++
.../collaboration/CollaborationServiceITCase.java | 10 ++++++++++
2 files changed, 12 insertions(+)
diff --git a/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/fachstelle/Fachstelle.java b/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/fachstelle/Fachstelle.java
index 928ca8d..f426252 100644
--- a/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/fachstelle/Fachstelle.java
+++ b/collaboration-manager-server/src/main/java/de/ozgcloud/collaboration/fachstelle/Fachstelle.java
@@ -1,6 +1,7 @@
package de.ozgcloud.collaboration.fachstelle;
import jakarta.validation.constraints.NotBlank;
+import jakarta.validation.constraints.NotNull;
import lombok.Builder;
import lombok.EqualsAndHashCode;
@@ -19,6 +20,7 @@ public class Fachstelle {
private String technicalId;
@NotBlank
private String subjectId;
+ @NotNull
private FachstelleType type;
public enum FachstelleType {
diff --git a/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/CollaborationServiceITCase.java b/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/CollaborationServiceITCase.java
index c701bc4..6247874 100644
--- a/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/CollaborationServiceITCase.java
+++ b/collaboration-manager-server/src/test/java/de/ozgcloud/collaboration/CollaborationServiceITCase.java
@@ -94,6 +94,16 @@ class CollaborationServiceITCase {
assertThrows(ConstraintViolationException.class, () -> service.createCollaborationRequest(request));
}
+ @DisplayName("should validate type of zustaendigeStelle")
+ @Test
+ void shouldValidateCollaborationZustaendigeStelleType() {
+ var request = CollaborationRequestTestFactory.createBuilder()
+ .zustaendigeStelle(FachstelleTestFactory.createBuilder().type(null).build())
+ .build();
+
+ assertThrows(ConstraintViolationException.class, () -> service.createCollaborationRequest(request));
+ }
+
@DisplayName("should validate zustaendigeStelle")
@Test
void shouldValidateCollaborationZustaendigeStelle() {
--
GitLab