From 64d66f3ba7ed4050aad43ed53219eedba8b15624 Mon Sep 17 00:00:00 2001 From: OZGCloud <ozgcloud@mgm-tp.com> Date: Fri, 19 Jul 2024 11:48:26 +0200 Subject: [PATCH] OZG-5636 refactor buildAttachment method --- .../bayernid/proxy/UploadStreamObserver.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/bayernid-proxy-impl/src/main/java/de/ozgcloud/nachrichten/postfach/bayernid/proxy/UploadStreamObserver.java b/bayernid-proxy-impl/src/main/java/de/ozgcloud/nachrichten/postfach/bayernid/proxy/UploadStreamObserver.java index 58b1301..06b5cde 100644 --- a/bayernid-proxy-impl/src/main/java/de/ozgcloud/nachrichten/postfach/bayernid/proxy/UploadStreamObserver.java +++ b/bayernid-proxy-impl/src/main/java/de/ozgcloud/nachrichten/postfach/bayernid/proxy/UploadStreamObserver.java @@ -47,8 +47,6 @@ import lombok.extern.log4j.Log4j2; @RequiredArgsConstructor public class UploadStreamObserver implements StreamObserver<GrpcSendBayernIdMessageRequest> { - static final String ATTACHMENT_FILE_SUFFIX = ".ozg-cloud.tmp"; - private final StreamObserver<GrpcSendBayernIdMessageResponse> responseObserver; private final BayernIdProxyService proxyService; private final BayernIdMessageMapper messageMapper; @@ -82,15 +80,17 @@ public class UploadStreamObserver implements StreamObserver<GrpcSendBayernIdMess } Attachment buildAttachment(GrpcAttachmentMetadata attachmentMetadata) { + InputStream temporallyFile; try { - return Attachment.builder() - .name(attachmentMetadata.getFileName()) - .type(attachmentMetadata.getFileType()) - .content(createTemporallyFile()) - .build(); + temporallyFile = createTemporallyFile(); } catch (IOException e) { throw new TechnicalException("Can not create temporary file for attachment " + attachmentMetadata.getFileName(), e); } + return Attachment.builder() + .name(attachmentMetadata.getFileName()) + .type(attachmentMetadata.getFileType()) + .content(temporallyFile) + .build(); } InputStream createTemporallyFile() throws IOException { -- GitLab