From 3216ed720e43bc64cf45fc49259b5bf00d91dcd6 Mon Sep 17 00:00:00 2001
From: Felix Reichenbach <felix.reichenbach@mgm-tp.com>
Date: Thu, 2 Jan 2025 16:20:42 +0100
Subject: [PATCH] OZG-7037 apply code review comments
---
.../ozgcloud/archive/common/command/CommandService.java | 2 +-
.../de/ozgcloud/archive/common/xta/XtaConfiguration.java | 2 +-
.../de/ozgcloud/archive/common/xta/XtaProperties.java | 8 ++++----
pom.xml | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/archive-manager-server/src/main/java/de/ozgcloud/archive/common/command/CommandService.java b/archive-manager-server/src/main/java/de/ozgcloud/archive/common/command/CommandService.java
index c219117..a1f4e51 100644
--- a/archive-manager-server/src/main/java/de/ozgcloud/archive/common/command/CommandService.java
+++ b/archive-manager-server/src/main/java/de/ozgcloud/archive/common/command/CommandService.java
@@ -44,7 +44,7 @@ public class CommandService {
@Qualifier(ArchiveManagerConfiguration.COMMAND_REMOTE_SERVICE_NAME) // NOSONAR
private final CommandRemoteService remoteService;
- @Qualifier(ArchiveManagerConfiguration.OZGCLOUD_COMMAND_SERVICE_NAME)
+ @Qualifier(ArchiveManagerConfiguration.OZGCLOUD_COMMAND_SERVICE_NAME) // NOSONAR
private final OzgCloudCommandService ozgCloudCommandService;
public Stream<ArchiveManagerCommand> findFinishedCommands(@NonNull String vorgangId) {
diff --git a/archive-manager-server/src/main/java/de/ozgcloud/archive/common/xta/XtaConfiguration.java b/archive-manager-server/src/main/java/de/ozgcloud/archive/common/xta/XtaConfiguration.java
index a58411a..174f586 100644
--- a/archive-manager-server/src/main/java/de/ozgcloud/archive/common/xta/XtaConfiguration.java
+++ b/archive-manager-server/src/main/java/de/ozgcloud/archive/common/xta/XtaConfiguration.java
@@ -36,7 +36,7 @@ class XtaConfiguration {
.msgBoxServiceUrl(xtaProperties.getMsgBoxServiceUrl())
.clientCertKeystore(buildKeystore(xtaProperties.getKeyStore()))
.trustStore(buildKeystore(xtaProperties.getTrustStore()))
- .maxListItems(xtaProperties.getMaxListItems())
+ .maxListItems(xtaProperties.getMaxLoadedMessages())
.clientIdentifiers(xtaProperties.getClientIdentifiers())
.build();
}
diff --git a/archive-manager-server/src/main/java/de/ozgcloud/archive/common/xta/XtaProperties.java b/archive-manager-server/src/main/java/de/ozgcloud/archive/common/xta/XtaProperties.java
index 1ad7ad8..d5409da 100644
--- a/archive-manager-server/src/main/java/de/ozgcloud/archive/common/xta/XtaProperties.java
+++ b/archive-manager-server/src/main/java/de/ozgcloud/archive/common/xta/XtaProperties.java
@@ -35,11 +35,11 @@ public class XtaProperties {
*/
private String managementServiceUrl;
/*
- * Maximum number of Messages loaded from message box.
+ * Maximum number of messages loaded from message box.
*/
- private int maxListItems = 50;
+ private int maxLoadedMessages = 50;
/*
- * Reference to client certifiaction key store.
+ * Reference to client certification key store.
*/
private XtaClientKeyStore keyStore;
/*
@@ -47,7 +47,7 @@ public class XtaProperties {
*/
private XtaClientKeyStore trustStore;
/*
- * Client identifiers used to identify cleint at XTA adapter.
+ * Client identifiers used to identify client at XTA adapter.
*/
private List<XtaIdentifier> clientIdentifiers;
diff --git a/pom.xml b/pom.xml
index 0dab886..2f8e05e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,7 +53,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<vorgang-manager.version>2.18.0</vorgang-manager.version>
<nachrichten-manager.version>2.15.0</nachrichten-manager.version>
- <api-lib.version>0.16.0-PR-38-SNAPSHOT</api-lib.version>
+ <api-lib.version>0.16.0-SNAPSHOT</api-lib.version>
<find-and-replace-maven-plugin.version>1.2.0</find-and-replace-maven-plugin.version>
<protoc-jar-plugin.version>3.11.4</protoc-jar-plugin.version>
<ozgcloud-common.version>4.7.0</ozgcloud-common.version>
--
GitLab