From 090316fb5798fe7b1bada451e71b5524d5bce1c8 Mon Sep 17 00:00:00 2001
From: Krzysztof Witukiewicz <krzysztof.witukiewicz@mgm-tp.com>
Date: Fri, 31 Jan 2025 10:59:58 +0100
Subject: [PATCH] OZG-7262 OZG-7584 Simplify tests
---
.../archive/kommentar/KommentarMapperTest.java | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/archive-manager-server/src/test/java/de/ozgcloud/archive/kommentar/KommentarMapperTest.java b/archive-manager-server/src/test/java/de/ozgcloud/archive/kommentar/KommentarMapperTest.java
index 90d0a00..e42ebae 100644
--- a/archive-manager-server/src/test/java/de/ozgcloud/archive/kommentar/KommentarMapperTest.java
+++ b/archive-manager-server/src/test/java/de/ozgcloud/archive/kommentar/KommentarMapperTest.java
@@ -27,7 +27,6 @@ import static org.assertj.core.api.Assertions.*;
import static org.mockito.ArgumentMatchers.*;
import static org.mockito.Mockito.*;
-import java.util.Collection;
import java.util.Map;
import org.junit.jupiter.api.BeforeEach;
@@ -165,21 +164,16 @@ class KommentarMapperTest {
void shouldCallAttachmentMapper() {
callMapper();
- verify(attachmentMapper).mapAttachments(argThat(this::isCollectionOfAttachmentIds));
+ verify(attachmentMapper).mapAttachments(GrpcKommentarTestFactory.ATTACHMENTS);
}
@Test
void shouldMapAllFields() {
- var kommentar = mapper.mapItemMapToKommentar(GrpcKommentarTestFactory.createItemAsMap());
+ var kommentar = callMapper();
assertThat(kommentar).usingRecursiveComparison().isEqualTo(KommentarTestFactory.create());
}
- @SuppressWarnings("unchecked")
- private boolean isCollectionOfAttachmentIds(Object obj) {
- return obj instanceof Collection && ((Collection<String>) obj).containsAll(GrpcKommentarTestFactory.ATTACHMENTS);
- }
-
private Kommentar callMapper() {
return mapper.mapItemMapToKommentar(GrpcKommentarTestFactory.createItemAsMap());
}
--
GitLab