From dadf1ef4afcfd0f7f0e09f68ff6f4b88ad23209d Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Wed, 27 Mar 2024 12:59:58 +0100
Subject: [PATCH] OZG-5012 remove missplaced verification; remove dev logs
---
.../libs/api-root-shared/src/lib/api-root.service.ts | 3 ---
.../src/lib/resource/resource.service.spec.ts | 10 +---------
.../tech-shared/src/lib/resource/resource.service.ts | 11 -----------
.../libs/vorgang-shared/src/lib/vorgang.service.ts | 3 ---
4 files changed, 1 insertion(+), 26 deletions(-)
diff --git a/alfa-client/libs/api-root-shared/src/lib/api-root.service.ts b/alfa-client/libs/api-root-shared/src/lib/api-root.service.ts
index e6af890e25..838ea15956 100644
--- a/alfa-client/libs/api-root-shared/src/lib/api-root.service.ts
+++ b/alfa-client/libs/api-root-shared/src/lib/api-root.service.ts
@@ -54,9 +54,6 @@ export class ApiRootService {
filter((apiRootStateResource: StateResource<ApiRootResource>) =>
this.shouldEmit(apiRootStateResource),
),
- tap((apiRootStateResource: StateResource<ApiRootResource>) => {
- if (isDevMode()) console.debug('APIROOT SERVICE - GET - EMIT: ', apiRootStateResource);
- }),
startWith(createEmptyStateResource<ApiRootResource>(true)),
);
}
diff --git a/alfa-client/libs/tech-shared/src/lib/resource/resource.service.spec.ts b/alfa-client/libs/tech-shared/src/lib/resource/resource.service.spec.ts
index 92e807edf1..3311716c86 100644
--- a/alfa-client/libs/tech-shared/src/lib/resource/resource.service.spec.ts
+++ b/alfa-client/libs/tech-shared/src/lib/resource/resource.service.spec.ts
@@ -16,9 +16,9 @@ import { singleCold, singleHot } from './marbles';
import { HttpErrorResponse } from '@angular/common/http';
import { createProblemDetail } from 'libs/tech-shared/test/error';
import { HttpError, ProblemDetail } from '../tech.model';
+import { cold } from 'jest-marbles';
import * as ResourceUtil from './resource.util';
-import { cold } from 'jest-marbles';
describe('ResourceService', () => {
let service: ResourceService<Resource, Resource>;
@@ -475,14 +475,6 @@ describe('ResourceService', () => {
service.loadResource = jest.fn();
});
- it('should throw error if stateresource is empty', () => {
- service.stateResource.next(createEmptyStateResource());
-
- expect(() => service.refresh()).toThrowError(
- 'No stateresource exists which can be refreshed.',
- );
- });
-
it('should set reload true on statresource', () => {
service.stateResource.next(createStateResource(createDummyResource()));
diff --git a/alfa-client/libs/tech-shared/src/lib/resource/resource.service.ts b/alfa-client/libs/tech-shared/src/lib/resource/resource.service.ts
index 191966e2a8..c14a661395 100644
--- a/alfa-client/libs/tech-shared/src/lib/resource/resource.service.ts
+++ b/alfa-client/libs/tech-shared/src/lib/resource/resource.service.ts
@@ -54,9 +54,6 @@ export class ResourceService<B extends Resource, T extends Resource> {
),
filter(([stateResource]) => !this.shouldFilter(stateResource)),
map(([stateResource]) => stateResource),
- tap((stateResource: StateResource<T>) => {
- if (isDevMode()) console.debug('RESOURCE SERVICE - GET - EMIT:', stateResource);
- }),
startWith(createEmptyStateResource<T>(true)),
);
}
@@ -174,17 +171,9 @@ export class ResourceService<B extends Resource, T extends Resource> {
}
public refresh(): void {
- this.verifyStateResource();
this.stateResource.next({ ...this.stateResource.value, reload: true });
}
- private verifyStateResource(): void {
- throwErrorOn(
- isNull(this.getStateResource()),
- 'No stateresource exists which can be refreshed.',
- );
- }
-
public canEdit(): boolean {
return this.hasLinkRel(this.config.editLinkRel);
}
diff --git a/alfa-client/libs/vorgang-shared/src/lib/vorgang.service.ts b/alfa-client/libs/vorgang-shared/src/lib/vorgang.service.ts
index ca986c4d81..a9edc7a138 100644
--- a/alfa-client/libs/vorgang-shared/src/lib/vorgang.service.ts
+++ b/alfa-client/libs/vorgang-shared/src/lib/vorgang.service.ts
@@ -72,9 +72,6 @@ export class VorgangService {
);
}),
map(([vorgangWithEingang]) => vorgangWithEingang),
- tap((vorgangWithEingang: StateResource<VorgangWithEingangResource>) => {
- if (isDevMode()) console.debug('VORGANG SERVICE - GET - EMIT: ', vorgangWithEingang);
- }),
startWith(createEmptyStateResource<VorgangWithEingangResource>(true)),
);
}
--
GitLab