diff --git a/alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/ExportConfiguration.java b/alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/ExportConfiguration.java index b28f0c4de38e0cd4b7ee3201f014ad43909b90c6..1ad1ea37461edf34756e2f478e3b56cc74e2bd88 100644 --- a/alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/ExportConfiguration.java +++ b/alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/ExportConfiguration.java @@ -23,7 +23,7 @@ class ExportConfiguration { @Bean static Validator configurationPropertiesValidator() { - return new BehoerdenschluesselPropertiesValidator(); + return new XdomeaPropertiesValidator(); } @Bean diff --git a/alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidator.java b/alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/XdomeaPropertiesValidator.java similarity index 85% rename from alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidator.java rename to alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/XdomeaPropertiesValidator.java index 1789c74036f8171291dd229dd70396f8a31c6948..8cc320ecb6346fbc79bd42a2826b08bec38aaff3 100644 --- a/alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidator.java +++ b/alfa-xdomea/src/main/java/de/ozgcloud/alfa/export/XdomeaPropertiesValidator.java @@ -7,7 +7,7 @@ import org.springframework.validation.Validator; import de.ozgcloud.common.errorhandling.TechnicalException; -public class BehoerdenschluesselPropertiesValidator implements Validator { +public class XdomeaPropertiesValidator implements Validator { @Override public boolean supports(Class<?> clazz) { @@ -17,6 +17,10 @@ public class BehoerdenschluesselPropertiesValidator implements Validator { @Override public void validate(Object target, Errors errors) { var properties = (XdomeaProperties) target; + validateBehoerdenschluesselProperties(errors, properties); + } + + private void validateBehoerdenschluesselProperties(Errors errors, XdomeaProperties properties) { if (StringUtils.isNotBlank(properties.getBehoerdenschluessel())) { validateNotBlank("behoerdenschluesselUri", properties, errors); validateNotBlank("behoerdenschluesselVersion", properties, errors); diff --git a/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidatorITCase.java b/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidatorITCase.java index 67a235f2095b6461c311c41c22f479b017bb7c5f..d74d131288e84ad0a38b471d5ccbd9a72beb6f7b 100644 --- a/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidatorITCase.java +++ b/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidatorITCase.java @@ -12,6 +12,6 @@ class BehoerdenschluesselPropertiesValidatorITCase { @Test void shouldExistInApplicationContext(ApplicationContext context) { - assertThat(context.getBean("configurationPropertiesValidator")).isNotNull().isInstanceOf(BehoerdenschluesselPropertiesValidator.class); + assertThat(context.getBean("configurationPropertiesValidator")).isNotNull().isInstanceOf(XdomeaPropertiesValidator.class); } } diff --git a/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidatorTest.java b/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/XdomeaPropertiesValidatorTest.java similarity index 84% rename from alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidatorTest.java rename to alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/XdomeaPropertiesValidatorTest.java index eb81f121bc6a7ae12c425c9825f7e1ec02d38bd3..cd6cf19672ab8118254ded34a4b2444d921f8f55 100644 --- a/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/BehoerdenschluesselPropertiesValidatorTest.java +++ b/alfa-xdomea/src/test/java/de/ozgcloud/alfa/export/XdomeaPropertiesValidatorTest.java @@ -9,10 +9,10 @@ import org.junit.jupiter.params.provider.NullAndEmptySource; import org.mockito.Spy; import org.springframework.validation.Errors; -class BehoerdenschluesselPropertiesValidatorTest { +class XdomeaPropertiesValidatorTest { @Spy - private BehoerdenschluesselPropertiesValidator validator; + private XdomeaPropertiesValidator validator; @Nested class TestSupports { @@ -57,7 +57,7 @@ class BehoerdenschluesselPropertiesValidatorTest { @ParameterizedTest @NullAndEmptySource void shouldHaveFieldErrors(String uri) { - var properties = havingBehoerdenschluesselUri(uri); + var properties = withBehoerdenschluesselUri(uri); var errors = validate(properties); @@ -67,7 +67,7 @@ class BehoerdenschluesselPropertiesValidatorTest { @ParameterizedTest @NullAndEmptySource void shouldHaveMeaningfulErrorMessage(String uri) { - var properties = havingBehoerdenschluesselUri(uri); + var properties = withBehoerdenschluesselUri(uri); var errors = validate(properties); @@ -77,14 +77,14 @@ class BehoerdenschluesselPropertiesValidatorTest { @ParameterizedTest @NullAndEmptySource void shouldHaveErrorCode(String uri) { - var properties = havingBehoerdenschluesselUri(uri); + var properties = withBehoerdenschluesselUri(uri); var errors = validate(properties); assertThat(errors.getFieldError(PROPERTY_NAME).getCode()).isEqualTo(ERROR_CODE); } - private XdomeaProperties havingBehoerdenschluesselUri(String uri) { + private XdomeaProperties withBehoerdenschluesselUri(String uri) { return XdomeaPropertiesTestFactory.createBuilder().behoerdenschluesselUri(uri).build(); } } @@ -99,7 +99,7 @@ class BehoerdenschluesselPropertiesValidatorTest { @ParameterizedTest @NullAndEmptySource void shouldHaveFieldErrors(String version) { - var properties = havingBehoerdenschluesselVersion(version); + var properties = withBehoerdenschluesselVersion(version); var errors = validate(properties); @@ -109,7 +109,7 @@ class BehoerdenschluesselPropertiesValidatorTest { @ParameterizedTest @NullAndEmptySource void shouldHaveMeaningfulErrorMessage(String version) { - var properties = havingBehoerdenschluesselVersion(version); + var properties = withBehoerdenschluesselVersion(version); var errors = validate(properties); @@ -119,14 +119,14 @@ class BehoerdenschluesselPropertiesValidatorTest { @ParameterizedTest @NullAndEmptySource void shouldHaveErrorCode(String version) { - var properties = havingBehoerdenschluesselVersion(version); + var properties = withBehoerdenschluesselVersion(version); var errors = validate(properties); assertThat(errors.getFieldError(PROPERTY_NAME).getCode()).isEqualTo(ERROR_CODE); } - private XdomeaProperties havingBehoerdenschluesselVersion(String version) { + private XdomeaProperties withBehoerdenschluesselVersion(String version) { return XdomeaPropertiesTestFactory.createBuilder().behoerdenschluesselVersion(version).build(); } }