From 6a33a4695f4956ada093cc04d5591f9cc880450b Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Fri, 4 Aug 2023 11:05:20 +0200
Subject: [PATCH] OZG-4087 OZG-4165 change service methodname and signature
---
.../main/java/de/ozgcloud/xdomea/ExportData.java | 14 ++++++++++++++
.../java/de/ozgcloud/xdomea/XDomeaController.java | 4 ----
.../de/ozgcloud/xdomea/XDomeaModelAssembler.java | 4 ----
.../java/de/ozgcloud/xdomea/XDomeaService.java | 4 ++--
.../de/ozgcloud/xdomea/ExportDataTestFactory.java | 13 +++++++++++++
.../de/ozgcloud/xdomea/XDomeaControllerTest.java | 5 -----
.../ozgcloud/xdomea/XDomeaModelAssemblerTest.java | 5 -----
.../java/de/ozgcloud/xdomea/XDomeaServiceTest.java | 4 ++--
8 files changed, 31 insertions(+), 22 deletions(-)
create mode 100644 alfa-xdomea/src/main/java/de/ozgcloud/xdomea/ExportData.java
delete mode 100644 alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaController.java
delete mode 100644 alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaModelAssembler.java
create mode 100644 alfa-xdomea/src/test/java/de/ozgcloud/xdomea/ExportDataTestFactory.java
delete mode 100644 alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaControllerTest.java
delete mode 100644 alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaModelAssemblerTest.java
diff --git a/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/ExportData.java b/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/ExportData.java
new file mode 100644
index 0000000000..1470dc7023
--- /dev/null
+++ b/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/ExportData.java
@@ -0,0 +1,14 @@
+package de.ozgcloud.xdomea;
+
+import lombok.AccessLevel;
+import lombok.Builder;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.ToString;
+
+@Getter
+@Builder(toBuilder = true)
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+@ToString
+class ExportData {
+}
diff --git a/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaController.java b/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaController.java
deleted file mode 100644
index 382b144225..0000000000
--- a/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaController.java
+++ /dev/null
@@ -1,4 +0,0 @@
-package de.ozgcloud.xdomea;
-
-class XDomeaController {
-}
diff --git a/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaModelAssembler.java b/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaModelAssembler.java
deleted file mode 100644
index 85e96158a3..0000000000
--- a/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaModelAssembler.java
+++ /dev/null
@@ -1,4 +0,0 @@
-package de.ozgcloud.xdomea;
-
-class XDomeaModelAssembler {
-}
diff --git a/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaService.java b/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaService.java
index 5cc88680d4..1589b93d63 100644
--- a/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaService.java
+++ b/alfa-xdomea/src/main/java/de/ozgcloud/xdomea/XDomeaService.java
@@ -12,11 +12,11 @@ import de.itvsh.kop.common.errorhandling.TechnicalException;
@Service
class XDomeaService {
- public ByteArrayOutputStream createVorgangExport() {
+ public ByteArrayOutputStream createExport(ExportData exportData) {
ByteArrayOutputStream outputBytes = new ByteArrayOutputStream();
try (ZipOutputStream zipOutputStream = new ZipOutputStream(outputBytes)) {
- putZipEntry("fake_file.txt", "data", zipOutputStream);
+ putZipEntry("export_test.txt", "test", zipOutputStream);
} catch (IOException ioe) {
throw new TechnicalException("Error creating zip file with Vorgang export", ioe);
diff --git a/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/ExportDataTestFactory.java b/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/ExportDataTestFactory.java
new file mode 100644
index 0000000000..63fc2cc5df
--- /dev/null
+++ b/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/ExportDataTestFactory.java
@@ -0,0 +1,13 @@
+package de.ozgcloud.xdomea;
+
+class ExportDataTestFactory {
+
+ public static ExportData create() {
+ return createBuilder().build();
+ }
+
+ public static ExportData.ExportDataBuilder createBuilder() {
+ return ExportData.builder();
+ }
+
+}
diff --git a/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaControllerTest.java b/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaControllerTest.java
deleted file mode 100644
index 905bc9fa14..0000000000
--- a/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaControllerTest.java
+++ /dev/null
@@ -1,5 +0,0 @@
-package de.ozgcloud.xdomea;
-
-class XDomeaControllerTest {
-
-}
\ No newline at end of file
diff --git a/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaModelAssemblerTest.java b/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaModelAssemblerTest.java
deleted file mode 100644
index cdec514ccf..0000000000
--- a/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaModelAssemblerTest.java
+++ /dev/null
@@ -1,5 +0,0 @@
-package de.ozgcloud.xdomea;
-
-class XDomeaModelAssemblerTest {
-
-}
\ No newline at end of file
diff --git a/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaServiceTest.java b/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaServiceTest.java
index 99312919ce..0a3a7c716d 100644
--- a/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaServiceTest.java
+++ b/alfa-xdomea/src/test/java/de/ozgcloud/xdomea/XDomeaServiceTest.java
@@ -10,11 +10,11 @@ class XDomeaServiceTest {
private XDomeaService service = new XDomeaService();
@Nested
- class TestCreateVorgangExport {
+ class TestCreateExport {
@Test
void shouldCreate() {
- var zipBytesStream = service.createVorgangExport();
+ var zipBytesStream = service.createExport(ExportDataTestFactory.create());
assertThat(zipBytesStream).isNotNull();
assertThat(zipBytesStream.toByteArray()).hasSizeGreaterThan(100);
--
GitLab