From 1f639415186703b756579bc25e6b3d52b95c7aef Mon Sep 17 00:00:00 2001
From: OZGCloud <ozgcloud@mgm-tp.com>
Date: Thu, 12 Sep 2024 11:52:41 +0200
Subject: [PATCH] OZG-6103 OZG-6631 Move attribute role to host element
---
.../src/lib/navbar/nav-item/nav-item.component.spec.ts | 8 ++++++++
.../src/lib/navbar/nav-item/nav-item.component.ts | 5 +++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.spec.ts b/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.spec.ts
index f33524b795..71b3e7c98f 100644
--- a/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.spec.ts
+++ b/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.spec.ts
@@ -61,4 +61,12 @@ describe('NavItemComponent', () => {
});
});
});
+
+ describe('template', () => {
+ describe('host element role attribute', () => {
+ it('should be "menuitem"', () => {
+ expect(fixture.nativeElement.getAttribute('role')).toBe('menuitem');
+ });
+ });
+ });
});
diff --git a/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.ts b/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.ts
index d5f54907fe..14acc1a1b2 100644
--- a/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.ts
+++ b/alfa-client/libs/design-system/src/lib/navbar/nav-item/nav-item.component.ts
@@ -1,5 +1,5 @@
import { CommonModule } from '@angular/common';
-import { Component, Input } from '@angular/core';
+import { Component, HostBinding, Input } from '@angular/core';
import { RouterLink, RouterLinkActive } from '@angular/router';
@Component({
@@ -14,7 +14,6 @@ import { RouterLink, RouterLinkActive } from '@angular/router';
'border border-transparent hover:border-primary',
'outline-2 outline-offset-4 outline-focus focus-visible:border-background-200',
]"
- role="menuitem"
[attr.data-test-id]="'link-to-' + to"
>
<ng-content select="[icon]" />
@@ -24,4 +23,6 @@ import { RouterLink, RouterLinkActive } from '@angular/router';
export class NavItemComponent {
@Input({ required: true }) caption!: string;
@Input() to: string;
+
+ @HostBinding('attr.role') role = 'menuitem';
}
--
GitLab