diff --git a/src/test/java/de/ozgcloud/admin/setting/PropertySourceTestFactory.java b/src/test/java/de/ozgcloud/admin/setting/PropertySourceTestFactory.java deleted file mode 100644 index 69a8565c2ddc55f26a4faba0632e7ac81d5b5ce9..0000000000000000000000000000000000000000 --- a/src/test/java/de/ozgcloud/admin/setting/PropertySourceTestFactory.java +++ /dev/null @@ -1,19 +0,0 @@ -package de.ozgcloud.admin.setting; - -import org.apache.commons.lang3.StringUtils; -import org.springframework.cloud.config.environment.PropertySource; - -import de.ozgcloud.admin.setting.postfach.PostfachSettingBodyTestFactory; -import lombok.AccessLevel; -import lombok.NoArgsConstructor; - -@NoArgsConstructor(access = AccessLevel.PRIVATE) -public class PropertySourceTestFactory { - public static PropertySource createVorgangManager() { - return new PropertySource(StringUtils.EMPTY, PostfachSettingBodyTestFactory.createPostfachAsFlattenedMapVorgangManager()); - } - - public static PropertySource createAlfa() { - return new PropertySource(StringUtils.EMPTY, PostfachSettingBodyTestFactory.createPostfachAsFlattenedMapAlfa()); - } -} \ No newline at end of file diff --git a/src/test/java/de/ozgcloud/admin/setting/SettingEnvironmentRepositoryTest.java b/src/test/java/de/ozgcloud/admin/setting/SettingEnvironmentRepositoryTest.java index bfd92fc4a617f53a47edda16e09a972926965967..4bb93d6f696c096c9b537ac4943c41539031aaff 100644 --- a/src/test/java/de/ozgcloud/admin/setting/SettingEnvironmentRepositoryTest.java +++ b/src/test/java/de/ozgcloud/admin/setting/SettingEnvironmentRepositoryTest.java @@ -39,9 +39,6 @@ class SettingEnvironmentRepositoryTest { private static final String ALFA = "Alfa"; private static final String VORGANG_MANAGER = "OzgCloud_VorgangManager"; - // private static final AlfaSettingDTO ALFA_SETTING_DTO = - // AlfaSettingDTOTestFactory.create(); - private static final VorgangManagerSettingDTO VORGANG_MANAGER_SETTING_DTO = VorgangManagerSettingDTOTestFactory.create(); @Nested class TestFindOne { diff --git a/src/test/java/de/ozgcloud/admin/setting/SettingEnvironmentTestFactory.java b/src/test/java/de/ozgcloud/admin/setting/SettingEnvironmentTestFactory.java deleted file mode 100644 index d65acd464924309219656c872db4e840850703f4..0000000000000000000000000000000000000000 --- a/src/test/java/de/ozgcloud/admin/setting/SettingEnvironmentTestFactory.java +++ /dev/null @@ -1,20 +0,0 @@ -package de.ozgcloud.admin.setting; - -import org.springframework.cloud.config.environment.Environment; - -public class SettingEnvironmentTestFactory { - public static final String ALFA = "Alfa"; - public static final String VORGANG_MANAGER = "OzgCloud_VorgangManager"; - - public static Environment createAlfa() { - var environment = new Environment(ALFA); - environment.add(PropertySourceTestFactory.createAlfa()); - return environment; - } - - public static Environment createVorgangManager() { - var environment = new Environment(VORGANG_MANAGER); - environment.add(PropertySourceTestFactory.createVorgangManager()); - return environment; - } -} diff --git a/src/test/java/de/ozgcloud/admin/setting/SettingServiceTest.java b/src/test/java/de/ozgcloud/admin/setting/SettingServiceTest.java index 96d0bdef53b7a20a4d5cd467087116745339da07..00af130bc3b191d9c1ff8b02af5812c628922662 100644 --- a/src/test/java/de/ozgcloud/admin/setting/SettingServiceTest.java +++ b/src/test/java/de/ozgcloud/admin/setting/SettingServiceTest.java @@ -4,6 +4,8 @@ import static org.assertj.core.api.Assertions.*; import static org.mockito.ArgumentMatchers.*; import static org.mockito.Mockito.*; +import java.util.Optional; + import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; @@ -28,12 +30,10 @@ class SettingServiceTest { @Mock private SettingMapper mapper; - private final String POSTFACH = "Postfach"; private final PostfachSettingBody postfach = PostfachSettingBodyTestFactory.create(); - private final Setting settingWithPostfach = SettingTestFactory.createBuilder().name(POSTFACH).settingBody(postfach).build(); - @Captor - private ArgumentCaptor<PostfachSettingBody> postfachCaptor; + private static final String POSTFACH = "Postfach"; + private final Setting settingWithPostfach = SettingTestFactory.createBuilder().name(POSTFACH).settingBody(postfach).build(); @Nested class TestGetAlfaSettingDTO { @@ -57,20 +57,12 @@ class SettingServiceTest { } @Test - void shouldCallMapperWithPostfach() { - when(mapper.mapAlfaPostfach(alfaBuilderCaptor.capture(), postfachCaptor.capture())).thenReturn(AlfaSettingDTOTestFactory.createBuilder()); - - service.getAlfaSettingDTO(); - - assertThat(postfachCaptor.getValue()).isEqualTo(postfach); - } - - @Test - void shouldCallMapperWithAlfaBuilder() { - when(mapper.mapAlfaPostfach(alfaBuilderCaptor.capture(), postfachCaptor.capture())).thenReturn(AlfaSettingDTOTestFactory.createBuilder()); + void shouldCallMapperWithEmptyBuilderAndPostfach() { + when(mapper.mapAlfaPostfach(any(), any())).thenReturn(AlfaSettingDTOTestFactory.createBuilder()); service.getAlfaSettingDTO(); + verify(mapper).mapAlfaPostfach(alfaBuilderCaptor.capture(), eq(postfach)); assertThat(alfaBuilderCaptor.getValue()).usingRecursiveComparison().isEqualTo(AlfaSettingDTO.builder()); } @@ -92,48 +84,67 @@ class SettingServiceTest { private final VorgangManagerSettingDTO vorgangManagerSetting = VorgangManagerSettingDTOTestFactory.create(); @BeforeEach - void mockRepository() { + void mockGetSettingWithPostfachFromDb() { doReturn(postfach).when(service).getSettingWithPostfachFromDb(); } - @Test - void shouldCallGetSettingWithPostfachFromDb() { + @BeforeEach + void mockMapper() { when(mapper.mapVorgangManagerPostfach(any(), any())).thenReturn(VorgangManagerSettingDTOTestFactory.createBuilder()); + } + @Test + void shouldCallGetSettingWithPostfachFromDb() { service.getVorgangManagerSettingDTO(); verify(service).getSettingWithPostfachFromDb(); } @Test - void shouldCallMapperWithPostfach() { - when(mapper.mapVorgangManagerPostfach(vorgangManagerBuilderCaptor.capture(), postfachCaptor.capture())) - .thenReturn(VorgangManagerSettingDTOTestFactory.createBuilder()); - + void shouldCallMapperWithEmptyBuilderAndPostfach() { service.getVorgangManagerSettingDTO(); - assertThat(postfachCaptor.getValue()).isEqualTo(postfach); + verify(mapper).mapVorgangManagerPostfach(vorgangManagerBuilderCaptor.capture(), eq(postfach)); + assertThat(vorgangManagerBuilderCaptor.getValue()).usingRecursiveComparison().isEqualTo(VorgangManagerSettingDTO.builder()); } @Test - void shouldCallMapperWithVorgangManagerBuilder() { - when(mapper.mapVorgangManagerPostfach(vorgangManagerBuilderCaptor.capture(), postfachCaptor.capture())) - .thenReturn(VorgangManagerSettingDTOTestFactory.createBuilder()); + void shouldReturnBuiltVorgangManagerSettingDTO() { + var resultSettingDTO = service.getVorgangManagerSettingDTO(); - service.getVorgangManagerSettingDTO(); + assertThat(resultSettingDTO).usingRecursiveComparison().isEqualTo(vorgangManagerSetting); + } - assertThat(vorgangManagerBuilderCaptor.getValue()).usingRecursiveComparison().isEqualTo(VorgangManagerSettingDTO.builder()); + } + + @Nested + class TestGetSettingWithPostfachFromDb { + @Test + void shouldCallRepository() { + when(repository.findOneByName(POSTFACH)).thenReturn(Optional.of(settingWithPostfach)); + + service.getSettingWithPostfachFromDb(); + + verify(repository).findOneByName(POSTFACH); } @Test - void shouldReturnBuiltVorgangManagerSettingDTO() { - when(mapper.mapVorgangManagerPostfach(any(), any())).thenReturn(VorgangManagerSettingDTOTestFactory.createBuilder()); + void shouldReturnPostfachSettingBody() { + when(repository.findOneByName(POSTFACH)).thenReturn(Optional.of(settingWithPostfach)); - var resultSettingDTO = service.getVorgangManagerSettingDTO(); + var returnedBody = service.getSettingWithPostfachFromDb(); - assertThat(resultSettingDTO).usingRecursiveComparison().isEqualTo(vorgangManagerSetting); + assertThat(returnedBody).isEqualTo(postfach); } + @Test + void shouldReturnEmptyPostfachSettingBodyForEmptySetting() { + when(repository.findOneByName(POSTFACH)).thenReturn(Optional.empty()); + + var returnedBody = service.getSettingWithPostfachFromDb(); + + assertThat(returnedBody).usingRecursiveComparison().isEqualTo(PostfachSettingBody.builder().build()); + } } }