diff --git a/src/main/java/de/ozgcloud/admin/keycloak/GroupMapper.java b/src/main/java/de/ozgcloud/admin/keycloak/GroupMapper.java index 2559aec6b8f68b0b3c7572217ac9ab2d0c039dc7..c71151ecd630bde09ea3ca835430031be361d34b 100644 --- a/src/main/java/de/ozgcloud/admin/keycloak/GroupMapper.java +++ b/src/main/java/de/ozgcloud/admin/keycloak/GroupMapper.java @@ -49,10 +49,10 @@ abstract class GroupMapper { return values.getFirst(); } - @Mapping(target = "attributes", expression = "java(getAttributes(groupToAdd))") + @Mapping(target = "attributes", expression = "java(buildGroupAttributes(groupToAdd))") public abstract GroupRepresentation toGroupRepresentation(AddGroupData groupToAdd); - Map<String, List<String>> getAttributes(AddGroupData groupToAdd) { + Map<String, List<String>> buildGroupAttributes(AddGroupData groupToAdd) { var organisationsEinheitId = groupToAdd.getOrganisationsEinheitId(); return StringUtils.isNotBlank(organisationsEinheitId) ? Map.of(keycloakApiProperties.getOrganisationsEinheitIdKey(), List.of(organisationsEinheitId)) : diff --git a/src/test/java/de/ozgcloud/admin/keycloak/GroupMapperTest.java b/src/test/java/de/ozgcloud/admin/keycloak/GroupMapperTest.java index 7d0c09d55ffd100e1dae94a66c2865869a8b0717..cbe73bd7b0186d895a6ff8140940ad478bc8f851 100644 --- a/src/test/java/de/ozgcloud/admin/keycloak/GroupMapperTest.java +++ b/src/test/java/de/ozgcloud/admin/keycloak/GroupMapperTest.java @@ -253,7 +253,7 @@ class GroupMapperTest { @BeforeEach void init() { - doReturn(ATTRIBUTES).when(mapper).getAttributes(addGroupData); + doReturn(ATTRIBUTES).when(mapper).buildGroupAttributes(addGroupData); } @Test @@ -271,10 +271,10 @@ class GroupMapperTest { } @Test - void shouldGetAttributes() { + void shouldBuildGroupAttributes() { callMapper(); - verify(mapper).getAttributes(addGroupData); + verify(mapper).buildGroupAttributes(addGroupData); } @Test @@ -290,14 +290,14 @@ class GroupMapperTest { } @Nested - class TestGetAttributes { + class TestBuildGroupAttributes { @ParameterizedTest @NullAndEmptySource void shouldReturnEmptyMap(String organisationsEinheitId) { var addGroupData = AddGroupDataTestFactory.createBuilder().organisationsEinheitId(organisationsEinheitId).build(); - var attributes = mapper.getAttributes(addGroupData); + var attributes = mapper.buildGroupAttributes(addGroupData); assertThat(attributes).isEmpty(); } @@ -306,7 +306,7 @@ class GroupMapperTest { void shouldAddOrganisationsEinheitIdToAttributes() { givenOrganisationsEinheitIdProperty(); - var attributes = mapper.getAttributes(AddGroupDataTestFactory.create()); + var attributes = mapper.buildGroupAttributes(AddGroupDataTestFactory.create()); assertThat(attributes).hasSize(1).containsEntry(ORGANIZATIONS_EINHEIT_ID_ATTRIBUTE, List.of(GroupTestFactory.ORGANISATIONS_EINHEIT_ID)); }