From a853c88a7e2f3c90fa2241b5603a783b27dd05ae Mon Sep 17 00:00:00 2001 From: OZGCloud <ozgcloud@mgm-tp.com> Date: Mon, 28 Oct 2024 13:30:04 +0100 Subject: [PATCH] OZG-6867 Renamed method getAddedResourceIdFromResponse() --- .../de/ozgcloud/admin/keycloak/KeycloakApiService.java | 4 ++-- .../ozgcloud/admin/keycloak/KeycloakApiServiceTest.java | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/de/ozgcloud/admin/keycloak/KeycloakApiService.java b/src/main/java/de/ozgcloud/admin/keycloak/KeycloakApiService.java index 057d0ab9..888f98c8 100644 --- a/src/main/java/de/ozgcloud/admin/keycloak/KeycloakApiService.java +++ b/src/main/java/de/ozgcloud/admin/keycloak/KeycloakApiService.java @@ -21,11 +21,11 @@ class KeycloakApiService { public String addGroup(GroupRepresentation groupRepresentation) { try (var response = groupsResource.add(groupRepresentation)) { - return getAddedResourceIdFromResponse(response); + return getCreatedResourceIdFromResponse(response); } } - String getAddedResourceIdFromResponse(Response response) { + String getCreatedResourceIdFromResponse(Response response) { if (response.getStatus() == Response.Status.CREATED.getStatusCode()) { return extractResourceIdFromLocationHeader(response.getHeaderString("Location")); } diff --git a/src/test/java/de/ozgcloud/admin/keycloak/KeycloakApiServiceTest.java b/src/test/java/de/ozgcloud/admin/keycloak/KeycloakApiServiceTest.java index 635351e6..b21abde4 100644 --- a/src/test/java/de/ozgcloud/admin/keycloak/KeycloakApiServiceTest.java +++ b/src/test/java/de/ozgcloud/admin/keycloak/KeycloakApiServiceTest.java @@ -58,7 +58,7 @@ class KeycloakApiServiceTest { @BeforeEach void init() { when(groupsResource.add(groupRepresentation)).thenReturn(response); - doReturn(RESOURCE_ID).when(service).getAddedResourceIdFromResponse(response); + doReturn(RESOURCE_ID).when(service).getCreatedResourceIdFromResponse(response); } @Test @@ -72,7 +72,7 @@ class KeycloakApiServiceTest { void shouldGetAddedResourceIdFromResponse() { callService(); - verify(service).getAddedResourceIdFromResponse(response); + verify(service).getCreatedResourceIdFromResponse(response); } @Test @@ -88,7 +88,7 @@ class KeycloakApiServiceTest { } @Nested - class TestGetAddedResourceIdFromResponse { + class TestGetCreatedResourceIdFromResponse { private final String RESOURCE_ID = GroupRepresentationTestFactory.create().getId(); private final String LOCATION = LoremIpsum.getInstance().getUrl(); @@ -131,7 +131,7 @@ class KeycloakApiServiceTest { } private String callService() { - return service.getAddedResourceIdFromResponse(response); + return service.getCreatedResourceIdFromResponse(response); } } -- GitLab