diff --git a/pom.xml b/pom.xml index 8b9b615b086429211a2a8c09d80075c634e97e9c..57499b2f89a59c71a13e1b4f738e109f72867f86 100644 --- a/pom.xml +++ b/pom.xml @@ -31,7 +31,7 @@ <parent> <groupId>de.ozgcloud.common</groupId> <artifactId>ozgcloud-common-parent</artifactId> - <version>4.7.0-SNAPSHOT</version> + <version>4.8.0-SNAPSHOT</version> <relativePath/> </parent> diff --git a/src/main/java/de/ozgcloud/admin/reporting/AggregationMapping.java b/src/main/java/de/ozgcloud/admin/reporting/AggregationMapping.java index 970a1a1fa0d534875dbcd55556cca87abe19004e..962142f10dbf00a19003a99363601e974dd0c5e4 100644 --- a/src/main/java/de/ozgcloud/admin/reporting/AggregationMapping.java +++ b/src/main/java/de/ozgcloud/admin/reporting/AggregationMapping.java @@ -12,7 +12,6 @@ import org.springframework.data.mongodb.core.mapping.Document; import com.fasterxml.jackson.annotation.JsonIgnore; -import de.ozgcloud.admin.reporting.ReportingAggregationManagerSettingDto.FormIdentifierDto; import lombok.Builder; import lombok.Getter; import lombok.Singular; @@ -32,7 +31,7 @@ public class AggregationMapping { private String name = "aggregationMapping"; @Valid - private FormIdentifierDto formIdentifier; + private FormIdentifier formIdentifier; @NotEmpty @Singular @@ -47,7 +46,9 @@ public class AggregationMapping { private String targetPath; } - static class FormIdentifer { + @Builder + @Getter + static class FormIdentifier { @NotBlank private String formEngineName; @NotBlank diff --git a/src/main/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDTOService.java b/src/main/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDtoService.java similarity index 93% rename from src/main/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDTOService.java rename to src/main/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDtoService.java index f75b2d1022ef4807f416953ba7a6db981ec44206..bd387c7758b2ae4b9cb45a65de9480c09b909537 100644 --- a/src/main/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDTOService.java +++ b/src/main/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDtoService.java @@ -9,7 +9,7 @@ import lombok.RequiredArgsConstructor; @RequiredArgsConstructor @DtoService(SettingConstants.AGGREGATION_MANAGER) -class ReportingAggregationManagerSettingDTOService implements SettingDtoService { +class ReportingAggregationManagerSettingDtoService implements SettingDtoService { private final AggregationMappingRepository repository; private final AggregationMappingMapper mapper; diff --git a/src/test/java/de/ozgcloud/admin/keycloak/KeycloakApiServiceITCase.java b/src/test/java/de/ozgcloud/admin/keycloak/KeycloakApiServiceITCase.java index dc560c4ed05543fb219f0d6e98376dbbe6c977e8..8f121650c6aa2d05a7904a7d2097996a91bfb793 100644 --- a/src/test/java/de/ozgcloud/admin/keycloak/KeycloakApiServiceITCase.java +++ b/src/test/java/de/ozgcloud/admin/keycloak/KeycloakApiServiceITCase.java @@ -29,6 +29,7 @@ import static org.assertj.core.groups.Tuple.tuple; import java.util.List; import java.util.Optional; +import org.assertj.core.api.InstanceOfAssertFactories; import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; import org.keycloak.representations.idm.GroupRepresentation; @@ -122,9 +123,9 @@ class KeycloakApiServiceITCase { private String getOrganisationsEinheitId(GroupRepresentation group) { var attributes = group.getAttributes(); - return attributes.containsKey(properties.getOrganisationsEinheitIdKey()) ? - attributes.get(properties.getOrganisationsEinheitIdKey()).getFirst() : - null; + return attributes.containsKey(properties.getOrganisationsEinheitIdKey()) + ? attributes.get(properties.getOrganisationsEinheitIdKey()).getFirst() + : null; } } @@ -175,7 +176,7 @@ class KeycloakApiServiceITCase { var groupId = service.addGroup(groupToAdd); assertThat(findGroupInKeycloak(groupId)).isPresent().get().extracting(GroupRepresentation::getSubGroups) - .asList().isEmpty(); + .asInstanceOf(InstanceOfAssertFactories.LIST).isEmpty(); } private GroupRepresentation createUniqueGroupRepresentation(String nameSuffix) { diff --git a/src/test/java/de/ozgcloud/admin/reporting/AggregationMappingTestFactory.java b/src/test/java/de/ozgcloud/admin/reporting/AggregationMappingTestFactory.java index a29204fdab7340ea14811b9b21149f102d68053b..1054ba6c3dd37de4155d595fc5eee830d7ab5507 100644 --- a/src/test/java/de/ozgcloud/admin/reporting/AggregationMappingTestFactory.java +++ b/src/test/java/de/ozgcloud/admin/reporting/AggregationMappingTestFactory.java @@ -3,7 +3,7 @@ package de.ozgcloud.admin.reporting; import java.util.UUID; import de.ozgcloud.admin.reporting.AggregationMapping.FieldMapping; -import de.ozgcloud.admin.reporting.ReportingAggregationManagerSettingDto.FormIdentifierDto; +import de.ozgcloud.admin.reporting.AggregationMapping.FormIdentifier; class AggregationMappingTestFactory { @@ -21,7 +21,7 @@ class AggregationMappingTestFactory { public static AggregationMapping.AggregationMappingBuilder createBuilder() { return AggregationMapping.builder() .id(UUID.randomUUID().toString()) - .formIdentifier(FormIdentifierDto.builder() + .formIdentifier(FormIdentifier.builder() .formEngineName(FORM_ENGINE_NAME) .formId(FORM_ID) .build()) diff --git a/src/test/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDTOServiceTest.java b/src/test/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDtoServiceTest.java similarity index 84% rename from src/test/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDTOServiceTest.java rename to src/test/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDtoServiceTest.java index 550a436450ae0e094993c0e11643c45e6ce48c71..ca109e6b368dd03e8f33c5d47df8dcd24b1f14bb 100644 --- a/src/test/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDTOServiceTest.java +++ b/src/test/java/de/ozgcloud/admin/reporting/ReportingAggregationManagerSettingDtoServiceTest.java @@ -10,10 +10,10 @@ import org.mapstruct.factory.Mappers; import org.mockito.InjectMocks; import org.mockito.Spy; -class ReportingAggregationManagerSettingDTOServiceTest { +class ReportingAggregationManagerSettingDtoServiceTest { @InjectMocks - private ReportingAggregationManagerSettingDTOService service; + private ReportingAggregationManagerSettingDtoService service; @Spy private AggregationMappingMapper mapper = Mappers.getMapper(AggregationMappingMapper.class); diff --git a/src/test/java/de/ozgcloud/admin/reporting/ReportingSettingDtoTestFactory.java b/src/test/java/de/ozgcloud/admin/reporting/ReportingSettingDtoTestFactory.java index 9bf014f17c866778bb0e4268147088a12dc440b1..48fa582cf2ce827b40683e9893630e82311ae5ee 100644 --- a/src/test/java/de/ozgcloud/admin/reporting/ReportingSettingDtoTestFactory.java +++ b/src/test/java/de/ozgcloud/admin/reporting/ReportingSettingDtoTestFactory.java @@ -14,7 +14,7 @@ class ReportingSettingDtoTestFactory { return createBuilder().build(); } - public static ReportingAggregationManagerSettingDto.ReportingSettingDtoBuilder createBuilder() { + public static ReportingAggregationManagerSettingDto.ReportingAggregationManagerSettingDtoBuilder createBuilder() { return ReportingAggregationManagerSettingDto.builder() .aggregationMapping(AggregationMappingDto.builder() .formIdentifier(FORM_IDENTIFIER)