diff --git a/ckanext/odsh/helpers.py b/ckanext/odsh/helpers.py index 0e85161bb30a7f90ca2e27050389614fbcf05876..308c92feb2c708222bdae0859e8a414f688016b2 100644 --- a/ckanext/odsh/helpers.py +++ b/ckanext/odsh/helpers.py @@ -7,19 +7,17 @@ log = logging.getLogger(__name__) def odsh_openness_score_dataset_html(dataset): score = 0 - #dataset = json.loads(dataset) resources = dataset.get('resources') - if resources is None: - return 0 - for resource in resources: - r_qa = resource.get('qa') - if r_qa: - try: - qa = ast.literal_eval() - resource_score = qa.get('openness_score') - if resource_score > score: - score = resource_score - except AttributeError, e: - log.error('Error while calculating openness score %s: %s\nException: %s', - e.__class__.__name__, unicode(e), traceback.format_exc()) + if resources: + for resource in resources: + r_qa = resource.get('qa') + if r_qa: + try: + qa = ast.literal_eval(r_qa) + resource_score = qa.get('openness_score') + if resource_score > score: + score = resource_score + except AttributeError, e: + log.error('Error while calculating openness score %s: %s\nException: %s', + e.__class__.__name__, unicode(e), traceback.format_exc()) return score