From 6322ba8384553b8f9fa1487165b27a5eb0d77bce Mon Sep 17 00:00:00 2001
From: Thorge Petersen <petersen@rz.uni-kiel.de>
Date: Fri, 14 Apr 2023 10:40:27 +0200
Subject: [PATCH] Removed more named route property labels in link generation

---
 ckanext/odsh/templates/datarequests/snippets/comment_item.html  | 2 +-
 .../odsh/templates/datarequests/snippets/datarequest_form.html  | 2 +-
 ckanext/odsh/templates/package/snippets/package_form.html       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ckanext/odsh/templates/datarequests/snippets/comment_item.html b/ckanext/odsh/templates/datarequests/snippets/comment_item.html
index 899eb7d3..625676a8 100644
--- a/ckanext/odsh/templates/datarequests/snippets/comment_item.html
+++ b/ckanext/odsh/templates/datarequests/snippets/comment_item.html
@@ -18,7 +18,7 @@
         {% if h.check_access('delete_datarequest_comment', {'id':comment.id }) %}
           <div class="comment-action">
             {% set locale = h.dump_json({'content': _('Are you sure you want to delete this comment?')}) %}
-            <a class="subtle-btn" id="delete-comment-{{ comment.id }}" href="{% url_for named_route='ckanext.datarequests.controllers.ui_controller:DataRequestsUI.delete_comment', datarequest_id=datarequest.id, comment_id=comment.id %}" data-module="confirm-action" data-module-i18n="{{ locale }}"><i class="icon-remove fa fa-times"></i></a>
+            <a class="subtle-btn" id="delete-comment-{{ comment.id }}" href="{% url_for 'ckanext.datarequests.controllers.ui_controller:DataRequestsUI.delete_comment', datarequest_id=datarequest.id, comment_id=comment.id %}" data-module="confirm-action" data-module-i18n="{{ locale }}"><i class="icon-remove fa fa-times"></i></a>
           </div>
         {% endif %}
         {% if can_update %}
diff --git a/ckanext/odsh/templates/datarequests/snippets/datarequest_form.html b/ckanext/odsh/templates/datarequests/snippets/datarequest_form.html
index df695074..a92d25ae 100644
--- a/ckanext/odsh/templates/datarequests/snippets/datarequest_form.html
+++ b/ckanext/odsh/templates/datarequests/snippets/datarequest_form.html
@@ -27,7 +27,7 @@ then itself be extended to add/remove blocks of functionality. #}
       {% block delete_button %}
         {% if h.check_access('delete_datarequest', {'id': data.get('id', '')}) and not data.state == 'deleted' %}
           {% set locale = h.dump_json({'content': _('Are you sure you want to delete this data request?')}) %}
-          <a class="btn btn-danger pull-left" href="{% url_for named_route='ckanext.datarequests.controllers.ui_controller:DataRequestsUI.delete', id=data.get('id') %}" data-module="confirm-action" data-module-i18n="{{ locale }}">{% block delete_button_text %}{{ _('Delete') }}{% endblock %}</a>
+          <a class="btn btn-danger pull-left" href="{% url_for 'ckanext.datarequests.controllers.ui_controller:DataRequestsUI.delete', id=data.get('id') %}" data-module="confirm-action" data-module-i18n="{{ locale }}">{% block delete_button_text %}{{ _('Delete') }}{% endblock %}</a>
         {% endif %}
       {% endblock %}
       <button class="btn btn-primary btn-arrow-right" type="submit" name="save">{% block save_button_text %}{{ _('Create Data Request') }}{% endblock %}</button>
diff --git a/ckanext/odsh/templates/package/snippets/package_form.html b/ckanext/odsh/templates/package/snippets/package_form.html
index 1b0c9226..36005089 100644
--- a/ckanext/odsh/templates/package/snippets/package_form.html
+++ b/ckanext/odsh/templates/package/snippets/package_form.html
@@ -28,7 +28,7 @@
       <div class="span6">
         {% block delete_button %}
         {% if h.check_access('package_delete', {'id': data.id}) and not data.state == 'deleted' %}
-        <a class="btn btn-danger pull-left" href="{% url_for named_route='dataset.delete', id=data.id %}"
+        <a class="btn btn-danger pull-left" href="{% url_for 'dataset.delete', id=data.id %}"
           data-module="confirm-action" data-module-content="{{ _('Are you sure you want to delete this dataset?') }}">
           {% block delete_button_text %}{{ _('Delete') }}{% endblock %}</a>
         {% endif %}
-- 
GitLab